webmention 1.0.2 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c757e8796a5d3c616772cf36055776e3b4b8d4d8767a22ddbec3866a2073936
-  data.tar.gz: d748c185ee8d1f8535101b24e8e0b271ef48b52539b2b2dfe9128c9478b9916a
+  metadata.gz: fe7be9c5256690feeefb414862b49e7ede87e1aabd63c0f7cb54004fdc9a3412
+  data.tar.gz: '078f32d632920db98684c12f3e4fb48048b32801846174848b878c04678a588d'
 SHA512:
-  metadata.gz: b1ae7e46c6c7587b0ba9ce065e5d28910a1c5b95039b4203052bd29a413b90587b88b4e04fe798f508462205549a62a2c3ee4dbfe914154ad5286a680ff20347
-  data.tar.gz: 4e3392411bdb28f2bad6af894ca9a88d2cfa8d29d5d2076793682cc815fe290a763b04e9bddc79d31a6d6a3a6461e7ac6a603d6dc8ab97b671616733b6ac4e59
+  metadata.gz: a9e717f3b4ba98a7cc8e022731fba654dece6c3d55584f0f23a84968e13de0c2df17f642e75852d8ef5d831348d9df954c0d9107b47e9280db73812a642ffaf5
+  data.tar.gz: 1af3ed848cfe7e78d7b493da12a3e2e2c9e8269b48d79cfb43c8c73483c45569c6689e6484c4c1d789fc14b6f40194b4a1a4bbe39c6a19eecdbe12e180613e88

data/.rubocop.yml

@@ -1,18 +1,20 @@
 require:
   - rubocop-performance
 
-Layout/AlignHash:
+AllCops:
+  NewCops: enable
+
+Layout/HashAlignment:
   EnforcedColonStyle: table
   EnforcedHashRocketStyle: table
 
+Layout/LineLength:
+  Enabled: false
+
 Metrics/BlockLength:
   Exclude:
-    - webmention.gemspec
     - test/**/*
 
-Metrics/LineLength:
-  Enabled: false
-
 Naming/RescuedExceptionsVariableName:
   PreferredName: exception
 
@@ -22,9 +24,5 @@ Style/Documentation:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-Style/SingleLineMethods:
-  Exclude:
-    - test/**/*
-
 Style/SymbolArray:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.4.7
+2.5.8

data/.simplecov

@@ -3,8 +3,10 @@ require 'simplecov-console'
 SimpleCov.start do
   add_filter '/test/'
 
-  formatter SimpleCov::Formatter::MultiFormatter.new([
-    SimpleCov::Formatter::Console,
-    SimpleCov::Formatter::HTMLFormatter
-  ])
+  formatter SimpleCov::Formatter::MultiFormatter.new(
+    [
+      SimpleCov::Formatter::Console,
+      SimpleCov::Formatter::HTMLFormatter
+    ]
+  )
 end

data/.travis.yml

@@ -1,13 +1,10 @@
+dist: bionic
 language: ruby
 rvm:
-  - 2.4
   - 2.5
   - 2.6
-cache:
-  - bundler
-before_install:
-  - gem update --system
-  - gem update bundler
+  - 2.7
+cache: bundler
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
   - chmod +x ./cc-test-reporter

data/CHANGELOG.md

@@ -1,5 +1,35 @@
 # Changelog
 
+## v4.0.0 / 2020-08-23
+
+- **Breaking change:** Update minimum supported Ruby version to 2.5 (b2bc62f)
+- Update indieweb-endpoints to 4.0 (e61588f)
+- Update project Ruby version to 2.5.8 (2a626a6)
+
+## v3.0.0 / 2020-05-19
+
+- Reject "internal" URLs when sending webmentions (#24) (ccc82c8)
+- Select only HTTP/HTTPS URLs when sending webmentions (#22) (39e5852)
+
+## 2.2.0 / 2020-05-18
+
+- Update absolutely and indieweb-endpoints gems (350d2ed)
+- Add pry-byebug and `bin/console` script (d2c5e03)
+- Move development dependencies to Gemfile per current Bundler conventions (3a2fc21)
+- Update development Ruby version to 2.4.10 (4c7d1f7)
+
+## 2.1.0 / 2020-04-06
+
+- Refactor `BaseParser` class and remove `Registerable` module (b706229)
+- Refactor `HttpRequest` and `NodeParser` classes into Service Objects (f29c073 and 7456bf1)
+
+## 2.0.0 / 2020-01-25
+
+- Add Ruby 2.7 to list of supported Ruby versions (c67ed14)
+- Update absolutely, addressable, http, and indieweb-endpoints version constaints (986d326 and 6ba054f)
+- Update development dependencies (74ac982)
+- Update project Ruby version to 2.4.9 and update documentation (fd61ddf)
+
 ## 1.0.2 / 2019-08-31
 
 - Update Addressable and WebMock gems (0b98981)

data/CONTRIBUTING.md

@@ -8,9 +8,9 @@ There are a couple ways you can help improve webmention-client-ruby:
 
 ## Getting Started
 
-webmention-client-ruby is developed using Ruby 2.4.7 and is additionally tested against Ruby 2.5 and 2.6 using [Travis CI](https://travis-ci.org/indieweb/webmention-client-ruby).
+webmention-client-ruby is developed using Ruby 2.5.8 and is additionally tested against Ruby 2.6 and 2.7 using [Travis CI](https://travis-ci.org/indieweb/webmention-client-ruby).
 
-Before making changes to webmention-client-ruby, you'll want to install Ruby 2.4.7. It's recommended that you use a Ruby version managment tool like [rbenv](https://github.com/rbenv/rbenv), [chruby](https://github.com/postmodern/chruby), or [rvm](https://github.com/rvm/rvm). Once you've installed Ruby 2.4.7 using your method of choice, install the project's gems by running:
+Before making changes to webmention-client-ruby, you'll want to install Ruby 2.5.8. It's recommended that you use a Ruby version managment tool like [rbenv](https://github.com/rbenv/rbenv), [chruby](https://github.com/postmodern/chruby), or [rvm](https://github.com/rvm/rvm). Once you've installed Ruby 2.5.8 using your method of choice, install the project's gems by running:
 
 ```sh
 bundle install

data/Gemfile

@@ -2,3 +2,14 @@ source 'https://rubygems.org'
 
 # Specify gem's dependencies in webmention.gemspec
 gemspec
+
+gem 'minitest', '~> 5.14'
+gem 'minitest-reporters', '~> 1.4'
+gem 'pry-byebug', '~> 3.9'
+gem 'rake', '~> 13.0'
+gem 'reek', '~> 6.0'
+gem 'rubocop', '~> 0.89.1'
+gem 'rubocop-performance', '~> 1.7'
+gem 'simplecov', '~> 0.19.0'
+gem 'simplecov-console', '~> 0.7.2'
+gem 'webmock', '~> 3.8'

data/README.md

@@ -16,9 +16,9 @@
 
 ## Getting Started
 
-Before installing and using webmention-client-ruby, you'll want to have [Ruby](https://www.ruby-lang.org) 2.4 (or newer) installed. It's recommended that you use a Ruby version managment tool like [rbenv](https://github.com/rbenv/rbenv), [chruby](https://github.com/postmodern/chruby), or [rvm](https://github.com/rvm/rvm).
+Before installing and using webmention-client-ruby, you'll want to have [Ruby](https://www.ruby-lang.org) 2.5 (or newer) installed. It's recommended that you use a Ruby version managment tool like [rbenv](https://github.com/rbenv/rbenv), [chruby](https://github.com/postmodern/chruby), or [rvm](https://github.com/rvm/rvm).
 
-webmention-client-ruby is developed using Ruby 2.4.7 and is additionally tested against Ruby 2.5 and 2.6 using [Travis CI](https://travis-ci.org/indieweb/webmention-client-ruby).
+webmention-client-ruby is developed using Ruby 2.5.8 and is additionally tested against Ruby 2.6 and 2.7 using [Travis CI](https://travis-ci.org/indieweb/webmention-client-ruby).
 
 ## Installation
 

data/lib/webmention.rb

@@ -8,20 +8,31 @@ require 'webmention/version'
 require 'webmention/exceptions'
 
 require 'webmention/client'
-require 'webmention/http_request'
-require 'webmention/registerable'
 
 require 'webmention/parsers'
+require 'webmention/parsers/base_parser'
 require 'webmention/parsers/html_parser'
 
+require 'webmention/services/http_request_service'
+
 module Webmention
-  class << self
-    def client(source)
-      Client.new(source)
-    end
+  # Create a new Webmention::Client
+  # Convenience method for Webmention::Client.new
+  #
+  #   client = Webmention.client('https://source.example.com/post/100')
+  #
+  # @param source [String] An absolute URL representing the source document
+  # @return [Webmention::Client]
+  def self.client(source)
+    Client.new(source)
+  end
 
-    def send_mention(source, target)
-      client(source).send_mention(target)
-    end
+  # Send a webmention from the source URL to the target URL
+  #
+  # @param source [String] An absolute URL representing the source document
+  # @param target [String] An absolute URL representing the target document
+  # @return [HTTP::Response, nil]
+  def self.send_mention(source, target)
+    client(source).send_mention(target)
   end
 end

data/lib/webmention/client.rb

@@ -1,5 +1,10 @@
 module Webmention
   class Client
+    # Create a new Webmention::Client
+    #
+    #   client = Webmention::Client.new('https://source.example.com/post/100')
+    #
+    # @param source [String] An absolute URL representing the source document
     def initialize(source)
       raise ArgumentError, "source must be a String (given #{source.class.name})" unless source.is_a?(String)
 
@@ -8,22 +13,34 @@ module Webmention
       raise ArgumentError, 'source must be an absolute URL (e.g. https://example.com)' unless source_uri.absolute?
     end
 
+    # Send webmentions to all mentioned URLs in this client's source document
+    #
+    # @return [Hash{String => HTTP::Response, nil}]
     def send_all_mentions
       mentioned_urls.each_with_object({}) { |url, hash| hash[url] = send_mention(url) }
     end
 
+    # Extract mentioned URLs from this client's source document
+    #
+    # @return [Array<String>]
+    # @raise [Webmention::UnsupportedMimeTypeError]
     def mentioned_urls
       raise UnsupportedMimeTypeError, "Unsupported MIME Type: #{source_response.mime_type}" unless parser_for_mime_type
 
       @mentioned_urls ||= parser_for_mime_type.new(source_response).results
     end
 
+    # Send a webmention from this client's source URL to the target URL
+    #
+    # @param target [String] An absolute URL representing the target document
+    # @return [HTTP::Response, nil]
+    # @raise [Webmention::ArgumentError, Webmention::ConnectionError, Webmention::InvalidURIError, Webmention::TimeoutError, Webmention::TooManyRedirectsError]
     def send_mention(target)
-      endpoint = IndieWeb::Endpoints.get(target).webmention
+      endpoint = IndieWeb::Endpoints.get(target)[:webmention]
 
       return unless endpoint
 
-      HttpRequest.post(Addressable::URI.parse(endpoint), source: @source, target: target)
+      Services::HttpRequestService.post(Addressable::URI.parse(endpoint), source: @source, target: target)
     rescue IndieWeb::Endpoints::IndieWebEndpointsError => exception
       raise Webmention.const_get(exception.class.name.split('::').last), exception
     end
@@ -35,7 +52,7 @@ module Webmention
     end
 
     def source_response
-      @source_response ||= HttpRequest.get(source_uri)
+      @source_response ||= Services::HttpRequestService.get(source_uri)
     end
 
     def source_uri

data/lib/webmention/parsers.rb

@@ -1,29 +1,11 @@
 module Webmention
   module Parsers
-    extend Registerable
-
-    class BaseParser
-      def initialize(response)
-        raise ArgumentError, "response must be an HTTP::Response (given #{response.class.name})" unless response.is_a?(HTTP::Response)
-
-        @response = response
-
-        raise UnsupportedMimeTypeError, "Unsupported MIME Type: #{response.mime_type}" unless self.class.mime_types.include?(response.mime_type)
-      end
-
-      def results
-        @results ||= parse_response_body
-      end
-
-      private
-
-      def response_body
-        @response_body ||= @response.body.to_s
-      end
+    def self.register(klass)
+      klass.mime_types.each { |mime_type| registered[mime_type] = klass }
+    end
 
-      def response_url
-        @response_url ||= @response.uri.to_s
-      end
+    def self.registered
+      @registered ||= {}
     end
   end
 end

data/lib/webmention/parsers/base_parser.rb

@@ -0,0 +1,27 @@
+module Webmention
+  module Parsers
+    class BaseParser
+      class << self
+        attr_reader :mime_types
+      end
+
+      def initialize(response)
+        raise ArgumentError, "response must be an HTTP::Response (given #{response.class.name})" unless response.is_a?(HTTP::Response)
+
+        @response = response
+
+        raise UnsupportedMimeTypeError, "Unsupported MIME Type: #{response.mime_type}" unless self.class.mime_types.include?(response.mime_type)
+      end
+
+      private
+
+      def response_body
+        @response_body ||= @response.body.to_s
+      end
+
+      def response_url
+        @response_url ||= @response.uri.to_s
+      end
+    end
+  end
+end

data/lib/webmention/parsers/html_parser.rb

@@ -1,23 +1,26 @@
 module Webmention
   module Parsers
     class HtmlParser < BaseParser
-      def self.mime_types
-        ['text/html']
-      end
+      @mime_types = ['text/html']
 
       Parsers.register(self)
 
-      HTML_ATTRIBUTE_MAP = {
-        cite:   %w[blockquote del ins q],
-        data:   %w[object],
-        href:   %w[a area],
-        poster: %w[video],
-        src:    %w[audio embed img source track video],
-        srcset: %w[img source]
+      HTML_ATTRIBUTES_MAP = {
+        'cite'   => %w[blockquote del ins q],
+        'data'   => %w[object],
+        'href'   => %w[a area],
+        'poster' => %w[video],
+        'src'    => %w[audio embed img source track video],
+        'srcset' => %w[img source]
       }.freeze
 
-      CSS_SELECTORS_MAP = HTML_ATTRIBUTE_MAP.each_with_object({}) do |(attribute, elements), hash|
-        hash[attribute] = elements.map { |element| "#{element}[#{attribute}]" }
+      CSS_SELECTORS_ARRAY = HTML_ATTRIBUTES_MAP.flat_map { |attribute, names| names.map { |name| "#{name}[#{attribute}]" } }.freeze
+
+      # Parse an HTML string for URLs
+      #
+      # @return [Array<String>] Unique external URLs whose scheme matches http/https
+      def results
+        @results ||= resolved_urls.uniq.select { |url| url.match?(%r{https?://}) }.reject { |url| url.match(/^#{response_url}(?:#.*)?$/) }
       end
 
       private
@@ -26,46 +29,35 @@ module Webmention
         @doc ||= Nokogiri::HTML(response_body)
       end
 
-      # Parse an HTML string for URLs
-      #
-      # @return [Array] the URLs
-      def parse_response_body
-        CSS_SELECTORS_MAP
-          .each_with_object([]) { |(*args), array| array << search_node(*args) }
-          .flatten
-          .map { |url| Absolutely.to_abs(base: response_url, relative: url) }
-          .uniq
+      def resolved_urls
+        UrlAttributesParser.parse(*url_attributes).map { |url| Absolutely.to_abs(base: response_url, relative: url) }
       end
 
       def root_node
-        @root_node ||= doc.css('.h-entry .e-content').first || doc.css('.h-entry').first || doc.css('body')
+        doc.at_css('.h-entry .e-content', '.h-entry') || doc.css('body')
+      end
+
+      def url_attributes
+        url_nodes.flat_map(&:attribute_nodes).select { |attribute| HTML_ATTRIBUTES_MAP.key?(attribute.name) }
       end
 
-      def search_node(attribute, selectors)
-        NodeParser.nodes_from(root_node, selectors).map { |node| NodeParser.values_from(node, attribute) }.reject(&:empty?)
+      def url_nodes
+        root_node.css(*CSS_SELECTORS_ARRAY)
       end
 
-      module NodeParser
-        class << self
-          # Search a node for matching elements
-          #
-          # @param node [Nokogiri::XML::Element]
-          # @param selectors [Array]
-          # @return [Nokogiri::XML::NodeSet]
-          def nodes_from(node, selectors)
-            node.css(*selectors)
-          end
+      module UrlAttributesParser
+        # @param attributes [Array<Nokogiri::XML::Attr>]
+        # @return [Array<String>]
+        def self.parse(*attributes)
+          attributes.flat_map { |attribute| value_from(attribute) }
+        end
 
-          # Derive attribute values from a single node
-          #
-          # @param node [Nokogiri::XML::Element]
-          # @param attribute [Symbol]
-          # @return [Array] the HTML attribute values
-          def values_from(node, attribute)
-            return Array(node[attribute]) unless attribute == :srcset
+        # @param attribute [Nokogiri::XML::Attr]
+        # @return [String, Array<String>]
+        def self.value_from(attribute)
+          return attribute.value unless attribute.name == 'srcset'
 
-            node[attribute].split(',').map { |value| value.strip.match(/^\S+/).to_s }
-          end
+          attribute.value.split(',').map { |value| value.strip.match(/^\S+/).to_s }
         end
       end
     end

data/lib/webmention/services/http_request_service.rb

@@ -0,0 +1,47 @@
+module Webmention
+  module Services
+    module HttpRequestService
+      # Defaults derived from Webmention specification examples
+      # https://www.w3.org/TR/webmention/#limits-on-get-requests
+      # rubocop:disable Layout/HashAlignment
+      HTTP_CLIENT_OPTS = {
+        follow: {
+          max_hops: 20
+        },
+        headers: {
+          accept: '*/*',
+          user_agent: 'Webmention Client (https://rubygems.org/gems/webmention)'
+        },
+        timeout_options: {
+          connect_timeout: 5,
+          read_timeout: 5
+        }
+      }.freeze
+      # rubocop:enable Layout/HashAlignment
+
+      class << self
+        def get(uri)
+          request(:get, uri)
+        end
+
+        def post(uri, **options)
+          request(:post, uri, form: options)
+        end
+
+        private
+
+        def client
+          @client ||= HTTP::Client.new(HTTP_CLIENT_OPTS)
+        end
+
+        def request(method, uri, **options)
+          client.request(method, uri, options)
+        rescue HTTP::ConnectionError,
+               HTTP::TimeoutError,
+               HTTP::Redirector::TooManyRedirectsError => exception
+          raise Webmention.const_get(exception.class.name.split('::').last), exception
+        end
+      end
+    end
+  end
+end

data/lib/webmention/version.rb

@@ -1,3 +1,3 @@
 module Webmention
-  VERSION = '1.0.2'.freeze
+  VERSION = '4.0.0'.freeze
 end

data/webmention.gemspec

@@ -1,10 +1,7 @@
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-
-require 'webmention/version'
+require_relative 'lib/webmention/version'
 
 Gem::Specification.new do |spec|
-  spec.required_ruby_version = ['>= 2.4', '< 2.7']
+  spec.required_ruby_version = Gem::Requirement.new('>= 2.5', '< 2.8')
 
   spec.name          = 'webmention'
   spec.version       = Webmention::VERSION
@@ -16,28 +13,18 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/indieweb/webmention-client-ruby'
   spec.license       = 'Apache-2.0'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|test)/}) }
+  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
+    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(bin|test)/}) }
+  end
 
   spec.require_paths = ['lib']
 
-  spec.metadata = {
-    'bug_tracker_uri' => "#{spec.homepage}/issues",
-    'changelog_uri'   => "#{spec.homepage}/blob/v#{spec.version}/CHANGELOG.md"
-  }
-
-  spec.add_development_dependency 'minitest', '~> 5.11'
-  spec.add_development_dependency 'minitest-reporters', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 12.3'
-  spec.add_development_dependency 'reek', '~> 5.4'
-  spec.add_development_dependency 'rubocop', '~> 0.74.0'
-  spec.add_development_dependency 'rubocop-performance', '~> 1.4'
-  spec.add_development_dependency 'simplecov', '~> 0.17.0'
-  spec.add_development_dependency 'simplecov-console', '~> 0.5.0'
-  spec.add_development_dependency 'webmock', '~> 3.7'
+  spec.metadata['bug_tracker_uri'] = "#{spec.homepage}/issues"
+  spec.metadata['changelog_uri']   = "#{spec.homepage}/blob/v#{spec.version}/CHANGELOG.md"
 
-  spec.add_runtime_dependency 'absolutely', '~> 3.0'
+  spec.add_runtime_dependency 'absolutely', '~> 4.0'
   spec.add_runtime_dependency 'addressable', '~> 2.7'
-  spec.add_runtime_dependency 'http', '~> 5.0.0.pre'
-  spec.add_runtime_dependency 'indieweb-endpoints', '~> 1.0'
+  spec.add_runtime_dependency 'http', '~> 4.4'
+  spec.add_runtime_dependency 'indieweb-endpoints', '~> 4.0'
   spec.add_runtime_dependency 'nokogiri', '~> 1.10'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webmention
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 4.0.0
 platform: ruby
 authors:
 - Aaron Parecki
@@ -9,148 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-31 00:00:00.000000000 Z
+date: 2020-08-24 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.11'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.11'
-- !ruby/object:Gem::Dependency
-  name: minitest-reporters
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '12.3'
-- !ruby/object:Gem::Dependency
-  name: reek
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.4'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.74.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.74.0
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.17.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.17.0
-- !ruby/object:Gem::Dependency
-  name: simplecov-console
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.0
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.7'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.7'
 - !ruby/object:Gem::Dependency
   name: absolutely
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
@@ -171,28 +45,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0.pre
+        version: '4.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.0.0.pre
+        version: '4.4'
 - !ruby/object:Gem::Dependency
   name: indieweb-endpoints
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -231,10 +105,10 @@ files:
 - lib/webmention.rb
 - lib/webmention/client.rb
 - lib/webmention/exceptions.rb
-- lib/webmention/http_request.rb
 - lib/webmention/parsers.rb
+- lib/webmention/parsers/base_parser.rb
 - lib/webmention/parsers/html_parser.rb
-- lib/webmention/registerable.rb
+- lib/webmention/services/http_request_service.rb
 - lib/webmention/version.rb
 - webmention.gemspec
 homepage: https://github.com/indieweb/webmention-client-ruby
@@ -242,7 +116,7 @@ licenses:
 - Apache-2.0
 metadata:
   bug_tracker_uri: https://github.com/indieweb/webmention-client-ruby/issues
-  changelog_uri: https://github.com/indieweb/webmention-client-ruby/blob/v1.0.2/CHANGELOG.md
+  changelog_uri: https://github.com/indieweb/webmention-client-ruby/blob/v4.0.0/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -251,17 +125,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
   - - "<"
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '2.8'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Webmention notification client

data/lib/webmention/http_request.rb

@@ -1,41 +0,0 @@
-module Webmention
-  class HttpRequest
-    # Defaults derived from Webmention specification examples
-    # https://www.w3.org/TR/webmention/#limits-on-get-requests
-    # rubocop:disable Layout/AlignHash
-    HTTP_CLIENT_OPTS = {
-      follow: {
-        max_hops: 20
-      },
-      headers: {
-        accept: '*/*',
-        user_agent: 'Webmention Client (https://rubygems.org/gems/webmention)'
-      },
-      timeout_options: {
-        connect_timeout: 5,
-        read_timeout: 5
-      }
-    }.freeze
-    # rubocop:enable Layout/AlignHash
-
-    class << self
-      def get(uri)
-        request(:get, uri)
-      end
-
-      def post(uri, **options)
-        request(:post, uri, form: options)
-      end
-
-      private
-
-      def request(method, uri, **options)
-        HTTP::Client.new(HTTP_CLIENT_OPTS).request(method, uri, options)
-      rescue HTTP::ConnectionError,
-             HTTP::TimeoutError,
-             HTTP::Redirector::TooManyRedirectsError => exception
-        raise Webmention.const_get(exception.class.name.split('::').last), exception
-      end
-    end
-  end
-end

data/lib/webmention/registerable.rb

@@ -1,11 +0,0 @@
-module Webmention
-  module Registerable
-    def register(klass)
-      klass.mime_types.each { |mime_type| registered[mime_type] = klass }
-    end
-
-    def registered
-      @registered ||= {}
-    end
-  end
-end