webloc 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8ff9f7c12df7756811c14678b08b8ab6e42839dbb687b802ad37addf372f82d
-  data.tar.gz: 71f8eec3e245afe13e755127b519999255547829f3903f7d70b90099434a7493
+  metadata.gz: 498d11e48961e5843a3a25fafb71f4738ebc10733037145ea30a17f176abcaa2
+  data.tar.gz: 78beeadfdafd1a7f414fc6f7b69c6fd24819ed79bb39a9148e72e1bc38089416
 SHA512:
-  metadata.gz: 82233db761cc8a120f29e0f98f6a285cf2184f3ec9c865feaef060deb1b6021682a604dc1f352ea9af3b9d81fc2dd7fab04a3d3f18e8b923e0f310eeb3e680ae
-  data.tar.gz: ce6d621dda047bd22bbc68353f031bcc91d579f3a46c0c2e049606bf9f778fbcb9d3a0ee03d87eef5c4ac3699ba351eb2be99d60a06500c9cef3cd95c036f2d7
+  metadata.gz: 99b273c4af784bdafe2cde8166da2c3672a263d2e412f0f1547e70ef4b8bf8de74185a13b1050e5c16b713e3f7b8c67baabe9f25b1366ee4e86876a95a368740
+  data.tar.gz: fdbd68bb1239b9b35b1eb8c3d3ef8302d69d8a48eca6830bf636eb693f6e8c9a35e19af02148fda21a2d5a2ce3be1e3b7bef8186d7917dd8c40f73a699557e60

data/.gitignore

@@ -1,3 +1,4 @@
 pkg/*
 *.gem
 .bundle
+.DS_Store

data/README.md

@@ -2,7 +2,7 @@
 
 *webloc* is a Ruby library that can read from and write to <tt>.webloc</tt> files as used on macOS. These are a variant of 'plist' format files, specifically used for storing links to URLs.
 
-It works on Ruby 2.7 and up, including Ruby 3.x, and supports URLs of up to 255 characters in length.
+It works on Ruby 2.7 and up, including Ruby 3.x, and supports URLs of up to 2048 characters in length (and probably longer, but this is around the de facto limit for URLs in most systems).
 
 ## Installation
 

data/lib/webloc/version.rb

@@ -1,3 +1,3 @@
 class Webloc
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/webloc.rb

@@ -13,9 +13,16 @@ class Webloc
     
     if data !~ /\<plist/
       offset = (data =~ /SURL_/)
-      length = data[offset + 6]
-      length = length.ord rescue length
-      url = data[offset + 7,length]  
+      length_offset = 7
+      if data[offset + 5] == "\x10"
+        length = data[offset + 6]
+        length = length.unpack('C')[0]  
+      elsif data[offset + 5] == "\x11"
+        length_offset = 8
+        length = data[offset + 6] + data[offset + 7]
+        length = length.unpack('S>')[0]  
+      end
+      url = data[offset + length_offset,length]
     else
       url = Plist::parse_xml(filename)['URL'] rescue nil
     end
@@ -30,10 +37,18 @@ class Webloc
 
     # PLIST OBJECT TABLE
     @data += "\xD1\x01\x02".bytes   # object 1 is a dictionary
-    @data += "\x53URL".bytes        # object 2 is an ASCII string of length 3
-    @data += "\x5f\x10".bytes       # object 3 is an ASCII string with a variable length length encoding (I know..)
-                              #   .. the '0' in \x10 denotes the length can be encoded within 2**0 bytes (i.e. 1!)
-    @data += @url.length.chr.bytes  # and here is that one byte..
+    @data += "SURL".bytes           # object 2
+
+    length_suffix = @url.length > 255 ? "\x11" : "\x10"
+    @data += ("\x5f" + length_suffix).bytes       # object 3 is an ASCII string with a variable length length encoding (I know..)
+                              #   .. the '0' in \x10 denotes the length can be encoded within 2**0 bytes (i.e. 1)
+                              #   .. the '1' in \x11 denotes the length can be encoded within 2**1 bytes (i.e. 2)
+    
+    if @url.length > 255
+      @data += [@url.length].pack('S>').bytes
+    else
+      @data += [@url.length].pack('C').bytes
+    end
     @data += @url.bytes             # and finally the URL itself
 
     # This is the offset table
@@ -52,7 +67,7 @@ class Webloc
     # Bytes 16-23 are for an offset from the offset table
     @data += "\x00\x00\x00\x00\x00\x00\x00\x00".bytes
     # Bytes 24-31 denote the position of the offset table from the start of the file
-    @data += "\x00\x00\x00\x00\x00\x00\x00".bytes + (@url.length + 18).chr.bytes
+    @data += "\x00\x00\x00\x00\x00\x00".bytes + [@url.length + 18].pack('S>').bytes
 
     @data = @data.pack('C*')
   end

data/test/webloc_test.rb

@@ -25,8 +25,16 @@ class WeblocTest < Test::Unit::TestCase
   end
 
   def test_webloc_can_handle_long_urls
-    url = "http://example.com/this-is-a-very-long-url-indeed-it-should-easily-go-over-110-characters-for-our-testing-purposes"
+    url = "http://example.com/this-is-a-very-long-url-abcde" + ('a' * 2000)
     assert_nothing_raised { Webloc.new(url).data }
+    file = Tempfile.new('test-long-webloc')
+    begin
+      Webloc.new(url).save(file.path)
+      assert_equal url, Webloc.load(file.path).url
+    ensure
+      file.close
+      file.unlink
+    end
   end
 
   def test_webloc_can_write_file

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webloc
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Peter Cooper
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-26 00:00:00.000000000 Z
+date: 2024-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plist
@@ -60,7 +60,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Reads and writes .webloc files on macOS