webkit_remote 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95ab18456b034195d0905cf56ab3a5d7915ce186
-  data.tar.gz: fc8dad063ba5493c45e6ff9017b9c954d1a09453
+  metadata.gz: bb9d8b3286536660ca3d24fa8a141624cf481ac7
+  data.tar.gz: 230b9d1de0ac94e75371b5b70008d34a0f314827
 SHA512:
-  metadata.gz: 8170978254202fcfba7393ceeb536292302d1c4710ac6e77d03f271e0faccd0ccc5a9fcdf58549edbe342301a2af241c0eab0822845444dc9f64d09ae9fc35c2
-  data.tar.gz: 90c803cb8956bc3da08a4c474aae08f80632528b4f5f3dbdaff555845150724ad4681530a2acd1a7034687d19770daa332dda2c9563df439ee309f7ba03db6d8
+  metadata.gz: 7f81789922130b6afaff41745a2476c9d6dc724cec3f0c9c2159f828598a2ee4ad0af1f513f259c3bb66b21ee0e7bdc6ca02829049afbd0915b8034b9184ae6b
+  data.tar.gz: 9c28a1f6f474f6e0992629e1d15e67f204e9891770f9a32fda629b2e555c00dd37b77c7b93217afd37f68c66759ac9a3ca3ecbae92b6277c9247c420722dcd4b

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/lib/webkit_remote/client/dom.rb

@@ -28,7 +28,7 @@ module Dom
 
   # Looks up cached information about a DOM node.
   #
-  # @private Use WebkitRemote::Client::Dom#querySelector or the other public
+  # @private Use WebkitRemote::Client::Dom#query_selector or the other public
   #     APIs instead of calling this directly
   #
   # @param [String] remote_id value of the nodeId attribute in the JSON
@@ -139,11 +139,14 @@ class DomNode
   #
   # @param [String] css_selector the CSS selector that must be matched by the
   #     returned node
-  # @return [WebkitRemote::Client::DomNode] DOM nodes in this node's subtree
-  #     that match the given selector
+  # @return [WebkitRemote::Client::DomNode] the first DOM node in this node's
+  #     subtree that matches the given selector; if no such node exists, nil is
+  #     returned
   def query_selector(css_selector)
     result = @client.rpc.call 'DOM.querySelector', nodeId: @remote_id,
                               selector: css_selector
+    node_id = result['nodeId']
+    return nil if node_id == 0
     @client.dom_node result['nodeId']
   end
 

data/test/webkit_remote/client/dom_test.rb

@@ -38,18 +38,27 @@ describe WebkitRemote::Client::DomNode do
   end
 
   describe 'querySelector' do
-    before :all do
-      @p = @root.query_selector 'p#load-confirmation'
-    end
+    describe 'with a selector that matches' do
+      before :all do
+        @p = @root.query_selector 'p#load-confirmation'
+      end
+
+      it 'returns a WebkitRemote::Client::DomNode' do
+        @p.must_be_kind_of WebkitRemote::Client::DomNode
+      end
 
-    it 'returns a WebkitRemote::Client::DomNode' do
-      @p.must_be_kind_of WebkitRemote::Client::DomNode
+      it 'returns a WebkitRemote::Client::DomNode with correct attributes' do
+        skip 'On-demand node processing not implemented'
+        @p.node_type.must_equal :element
+        @p.name.must_equal 'P'
+      end
     end
 
-    it 'returns a WebkitRemote::Client::DomNode with correct attributes' do
-      skip 'On-demand node processing not implemented'
-      @p.node_type.must_equal :element
-      @p.name.must_equal 'P'
+    describe 'with a selector that does not match' do
+      it 'returns nil' do
+        node = @root.query_selector '#this-id-should-not-exist'
+        node.must_equal nil
+      end
     end
   end
 

data/webkit_remote.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "webkit_remote"
-  s.version = "0.5.0"
+  s.version = "0.5.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Victor Costan"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webkit_remote
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Victor Costan