webkit_remote 0.3.2 → 0.4.0

data/test/webkit_remote/client/{remote_object_group_test.rb → js_object_group_test.rb}

@@ -1,6 +1,6 @@
 require File.expand_path('../../helper.rb', File.dirname(__FILE__))
 
-describe WebkitRemote::Client::RemoteObjectGroup do
+describe WebkitRemote::Client::JsObjectGroup do
   before :each do
     @client = WebkitRemote.local port: 9669
     @client.page_events = true

data/test/webkit_remote/client/{remote_object_test.rb → js_object_test.rb}

@@ -1,6 +1,6 @@
 require File.expand_path('../../helper.rb', File.dirname(__FILE__))
 
-describe WebkitRemote::Client::RemoteObject do
+describe WebkitRemote::Client::JsObject do
   before :each do
     @client = WebkitRemote.local port: 9669
     @client.page_events = true
@@ -18,50 +18,57 @@ describe WebkitRemote::Client::RemoteObject do
       end
 
       it 'enumerates the properties correctly' do
-        @object.properties[:answer].name.must_equal :answer
-        @object.properties[:test].name.must_equal :test
-        @object.properties[:other].must_equal nil
+        @object.properties['answer'].name.must_equal 'answer'
+        @object.properties['test'].name.must_equal 'test'
+        @object.properties['other'].must_equal nil
       end
 
       it 'gets the correct values' do
-        @object.properties[:answer].value.must_equal 42
-        @object.properties[:test].value.must_equal true
+        @object.properties['answer'].value.must_equal 42
+        @object.properties['test'].value.must_equal true
       end
 
       it 'sets owner correctly' do
-        @object.properties[:answer].owner.must_equal @object
+        @object.properties['answer'].owner.must_equal @object
       end
 
       it 'does not have extra properties' do
         @object.properties.select { |name, property| property.enumerable? }.
-                keys.sort.must_equal [:answer, :test]
+                keys.sort.must_equal ['answer', 'test']
       end
 
       it 'recognizes writable properties' do
-        @object.properties[:answer].writable?.must_equal true
-        @object.properties[:constructor].writable?.must_equal false
+        @object.properties['answer'].writable?.must_equal true
+        @object.properties['constructor'].writable?.must_equal false
       end
 
       it 'recognizes configurable properties' do
-        @object.properties[:answer].configurable?.must_equal true
-        @object.properties[:constructor].configurable?.must_equal false
+        @object.properties['answer'].configurable?.must_equal true
+        @object.properties['constructor'].configurable?.must_equal false
       end
 
       it 'recognizes enumerable properties' do
-        @object.properties[:answer].enumerable?.must_equal true
-        @object.properties[:constructor].enumerable?.must_equal false
+        @object.properties['answer'].enumerable?.must_equal true
+        @object.properties['constructor'].enumerable?.must_equal false
       end
 
       describe 'after property update' do
         before do
-          @object.properties[:DONE]
+          @object.properties['DONE']
           @client.remote_eval 'window.t.test = "updated"'
         end
         it 'does not automatically refresh' do
-          @object.properties[:test].value.must_equal true
+          @object.properties['test'].value.must_equal true
         end
         it 'refreshes when properties! is called' do
-          @object.properties![:test].value.must_equal 'updated'
+          @object.properties!['test'].value.must_equal 'updated'
+        end
+      end
+
+      describe 'inspect' do
+        it 'contains the property name and its enumerable status' do
+          @object.properties['test'].inspect.must_match(
+            /<WebkitRemote::Client::JsProperty:.*\s+name="test"\s+configurable=.+\s+enumerable=.+>/)
         end
       end
     end
@@ -72,9 +79,9 @@ describe WebkitRemote::Client::RemoteObject do
       end
 
       it 'recognizes configurable, non-writable, enumerable properties' do
-        @object.properties[:DONE].configurable?.must_equal true
-        @object.properties[:DONE].writable?.must_equal false
-        @object.properties[:DONE].enumerable?.must_equal true
+        @object.properties['DONE'].configurable?.must_equal true
+        @object.properties['DONE'].writable?.must_equal false
+        @object.properties['DONE'].enumerable?.must_equal true
       end
     end
   end
@@ -120,7 +127,7 @@ describe WebkitRemote::Client::RemoteObject do
                                      @arg1, @arg2
       end
       it 'passes the objects and returns an object correctly' do
-        @result.must_be_kind_of WebkitRemote::Client::RemoteObject
+        @result.must_be_kind_of WebkitRemote::Client::JsObject
         @result.js_class_name.must_equal 'TestClass'
         @result.bound_call('TestClass.prototype.toString').
                 must_equal 'hello ruby, rbx and jruby'

data/test/webkit_remote/client/runtime_test.rb

@@ -94,8 +94,8 @@ describe WebkitRemote::Client::Runtime do
         group = @client.object_group('yes')
         group.release_all if group
       end
-      it 'returns an RemoteObject instance' do
-        @object.must_be_kind_of WebkitRemote::Client::RemoteObject
+      it 'returns an JsObject instance' do
+        @object.must_be_kind_of WebkitRemote::Client::JsObject
       end
       it 'sets the object properties correctly' do
         @object.js_class_name.must_equal 'TestClass'
@@ -116,8 +116,8 @@ describe WebkitRemote::Client::Runtime do
         group = @client.object_group('yes')
         group.release_all if group
       end
-      it 'returns an RemoteObject instance' do
-        @object.must_be_kind_of WebkitRemote::Client::RemoteObject
+      it 'returns an JsObject instance' do
+        @object.must_be_kind_of WebkitRemote::Client::JsObject
       end
       it 'sets the object properties correctly' do
         @object.js_class_name.must_equal 'Object'
@@ -139,8 +139,8 @@ describe WebkitRemote::Client::Runtime do
         group.release_all if group
       end
 
-      it 'returns a RemoteObject instance' do
-        @function.must_be_kind_of WebkitRemote::Client::RemoteObject
+      it 'returns a JsObject instance' do
+        @function.must_be_kind_of WebkitRemote::Client::JsObject
       end
 
       it 'sets the object properties correctly' do

data/test/webkit_remote/client_test.rb

@@ -2,7 +2,7 @@ require File.expand_path('../helper.rb', File.dirname(__FILE__))
 
 describe WebkitRemote::Client do
   before :each do
-    @process = WebkitRemote::Process.new port: 9669
+    @process = WebkitRemote::Process.new port: 9669, xvfb: true
     @process.start
     @browser = WebkitRemote::Browser.new process: @process, stop_process: true
     tab = @browser.tabs.first

data/test/webkit_remote/process_test.rb

@@ -1,51 +1,103 @@
 require File.expand_path('../helper.rb', File.dirname(__FILE__))
 
 describe WebkitRemote::Process do
-  before :each do
-    @process = WebkitRemote::Process.new port: 9669
-  end
-  after :each do
-    @process.stop if @process
-  end
-
-  describe '#running' do
-    it 'returns false before #start is called' do
-      @process.running?.must_equal false
-    end
-  end
-
-  describe '#start' do
+  describe 'on Xvfb' do
     before :each do
-      @browser = @process.start
+      @process = WebkitRemote::Process.new port: 9669, xvfb: true
     end
     after :each do
-      @browser.close if @browser
       @process.stop if @process
     end
 
-    it 'makes running? return true' do
-      @process.running?.must_equal true
+    describe '#running' do
+      it 'returns false before #start is called' do
+        @process.running?.must_equal false
+      end
+    end
+
+    describe '#start' do
+      before :each do
+        @browser = @process.start
+      end
+      after :each do
+        @browser.close if @browser
+        @process.stop if @process
+      end
+
+      it 'makes running? return true' do
+        @process.running?.must_equal true
+      end
+
+      it 'returns a Browser instance that does not auto-stop the process' do
+        @browser.must_be_kind_of WebkitRemote::Browser
+        @browser.closed?.must_equal false
+        @browser.stop_process?.must_equal false
+      end
+
+      describe '#stop' do
+        before :each do
+          @process.stop
+        end
+
+        it 'makes running? return false' do
+          @process.running?.must_equal false
+        end
+
+        it 'kills the http server that responds to /json' do
+          begin
+            @browser.tabs
+            fail 'browser process not killed'
+          rescue EOFError
+            pass
+          rescue Errno::ECONNRESET
+            pass
+          end
+        end
+      end
     end
+  end
 
-    it 'returns a Browser instance that does not auto-stop the process' do
-      @browser.must_be_kind_of WebkitRemote::Browser
-      @browser.closed?.must_equal false
-      @browser.stop_process?.must_equal false
+  describe 'on real X desktop' do
+    before :each do
+      unless ENV['DISPLAY'] and /\:\d+/ =~ ENV['DISPLAY']
+        skip 'No real X desktop configured'
+      end
+      @process = WebkitRemote::Process.new port: 9669
+    end
+    after :each do
+      @process.stop if @process
     end
 
-    describe '#stop' do
+    describe '#start' do
       before :each do
-        @process.stop
+        @browser = @process.start
+      end
+      after :each do
+        @browser.close if @browser
+        @process.stop if @process
       end
 
-      it 'makes running? return false' do
-        @process.running?.must_equal false
+      it 'returns a Browser instance that does not auto-stop the process' do
+        @browser.must_be_kind_of WebkitRemote::Browser
+        @browser.closed?.must_equal false
+        @browser.stop_process?.must_equal false
       end
 
-      it 'kills the http server that responds to /json' do
-        lambda {
-          @browser.tabs
-        }.must_raise EOFError
+      describe '#stop' do
+        before :each do
+          @process.stop
+        end
+
+        it 'kills the http server that responds to /json' do
+          begin
+            @browser.tabs
+            fail 'browser process not killed'
+          rescue EOFError
+            pass
+          rescue Errno::ECONNRESET
+            pass
+          end
+        end
       end
     end
   end

data/test/webkit_remote/rpc_test.rb

@@ -2,7 +2,7 @@ require File.expand_path('../helper.rb', File.dirname(__FILE__))
 
 describe WebkitRemote::Rpc do
   before :each do
-    @process = WebkitRemote::Process.new port: 9669
+    @process = WebkitRemote::Process.new port: 9669, xvfb: true
     @process.start
     @browser = WebkitRemote::Browser.new process: @process, stop_process: true
     tab = @browser.tabs.first

data/test/webkit_remote_test.rb

@@ -3,7 +3,7 @@ require File.expand_path('helper.rb', File.dirname(__FILE__))
 describe WebkitRemote do
   describe 'local' do
     before do
-      @client = WebkitRemote.local port: 9669
+      @client = WebkitRemote.local port: 9669, xvfb: true
     end
     after do
       @client.close
@@ -29,7 +29,7 @@ describe WebkitRemote do
 
   describe 'remote' do
     before do
-      @process = WebkitRemote::Process.new port: 9669
+      @process = WebkitRemote::Process.new port: 9669, xvfb: true
       browser = @process.start
       browser.close
       @client = WebkitRemote.remote host: 'localhost', port: 9669

data/webkit_remote.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "webkit_remote"
-  s.version = "0.3.2"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Victor Costan"]
-  s.date = "2012-11-10"
+  s.date = "2012-11-16"
   s.description = "Launches Google Chrome instances and controls them via the Remote Debugging server"
   s.email = "victor@costan.us"
   s.extra_rdoc_files = [
@@ -30,6 +30,8 @@ Gem::Specification.new do |s|
     "lib/webkit_remote/client.rb",
     "lib/webkit_remote/client/console.rb",
     "lib/webkit_remote/client/console_events.rb",
+    "lib/webkit_remote/client/dom.rb",
+    "lib/webkit_remote/client/dom_events.rb",
     "lib/webkit_remote/client/network.rb",
     "lib/webkit_remote/client/network_events.rb",
     "lib/webkit_remote/client/page.rb",
@@ -41,6 +43,7 @@ Gem::Specification.new do |s|
     "lib/webkit_remote/top_level.rb",
     "test/fixtures/config.ru",
     "test/fixtures/html/console.html",
+    "test/fixtures/html/dom.html",
     "test/fixtures/html/load.html",
     "test/fixtures/html/network.html",
     "test/fixtures/html/runtime.html",
@@ -49,10 +52,11 @@ Gem::Specification.new do |s|
     "test/helper.rb",
     "test/webkit_remote/browser_test.rb",
     "test/webkit_remote/client/console_test.rb",
+    "test/webkit_remote/client/dom_test.rb",
+    "test/webkit_remote/client/js_object_group_test.rb",
+    "test/webkit_remote/client/js_object_test.rb",
     "test/webkit_remote/client/network_test.rb",
     "test/webkit_remote/client/page_test.rb",
-    "test/webkit_remote/client/remote_object_group_test.rb",
-    "test/webkit_remote/client/remote_object_test.rb",
     "test/webkit_remote/client/runtime_test.rb",
     "test/webkit_remote/client_test.rb",
     "test/webkit_remote/event_test.rb",
@@ -75,6 +79,7 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<faye-websocket>, [">= 0.4.6"])
       s.add_runtime_dependency(%q<posix-spawn>, [">= 0.3.6"])
       s.add_development_dependency(%q<bundler>, [">= 1.2.1"])
+      s.add_development_dependency(%q<debugger>, [">= 1.2.1"])
       s.add_development_dependency(%q<jeweler>, [">= 1.8.4"])
       s.add_development_dependency(%q<minitest>, [">= 4.1.0"])
       s.add_development_dependency(%q<puma>, [">= 1.6.3"])
@@ -89,6 +94,7 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<faye-websocket>, [">= 0.4.6"])
       s.add_dependency(%q<posix-spawn>, [">= 0.3.6"])
       s.add_dependency(%q<bundler>, [">= 1.2.1"])
+      s.add_dependency(%q<debugger>, [">= 1.2.1"])
       s.add_dependency(%q<jeweler>, [">= 1.8.4"])
       s.add_dependency(%q<minitest>, [">= 4.1.0"])
       s.add_dependency(%q<puma>, [">= 1.6.3"])
@@ -104,6 +110,7 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<faye-websocket>, [">= 0.4.6"])
     s.add_dependency(%q<posix-spawn>, [">= 0.3.6"])
     s.add_dependency(%q<bundler>, [">= 1.2.1"])
+    s.add_dependency(%q<debugger>, [">= 1.2.1"])
     s.add_dependency(%q<jeweler>, [">= 1.8.4"])
     s.add_dependency(%q<minitest>, [">= 4.1.0"])
     s.add_dependency(%q<puma>, [">= 1.6.3"])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webkit_remote
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-10 00:00:00.000000000 Z
+date: 2012-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: eventmachine
@@ -75,6 +75,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.2.1
+- !ruby/object:Gem::Dependency
+  name: debugger
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.2.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.2.1
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
@@ -241,6 +257,8 @@ files:
 - lib/webkit_remote/client.rb
 - lib/webkit_remote/client/console.rb
 - lib/webkit_remote/client/console_events.rb
+- lib/webkit_remote/client/dom.rb
+- lib/webkit_remote/client/dom_events.rb
 - lib/webkit_remote/client/network.rb
 - lib/webkit_remote/client/network_events.rb
 - lib/webkit_remote/client/page.rb
@@ -252,6 +270,7 @@ files:
 - lib/webkit_remote/top_level.rb
 - test/fixtures/config.ru
 - test/fixtures/html/console.html
+- test/fixtures/html/dom.html
 - test/fixtures/html/load.html
 - test/fixtures/html/network.html
 - test/fixtures/html/runtime.html
@@ -260,10 +279,11 @@ files:
 - test/helper.rb
 - test/webkit_remote/browser_test.rb
 - test/webkit_remote/client/console_test.rb
+- test/webkit_remote/client/dom_test.rb
+- test/webkit_remote/client/js_object_group_test.rb
+- test/webkit_remote/client/js_object_test.rb
 - test/webkit_remote/client/network_test.rb
 - test/webkit_remote/client/page_test.rb
-- test/webkit_remote/client/remote_object_group_test.rb
-- test/webkit_remote/client/remote_object_test.rb
 - test/webkit_remote/client/runtime_test.rb
 - test/webkit_remote/client_test.rb
 - test/webkit_remote/event_test.rb
@@ -286,7 +306,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3000124756786155400
+      hash: 4292049841560848513
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: