webdrivers 4.4.0 → 4.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7f905a3a4839d0f0a56317926d560cab4ee29f98b3d36d4feb1bb671e3f1b23b
-  data.tar.gz: 44ae96f9ba7edfbb2fb1bd1fd7ef319e73643f5a43c0fce59c51e2b94c1a25c8
+  metadata.gz: 5a9aab40e8054bb95185ed1231b7f74757811afb4ad47553b7b78c2fc35ea936
+  data.tar.gz: c77d486952c76061d5007030b8e02025a72870469043617ddb230c16b11d0f1f
 SHA512:
-  metadata.gz: 73d60000abc1ad06f692ee556bca7bd57403cde91f2152b5349fda2b0feaa2afb261dd87b1e16f6f8c74e843634b8dbde3da85ed666164920e78163fed764029
-  data.tar.gz: 1c94fde9cafdb1929a3e70ada28c7dfec07cbae6f68220e247ffe62343700c5b3ca2c0556d1d028d4d25b0f6bbd76923c402f1925574ec6f117eb8c4066e6255
+  metadata.gz: c9f29b0e62b33afe328f833ac8a8cb55e11e137938d22a7a66e9e72aa837ee58a9a00f94aa06977c78eac88bd3f446571753728536414b4a9b34a1ddfc0971bf
+  data.tar.gz: 2b979a07116667932ee3e0ca71678f1eec119840b712a2d265a61b1c1585bc14134e1238829d336bedf8c1373bff08cd6f0a80c66bf8378d63123e53a3ab249b

data/CHANGELOG.md

@@ -1,5 +1,22 @@
+### 4.4.2 (2020-12-29)
+* Use new powershell if available to enhance WSL support ([#176](https://github.com/titusfortner/webdrivers/issues/176), 
+  [#186](https://github.com/titusfortner/webdrivers/pull/186)). Thanks, [G-Rath](https://github.com/G-Rath) and 
+  [131](https://github.com/131)!
+* Update rubocop version (development dependency only) ([#178](https://github.com/titusfortner/webdrivers/pull/178)).
+  Thanks, [utkarsh2102](https://github.com/utkarsh2102)!
+* Replace `git ls-files` with `dir` in the gemspec for better Debian support ([#179](https://github.com/titusfortner/webdrivers/pull/179),
+  [#184](https://github.com/titusfortner/webdrivers/issues/184)).
+  Thanks again, [utkarsh2102](https://github.com/utkarsh2102)!
+* Update README with `require: false` when adding gem to Gemfile ([#183](https://github.com/titusfortner/webdrivers/pull/183)).
+* Make WSL detection more generic ([#187](https://github.com/titusfortner/webdrivers/pull/187)).
+  [rbclark](https://github.com/rbclark)!
+  
+### 4.4.1 (2020-06-01)
+* Do not include binstubs used for troubleshooting only. Fixes [#174](https://github.com/titusfortner/webdrivers/issues/174).
+
 ### 4.4.0 (2020-05-31)
-* Implement initial support for WSLv1 ([#172](https://github.com/titusfortner/webdrivers/issues/172)). Thanks G-Rath!
+* Implement support for `chromedriver` in Windows Subsystem for Linux (WSL) v1 ([#172](https://github.com/titusfortner/webdrivers/issues/172)). 
+  Thanks, [G-Rath](https://github.com/G-Rath)!
 * Chrome/Edgedriver - Fix [#171](https://github.com/titusfortner/webdrivers/issues/171) by making sure the cached
 driver build version matches the browser build version before using it.
 * Chrome/Edgedriver - Driver version check now matches the driver and browser `major.minor.build` versions instead of just 

data/README.md

@@ -15,11 +15,13 @@ Run Selenium tests more easily with automatic installation and updates for all s
 * [IEDriverServer](https://github.com/SeleniumHQ/selenium/wiki/InternetExplorerDriver)
 * [msedgedriver](https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/)
 
+Works on macOS, Linux, Windows, and Windows Subsystem for Linux (WSL) v1.
+
 ## Usage
 
 In your Gemfile:
 
-`gem 'webdrivers', '~> 4.0'`
+`gem 'webdrivers', '~> 4.0', require: false`
 
 In your project:
 
@@ -192,6 +194,14 @@ The logging level can be configured for debugging purpose:
 Webdrivers.logger.level = :DEBUG
 ```
 
+### WSLv1 support
+
+While WSLv1 is not designed to run headful applications like Chrome, it can run exes; as such when found to be running
+in WSL, `webdrivers` will use the Windows `chromedriver.exe`.
+
+It's recommended that you install the new PowerShell (PS7) to avoid [a known issue](https://github.com/microsoft/terminal/issues/367) 
+with the console font being changed when calling the old PowerShell (PS5).
+
 ### Browser Specific Notes
 
 #### Chrome/Chromium

data/lib/webdrivers/chrome_finder.rb

@@ -104,6 +104,8 @@ module Webdrivers
       end
 
       def win_version(location)
+        System.call("pwsh.exe -command \"(Get-ItemProperty '#{location}').VersionInfo.ProductVersion\"")&.strip
+      rescue StandardError
         System.call("powershell.exe \"(Get-ItemProperty '#{location}').VersionInfo.ProductVersion\"")&.strip
       end
 

data/lib/webdrivers/chromedriver.rb

@@ -73,13 +73,12 @@ module Webdrivers
           else
             msg
           end
-              rescue NetworkError
-                "#{msg} A network issue is preventing determination of latest chromedriver release."
+        rescue NetworkError
+          "#{msg} A network issue is preventing determination of latest chromedriver release."
         end
 
         msg = "#{msg} Please set `Webdrivers::Chromedriver.required_version = <desired driver version>` "\
-'to a known chromedriver version: https://chromedriver.storage.googleapis.com/index.html'
-
+              'to a known chromedriver version: https://chromedriver.storage.googleapis.com/index.html'
         Webdrivers.logger.debug msg
         raise VersionError, msg
       end

data/lib/webdrivers/edgedriver.rb

@@ -26,10 +26,6 @@ module Webdrivers
         'https://msedgedriver.azureedge.net/'
       end
 
-      def remove
-        super
-      end
-
       private
 
       def latest_point_release(version)
@@ -58,8 +54,8 @@ module Webdrivers
           else
             msg
           end
-              rescue NetworkError
-                "#{msg} A network issue is preventing determination of latest msedgedriver release."
+        rescue NetworkError
+          "#{msg} A network issue is preventing determination of latest msedgedriver release."
         end
 
         "#{msg} Please set `Webdrivers::Edgedriver.required_version = <desired driver version>` "\

data/lib/webdrivers/iedriver.rb

@@ -44,16 +44,19 @@ module Webdrivers
       end
 
       def downloads
-        doc = Nokogiri::XML.parse(Network.get(base_url))
-        items = doc.css('Key').collect(&:text)
-        items.select! { |item| item.include?('IEDriverServer_Win32') }
-        ds = items.each_with_object({}) do |item, hash|
-          key = normalize_version item[/([^_]+)\.zip/, 1]
-          hash[key] = "#{base_url}#{item}"
+        ds = download_manifest.each_with_object({}) do |item, hash|
+          version = normalize_version item[/([^_]+)\.zip/, 1]
+          hash[version] = "#{base_url}#{item}"
         end
         Webdrivers.logger.debug "Versions now located on downloads site: #{ds.keys}"
         ds
       end
+
+      def download_manifest
+        doc = Nokogiri::XML.parse(Network.get(base_url))
+        items = doc.css('Key').collect(&:text)
+        items.select { |item| item.include?('IEDriverServer_Win32') }
+      end
     end
   end
 end

data/lib/webdrivers/network.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'net/http'
+
 module Webdrivers
   #
   # @api private

data/lib/webdrivers/system.rb

@@ -150,7 +150,7 @@ module Webdrivers
 
       # @return [TrueClass, FalseClass]
       def wsl?
-        platform == 'linux' && File.open('/proc/version').read.include?('Microsoft')
+        platform == 'linux' && File.open('/proc/version').read.downcase.include?('microsoft')
       end
 
       # @param [String] path

data/lib/webdrivers/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Webdrivers
-  VERSION = '4.4.0'
+  VERSION = '4.4.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.2
 platform: ruby
 authors:
 - Titus Fortner
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-01 00:00:00.000000000 Z
+date: 2020-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -60,14 +60,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.66'
+        version: '0.89'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.66'
+        version: '0.89'
+- !ruby/object:Gem::Dependency
+  name: rubocop-packaging
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -88,14 +102,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: '1.42'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: '1.42'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -163,25 +177,13 @@ description: Run Selenium tests more easily with install and updates for all sup
 email:
 - titusfortner@gmail.com
 - kapoorlakshya@gmail.com
-executables:
-- console
-- setup
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/ISSUE_TEMPLATE.md"
-- ".gitignore"
-- ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
-- appveyor.yml
-- bin/console
-- bin/setup
-- gemfiles/Gemfile.edge
 - lib/webdrivers.rb
 - lib/webdrivers/Rakefile
 - lib/webdrivers/chrome_finder.rb
@@ -210,17 +212,14 @@ files:
 - spec/webdrivers/system_spec.rb
 - spec/webdrivers/webdrivers_spec.rb
 - spec/webdrivers_proxy_support_spec.rb
-- support/install_jruby.ps1
-- support/install_msedge.ps1
-- webdrivers.gemspec
 homepage: https://github.com/titusfortner/webdrivers
 licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/titusfortner/webdrivers/issues
   changelog_uri: https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/webdrivers/4.4.0
-  source_code_uri: https://github.com/titusfortner/webdrivers/tree/v4.4.0
+  documentation_uri: https://www.rubydoc.info/gems/webdrivers/4.4.2
+  source_code_uri: https://github.com/titusfortner/webdrivers/tree/v4.4.2
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -236,8 +235,18 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Easy download and use of browser drivers.
-test_files: []
+test_files:
+- spec/spec_helper.rb
+- spec/webdrivers/chrome_finder_spec.rb
+- spec/webdrivers/edge_finder_spec.rb
+- spec/webdrivers/webdrivers_spec.rb
+- spec/webdrivers/system_spec.rb
+- spec/webdrivers/edgedriver_spec.rb
+- spec/webdrivers/i_edriver_spec.rb
+- spec/webdrivers/geckodriver_spec.rb
+- spec/webdrivers/chromedriver_spec.rb
+- spec/webdrivers_proxy_support_spec.rb

data/.github/ISSUE_TEMPLATE.md

@@ -1,16 +0,0 @@
-#### Summary
-Short summary of the bug or feature request.
-
-#### Debug Info
-Please provide the following information for bug reports:
-
-* Webdrivers version:
-* Ruby version:
-* Operating system / CI Environment:
-* Browser and version:
-
-#### Expected Behavior
-What you expect to happen.
-
-#### Actual Behavior
-What is actually happening: Error message, stack trace, DEBUG log if applicable (set `Webdrivers.logger.level = :DEBUG` after you require webdrivers)

data/.gitignore

@@ -1,8 +0,0 @@
-*.gem
-.bundle
-Gemfile.lock
-pkg/*
-chromedriver.log
-/.idea/
-coverage/
-gemfiles/Gemfile.*.lock

data/.rubocop.yml

@@ -1,48 +0,0 @@
-AllCops:
-  TargetRubyVersion: 2.4.10
-
-require:
-  - rubocop-rspec
-  - rubocop-performance
-
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-Layout/EndOfLine:
-  EnforcedStyle: lf
-
-Layout/LineLength:
-  Max: 120
-  IgnoredPatterns:
-    - '\s+# rubocop:disable'
-
-Metrics/MethodLength:
-  Max: 20
-
-Metrics/BlockLength:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/webdrivers/tasks/*.rake'
-    - 'webdrivers.gemspec'
-
-Metrics/ClassLength:
-  Max: 116
-  Exclude:
-    - 'lib/webdrivers/system.rb'
-
-Metrics/CyclomaticComplexity:
-  Max: 8
-
-Metrics/AbcSize:
-  Max: 16
-  Exclude:
-    - 'lib/webdrivers/chromedriver.rb'
-
-Style/Documentation:
-  Enabled: false
-
-RSpec/ExampleLength:
-  Enabled: false
-
-RSpec/MultipleExpectations:
-  Enabled: false

data/.travis.yml

@@ -1,41 +0,0 @@
-language: ruby
-cache: bundler
-addons:
-  apt:
-    packages:
-      - chromium-browser
-      - libgconf-2-4
-  chrome: stable
-script: bundle exec rake $RAKE_TASK
-before_install:
-  - gem update --system -N
-  - gem install bundler -N
-matrix:
-  include:
-    - rvm: 2.4
-      env: RAKE_TASK=spec
-    - rvm: 2.5
-      env: RAKE_TASK=spec
-    - rvm: 2.6
-      env: RAKE_TASK=spec
-    - rvm: 2.7
-      os: osx
-      env: RAKE_TASK=spec
-    - rvm: 2.7
-      env: RAKE_TASK=rubocop
-    - rvm: jruby-9.2.11.1
-      jdk: openjdk8
-      env: RAKE_TASK=spec
-    - rvm: 2.7
-      env: RAKE_TASK=spec
-      gemfile: gemfiles/Gemfile.edge
-      os: osx
-      osx_image: xcode11.3
-      addons:
-        chrome: stable
-        homebrew:
-          taps: homebrew/cask-versions
-          casks:
-            - microsoft-edge
-  allow_failures:
-    - gemfile: gemfiles/Gemfile.edge

data/Gemfile

@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in webdrivers.gemspec
-gemspec

data/Rakefile

@@ -1,11 +0,0 @@
-# frozen_string_literal: true
-
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
-require 'rubocop/rake_task'
-
-RuboCop::RakeTask.new
-
-RSpec::Core::RakeTask.new(:spec)
-
-task default: %i[rubocop spec]

data/appveyor.yml

@@ -1,45 +0,0 @@
-build: off
-cache:
-  - vendor/bundle
-image:
-  - Visual Studio 2019
-environment:
-  matrix:
-    - RUBY_VERSION: Ruby24-x64
-      RUBY_BIN: ruby
-      RAKE_TASK: rubocop
-      SCRIPT_CONTEXT: bundle exec
-    - RUBY_VERSION: Ruby24-x64
-      RUBY_BIN: ruby
-      RAKE_TASK: spec
-      SCRIPT_CONTEXT: bundle exec
-    - RUBY_VERSION: Ruby25-x64
-      RUBY_BIN: ruby
-      RAKE_TASK: spec
-      SCRIPT_CONTEXT: bundle exec
-    - RUBY_VERSION: Ruby26-x64
-      RUBY_BIN: ruby
-      RAKE_TASK: spec
-      SCRIPT_CONTEXT: bundle exec
-    - RUBY_VERSION: jruby-9.2.11.1
-      RUBY_BIN: jruby
-      RAKE_TASK: spec
-      SCRIPT_CONTEXT: jruby -G -S
-    - RUBY_VERSION: Ruby26-x64
-      RUBY_BIN: ruby
-      RAKE_TASK: spec
-      SCRIPT_CONTEXT: bundle exec
-      BUNDLE_GEMFILE: gemfiles/Gemfile.edge
-install:
-  - ps: if ($env:RUBY_BIN -eq 'jruby') { support\install_jruby.ps1 }
-  - ps: support\install_msedge.ps1
-  - set PATH=C:\%RUBY_VERSION%\bin;%PATH%
-  - '%RUBY_BIN% -S gem update --system -N'
-  - '%RUBY_BIN% -S gem install bundler -N'
-  - '%RUBY_BIN% -S bundle install'
-before_test:
-  - '%RUBY_BIN% -v'
-  - '%RUBY_BIN% -S gem -v'
-  - '%RUBY_BIN% -S bundle -v'
-test_script:
-  - '%SCRIPT_CONTEXT% rake %RAKE_TASK%'

data/bin/console

@@ -1,15 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-require 'bundler/setup'
-require 'webdrivers'
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require 'irb'
-IRB.start(__FILE__)

data/bin/setup

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here

data/gemfiles/Gemfile.edge

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in webdrivers.gemspec
-gemspec path: '..'
-gem 'selenium-webdriver', github: 'seleniumhq/selenium', glob: 'rb/*.gemspec'

data/support/install_jruby.ps1

@@ -1,7 +0,0 @@
-$downloadLink = "https://repo1.maven.org/maven2/org/jruby/jruby-dist/9.2.11.1/jruby-dist-9.2.11.1-bin.zip"
-$zipPath = "c:\jruby-dist-9.2.11.1-bin.zip"
-
-Write-Host "Installing $($env:RUBY_VERSION)" -ForegroundColor cyan
-appveyor DownloadFile "$($downloadLink)" -FileName "$($zipPath)"
-7z x "$($zipPath)" -oc:\ -y # Unzip to c:\
-Write-Host "JRuby installed.`n" -ForegroundColor green

data/support/install_msedge.ps1

@@ -1,11 +0,0 @@
-$downloadLink = "https://go.microsoft.com/fwlink/?linkid=2108834&Channel=Stable&language=en"
-$installerFile = "C:\MicrosoftEdgeSetup.exe"
-
-#  Note: We're purposely skipping the -Wait flag in Start-Process.
-#  This is because Edge auto-launches after the setup is done and
-#  Start-Process continues to indefinitely wait on that process.
-Write-Host "Downloading Microsoft Edge (Stable)..." -ForegroundColor cyan
-Invoke-WebRequest $downloadLink -OutFile $installerFile
-Write-Host "Installing..." -ForegroundColor cyan
-Start-Process $installerFile
-Write-Host "Microsoft Edge (Stable) installed.`n" -ForegroundColor green

data/webdrivers.gemspec

@@ -1,41 +0,0 @@
-# frozen_string_literal: true
-
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift lib unless $LOAD_PATH.include?(lib)
-require 'webdrivers/version'
-
-Gem::Specification.new do |s|
-  s.name        = 'webdrivers'
-  s.version     = Webdrivers::VERSION
-  s.required_ruby_version = '>= 2.4.0'
-  s.authors     = ['Titus Fortner', 'Lakshya Kapoor', 'Thomas Walpole']
-  s.email       = %w[titusfortner@gmail.com kapoorlakshya@gmail.com]
-  s.homepage    = 'https://github.com/titusfortner/webdrivers'
-  s.summary     = 'Easy download and use of browser drivers.'
-  s.description = 'Run Selenium tests more easily with install and updates for all supported webdrivers.'
-  s.licenses    = ['MIT']
-
-  s.metadata = {
-    'bug_tracker_uri' => 'https://github.com/titusfortner/webdrivers/issues',
-    'changelog_uri' => 'https://github.com/titusfortner/webdrivers/blob/master/CHANGELOG.md',
-    'documentation_uri' => "https://www.rubydoc.info/gems/webdrivers/#{Webdrivers::VERSION}",
-    'source_code_uri' => "https://github.com/titusfortner/webdrivers/tree/v#{Webdrivers::VERSION}"
-  }
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
-  s.require_paths = ['lib']
-
-  s.add_development_dependency 'ffi', '~> 1.0' # For selenium-webdriver on Windows
-  s.add_development_dependency 'rake', '~> 12.0'
-  s.add_development_dependency 'rspec', '~> 3.0'
-  s.add_development_dependency 'rubocop', '~>0.66'
-  s.add_development_dependency 'rubocop-performance'
-  s.add_development_dependency 'rubocop-rspec', '~>1.32'
-  s.add_development_dependency 'simplecov', '~>0.16'
-
-  s.add_runtime_dependency 'nokogiri', '~> 1.6'
-  s.add_runtime_dependency 'rubyzip', '>= 1.3.0'
-  s.add_runtime_dependency 'selenium-webdriver', '>= 3.0', '< 4.0'
-end