webdrivers 4.0.0.rc1 → 4.0.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 35e2346c87541df0f3aade8f330ef3f9df6376cd
-  data.tar.gz: fd9c3d144960b435ff139b1d6b7073ef9ebd5a87
+SHA256:
+  metadata.gz: c15a5f991a655dcb0ab30ccfa3daac4facd4f051e02147d48c140ee1f272c9b5
+  data.tar.gz: 035b0fd8214ba3d26a8789f349bef233e31a86b4cf7d6852f564a7681feffd3c
 SHA512:
-  metadata.gz: 0dd52833bcd3c354c45ec026c6d041d845018274fe27164a0fa0ec31f002b917221463659d9aa51e09824805444158775e63ba3b7c94c66e833b7f0dca09e2ab
-  data.tar.gz: 00e2e731f00ee020511d62fab5084eeaff766ffef19d7f11cba06e9a13dcd73ed31d2fd043811e5160de4dc920a515d9d74ee8244de7b7dd7484054fe7bed7d3
+  metadata.gz: ea32e06957c4b7b4fb4146ac21f1cabad8e712fd47f612c61e21dbd5eae0effe841874f4c5e8e9587d00a44ea85eb90c8fbbad600e05c3b713cb9748d93d697d
+  data.tar.gz: 6a8c82ee41b75e06028c01f20a15491f3f30e5ba6b4bfb5cc13b9e05390718199b4b4a36f27b261536cbabf5fc3e3bf4217c8229f87c65798b35070833e0cab3

data/.github/ISSUE_TEMPLATE.md

@@ -1,14 +1,14 @@
-#### Summary
-Short summary of the bug or feature request.
-
-#### Debug Info
-Please provide the following information for bug reports:
-
-* Operating system / CI Environment:
-* Browser and version:
-
-#### Expected Behavior
-What you expect to happen.
-
-#### Actual Behavior
+#### Summary
+Short summary of the bug or feature request.
+
+#### Debug Info
+Please provide the following information for bug reports:
+
+* Operating system / CI Environment:
+* Browser and version:
+
+#### Expected Behavior
+What you expect to happen.
+
+#### Actual Behavior
 What is actually happening: Error message, stack trace, DEBUG log if applicable (set `Webdrivers.logger.level = :DEBUG` after you require webdrivers)

data/.gitignore

@@ -1,7 +1,7 @@
-*.gem
-.bundle
-Gemfile.lock
-pkg/*
-chromedriver.log
-/.idea/
-coverage/
+*.gem
+.bundle
+Gemfile.lock
+pkg/*
+chromedriver.log
+/.idea/
+coverage/

data/CHANGELOG.md

@@ -1,11 +1,17 @@
+### 4.0.0.rc2 (2019-05-21)
+* Fix a bug with `WD_CACHE_TIME` when using the rake tasks (issue [#123](https://github.com/titusfortner/webdrivers/pull/123))
+
 ### 4.0.0.rc1 (2019-05-20)
-* locate Chrome binary the same way as chromedriver to ensure the correct browser version is obtained by default 
-* add rake tasts for update, remove and version
-* removed all deprecated code
+* Locate Chrome binary the same way as chromedriver to ensure the correct browser version is 
+obtained by default (issue [#45](https://github.com/titusfortner/webdrivers/issues/45))
+* Add rake tasks for update, remove and version 
+(issues [#28](https://github.com/titusfortner/webdrivers/issues/28) 
+[#77](https://github.com/titusfortner/webdrivers/issues/77))
+* Removed all deprecated code
 
 ### 3.9.4 (2019-05-20)
-* Fix bug from bug fix that warned users about setting cache time when it was already set (issue #118) 
-* make #base_url public for easier mocking (issue #109)
+* Fix bug from bug fix that warned users about setting cache time when it was already set (issue [#118](https://github.com/titusfortner/webdrivers/pull/118)) 
+* Make #base_url public for easier mocking (issue [#109](https://github.com/titusfortner/webdrivers/issues/109))
 
 ### 3.9.3 (2019-05-17)
 * Fix the bug that warned users about setting cache time when it was already set 

data/README.md

@@ -192,7 +192,11 @@ To use Microsoft Edge, please visit the
 
 ## Wiki
 
-Please see the [wiki](https://github.com/titusfortner/webdrivers/wiki) for solutions to commonly reported issues.
+Please see the [wiki](https://github.com/titusfortner/webdrivers/wiki) 
+for solutions to commonly reported issues.
+
+Join us in the `#webdrivers-gem` channel on [Slack](https://seleniumhq.herokuapp.com/)
+if you prefer a live discussion instead.
 
 ## License
 

data/lib/webdrivers/common.rb

@@ -26,7 +26,7 @@ module Webdrivers
     # Returns the amount of time (Seconds) the gem waits between two update checks.
     #
     def cache_time
-      @cache_time || ENV['WD_CACHE_TIME'].to_i
+      (@cache_time || ENV['WD_CACHE_TIME']).to_i
     end
 
     #

data/lib/webdrivers/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Webdrivers
-  VERSION = '4.0.0.rc1'
+  VERSION = '4.0.0.rc2'
 end

data/spec/webdrivers/chromedriver_spec.rb

@@ -134,13 +134,6 @@ describe Webdrivers::Chromedriver do
         expect(chromedriver.current_version.version).to eq('72.0.3626.7')
       end
     end
-
-    context 'when ENV variable WD_CACHE_TIME is set' do
-      it 'uses cache time value from ENV variable' do
-        allow(ENV).to receive(:[]).with('WD_CACHE_TIME').and_return('999')
-        expect(Webdrivers.cache_time).to be(999)
-      end
-    end
   end
 
   describe '#current_version' do
@@ -257,30 +250,6 @@ describe Webdrivers::Chromedriver do
     end
   end
 
-  describe '#install_dir' do
-    it 'uses ~/.webdrivers as default value' do
-      expect(Webdrivers.install_dir).to include('.webdriver')
-    end
-
-    it 'uses provided value' do
-      begin
-        install_dir            = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
-        Webdrivers.install_dir = install_dir
-
-        expect(Webdrivers.install_dir).to eq install_dir
-      ensure
-        Webdrivers.install_dir = nil
-      end
-    end
-
-    context 'when ENV variable WD_INSTALL_DIR is set' do
-      it 'uses path from the ENV variable' do
-        allow(ENV).to receive(:[]).with('WD_INSTALL_DIR').and_return('custom_dir')
-        expect(Webdrivers.install_dir).to be('custom_dir')
-      end
-    end
-  end
-
   describe '#driver_path' do
     it 'returns full location of binary' do
       expect(chromedriver.driver_path).to match("#{File.join(ENV['HOME'])}/.webdrivers/chromedriver")

data/spec/webdrivers/webdrivers_spec.rb

@@ -14,5 +14,55 @@ describe Webdrivers do
       msg = /Webdrivers Driver caching is turned off in this version, but will be enabled by default in 4\.x/
       expect { Webdrivers::Chromedriver.update }.not_to output(msg).to_stdout_from_any_process
     end
+
+    context 'when ENV variable WD_CACHE_TIME is set and Webdrivers.cache_time is not' do
+      before { described_class.cache_time = nil }
+
+      it 'uses cache time value from ENV variable' do
+        allow(ENV).to receive(:[]).with('WD_CACHE_TIME').and_return('999')
+        expect(described_class.cache_time).to be(999)
+      end
+
+      it 'returns cache time as an Integer' do
+        allow(ENV).to receive(:[]).with('WD_CACHE_TIME').and_return('999')
+        expect(described_class.cache_time).to be_an_instance_of(Integer)
+      end
+    end
+
+    context 'when Webdrivers.cache_time is set' do
+      it 'returns cache time as an Integer' do
+        described_class.cache_time = '999'
+        expect(described_class.cache_time).to be_an_instance_of(Integer)
+      end
+    end
+  end
+
+  describe '#install_dir' do
+    it 'uses ~/.webdrivers as default value' do
+      expect(described_class.install_dir).to include('.webdriver')
+    end
+
+    it 'uses provided value' do
+      begin
+        install_dir                 = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
+        described_class.install_dir = install_dir
+
+        expect(described_class.install_dir).to eq install_dir
+      ensure
+        described_class.install_dir = nil
+      end
+    end
+
+    context 'when ENV variable WD_INSTALL_DIR is set and Webdrivers.install_dir is not' do
+      it 'uses path from the ENV variable' do
+        begin
+          described_class.install_dir = nil
+          allow(ENV).to receive(:[]).with('WD_INSTALL_DIR').and_return('custom_dir')
+          expect(described_class.install_dir).to be('custom_dir')
+        ensure
+          described_class.install_dir = nil
+        end
+      end
+    end
   end
 end

data/webdrivers.gemspec

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 lib = File.expand_path('lib', __dir__)
-$:.unshift lib unless $:.include?(lib)
-require "webdrivers/version"
+$LOAD_PATH.unshift lib unless $LOAD_PATH.include?(lib)
+require 'webdrivers/version'
 
 Gem::Specification.new do |s|
   s.name        = 'webdrivers'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 4.0.0.rc1
+  version: 4.0.0.rc2
 platform: ruby
 authors:
 - Titus Fortner
@@ -212,15 +212,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.4
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Easy download and use of browser drivers.
-test_files:
-- spec/spec_helper.rb
-- spec/webdrivers/chromedriver_spec.rb
-- spec/webdrivers/geckodriver_spec.rb
-- spec/webdrivers/i_edriver_spec.rb
-- spec/webdrivers/webdrivers_spec.rb
-- spec/webdrivers_proxy_support_spec.rb
+test_files: []