webdrivers 3.8.0 → 3.8.1

data/lib/webdrivers/selenium.rb

@@ -1,38 +1,40 @@
-require 'selenium-webdriver'
-
-# v3.151.59 and higher
-if ::Selenium::WebDriver::Service.respond_to? :driver_path=
-  ::Selenium::WebDriver::Chrome::Service.driver_path  = proc { ::Webdrivers::Chromedriver.update }
-  ::Selenium::WebDriver::Firefox::Service.driver_path = proc { ::Webdrivers::Geckodriver.update }
-  ::Selenium::WebDriver::Edge::Service.driver_path    = proc { ::Webdrivers::MSWebdriver.update }
-  ::Selenium::WebDriver::IE::Service.driver_path      = proc { ::Webdrivers::IEdriver.update }
-else
-  # v3.141.0 and lower
-  module Selenium
-    module WebDriver
-      module Chrome
-        def self.driver_path
-          @driver_path ||= Webdrivers::Chromedriver.update
-        end
-      end
-
-      module Firefox
-        def self.driver_path
-          @driver_path ||= Webdrivers::Geckodriver.update
-        end
-      end
-
-      module Edge
-        def self.driver_path
-          @driver_path ||= Webdrivers::MSWebdriver.update
-        end
-      end
-
-      module IE
-        def self.driver_path
-          @driver_path ||= Webdrivers::IEdriver.update
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+require 'selenium-webdriver'
+
+# v3.151.59 and higher
+if ::Selenium::WebDriver::Service.respond_to? :driver_path=
+  ::Selenium::WebDriver::Chrome::Service.driver_path  = proc { ::Webdrivers::Chromedriver.update }
+  ::Selenium::WebDriver::Firefox::Service.driver_path = proc { ::Webdrivers::Geckodriver.update }
+  ::Selenium::WebDriver::Edge::Service.driver_path    = proc { ::Webdrivers::MSWebdriver.update }
+  ::Selenium::WebDriver::IE::Service.driver_path      = proc { ::Webdrivers::IEdriver.update }
+else
+  # v3.141.0 and lower
+  module Selenium
+    module WebDriver
+      module Chrome
+        def self.driver_path
+          @driver_path ||= Webdrivers::Chromedriver.update
+        end
+      end
+
+      module Firefox
+        def self.driver_path
+          @driver_path ||= Webdrivers::Geckodriver.update
+        end
+      end
+
+      module Edge
+        def self.driver_path
+          @driver_path ||= Webdrivers::MSWebdriver.update
+        end
+      end
+
+      module IE
+        def self.driver_path
+          @driver_path ||= Webdrivers::IEdriver.update
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,5 +1,12 @@
-require 'simplecov'
-SimpleCov.start
-
-require 'rspec'
-require 'webdrivers'
+# frozen_string_literal: true
+
+require 'simplecov'
+SimpleCov.start
+
+require 'rspec'
+require 'webdrivers'
+
+RSpec.configure do |config|
+  config.filter_run_including focus: true unless ENV['CI']
+  config.run_all_when_everything_filtered = true
+end

data/spec/webdrivers/chromedriver_spec.rb

@@ -1,104 +1,129 @@
-require 'spec_helper'
-
-describe Webdrivers::Chromedriver do
-  let(:chromedriver) { described_class }
-
-  it 'updates' do
-    chromedriver.update
-  end
-
-  it 'parses chromedriver versions before 2.10' do
-    expect(chromedriver.send(:normalize, '2.9').version).to eq '2.9'
-  end
-
-  it 'finds latest version' do
-    old_version = Gem::Version.new('2.30')
-    future_version = Gem::Version.new('80.00')
-    latest_version = chromedriver.latest_version
-
-    expect(latest_version).to be > old_version
-    expect(latest_version).to be < future_version
-  end
-
-  it 'downloads latest release for current version of Chrome by default' do
-    chromedriver.remove
-    chromedriver.download
-    cur_ver    = chromedriver.current_version.version
-    latest_ver = chromedriver.latest_version.version
-    expect(cur_ver).to eq latest_ver
-  end
-
-  it 'downloads specified version by Float' do
-    chromedriver.remove
-    chromedriver.version = 2.29
-    chromedriver.download
-    expect(chromedriver.current_version.version).to include '2.29'
-  end
-
-  it 'downloads specified version by String' do
-    chromedriver.remove
-    chromedriver.version = '73.0.3683.68'
-    chromedriver.download
-    expect(chromedriver.current_version.version).to eq '73.0.3683.68'
-  end
-
-  it 'removes chromedriver' do
-    chromedriver.remove
-    expect(chromedriver.current_version).to be_nil
-  end
-
-  if Selenium::WebDriver::Platform.linux? && ENV['TRAVIS']
-    # Ubuntu 14.04 (trusty) is limited to v65
-    context 'when using a Chromium version < 70.0.3538' do
-      before do
-        chromedriver.remove
-        chromedriver.version = nil
-        Selenium::WebDriver::Chrome.path = `which chromium-browser`.strip
-      end
-
-      it 'downloads chromedriver 2.46' do
-        chromedriver.update
-        expect(chromedriver.current_version.version[/\d+.\d+/]).to eq('2.46')
-      end
-    end
-  end
-
-  # Workaround for Google Chrome when using Jruby on Windows.
-  # @see https://github.com/titusfortner/webdrivers/issues/41
-  if RUBY_PLATFORM == 'java' && Selenium::WebDriver::Platform.windows?
-    context 'when using Jruby on Windows' do
-      it 'uses Jruby specific workaround to retrieve the Google Chrome version' do
-        chromedriver.remove
-        chromedriver.update
-        expect(chromedriver.current_version).not_to be_nil
-      end
-    end
-  end
-
-  context 'when offline' do
-    before { allow(chromedriver).to receive(:site_available?).and_return(false) }
-
-    it 'raises exception finding latest version' do
-      expect { chromedriver.latest_version }.to raise_error(StandardError, 'Can not reach site')
-    end
-
-    it 'raises exception downloading' do
-      expect { chromedriver.download }.to raise_error(StandardError, 'Can not reach site')
-    end
-  end
-
-  it 'allows setting of install directory' do
-    begin
-      install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
-      Webdrivers.install_dir = install_dir
-      expect(chromedriver.install_dir).to eq install_dir
-    ensure
-      Webdrivers.install_dir = nil
-    end
-  end
-
-  it 'returns full location of binary' do
-    install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers'))
-    expect(chromedriver.binary).to match %r{#{install_dir}/chromedriver}
-  end
-end
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Webdrivers::Chromedriver do
+  let(:chromedriver) { described_class }
+
+  it 'updates' do
+    chromedriver.update
+  end
+
+  it 'parses chromedriver versions before 2.10' do
+    expect(chromedriver.send(:normalize_version, '2.9').version).to eq '2.9'
+  end
+
+  it 'finds latest version' do
+    old_version = Gem::Version.new('2.30')
+    future_version = Gem::Version.new('80.00')
+    latest_version = chromedriver.latest_version
+
+    expect(latest_version).to be > old_version
+    expect(latest_version).to be < future_version
+  end
+
+  it 'downloads latest release for current version of Chrome by default' do
+    chromedriver.remove
+    chromedriver.download
+    cur_ver    = chromedriver.current_version.version
+    latest_ver = chromedriver.latest_version.version
+    expect(cur_ver).to eq latest_ver
+  end
+
+  it 'downloads specified version by Float' do
+    chromedriver.remove
+    chromedriver.version = 2.29
+    chromedriver.download
+    expect(chromedriver.current_version.version).to include '2.29'
+  end
+
+  it 'downloads specified version by String' do
+    chromedriver.remove
+    chromedriver.version = '73.0.3683.68'
+    chromedriver.download
+    expect(chromedriver.current_version.version).to eq '73.0.3683.68'
+  end
+
+  it 'removes chromedriver' do
+    chromedriver.remove
+    expect(chromedriver.current_version).to be_nil
+  end
+
+  context 'when using a Chromium version < 70.0.3538' do
+    it 'downloads chromedriver 2.46' do
+      chromedriver.remove
+      chromedriver.version = nil
+      chromedriver.instance_variable_set('@latest_version', nil)
+
+      allow(chromedriver).to receive(:chrome_version).and_return('70.0.0')
+      chromedriver.update
+
+      expect(chromedriver.current_version.version[/\d+.\d+/]).to eq('2.46')
+    end
+  end
+
+  context 'when using a Chromium version that does not have an associated driver' do
+    before do
+      chromedriver.remove
+      chromedriver.version = nil
+      chromedriver.instance_variable_set('@latest_version', nil)
+    end
+
+    it 'raises an exception for beta version' do
+      allow(chromedriver).to receive(:chrome_version).and_return('100.0.0')
+      msg = 'you appear to be using a non-production version of Chrome; please set '\
+'`Webdrivers::Chromedriver.version = <desired driver version>` to an known chromedriver version: '\
+'https://chromedriver.storage.googleapis.com/index.html'
+      expect { chromedriver.update }.to raise_exception(StandardError, msg)
+    end
+
+    it 'raises an exception for unknown version' do
+      allow(chromedriver).to receive(:chrome_version).and_return('72.0.0')
+      msg = 'please set `Webdrivers::Chromedriver.version = <desired driver version>` to an known chromedriver '\
+'version: https://chromedriver.storage.googleapis.com/index.html'
+      expect { chromedriver.update }.to raise_exception(StandardError, msg)
+    end
+  end
+
+  # Workaround for Google Chrome when using Jruby on Windows.
+  # @see https://github.com/titusfortner/webdrivers/issues/41
+  if RUBY_PLATFORM == 'java' && Selenium::WebDriver::Platform.windows?
+    context 'when using Jruby on Windows' do
+      it 'uses Jruby specific workaround to retrieve the Google Chrome version' do
+        chromedriver.remove
+        chromedriver.update
+        expect(chromedriver.current_version).not_to be_nil
+      end
+    end
+  end
+
+  context 'when offline' do
+    before do
+      chromedriver.instance_variable_set('@latest_version', nil)
+      allow(chromedriver).to receive(:site_available?).and_return(false)
+    end
+
+    it 'raises exception finding latest version' do
+      expect { chromedriver.latest_version }.to raise_error(StandardError, 'Can not reach site')
+    end
+
+    it 'raises exception downloading' do
+      expect { chromedriver.download }.to raise_error(StandardError, 'Can not reach site')
+    end
+  end
+
+  it 'allows setting of install directory' do
+    begin
+      install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers2'))
+      Webdrivers.install_dir = install_dir
+      expect(chromedriver.install_dir).to eq install_dir
+    ensure
+      Webdrivers.install_dir = nil
+    end
+  end
+
+  it 'returns full location of binary' do
+    install_dir = File.expand_path(File.join(ENV['HOME'], '.webdrivers'))
+    expect(chromedriver.binary).to match %r{#{install_dir}/chromedriver}
+  end
+end

data/spec/webdrivers/geckodriver_spec.rb

@@ -1,60 +1,66 @@
-require 'spec_helper'
-
-describe Webdrivers::Geckodriver do
-  let(:geckodriver) { described_class }
-
-  it 'raises exception if unable to get latest geckodriver and no geckodriver present' do
-    geckodriver.remove
-    allow(geckodriver).to receive(:desired_version).and_return(nil)
-    msg = /^Unable to find the latest version of geckodriver(.exe)?; try downloading manually from (.*)?and place in (.*)?\.webdrivers$/
-    expect { geckodriver.update }.to raise_exception StandardError, msg
-  end
-
-  it 'uses found version of geckodriver if latest release unable to be found' do
-    geckodriver.download
-    allow(geckodriver).to receive(:desired_version).and_return(nil)
-    expect(geckodriver.update).to match(%r{\.webdrivers/geckodriver})
-  end
-
-  it 'finds latest version' do
-    old_version = Gem::Version.new('0.17')
-    future_version = Gem::Version.new('0.30')
-    desired_version = geckodriver.desired_version
-
-    expect(desired_version).to be > old_version
-    expect(desired_version).to be < future_version
-  end
-
-  it 'downloads latest version by default' do
-    geckodriver.download
-    expect(geckodriver.current_version).to eq geckodriver.desired_version
-  end
-
-  it 'downloads specified version' do
-    begin
-      geckodriver.remove
-      geckodriver.version = '0.17.0'
-      geckodriver.download
-      expect(geckodriver.current_version.version).to eq '0.17.0'
-    ensure
-      geckodriver.version = nil
-    end
-  end
-
-  it 'removes geckodriver' do
-    geckodriver.remove
-    expect(geckodriver.current_version).to be_nil
-  end
-
-  context 'when offline' do
-    before { allow(geckodriver).to receive(:site_available?).and_return(false) }
-
-    it 'raises exception finding latest version' do
-      expect { geckodriver.desired_version }.to raise_error(StandardError, 'Can not reach site')
-    end
-
-    it 'raises exception downloading' do
-      expect { geckodriver.download }.to raise_error(StandardError, 'Can not reach site')
-    end
-  end
-end
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe Webdrivers::Geckodriver do
+  let(:geckodriver) { described_class }
+
+  it 'raises exception if unable to get latest geckodriver and no geckodriver present' do
+    geckodriver.remove
+    allow(geckodriver).to receive(:desired_version).and_return(nil)
+    gd = 'Unable to find the latest version of geckodriver'
+    msg = /^#{gd}(.exe)?; try downloading manually from (.*)?and place in (.*)?\.webdrivers$/
+    expect { geckodriver.update }.to raise_exception StandardError, msg
+  end
+
+  it 'uses found version of geckodriver if latest release unable to be found' do
+    geckodriver.download
+    allow(geckodriver).to receive(:desired_version).and_return(nil)
+    expect(geckodriver.update).to match(%r{\.webdrivers/geckodriver})
+  end
+
+  it 'finds latest version' do
+    old_version = Gem::Version.new('0.17')
+    future_version = Gem::Version.new('0.30')
+    desired_version = geckodriver.desired_version
+
+    expect(desired_version).to be > old_version
+    expect(desired_version).to be < future_version
+  end
+
+  it 'downloads latest version by default' do
+    geckodriver.download
+    expect(geckodriver.current_version).to eq geckodriver.desired_version
+  end
+
+  it 'downloads specified version' do
+    begin
+      geckodriver.remove
+      geckodriver.version = '0.17.0'
+      geckodriver.download
+      expect(geckodriver.current_version.version).to eq '0.17.0'
+    ensure
+      geckodriver.version = nil
+    end
+  end
+
+  it 'removes geckodriver' do
+    geckodriver.remove
+    expect(geckodriver.current_version).to be_nil
+  end
+
+  context 'when offline' do
+    before do
+      geckodriver.instance_variable_set('@latest_version', nil)
+      allow(geckodriver).to receive(:site_available?).and_return(false)
+    end
+
+    it 'raises exception finding latest version' do
+      expect { geckodriver.desired_version }.to raise_error(StandardError, 'Can not reach site')
+    end
+
+    it 'raises exception downloading' do
+      expect { geckodriver.download }.to raise_error(StandardError, 'Can not reach site')
+    end
+  end
+end