webdrivers 3.7.2 → 3.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6ef60a7f9627b14fa90b684a1f807e8b853a0eda388bd21d8a3017ca98da585d
-  data.tar.gz: 8d221be9ff66fd793c50934990c12236349a0ad04a1b0e9a9fcfc7d65632231a
+  metadata.gz: f215e928688103db9bbc522a6af8058bd47f11fa48b553923d6b1a70bdb9a1ee
+  data.tar.gz: fa1b202ad49b119ddf1ad2eedfc6dc520d25a2de3e88aabd5cc91ed4a9342d15
 SHA512:
-  metadata.gz: 32bb8a8f53ad38f1d6a6e7f25c62787039db4e4e165f5d52f08877a05da8230bcb1fc2387cfd8cd75aa653aed689ee06eb21ea0fd25e3b491c0605d5f2c0ca86
-  data.tar.gz: 3dc0a5206c967a98b25aa5e0bf1b257769d362894f4f00141a988b6fdd6bd395cbc40785dee73c88e016b0cb40c3b0198696e950db4a6cdda43e38d1278349f5
+  metadata.gz: 9c075eb9927535e331def0814676e54c1844a383ba641507ca09327b63839c2bb2691e08039c3bd3d14f590eaebfd9f09d59c4fc46098164d9a266c54803c67e
+  data.tar.gz: 84f7e19c0a7aca6b09d3407b26dad01098027373530ac0916f6d8cf19894cdb57c91ba6345ed71c6c798d99fdb57af5297098120a8dfc2606acf71314bc0400c

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-### 3.7.2 (2019-03-29)
+### 3.8.0 (2019-04-17)
+* Add support for `selenium-webdriver` v4. See [#69](https://github.com/titusfortner/webdrivers/pull/69).
+* Remove dependency on `net_http_ssl_fix` gem. `Webdrivers.net_http_ssl_fix` now raises an exception and points to other solutions. See [#60](https://github.com/titusfortner/webdrivers/pull/60) and [#68](https://github.com/titusfortner/webdrivers/pull/68).
+
+### 3.7.2 (2019-04-01)
 * Fix bugs in methods that retrieve Chrome/Chromium version. See [#43](https://github.com/titusfortner/webdrivers/pull/43) and [#52](https://github.com/titusfortner/webdrivers/issues/52).
 * Add workaround for a Jruby bug when retrieving Chrome version on Windows. See [#41](https://github.com/titusfortner/webdrivers/issues/41).
 * Update README with more information.

data/README.md

@@ -5,7 +5,7 @@
 
 Run Selenium tests more easily with automatic installation and updates for all supported webdrivers.
 
-# Description
+## Description
 
 `webdrivers` downloads drivers and directs Selenium to use them. Currently supports:
 
@@ -14,7 +14,7 @@ Run Selenium tests more easily with automatic installation and updates for all s
 * [IEDriverServer](https://github.com/SeleniumHQ/selenium/wiki/InternetExplorerDriver)
 * [MicrosoftWebDriver](https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/)
 
-# Usage
+## Usage
 
 In your Gemfile: 
 
@@ -29,7 +29,7 @@ require 'webdrivers'
 The drivers will now be automatically downloaded or updated when you launch a browser
 through Selenium. 
 
-**Download Location**
+### Download Location
 
 The default download location is `~/.webdrivers` directory, and this is configurable:
  
@@ -37,7 +37,7 @@ The default download location is `~/.webdrivers` directory, and this is configur
  Webdrivers.install_dir = '/webdrivers/install/dir'
 ```
 
-**Version Pinning**
+### Version Pinning
 
 If you would like to use a specific (older or beta) version, you can specify it for each driver. Otherwise, the latest (stable) 
 driver will be downloaded and passed to Selenium.
@@ -62,7 +62,7 @@ You can also trigger the update in your code, but it is not required:
 Webdrivers::Chromedriver.update
 ```
 
-# Proxy
+### Proxy
 
 If there is a proxy between you and the Internet then you will need to configure
 the gem to use the proxy.  You can do this by calling the `configure` method.
@@ -76,17 +76,27 @@ Webdrivers.configure do |config|
 end
 ````
 
+### `SSL_connect` errors
+
 If you are getting an error like this (especially common on Windows):
  
 `SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed`
 
+Add the following to your Gemfile:
+
+```ruby
+gem "net_http_ssl_fix"
+```
+
 Add the following to your code:
 
 ````ruby
-Webdrivers.net_http_ssl_fix
+require 'net_http_ssl_fix'
 ````
 
-# Logging
+Other solutions are documented on the RubyGems [website](https://guides.rubygems.org/ssl-certificate-update/).
+
+### Logging
 
 The logging level can be configured for debugging purpose:
 
@@ -94,9 +104,9 @@ The logging level can be configured for debugging purpose:
 Webdrivers.logger.level = :DEBUG
 ```
 
-# Browser Specific Notes
+### Browser Specific Notes
 
-**When using Chrome/Chromium**
+#### When using Chrome/Chromium
 
 The version of `chromedriver` will depend on the version of Chrome you are using it with:
 
@@ -112,7 +122,7 @@ Selenium::WebDriver::Chrome.path = '/chromium/install/path/to/binary'
 
 This is also required if Google Chrome is not installed in its [default location](https://github.com/SeleniumHQ/selenium/wiki/ChromeDriver).
 
-**When using Microsoft Edge**
+#### When using Microsoft Edge
 
 After updating Microsoft Edge on Windows 10, you will need to delete the existing binary (`%USERPROFILE%/.webdrivers/MicrosoftWebDriver.exe`) to
 to be able to download the latest version through this gem.
@@ -124,21 +134,19 @@ expected version and skips the download process.
 
 If you continue with the outdated binary, Selenium will throw an error: `unable to connect to MicrosoftWebDriver localhost:17556`.
 
-# Wiki
+## Wiki
 
 Please see the [wiki](https://github.com/titusfortner/webdrivers/wiki) for solutions to commonly reported issues.
 
-# License
+## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT),
 see LICENSE.txt for full details and copyright.
 
-
-# Contributing
+## Contributing
 
 Bug reports and pull requests are welcome [on GitHub](https://github.com/titusfortner/webdrivers). Run `bundle exec rake` and squash the commits in your PRs.
 
-
 ## Copyright
 
 Copyright (c) 2017 Titus Fortner

data/lib/webdrivers.rb

@@ -19,7 +19,8 @@ module Webdrivers
     end
 
     def net_http_ssl_fix
-      require 'net_http_ssl_fix'
+      raise 'Webdrivers.net_http_ssl_fix is no longer available.' \
+      ' Please see https://github.com/titusfortner/webdrivers#ssl_connect-errors.'
     end
   end
 end

data/lib/webdrivers/common.rb

@@ -137,8 +137,8 @@ module Webdrivers
         get(base_url)
         Webdrivers.logger.debug "Found Site: #{base_url}"
         true
-      rescue StandardError => ex
-        Webdrivers.logger.debug ex.inspect
+      rescue StandardError => e
+        Webdrivers.logger.debug e
         false
       end
 

data/lib/webdrivers/selenium.rb

@@ -1,28 +1,37 @@
 require 'selenium-webdriver'
 
-module Selenium
-  module WebDriver
-    module Chrome
-      def self.driver_path
-        @driver_path ||= Webdrivers::Chromedriver.update
+# v3.151.59 and higher
+if ::Selenium::WebDriver::Service.respond_to? :driver_path=
+  ::Selenium::WebDriver::Chrome::Service.driver_path  = proc { ::Webdrivers::Chromedriver.update }
+  ::Selenium::WebDriver::Firefox::Service.driver_path = proc { ::Webdrivers::Geckodriver.update }
+  ::Selenium::WebDriver::Edge::Service.driver_path    = proc { ::Webdrivers::MSWebdriver.update }
+  ::Selenium::WebDriver::IE::Service.driver_path      = proc { ::Webdrivers::IEdriver.update }
+else
+  # v3.141.0 and lower
+  module Selenium
+    module WebDriver
+      module Chrome
+        def self.driver_path
+          @driver_path ||= Webdrivers::Chromedriver.update
+        end
       end
-    end
 
-    module Firefox
-      def self.driver_path
-        @driver_path ||= Webdrivers::Geckodriver.update
+      module Firefox
+        def self.driver_path
+          @driver_path ||= Webdrivers::Geckodriver.update
+        end
       end
-    end
 
-    module Edge
-      def self.driver_path
-        @driver_path ||= Webdrivers::MSWebdriver.update
+      module Edge
+        def self.driver_path
+          @driver_path ||= Webdrivers::MSWebdriver.update
+        end
       end
-    end
 
-    module IE
-      def self.driver_path
-        @driver_path ||= Webdrivers::IEdriver.update
+      module IE
+        def self.driver_path
+          @driver_path ||= Webdrivers::IEdriver.update
+        end
       end
     end
   end

data/spec/webdrivers_proxy_support_spec.rb

@@ -42,4 +42,10 @@ describe Webdrivers do
   it 'does not use the Proxy when proxy is not configured' do
     expect(http_object.instance_variable_get('@is_proxy_class')).to be false
   end
+
+  it 'raises an exception when net_http_ssl_fix is called.' do
+    err = 'Webdrivers.net_http_ssl_fix is no longer available.' \
+      ' Please see https://github.com/titusfortner/webdrivers#ssl_connect-errors.'
+    expect { described_class.net_http_ssl_fix }.to raise_error(StandardError, err)
+  end
 end

data/webdrivers.gemspec

@@ -2,7 +2,7 @@ $LOAD_PATH.push File.expand_path('../lib', __dir__)
 
 Gem::Specification.new do |s|
   s.name        = 'webdrivers'
-  s.version     = '3.7.2'
+  s.version     = '3.8.0'
   s.authors     = ['Titus Fortner', 'Lakshya Kapoor']
   s.email       = %w[titusfortner@gmail.com kapoorlakshya@gmail.com]
   s.homepage    = 'https://github.com/titusfortner/webdrivers'
@@ -21,7 +21,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rubocop-rspec', '~>1.32'
   s.add_development_dependency 'simplecov', '~>0.16'
 
-  s.add_runtime_dependency 'net_http_ssl_fix'
   s.add_runtime_dependency 'nokogiri', '~> 1.6'
   s.add_runtime_dependency 'rubyzip', '~> 1.0'
   s.add_runtime_dependency 'selenium-webdriver', '~> 3.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.7.2
+  version: 3.8.0
 platform: ruby
 authors:
 - Titus Fortner
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-01 00:00:00.000000000 Z
+date: 2019-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -81,20 +81,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.16'
-- !ruby/object:Gem::Dependency
-  name: net_http_ssl_fix
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement