webdrivers 3.7.1 → 3.7.2

data/spec/{geckodriver_spec.rb → webdrivers/geckodriver_spec.rb}

@@ -1,8 +1,7 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Webdrivers::Geckodriver do
-
-  let(:geckodriver) { Webdrivers::Geckodriver }
+  let(:geckodriver) { described_class }
 
   it 'raises exception if unable to get latest geckodriver and no geckodriver present' do
     geckodriver.remove
@@ -14,7 +13,7 @@ describe Webdrivers::Geckodriver do
   it 'uses found version of geckodriver if latest release unable to be found' do
     geckodriver.download
     allow(geckodriver).to receive(:desired_version).and_return(nil)
-    expect(geckodriver.update).to match(/\.webdrivers\/geckodriver/)
+    expect(geckodriver.update).to match(%r{\.webdrivers/geckodriver})
   end
 
   it 'finds latest version' do
@@ -51,12 +50,11 @@ describe Webdrivers::Geckodriver do
     before { allow(geckodriver).to receive(:site_available?).and_return(false) }
 
     it 'raises exception finding latest version' do
-      expect { geckodriver.desired_version }.to raise_error(StandardError, "Can not reach site")
+      expect { geckodriver.desired_version }.to raise_error(StandardError, 'Can not reach site')
     end
 
     it 'raises exception downloading' do
-      expect { geckodriver.download }.to raise_error(StandardError, "Can not reach site")
+      expect { geckodriver.download }.to raise_error(StandardError, 'Can not reach site')
     end
   end
-
 end

data/spec/{iedriver_spec.rb → webdrivers/i_edriver_spec.rb}

@@ -1,12 +1,11 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Webdrivers::IEdriver do
-
-  let(:iedriver) { Webdrivers::IEdriver }
+  let(:iedriver) { described_class }
 
   it 'finds latest version' do
-    old_version = Gem::Version.new("3.12.0")
-    future_version = Gem::Version.new("4.0")
+    old_version = Gem::Version.new('3.12.0')
+    future_version = Gem::Version.new('4.0')
     desired_version = iedriver.desired_version
 
     expect(desired_version).to be > old_version
@@ -27,12 +26,11 @@ describe Webdrivers::IEdriver do
     before { allow(iedriver).to receive(:site_available?).and_return(false) }
 
     it 'raises exception finding latest version' do
-      expect {iedriver.latest_version}.to raise_error(StandardError, "Can not reach site")
+      expect { iedriver.latest_version }.to raise_error(StandardError, 'Can not reach site')
     end
 
     it 'raises exception downloading' do
-      expect {iedriver.download}.to raise_error(StandardError, "Can not reach site")
+      expect { iedriver.download }.to raise_error(StandardError, 'Can not reach site')
     end
   end
-
 end

data/spec/{mswebdriver_spec.rb → webdrivers/ms_webdriver_spec.rb}

@@ -1,8 +1,7 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Webdrivers::MSWebdriver do
-
-  let(:mswebdriver) { Webdrivers::MSWebdriver }
+  let(:mswebdriver) { described_class }
 
   it 'downloads mswebdriver' do
     mswebdriver.remove
@@ -12,15 +11,14 @@ describe Webdrivers::MSWebdriver do
 
   it 'removes mswebdriver' do
     mswebdriver.remove
-    expect(File.exist?(mswebdriver.send :binary)).to be false
+    expect(File.exist?(mswebdriver.send(:binary))).to be false
   end
 
   context 'when offline' do
     before { allow(mswebdriver).to receive(:site_available?).and_return(false) }
 
     it 'raises exception downloading' do
-      expect { mswebdriver.download }.to raise_error(StandardError, "Can not reach site")
+      expect { mswebdriver.download }.to raise_error(StandardError, 'Can not reach site')
     end
   end
-
 end

data/spec/webdrivers_proxy_support_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+class FakeDriver < Webdrivers::Common
+  def self.http_object
+    http
+  end
+end
+
+describe Webdrivers do
+  let(:http_object) { FakeDriver.http_object }
+
+  before do
+    described_class.proxy_addr = nil
+    described_class.proxy_port = nil
+    described_class.proxy_user = nil
+    described_class.proxy_pass = nil
+  end
+
+  it 'allows the proxy values to be set via configuration' do
+    described_class.configure do |config|
+      config.proxy_addr = 'proxy_addr'
+      config.proxy_port = '8888'
+      config.proxy_user = 'proxy_user'
+      config.proxy_pass = 'proxy_pass'
+    end
+
+    expect(described_class.proxy_addr).to eql 'proxy_addr'
+    expect(described_class.proxy_port).to eql '8888'
+    expect(described_class.proxy_user).to eql 'proxy_user'
+    expect(described_class.proxy_pass).to eql 'proxy_pass'
+  end
+
+  it 'uses the Proxy when the proxy_addr is set' do
+    described_class.configure do |config|
+      config.proxy_addr = 'proxy_addr'
+      config.proxy_port = '8080'
+    end
+
+    expect(http_object.instance_variable_get('@is_proxy_class')).to be true
+  end
+
+  it 'does not use the Proxy when proxy is not configured' do
+    expect(http_object.instance_variable_get('@is_proxy_class')).to be false
+  end
+end

data/webdrivers.gemspec

@@ -1,10 +1,8 @@
-# -*- encoding: utf-8 -*-
-
 $LOAD_PATH.push File.expand_path('../lib', __dir__)
 
 Gem::Specification.new do |s|
   s.name        = 'webdrivers'
-  s.version     = '3.7.1'
+  s.version     = '3.7.2'
   s.authors     = ['Titus Fortner', 'Lakshya Kapoor']
   s.email       = %w[titusfortner@gmail.com kapoorlakshya@gmail.com]
   s.homepage    = 'https://github.com/titusfortner/webdrivers'
@@ -19,6 +17,9 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'rake', '~> 10.0'
   s.add_development_dependency 'rspec', '~> 3.0'
+  s.add_development_dependency 'rubocop', '~>0.66'
+  s.add_development_dependency 'rubocop-rspec', '~>1.32'
+  s.add_development_dependency 'simplecov', '~>0.16'
 
   s.add_runtime_dependency 'net_http_ssl_fix'
   s.add_runtime_dependency 'nokogiri', '~> 1.6'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.7.1
+  version: 3.7.2
 platform: ruby
 authors:
 - Titus Fortner
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-26 00:00:00.000000000 Z
+date: 2019-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -39,6 +39,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.66'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.66'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.32'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.32'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
 - !ruby/object:Gem::Dependency
   name: net_http_ssl_fix
   requirement: !ruby/object:Gem::Requirement
@@ -105,6 +147,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -119,12 +162,12 @@ files:
 - lib/webdrivers/logger.rb
 - lib/webdrivers/mswebdriver.rb
 - lib/webdrivers/selenium.rb
-- spec/chromedriver_spec.rb
-- spec/geckodriver_spec.rb
-- spec/iedriver_spec.rb
-- spec/mswebdriver_spec.rb
-- spec/proxy_support_spec.rb
 - spec/spec_helper.rb
+- spec/webdrivers/chromedriver_spec.rb
+- spec/webdrivers/geckodriver_spec.rb
+- spec/webdrivers/i_edriver_spec.rb
+- spec/webdrivers/ms_webdriver_spec.rb
+- spec/webdrivers_proxy_support_spec.rb
 - webdrivers.gemspec
 homepage: https://github.com/titusfortner/webdrivers
 licenses:
@@ -145,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Easy download and use of browser drivers.

data/spec/proxy_support_spec.rb

@@ -1,45 +0,0 @@
-require 'spec_helper'
-
-class FakeDriver < Webdrivers::Common
-  def self.http_object
-    self.http
-  end
-end
-
-describe "Support for proxies" do
-  let(:http_object) { FakeDriver.http_object }
-
-  before do
-    Webdrivers.proxy_addr = nil
-    Webdrivers.proxy_port = nil
-    Webdrivers.proxy_user = nil
-    Webdrivers.proxy_pass = nil
-  end
-
-  it 'should allow the proxy values to be set via configuration' do
-    Webdrivers.configure do |config|
-      config.proxy_addr = 'proxy_addr'
-      config.proxy_port = '8888'
-      config.proxy_user = 'proxy_user'
-      config.proxy_pass = 'proxy_pass'
-    end
-
-    expect(Webdrivers.proxy_addr).to eql 'proxy_addr'
-    expect(Webdrivers.proxy_port).to eql '8888'
-    expect(Webdrivers.proxy_user).to eql 'proxy_user'
-    expect(Webdrivers.proxy_pass).to eql 'proxy_pass'
-  end
-
-  it 'should use the Proxy when the proxy_addr is set' do
-    Webdrivers.configure do |config|
-      config.proxy_addr = 'proxy_addr'
-      config.proxy_port = '8080'
-    end
-
-    expect(http_object.instance_variable_get('@is_proxy_class')).to be true
-  end
-
-  it 'should not use the Proxy when proxy is not configured' do
-    expect(http_object.instance_variable_get('@is_proxy_class')).to be false
-  end
-end