webdrivers 3.3.1 → 3.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e797daab91623814fcd8a1d5ab92edccf0be063
-  data.tar.gz: d0f7101c1f88765150d2fdba2dd47974f2adb298
+  metadata.gz: 98ee403ab70bdf319556340985c8b55679f32f8b
+  data.tar.gz: 20b7c301923679af4b44303c0773e002e1ae78ef
 SHA512:
-  metadata.gz: 221dfa39597516e7f7dd876f52095dc87af490f72f82cb417776ccd86918609656d408eebf9dd2768523a5cad2f24d378b71bad534e09909c31501ab96e44c01
-  data.tar.gz: 2f2c9732436f84bdc4a1a2a21fd6d693d5722eb50af22aeffb18f68fd34c9365b0bf3abae0585f3beb758f4ce603a66ca74a59877c66ade2f274c01e95885239
+  metadata.gz: 4847b46b7053268160fc437d2c484c082de30f8b3201d783e0b30038d3816b0ca2a18b2a20dca09ec2ca21012ae46c09d7377de8c759418479fca1ce24db6bda
+  data.tar.gz: cd06df2ec1222f1315219d284dd712209fcc5c329720222a8822460af8035ca8bb4e519d418fe1da0923d0fc62e922c2b9d53ca1aaebe6181eb8c6cdc4eaa23c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 3.3.2 (2018-05-04)
+
+* Fix bug with IEDriver versioning (Thanks Aleksei Gusev)
+
 ### 3.3.1 (2018-05-04)
 
 * Fix bug with MSWebdriver to fetch the correct driver instead of latest (Thanks kapoorlakshya) 

data/lib/webdrivers/iedriver.rb

@@ -1,4 +1,5 @@
 require 'nokogiri'
+require 'rubygems/version'
 
 module Webdrivers
   class IEdriver < Common
@@ -12,10 +13,15 @@ module Webdrivers
         normalize string.match(/IEDriverServer.exe (\d\.\d+\.\d*\.\d*)/)[1]
       end
 
+      def latest
+        downloads.keys.sort.last
+      end
+
+
       private
 
       def normalize(string)
-        string.to_f
+        Gem::Version.new(string)
       end
 
       def file_name
@@ -35,7 +41,7 @@ module Webdrivers
           items = doc.css("Key").collect(&:text)
           items.select! { |item| item.include?('IEDriverServer_Win32') }
           ds = items.each_with_object({}) do |item, hash|
-            key = normalize item[/^[^\/]+/]
+            key = normalize item[/([^_]+)\.zip/, 1]
             hash[key] = "#{base_url}#{item}"
           end
           Webdrivers.logger.debug "Versions now located on downloads site: #{ds.keys}"

data/spec/iedriver_spec.rb

@@ -5,8 +5,7 @@ describe Webdrivers::IEdriver do
   let(:iedriver) { Webdrivers::IEdriver }
 
   it 'finds latest version' do
-    expect(iedriver.latest).to be > 3.4
-    expect(iedriver.latest).to be < 4
+    expect(iedriver.latest.segments).to eq [3, 12, 0]
   end
 
   it 'downloads iedriver' do

data/spec/mswebdriver_spec.rb

@@ -19,7 +19,7 @@ describe Webdrivers::MSWebdriver do
     before { allow(mswebdriver).to receive(:site_available?).and_return(false) }
 
     it 'raises exception downloading' do
-      expect { mswebdriver.download }.to raise_error(StandardError, "Can not reach site")
+      expect { mswebdriver.download }.to raise_error(RuntimeError, "Failed to check Microsoft Edge version.")
     end
   end
 

data/webdrivers.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "webdrivers"
-  s.version     = "3.3.1"
+  s.version     = "3.3.2"
   s.authors     = ["Titus Fortner"]
   s.email       = ["titusfortner@gmail.com"]
   s.homepage    = "https://github.com/titusfortner/webdrivers"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.2
 platform: ruby
 authors:
 - Titus Fortner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-04 00:00:00.000000000 Z
+date: 2018-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -130,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.2.3
 signing_key: 
 specification_version: 4
 summary: Easy download and use of browser drivers.