webdrivers 3.3.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38a8045b1c217acbc4ef3163a4c5cf9c7b49f39d
-  data.tar.gz: c37958c1c522eaa4678052ffa59699287f182cce
+  metadata.gz: 5e797daab91623814fcd8a1d5ab92edccf0be063
+  data.tar.gz: d0f7101c1f88765150d2fdba2dd47974f2adb298
 SHA512:
-  metadata.gz: 3f393257af259775e469647eb1d6bd3bc2afd869ffc7fbf03a9bf00188d6be30157cf214610f0398c0451f06ef99b1d3d9ff0abbe5769c1595373308e097cacf
-  data.tar.gz: 30e8898a5314378a9df00b15100bdb5c63e914b991d683b42fccc3422ddd351ebcf4c0f67b181df010418333ca7dfcd3c35a49045f069337dce7e02a9a768977
+  metadata.gz: 221dfa39597516e7f7dd876f52095dc87af490f72f82cb417776ccd86918609656d408eebf9dd2768523a5cad2f24d378b71bad534e09909c31501ab96e44c01
+  data.tar.gz: 2f2c9732436f84bdc4a1a2a21fd6d693d5722eb50af22aeffb18f68fd34c9365b0bf3abae0585f3beb758f4ce603a66ca74a59877c66ade2f274c01e95885239

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 3.3.1 (2018-05-04)
+
+* Fix bug with MSWebdriver to fetch the correct driver instead of latest (Thanks kapoorlakshya) 
+
 ### 3.3.0 (2018-04-29)
 
 * Ensures downloading correct MSWebdriver version (Thanks kapoorlakshya) 

data/README.md

@@ -24,7 +24,7 @@ in your Gemfile:
 
 in your project:
 
-`require 'webdrivers'
+`require 'webdrivers'`
 
 If there is a proxy between you and the Internet then you will need to configure
 the gem to use the proxy.  You can do this by calling the `configure` method.
@@ -38,6 +38,18 @@ Webdrivers.configure do |config|
 end
 ````
 
+**Note when using Microsoft Edge**:
+
+After updating Microsoft Edge on Windows 10, you will need to delete the existing binary (`%USERPROFILE%/.webdrivers/MicrosoftWebDriver.exe`) to
+to be able to download the latest version through this gem.
+
+This is because `MicrosoftWebDriver.exe` is not backwards compatible and it does not have an argument to retrieve 
+the current version. We work around this limitation by querying the current Edge version from the registry and 
+fetching the corresponding binary IF a file does not already exist. If a file does exist, the gem assumes it is the 
+expected version and skips the download process.
+
+If you continue with the outdated binary, Selenium will throw an error: `unable to connect to MicrosoftWebDriver localhost:17556`.
+
 # License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT), 

data/lib/webdrivers/common.rb

@@ -9,24 +9,23 @@ module Webdrivers
         unless site_available?
           return current.nil? ? nil : binary
         end
-        released      = latest()
-        location      = binary()
-        binary_exists = File.exists?(location)
+        released = latest()
+        location = binary()
 
-        return location if released.nil? && binary_exists
+        return location if released.nil? && File.exists?(binary) # Newer not found, keep current
 
-        if released.nil?
+        if released.nil? # Can't find latest and no existing binary
           msg = "Unable to find the latest version of #{file_name}; try downloading manually from #{base_url} and place in #{install_dir}"
           raise StandardError, msg
         end
 
-        if current == released && binary_exists # Already have latest/matching one
+        if correct_binary?
           Webdrivers.logger.debug "Expected webdriver version found"
           return location
         end
 
-        remove if binary_exists # Remove outdated exe
-        download
+        remove # Remove outdated exe
+        download # Fetch latest
       end
 
       def latest
@@ -178,6 +177,12 @@ module Webdrivers
       def install_dir
         File.expand_path(File.join(ENV['HOME'], ".webdrivers")).tap { |dir| FileUtils.mkdir_p dir }
       end
+
+      # Already have latest version downloaded?
+      def correct_binary?
+        latest == current && File.exists?(binary)
+      end
+
     end
   end
 end

data/lib/webdrivers/mswebdriver.rb

@@ -1,5 +1,6 @@
 module Webdrivers
   class MSWebdriver < Common
+
     class << self
 
       def current
@@ -18,6 +19,13 @@ module Webdrivers
         build.to_i
       end
 
+      # Webdriver binaries for Microsoft Edge are not backwards compatible.
+      # For this reason, instead of downloading the latest binary we download the correct one for the
+      # currently installed browser version.
+      def download(version = current)
+        super
+      end
+
       private
 
       def normalize(string)
@@ -40,6 +48,13 @@ module Webdrivers
       def base_url
         'https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/'
       end
+
+      # Assume we have the latest if file exists since MicrosoftWebdriver.exe does not have an
+      # argument to check the current version.
+      def correct_binary?
+        File.exist?(binary)
+      end
+
     end
   end
 end

data/spec/geckodriver_spec.rb

@@ -7,7 +7,7 @@ describe Webdrivers::Geckodriver do
   it 'raises exception if unable to get latest geckodriver and no geckodriver present' do
     geckodriver.remove
     allow(geckodriver).to receive(:latest).and_return(nil)
-    msg = /^Unable to find the latest version of geckodriver; try downloading manually from (.*)?and place in (.*)?\.webdrivers$/
+    msg = /^Unable to find the latest version of geckodriver(.exe)?; try downloading manually from (.*)?and place in (.*)?\.webdrivers$/
     expect { geckodriver.update }.to raise_exception StandardError, msg
   end
 

data/spec/mswebdriver_spec.rb

@@ -6,7 +6,7 @@ describe Webdrivers::MSWebdriver do
 
   it 'downloads mswebdriver' do
     mswebdriver.remove
-    allow(mswebdriver).to receive(:current).and_return(0)
+    allow(mswebdriver).to receive(:current)
     expect(File.exist?(mswebdriver.download)).to be true
   end
 

data/webdrivers.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "webdrivers"
-  s.version     = "3.3.0"
+  s.version     = "3.3.1"
   s.authors     = ["Titus Fortner"]
   s.email       = ["titusfortner@gmail.com"]
   s.homepage    = "https://github.com/titusfortner/webdrivers"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: webdrivers
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
 platform: ruby
 authors:
 - Titus Fortner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-30 00:00:00.000000000 Z
+date: 2018-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec