webdav 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a68489cf05ff70988c883f17b41a303db682c85346c4aa27dbadf1cf9f8c869
-  data.tar.gz: a3544d9e0bcdd1b9bbe05720e72a10613ec291280f20d3030521189a68281fb5
+  metadata.gz: 282fc0b7d1998d1002ce33a6a590d1b42b352d7918ed41c001a75fac0f473bfa
+  data.tar.gz: 3c61685c5a13c143db955a376985b175fa7799efe13e986e8a7044bed8c27f2a
 SHA512:
-  metadata.gz: 48e20a5991a5093884a4009ae00c91d807953b158044e413b338aa2cfbccb228257b4128fcb98a128159436ecf541fe8d5cb291816ca9c48e77258589626149d
-  data.tar.gz: 887a1baac0d7d8592da56894dc1e74b907ccd3ce69a92dbe87f8bef0e10cca9b58ea22e89447ff9682c6a8de09e920989c1d200450fdd2d13e03b358545c3580
+  metadata.gz: ec83adb732f914c8786003133ecdc4e9ebbc71a42e3d2e0b59d1b76c1b21e9ab48ffc5af3cea08a193676e71591e5c850da2af57977d3a12c354a7c32cc0b04d
+  data.tar.gz: 761abe1872f20ca61c80ba3468709da9dea781116866c7ece0954cd67ddfdb65011981c859ffd15ec7bb79c7a9849be2db36c19e6b8a6ea56c55d7f4cef33993

data/CHANGELOG

@@ -1,5 +1,27 @@
 # CHANGELOG
 
+## 20260520
+
+0.1.2: Fix Response#success? to return true only for 2xx responses.
+
+1. ~ WebDAV::Response#success?: Was `code < 400` which incorrectly reported 1xx and 3xx as successful. Now `code >= 200 && code < 300`.
+2. ~ test/WebDAV/Response_test.rb: + tests for 3xx and 5xx behaviour.
+3. ~ webdav.gemspec: Remove http.rb version constraint (was `>= 0.18.0`; the original rationale, Net::HTTP::Report being in http.rb 0.18.0, was reverted in webdav 0.1.1 and http.rb 0.18.1).
+4. ~ webdav.gemspec: + rexml runtime dependency (default gem on Ruby 3+; required by WebDAV::MultiStatus).
+5. ~ webdav.gemspec: Pin minitest development dependency to `~> 5.27` (Minitest 6 split `minitest/mock` into a separate gem).
+6. ~ WebDAV::VERSION: /0.1.1/0.1.2/
+7. ~ CHANGELOG: + 0.1.2 entry
+
+## 20260508
+
+0.1.1: Reinstate Net::HTTP::Report.
+
+1. + lib/Net/HTTP/Report.rb: Reinstated after checking after it was incorrectly removed in 0.1.0. REPORT is from RFC 3253 (WebDAV versioning) and is not a core HTTP method.
+2. ~ lib/webdav.rb: + require_relative './Net/HTTP/Report'
+3. + test/Net/HTTP/Report_test.rb
+4. ~ WebDAV::VERSION: /0.1.0/0.1.1/
+5. ~ CHANGELOG: + 0.1.1
+
 ## 20260508
 
 0.1.0: Remove Net::HTTP::Report; now provided by http.rb 0.18.0.

data/README.md

@@ -1,6 +1,7 @@
 # webdav
 
-A Ruby WebDAV client library.
+A WebDAV client library for Ruby.
+
 
 ## Installation
 
@@ -14,6 +15,7 @@ Or in your Gemfile:
 gem 'webdav'
 ```
 
+
 ## Usage
 
 ```ruby
@@ -80,7 +82,7 @@ response = dav.lock('/documents/report.txt', body: lock_body)
 dav.unlock('/documents/report.txt', token: 'urn:uuid:...')
 ```
 
-### REPORT
+### Reporting
 
 ```ruby
 response = dav.report('/calendars/user/', body: report_xml, depth: '1')
@@ -89,18 +91,37 @@ response.resources.each do |resource|
 end
 ```
 
-## Verbs
 
-### WebDAV (RFC 4918 / RFC 3253)
+## Methods
+
+WebDAV extends HTTP with additional methods for distributed authoring. This gem provides all the methods defined in RFC 4918 ("HTTP Extensions for Web Distributed Authoring and Versioning") and the REPORT method from RFC 3253 ("Versioning Extensions to WebDAV"), which is essential for CalDAV and CardDAV queries.
+
+Ruby's standard library includes request classes for the RFC 4918 methods (Propfind, Proppatch, Mkcol, Copy, Move, Lock, Unlock) but not for REPORT. This gem defines `Net::HTTP::Report` to fill that gap.
+
+These methods are not provided by the `http.rb` gem, which deliberately limits itself to the core HTTP methods defined in RFC 9110 ("HTTP Semantics") and RFC 5789 ("PATCH Method for HTTP").
+
+### Properties (RFC 4918)
+
+- `propfind(path, body:, depth:)` — retrieve properties from a resource
+- `proppatch(path, body:)` — set or remove properties on a resource
+
+### Versioning (RFC 3253)
+
+- `report(path, body:, depth:)` — query for information about a resource; used by CalDAV and CardDAV
+
+### Collections (RFC 4918)
+
+- `mkcol(path)` — create a new collection (directory)
 
-- `propfind(path, body:, depth:)` — Retrieve properties
-- `proppatch(path, body:)` — Modify properties
-- `report(path, body:, depth:)` — Run a report query
-- `mkcol(path)` — Create a collection
-- `copy(path, to:, depth:, overwrite:)` — Copy a resource
-- `move(path, to:, overwrite:)` — Move a resource
-- `lock(path, body:)` — Lock a resource
-- `unlock(path, token:)` — Unlock a resource
+### Namespace (RFC 4918)
+
+- `copy(path, to:, depth:, overwrite:)` — copy a resource
+- `move(path, to:, overwrite:)` — move a resource
+
+### Locking (RFC 4918)
+
+- `lock(path, body:)` — lock a resource
+- `unlock(path, token:)` — unlock a resource
 
 ### Standard HTTP
 
@@ -113,6 +134,7 @@ end
 - `options(path)`
 - `trace(path)`
 
+
 ## Responses
 
 All methods return either a `WebDAV::Response` or a `WebDAV::MultiStatus`.
@@ -129,20 +151,31 @@ All methods return either a `WebDAV::Response` or a `WebDAV::MultiStatus`.
 
 `WebDAV::MultiStatus` additionally provides:
 
-- `resources`
-— an array of hashes, each with:
+- `resources` — an array of hashes, each with:
   - `href`
   - `properties`
   - `status`
 
+
 ## Errors
 
 Responses with status >= 400 raise `WebDAV::Error`, which has `code`, `message`, and `body`.
 
+
 ## Dependencies
 
 - [http.rb](https://github.com/thoran/http.rb)
 
+
+## Contributing
+
+1. Fork it [https://github.com/thoran/webdav/fork](https://github.com/thoran/webdav/fork)
+2. Create your feature branch (git checkout -b my-new-feature)
+3. Commit your changes (git commit -am 'Add some feature')
+4. Push to the branch (git push origin my-new-feature)
+5. Create a new pull request
+
+
 ## Licence
 
 MIT

data/lib/Net/HTTP/Report.rb

@@ -0,0 +1,16 @@
+# Net/HTTP/Report.rb
+# Net::HTTP::Report
+
+require 'net/http'
+
+module Net
+  class HTTP
+    class Report < Net::HTTPRequest
+
+      METHOD = 'REPORT'
+      REQUEST_HAS_BODY = true
+      RESPONSE_HAS_BODY = true
+
+    end
+  end
+end

data/lib/WebDAV/Response.rb

@@ -6,7 +6,7 @@ class WebDAV
     attr_reader :code, :message, :headers, :body
 
     def success?
-      code < 400
+      code >= 200 && code < 300
     end
 
     def etag

data/lib/WebDAV/VERSION.rb

@@ -2,5 +2,5 @@
 # WebDAV::VERSION
 
 class WebDAV
-  VERSION = '0.1.0'
+  VERSION = '0.1.2'
 end

data/lib/webdav.rb

@@ -3,9 +3,9 @@
 
 gem 'http.rb'; require 'http.rb'
 require 'net/http'
-require 'rexml/document'
 require 'uri'
 
+require_relative './Net/HTTP/Report'
 require_relative './String/to_const'
 require_relative './WebDAV/Error'
 require_relative './WebDAV/MultiStatus'
@@ -25,7 +25,7 @@ class WebDAV
     handle_response(response)
   end
 
-  # Reports
+  # Versioning
 
   def report(path, body:, depth: '1')
     response = request(:report, path, body: body, headers: {'Depth' => depth})

data/test/Net/HTTP/Report_test.rb

@@ -0,0 +1,21 @@
+# test/Net/HTTP/Report_test.rb
+
+require_relative '../../helper'
+
+describe Net::HTTP::Report do
+  it "is a subclass of Net::HTTPRequest" do
+    _(Net::HTTP::Report < Net::HTTPRequest).must_equal(true)
+  end
+
+  it "has the correct METHOD" do
+    _(Net::HTTP::Report::METHOD).must_equal('REPORT')
+  end
+
+  it "accepts a body" do
+    _(Net::HTTP::Report::REQUEST_HAS_BODY).must_equal(true)
+  end
+
+  it "expects a response body" do
+    _(Net::HTTP::Report::RESPONSE_HAS_BODY).must_equal(true)
+  end
+end

data/test/WebDAV/Response_test.rb

@@ -39,11 +39,23 @@ describe WebDAV::Response do
       _(response.success?).must_equal true
     end
 
+    it "returns false for 3xx responses" do
+      redirect_response = MockResponse.new(code: '302', message: 'Found', body: '')
+      r = WebDAV::Response.new(redirect_response)
+      _(r.success?).must_equal false
+    end
+
     it "returns false for 4xx responses" do
       error_response = MockResponse.new(code: '404', message: 'Not Found', body: '')
       r = WebDAV::Response.new(error_response)
       _(r.success?).must_equal false
     end
+
+    it "returns false for 5xx responses" do
+      error_response = MockResponse.new(code: '500', message: 'Internal Server Error', body: '')
+      r = WebDAV::Response.new(error_response)
+      _(r.success?).must_equal false
+    end
   end
 
   describe "#etag" do

data/webdav.gemspec

@@ -37,11 +37,12 @@ Gem::Specification.new do |spec|
   ].flatten
 
   spec.dependencies = [
-    ['http.rb', '>= 0.18.0']
+    ['http.rb'],
+    ['rexml']
   ]
 
-  spec.development_dependencies = %w{
-    minitest
-    rake
-  }
+  spec.development_dependencies = [
+    ['minitest', '~> 5.27'],
+    ['rake']
+  ]
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webdav
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - thoran
@@ -15,28 +15,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.18.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.18.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rexml
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.27'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.27'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -62,6 +76,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- lib/Net/HTTP/Report.rb
 - lib/String/to_const.rb
 - lib/Thoran/Array/AllButFirst/all_but_first.rb
 - lib/Thoran/Array/FirstX/firstX.rb
@@ -71,6 +86,7 @@ files:
 - lib/WebDAV/Response.rb
 - lib/WebDAV/VERSION.rb
 - lib/webdav.rb
+- test/Net/HTTP/Report_test.rb
 - test/WebDAV/Error_test.rb
 - test/WebDAV/MultiStatus_test.rb
 - test/WebDAV/Response_test.rb
@@ -95,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.11
+rubygems_version: 4.0.12
 specification_version: 4
 summary: A Ruby WebDAV client library.
 test_files: []