webaccount 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90b5b4da3fa0eee7ac4a4c6c85ce3b59a7640bc7aaff8065b7c8432920d8a255
-  data.tar.gz: 1a5efd14b2d09b0dd2d6eeaef4128272d7e34e18779e62cf968a95455858ee1a
+  metadata.gz: 6a94193d490acdd37702fbd4d09835e2a54ef201f5d214713e60bae26845c954
+  data.tar.gz: 15aff8916367524214eb14a2979b3f9d7695557272f2fe44aa035a59aaccc12a
 SHA512:
-  metadata.gz: dbf5f58ce0a99f2232796010962a20f39b45a55e8ba0c5c414b2c3c50ea3c8f54fe409ab4b36878d36a5cf849664b187c3119bc3a79e483c50c2e2196f3b55a8
-  data.tar.gz: 935406e37e640aafd799a60a422314282874d0ffc5369fe398dde3b0948987da01583fc649ffdb47ebf58c421c0881fcf2a00dbeabeb5595ad1e92cac890b37c
+  metadata.gz: 04a678d61437fba7d075eea20c1259786ecbfcb47d701305dac1ff8d362231be7f0a6c474a8497b5a3d8f86ec28e99d5a20267744d4bc32bdcf474322e09bc25
+  data.tar.gz: 67e7b968e7fcab39c8696c087232cb0b020a60e049bfd5279d1a67653293a868553aac0c7cfc7f9ac05ecb4dc5b339d646c1d286dbb2271a6189bd5747a8ed8d

data/CHANGELOG

@@ -1,7 +1,17 @@
-# CHANGELOG
+# webaccount/CHANGELOG
 
 ## 20261011
 
+0.6.0: + WebAccount#still_logged_in?, which says at once whether the page now showing still has the logout button.
+
+logged_in? answers from what login() found, and is not told when a session expires afterwards; logged_out? waits up to default_wait_timeout, 30s, for the logged-out marker, which is too long to ask of every page. Something driving the browser from page to page, as 0.5.0 lets it, had no quick way to notice that the session had ended underneath it.
+
+1. + WebAccount#still_logged_in?(): whether the logout button is on the page now showing, by element_present?, which does not wait; and logged_in? is brought into line with the answer.
+2. ~ test/webaccount_test.rb: + true and false with logged_in? following, and a single look rather than a wait, with a stand-in for the browser. All three fail against 0.5.0.
+3. ~ README.md: + still_logged_in?, under Driving the browser once logged in; /WebAccount\/fork/webaccount\/fork/ in Contributing, the repository having been renamed webaccount.
+4. ~ CHANGELOG: /# CHANGELOG/# webaccount\/CHANGELOG/, after the repository.
+5. ~ VERSION: /0.5.0/0.6.0/
+
 0.5.0: + WebAccount#driver, public, so that the logged-in browser can be driven from outside.
 
 driver was private, so once login() had done its work the session it made could be used only by a sub-class. Something which wants the pages behind a login without being a WebAccount, a spider fetching and screenshotting them, had no way to reach the browser holding the session.

data/README.md

@@ -152,6 +152,12 @@ There are two, both overridable in a sub-class:
   my_account.shutdown
 ```
 
+`still_logged_in?` says whether the page now showing still has the logout button, at once rather than after waiting, so that something moving from page to page can tell when the session has ended, and log in again:
+```ruby
+  my_account.driver.get(url)
+  my_account.login unless my_account.still_logged_in?
+```
+
 ### Overriding the login method to customise logins
 ```ruby
   require 'webaccount'
@@ -186,7 +192,7 @@ Prefer `find` over `driver.find_element`: it waits up to `default_find_timeout`
 
 ## Contributing
 
-1. Fork it: https://github.com/thoran/WebAccount/fork
+1. Fork it: https://github.com/thoran/webaccount/fork
 2. Create your feature branch: `git checkout -b my-new-feature`
 3. Commit your changes: `git commit -am 'Add some feature'`
 4. Push to the branch: `git push origin my-new-feature`

data/lib/webaccount/VERSION.rb

@@ -2,5 +2,5 @@
 # WebAccount::VERSION
 
 class WebAccount
-  VERSION = '0.5.0'
+  VERSION = '0.6.0'
 end

data/lib/webaccount.rb

@@ -72,6 +72,10 @@ class WebAccount
     end
   end
 
+  def still_logged_in?
+    @logged_in = driver.element_present?(logout_button_selector.keys.first, logout_button_selector.values.first)
+  end
+
   private
 
   # driver construction

data/test/webaccount_test.rb

@@ -42,4 +42,35 @@ describe WebAccount do
       end
     end
   end
+
+  describe "#still_logged_in?" do
+    def account_with_page(logout_button_present)
+      page = Object.new
+      page.define_singleton_method(:element_present?){|how, what| (@asked ||= []) << [how, what]; logout_button_present}
+      page.define_singleton_method(:asked){@asked}
+      account = WebAccount.new(logout_button_selector: {css: '#logout'})
+      account.instance_variable_set(:@driver, page)
+      [account, page]
+    end
+
+    it "is true, and makes logged_in? true, where the page has the logout button" do
+      account, page = account_with_page(true)
+      _(account.still_logged_in?).must_equal(true)
+      _(account.logged_in?).must_equal(true)
+      _(page.asked).must_equal([[:css, '#logout']])
+    end
+
+    it "is false, and makes logged_in? false, where the page has not" do
+      account, _page = account_with_page(false)
+      account.instance_variable_set(:@logged_in, true)
+      _(account.still_logged_in?).must_equal(false)
+      _(account.logged_in?).must_equal(false)
+    end
+
+    it "asks once rather than waiting for the button to appear" do
+      account, page = account_with_page(false)
+      account.still_logged_in?
+      _(page.asked.length).must_equal(1)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: webaccount
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - thoran