weather_jp 1.0.4 → 2.0.0

data/spec/weather_jp/city_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+RSpec.describe WeatherJp::City do
+  include Fixturable
+  set_fixture 'tokyo.xml'
+
+  let(:weather) { WeatherJp.get(:tokyo) }
+  let(:city) { weather.city }
+
+  describe '#full_name' do
+    subject { city.full_name }
+    it { is_expected.to eq('東京都 東京') }
+  end
+
+  describe '#code' do
+    subject { city.code }
+    it { is_expected.to eq('JAXX0085') }
+  end
+
+  describe '#latitude' do
+    subject { city.latitude }
+    it { is_expected.to eq(35.6751957) }
+  end
+
+  describe '#longitude' do
+    subject { city.longitude }
+    it { is_expected.to eq(139.7695956) }
+  end
+
+  describe '#to_hash' do
+    subject { city.to_hash }
+    it { is_expected.to be_kind_of(Hash) }
+    it { is_expected.not_to be_empty }
+  end
+end

data/spec/weather_jp/day_weather_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+RSpec.describe WeatherJp::DayWeather do
+  include Fixturable
+  set_fixture 'tokyo.xml'
+
+  let(:weather) { WeatherJp.get(:tokyo) }
+  let(:day_weather) { weather.tomorrow }
+
+  describe '#text' do
+    subject { day_weather.text }
+    it { is_expected.to eq('晴れ') }
+  end
+
+  describe '#high' do
+    subject { day_weather.high }
+    it { is_expected.to eq(52) }
+  end
+
+  describe '#low' do
+    subject { day_weather.low }
+    it { is_expected.to eq(34) }
+  end
+
+  describe '#precip' do
+    subject { day_weather.precip }
+    it { is_expected.to eq(0) }
+  end
+
+  describe '#date_text' do
+    context 'with current' do
+      let(:day_weather) { weather.current }
+      subject { day_weather.date_text }
+      it { is_expected.to eq('今') }
+    end
+
+    context 'with today' do
+      let(:day_weather) { weather.today }
+      subject { day_weather.date_text }
+      it { is_expected.to eq('今日') }
+    end
+
+    context 'with tomorrow' do
+      let(:day_weather) { weather.tomorrow }
+      subject { day_weather.date_text }
+      it { is_expected.to eq('明日') }
+    end
+
+    context 'with day after tomorrow' do
+      let(:day_weather) { weather.day_after_tomorrow }
+      subject { day_weather.date_text }
+      it { is_expected.to eq('明後日') }
+    end
+
+    context 'with 3 days later' do
+      let(:day_weather) { weather.for(3) }
+      subject { day_weather.date_text }
+      it { is_expected.to eq('3日後') }
+    end
+  end
+
+  describe '#to_s' do
+    subject { day_weather.to_s }
+    it { is_expected.to match(/天気/) }
+  end
+
+  describe '#to_hash' do
+    subject { day_weather.to_hash }
+    it { is_expected.to be_kind_of(Hash) }
+    it { is_expected.not_to be_empty }
+  end
+
+  context 'with current weather' do
+    let(:day_weather) { weather.current }
+
+    describe '#temperature' do
+      subject { day_weather.temperature }
+      it { is_expected.to eq(41) }
+    end
+
+    describe '#wind_speed' do
+      subject { day_weather.wind_speed }
+      it { is_expected.to eq(20) }
+    end
+
+    describe '#wind_text' do
+      subject { day_weather.wind_text }
+      it { is_expected.to eq('風向: 北北西 / 風速: 20 マイル') }
+    end
+  end
+end

data/spec/weather_jp/request_parser_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe WeatherJp::RequestParser do
+  describe '.parse' do
+    {
+      '東京の今日の天気' => {day: :today, city: '東京'},
+      '今日の東京の天気' => {day: :today, city: '東京'},
+      '東京のいまの天気' => {day: :current, city: '東京'},
+      'いまの東京の天気' => {day: :current, city: '東京'},
+      '東京の今の天気' => {day: :current, city: '東京'},
+      '今の東京の天気' => {day: :current, city: '東京'},
+      '東京の明日の天気' => {day: :tomorrow, city: '東京'},
+      '東京の明後日の天気' => {day: :day_after_tomorrow, city: '東京'},
+      '東京の3日後の天気' => {day: 3, city: '東京'},
+      '東京の３日後の天気' => {day: 3, city: '東京'},
+      '東京の4日後の天気' => {day: 4, city: '東京'},
+      '東京の４日後の天気' => {day: 4, city: '東京'},
+      '東京の今日の天気教えて〜' => {day: :today, city: '東京'},
+      'あきるの市の今日の天気' => {day: :today, city: 'あきるの市'},
+      'あきるの市の今日の天気教えなさい' => {day: :today, city: 'あきるの市'},
+      '今日のあきるの市の天気' => {day: :today, city: 'あきるの市'}
+    }.each do |sentence, expected|
+      it "parses #{sentence} then return '#{expected}'" do
+        request = WeatherJp::RequestParser.parser(sentence)
+        expect(request).to be_kind_of(WeatherJp::RequestParser::Request)
+        expect(request.city).to eq(expected[:city])
+        expect(request.day).to eq(expected[:day])
+      end
+    end
+  end
+end

data/spec/weather_jp/weather_spec.rb

@@ -0,0 +1,51 @@
+require 'spec_helper'
+
+RSpec.describe WeatherJp::Weather do
+  include Fixturable
+  set_fixture 'tokyo.xml'
+
+  let(:weather) { WeatherJp.get(:tokyo) }
+
+  describe '#each' do
+    it 'succeeds' do
+      expect { weather.each {} }.not_to raise_error
+    end
+  end
+
+  describe '#each_without_current' do
+    it 'succeeds' do
+      expect { weather.each_without_current {} }.not_to raise_error
+    end
+  end
+
+  describe '#current' do
+    subject { weather.current }
+    it { is_expected.to be_kind_of(WeatherJp::DayWeather) }
+  end
+
+  describe '#today' do
+    subject { weather.today }
+    it { is_expected.to be_kind_of(WeatherJp::DayWeather) }
+  end
+
+  describe '#tomorrow' do
+    subject { weather.tomorrow }
+    it { is_expected.to be_kind_of(WeatherJp::DayWeather) }
+  end
+
+  describe '#day_after_tomorrow' do
+    subject { weather.day_after_tomorrow }
+    it { is_expected.to be_kind_of(WeatherJp::DayWeather) }
+  end
+
+  describe '#for' do
+    context 'with a Date' do
+      subject { weather.for(Date.parse('2015-01-01')) }
+      it 'is not implemented' do
+        expect { subject }.to raise_error(NotImplementedError)
+      end
+    end
+  end
+end
+
+

data/spec/weather_jp_spec.rb

@@ -1,52 +1,18 @@
-# -*- coding: utf-8 -*-
 require 'spec_helper'
 
-describe "WeatherJp" do
-  before :all do
-    @weather = WeatherJp.get :tokyo
-  end
-
-  describe ".get" do
-    it "should return Weather instance" do
-      @weather.class.should == WeatherJp::Weather
-    end
+RSpec.describe WeatherJp do
+  include Fixturable
+  set_fixture 'tokyo.xml'
 
-    it "should accept option and return DayWeather object" do
-      WeatherJp.get(:tokyo, :today).class.
-        should == WeatherJp::Weather::DayWeather
-    end
-  end
+  let(:weather) { WeatherJp.get(:tokyo) }
 
-  describe ".customize_to_s" do
-    it "should customize DayWeather#to_s" do
-      WeatherJp.customize_to_s { 'success' }
-      WeatherJp.get(:tokyo, :today).to_s.should == 'success'
-    end
+  describe '.get' do
+    subject { described_class.get(:tokyo) }
+    it { is_expected.to be_kind_of(WeatherJp::Weather) }
   end
 
-  describe ".parser" do
-    it "should parse japanese string" do
-      {
-        "東京の今日の天気" => {day: "today", city: "東京"},
-        "今日の東京の天気" => {day: "today", city: "東京"},
-        "東京のいまの天気" => {day: "today", city: "東京"},
-        "いまの東京の天気" => {day: "today", city: "東京"},
-        "東京の今の天気" => {day: "today", city: "東京"},
-        "今の東京の天気" => {day: "today", city: "東京"},
-        "東京の明日の天気" => {day: "tomorrow", city: "東京"},
-        "東京の明後日の天気" => {day: "day_after_tomorrow", city: "東京"},
-        "東京の3日後の天気" => {day: 3, city: "東京"},
-        "東京の３日後の天気" => {day: 3, city: "東京"},
-        "東京の4日後の天気" => {day: 4, city: "東京"},
-        "東京の４日後の天気" => {day: 4, city: "東京"},
-        "東京の今日の天気教えて〜" => {day: "today", city: "東京"},
-        "あきるの市の今日の天気" => {day: "today", city: "あきるの市"},
-        "あきるの市の今日の天気教えなさい" => {day: "today", city: "あきるの市"},
-        "今日のあきるの市の天気" => {day: "today", city: "あきるの市"}
-      }.each do |test, expect|
-        WeatherJp.parser(test).should == expect
-      end
-    end
+  describe '.parse' do
+    subject { described_class.parse('明日の東京の天気') }
+    it { is_expected.to be_kind_of(WeatherJp::DayWeather) }
   end
 end
-

data/weather_jp.gemspec

@@ -15,8 +15,13 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = WeatherJp::VERSION
 
-  gem.add_dependency "nokogiri", "~>1.5.5"
+  gem.add_dependency "activesupport"
+  gem.add_dependency "nokogiri" # was "1.6.5"
+  gem.add_dependency "rack"
   gem.add_dependency "rake", ">= 0.9.2"
-  gem.add_development_dependency "rspec"
-  gem.add_development_dependency "rspec-core"
+  gem.add_development_dependency "pry"
+  gem.add_development_dependency "rspec", "~> 3"
+  gem.add_development_dependency "simplecov"
+  gem.add_development_dependency "webmock"
+  gem.add_development_dependency "coveralls"
 end

metadata

@@ -1,69 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: weather_jp
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 2.0.0
 platform: ruby
 authors:
 - Taiki ONO
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-01 00:00:00.000000000 Z
+date: 2015-01-17 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.5
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.5
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.9.2
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-core
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Fetch Japan weather info as Ruby object easily.
@@ -73,24 +143,30 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".coveralls.yml"
+- ".gitignore"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
-- HISTORY.md
 - LICENSE
-- README.jp.md
 - README.md
 - Rakefile
 - lib/weather_jp.rb
+- lib/weather_jp/adapter.rb
+- lib/weather_jp/city.rb
 - lib/weather_jp/day_weather.rb
+- lib/weather_jp/request_parser.rb
 - lib/weather_jp/version.rb
-- spec/day_weather_spec.rb
-- spec/fixture/RSS.rss
-- spec/fixture/ny.rss
+- lib/weather_jp/weather.rb
+- spec/fixture/not_found.xml
+- spec/fixture/tokyo.xml
 - spec/spec_helper.rb
+- spec/weather_jp/adapter_spec.rb
+- spec/weather_jp/city_spec.rb
+- spec/weather_jp/day_weather_spec.rb
+- spec/weather_jp/request_parser_spec.rb
+- spec/weather_jp/weather_spec.rb
 - spec/weather_jp_spec.rb
-- spec/weather_spec.rb
-- spec/wrapper_spec.rb
 - weather_jp.gemspec
 homepage: http://taiki45.github.com/weather_jp
 licenses: []
@@ -101,25 +177,27 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Japan weather info API wrapper.
 test_files:
-- spec/day_weather_spec.rb
-- spec/fixture/RSS.rss
-- spec/fixture/ny.rss
+- spec/fixture/not_found.xml
+- spec/fixture/tokyo.xml
 - spec/spec_helper.rb
+- spec/weather_jp/adapter_spec.rb
+- spec/weather_jp/city_spec.rb
+- spec/weather_jp/day_weather_spec.rb
+- spec/weather_jp/request_parser_spec.rb
+- spec/weather_jp/weather_spec.rb
 - spec/weather_jp_spec.rb
-- spec/weather_spec.rb
-- spec/wrapper_spec.rb