weather_hacker 0.1.0 → 0.1.1

data/README.md

@@ -19,36 +19,47 @@ Or install it yourself as:
     $ gem install weather_hacker
 
 ## Usage
-~~~
+Here's an example script to watch the weather forecast:
+
+```ruby
+# forecast.rb
 require "weather_hacker"
+require "yaml"
+require "date"
 
 zipcode = "690-0261"
 weather = WeatherHacker.new(zipcode)
 
-weather.on(Date.today)
-#=> {
-#         "weather" => "晴れ",
-#     "temperature" => { "max" => "18", "min" => "1" }
-#   }
-
-weather.today
-#=> {
-#         "weather" => "晴れ",
-#     "temperature" => { "max" => "18", "min" => "1" }
-#   }
-
-weather.tomorrow
-#=> {
-#         "weather" => "晴時々曇",
-#     "temperature" => { "max" => 21, "min" => 9 }
-#   }
-
-weather.day_after_tomorrow
-#=> {
-#         "weather" => "晴時々曇",
-#     "temperature" => { "max" => nil, "min" => nil }
-#   }
-~~~
+y weather.on(Date.today)
+y weather.today
+y weather.tomorrow
+y weather.day_after_tomorrow
+```
+
+```
+$ gem install weather_hacker
+$ ruby forecast.rb
+---
+weather: 晴れ
+temperature:
+  max: '18'
+  min: '1'
+---
+weather: 晴れ
+temperature:
+  max: '18'
+  min: '1'
+---
+weather: 晴時々曇
+temperature:
+  max: '18'
+  min: '2'
+---
+weather: 曇り
+temperature:
+  max: '21'
+  min: '9'
+```
 
 ## Contributing
 

data/lib/weather_hacker/client.rb

@@ -91,8 +91,8 @@ class WeatherHacker
 
     # parse area table hash of response from Weather API
     def parse_area_table(hash)
-      @pref_by_city = {}
-      @id_by_city   = {}
+      @pref_by_city ||= {}
+      @id_by_city   ||= {}
 
       hash["rss"]["channel"]["source"]["area"].each do |area|
         prefs = [area["pref"]].flatten

data/lib/weather_hacker/version.rb

@@ -1,3 +1,3 @@
 class WeatherHacker
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/weather_hacker.rb

@@ -10,9 +10,9 @@ class WeatherHacker
   end
 
   # define these methods
-  # * WeatherHacker#today(zipcode)
-  # * WeatherHacker#tomorrow(zipcode)
-  # * WeatherHacker#dayaftertomorrow(zipcode)
+  # * WeatherHacker#today
+  # * WeatherHacker#tomorrow
+  # * WeatherHacker#day_after_tomorrow
   [:today, :tomorrow, :day_after_tomorrow].each do |day|
     define_method(day) do
       @client.get_weather(@zipcode, :day => day.to_s.tr("_", ""))

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 $LOAD_PATH.unshift File.expand_path("../", __FILE__)
 $LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
 
+require "simplecov"
 require "weather_hacker"

data/spec/weather_hacker/client_spec.rb

@@ -27,16 +27,39 @@ describe "WeatherHacker::Client" do
     end
   end
 
-  describe "#update_area_table" do
-    it "has not table before call" do
+  shared_examples_for "having area table" do
+    it "has area table" do
+      @client.send(:id_by_city).keys.size.should_not == 0
+      @client.send(:pref_by_city).keys.size.should_not == 0
+    end
+  end
+
+  shared_examples_for "not having area table" do
+    it "has not area table" do
       @client.instance_variable_get(:@id_by_city).should be_nil
       @client.instance_variable_get(:@pref_by_city).should be_nil
     end
+  end
+
+  describe "#id_by_city" do
+    context "before call" do
+      it_behaves_like "not having area table"
+    end
 
-    it "has area table after call" do
-      @client.send(:update_area_table)
-      @client.send(:id_by_city).keys.size.should_not == 0
-      @client.send(:pref_by_city).keys.size.should_not == 0
+    context "after call" do
+      before { @client.send(:id_by_city) }
+      it_behaves_like "having area table"
+    end
+  end
+
+  describe "#pref_by_city" do
+    context "before call" do
+      it_behaves_like "not having area table"
+    end
+
+    context "after call" do
+      before { @client.send(:pref_by_city) }
+      it_behaves_like "having area table"
     end
   end
 
@@ -46,4 +69,29 @@ describe "WeatherHacker::Client" do
       city_id.should be_kind_of Integer
     end
   end
+
+  describe "#id_by_pref" do
+    it "is cached in instance variable" do
+      @client.instance_variable_get(:@id_by_pref).should be_nil
+      @client.send(:id_by_pref)
+      @client.instance_variable_get(:@id_by_pref).should be_kind_of Hash
+
+      @client.should_not_receive(:pref_by_city)
+      @client.send(:id_by_pref)
+    end
+
+    it "return table of id by pref" do
+      @client.send(:id_by_pref).should be_kind_of Hash
+    end
+  end
+
+  describe "#parse_area_table" do
+    context "when passed malformed hash response" do
+      it do
+        expect {
+          @client.send(:parse_area_table, {:unexpected => :hash})
+        }.to raise_error(WeatherHacker::Client::ParseError)
+      end
+    end
+  end
 end

data/weather_hacker.gemspec

@@ -18,4 +18,6 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'rake', '>= 0.9.2'
   gem.add_dependency "httparty"
   gem.add_development_dependency "rspec"
+  gem.add_development_dependency "simplecov"
+  gem.add_development_dependency "simplecov-vim"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: weather_hacker
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70211207058840 !ruby/object:Gem::Requirement
+  requirement: &70218237022340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 0.9.2
   type: :runtime
   prerelease: false
-  version_requirements: *70211207058840
+  version_requirements: *70218237022340
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &70211207058420 !ruby/object:Gem::Requirement
+  requirement: &70218237021920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70211207058420
+  version_requirements: *70218237021920
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70211207057960 !ruby/object:Gem::Requirement
+  requirement: &70218237021460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +43,29 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70211207057960
+  version_requirements: *70218237021460
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: &70218237021040 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70218237021040
+- !ruby/object:Gem::Dependency
+  name: simplecov-vim
+  requirement: &70218237020620 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70218237020620
 description: Library for Livedoor Weather Web Service
 email:
 - r7kamura@gmail.com
@@ -81,7 +103,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2444633236054431010
+      hash: -1826125772160872950
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -90,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2444633236054431010
+      hash: -1826125772160872950
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.15