weather-forecasts 1.1.1

data/spec/lib/ndfd/client/query/select_by_days_query_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectByDaysQuery do
+  let(:conditions) {
+    {
+      :coordinates => [ {:latitude => 38.99, :longitude => -77.01 }],
+      :days        => 5,
+      :start_date  => Time.zone.now,
+      :unit        => "e",
+      :format      => "24 hourly"
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select_by_days }
+
+  before(:each) do
+    # Silence HTTPI logger (used by Savon)
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_by_days_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    it "returns a valid response" do
+      @response.should be_a(Hash)
+      @response[:parameters]["point1"][:temperature][:maximum][:name].should == "Daily Maximum Temperature"
+    end
+  end
+end

data/spec/lib/ndfd/client/query/select_coordinates_by_cities_query_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectCoordinatesByCitiesQuery do
+  let(:conditions) {
+    {
+      :display => :all
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select_coordinates_by_cities }
+
+  # Silence savon's HTTP request logger
+  before(:each) do
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_coordinates_by_cities_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    it "returns a valid response" do
+      @response.should be_a(Hash)
+      @response["Denver,CO"].values.each do |value|
+        value.should be_a(Numeric)
+      end
+    end
+  end
+end

data/spec/lib/ndfd/client/query/select_coordinates_by_zip_query_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectCoordinatesByZipQuery do
+  let(:conditions) {
+    {
+      :zip => ["80129", "80128"]
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select_coordinates_by_zip }
+
+  # Silence savon's HTTP request logger
+  before(:each) do
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_coordinates_by_zip_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    it "returns a valid response" do
+      @response.should be_a(Hash)
+      @response.keys.should include(*conditions[:zip])
+      @response.each do |_, value|
+        value.values.each {|v| v.should be_a(Numeric) }
+      end
+    end
+  end
+end

data/spec/lib/ndfd/client/query/select_corner_coordinates_query_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectCornerCoordinatesQuery do
+  let(:conditions) {
+    {
+      :sector => :conus
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select_corner_coordinates }
+
+  # Silence savon's HTTP request logger
+  before(:each) do
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_corner_coordinates_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    it "returns a valid response" do
+      @response.should be_a(Array)
+
+      @response.first.keys.should include(:latitude, :longitude)
+      @response.first.values.each do |value|
+        value.should be_a(Numeric)
+      end
+    end
+  end
+end

data/spec/lib/ndfd/client/query/select_gridpoint_coordinates_query_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectGridpointCoordinatesQuery do
+  let(:conditions) {
+    {
+      :lower_left_coordinate  => { :latitude => 39.547101, :longitude => -105.215759 },
+      :upper_right_coordinate => { :latitude => 39.991484, :longitude => -104.704895 },
+      :resolution             => 2
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select_gridpoint_coordinates }
+
+  # Silence savon's HTTP request logger
+  before(:each) do
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_gridpoint_coordinates_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    it "returns a valid response" do
+      @response.should be_a(Array)
+
+      @response.first.keys.should include(:latitude, :longitude)
+      @response.first.values.each do |value|
+        value.should be_a(Numeric)
+      end
+    end
+  end
+end

data/spec/lib/ndfd/client/query/select_linepoint_coordinates_query_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectLinepointCoordinatesQuery do
+  let(:conditions) {
+    {
+      :start_coordinate => { :latitude => 39.547101, :longitude => -105.215759 },
+      :stop_coordinate  => { :latitude => 39.991484, :longitude => -104.704895 }
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select_linepoint_coordinates }
+
+  # Silence savon's HTTP request logger
+  before(:each) do
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_linepoint_coordinates_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    it "returns a valid response" do
+      @response.should be_a(Array)
+
+      @response.first.keys.should include(:latitude, :longitude)
+      @response.first.values.each do |value|
+        value.should be_a(Numeric)
+      end
+    end
+  end
+end

data/spec/lib/ndfd/client/query/select_query_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectQuery do
+  let(:dimensions) {
+    # NOTE: Adding all dimensions to ensure it doesn't blow up when parsing
+    [ :maxt,:mint,:temp,:dew,:appt,:pop12,:qpf,:snow,:sky,:rh,:wspd,:wdir,:wx,:icons,
+      :waveh,:incw34,:incw50,:incw64,:cumw34,:cumw50,:cumw64,:wgust,:critfireo,:dryfireo,
+      :conhazo,:ptornado,:phail,:ptstmwinds,:pxtornado,:pxhail,:pxtstmwinds,:ptotsvrtstm,
+      :pxtotsvrtstm,:tmpabv14d,:tmpblw14d,:tmpabv30d,:tmpblw30d,:tmpabv90d,:tmpblw90d,
+      :prcpabv14d,:prcpblw14d,:prcpabv30d,:prcpblw30d,:prcpabv90d,:prcpblw90d,:precipa_r,
+      :sky_r,:td_r,:temp_r,:wdir_r,:wspd_r,:wwa,:iceaccum,:maxrh,:minrh ]
+  }
+
+  let(:conditions) {
+    {
+      :coordinates => [ {:latitude => 38.99, :longitude => -77.01 }],
+      :product     => "time-series",
+      :start_time  => Time.zone.now,
+      :end_time    => Time.zone.now + 6.days,
+      :unit        => "e"
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select(*dimensions) }
+
+  before(:each) do
+    # Silence HTTPI logger (used by Savon)
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    # TODO: Add verification for each metric
+    it "returns a valid response" do
+      @response.should be_a(Hash)
+      @response[:parameters]["point1"][:temperature][:maximum][:name].should == "Daily Maximum Temperature"
+    end
+  end
+end

data/spec/lib/ndfd/client/query/select_square_coordinates_query_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectSquareCoordinatesQuery do
+  let(:conditions) {
+    {
+      :center_point => { :latitude => 39.547101, :longitude => -105.215759 },
+      :distance     => { :latitude => 0.547101, :longitude => 0.215759 },
+      :resolution   => 10
+    }
+  }
+
+  let(:null_logger)  { Logger.new(File.open("/dev/null", "w")) }
+
+  subject { WeatherForecasts.client(:logger => null_logger).select_square_coordinates }
+
+  # Silence savon's HTTP request logger
+  before(:each) do
+    HTTPI.logger = null_logger
+  end
+
+  describe "#execute" do
+    before(:each) do
+      VCR.use_cassette('select_square_coordinates_query') do
+        @response = subject.where(conditions).execute
+      end
+    end
+
+    it "returns a valid response" do
+      @response.should be_a(Array)
+
+      @response.first.keys.should include(:latitude, :longitude)
+      @response.first.values.each do |value|
+        value.should be_a(Numeric)
+      end
+    end
+  end
+end

data/spec/lib/ndfd/client/query/selection_attributes_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client::SelectionAttributes do
+  let(:attr) { :blah }
+
+  subject { WeatherForecasts::Client::SelectionAttributes.new(attr) }
+
+  describe "#valid?" do
+    it "raises an error if an invalid selection attribute is used" do
+      expect { subject.valid?(:wrong) }.to raise_error(WeatherForecasts::Client::InvalidSelectionAttributeError)
+    end
+  end
+end

data/spec/lib/ndfd/client/query_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+class WeatherForecasts::Client::TestQuery < WeatherForecasts::Client::Query
+  set_selection_attributes :thing1, :thing2
+
+  property :property1, :type => Array,  :required => true, :required_keys => [:lat, :long]
+  property :property2, :type => String, :required => true, :options => ["one", "two"], :default => "one"
+end
+
+describe WeatherForecasts::Client::Query do
+  let(:soap_client) { double }
+  let(:attrs) { {} }
+  let(:subclass) { WeatherForecasts::Client::TestQuery }
+
+  let(:conditions_with_defaults) { {
+      :property1 => [{ :lat => 67.87, :long => -107.37 }]
+    }
+  }
+
+  let(:conditions_overriding_defaults) { {
+      :property1 => [{ :lat => 67.87, :long => -107.37 }],
+      :property2 => "two"
+    }
+  }
+
+  subject { subclass.new(soap_client, attrs) }
+
+  describe "#where" do
+    it "updates the #conditions attributes and sets any defaults that aren't set" do
+      subject.where(conditions_with_defaults)
+      subject.conditions.should == conditions_with_defaults.merge(:property2 => "one")
+    end
+
+    it "does not set a conditions to a default value if it is already set" do
+      subject.where(conditions_overriding_defaults)
+      subject.conditions.should == conditions_overriding_defaults
+    end
+
+    it "returns self" do
+      subject.where(conditions_overriding_defaults).should be_a(subclass)
+    end
+  end
+
+  describe "#execute" do
+    it "raises a not implemented error (intended for subclasses)" do
+      expect { subject.execute }.to raise_error(NotImplementedError)
+    end
+  end
+
+  describe "#validate" do
+    context "for selection attributes" do
+      context "with valid selection attributes" do
+        it "validates that the selection attributes are appropriately set" do
+          instance = subclass.new(soap_client, [:thing1, :thing2])
+          instance.where(conditions_with_defaults)
+
+          expect { instance.validate }.not_to raise_error
+        end
+      end
+
+      context "with invalid selection attributes" do
+        it "raises an error" do
+          instance = subclass.new(soap_client, [:thing1, :thing2, :thing3])
+          instance.where(conditions_with_defaults)
+
+          expect { instance.validate }.to raise_error(WeatherForecasts::Client::InvalidSelectionAttributeError)
+        end
+      end
+    end
+
+    context "for conditions" do
+      context "with valid conditions" do
+        it "validates that the conditions are appropriately set" do
+          instance = subclass.new(soap_client)
+          instance.where(conditions_with_defaults)
+
+          expect { instance.validate }.not_to raise_error
+        end
+      end
+
+      context "with invalid conditions" do
+        it "raises an error" do
+          instance = subclass.new(soap_client)
+          instance.where(conditions_with_defaults.merge(:property2 => "blah"))
+
+          expect { instance.validate }.to raise_error(WeatherForecasts::Client::InvalidOptionSpecifiedError)
+        end
+      end
+    end
+  end
+end

data/spec/lib/ndfd/client_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe WeatherForecasts::Client do
+  subject { WeatherForecasts.client }
+
+  let(:options) { double }
+
+  describe "#soap_client" do
+    it "returns a soap client" do
+      subject.soap_client.should be_a(Savon::Client)
+    end
+  end
+
+  describe "#select" do
+    it "returns as WeatherForecasts::Client::SelectQuery object" do
+      subject.select(options).should be_a(WeatherForecasts::Client::SelectQuery)
+    end
+  end
+
+  describe "#select_by_days" do
+    it "returns as WeatherForecasts::Client::SelectByDaysQuery object" do
+      subject.select_by_days.should be_a(WeatherForecasts::Client::SelectByDaysQuery)
+    end
+  end
+
+  describe "#select_coordinates_by_zip" do
+    it "returns as WeatherForecasts::Client::SelectCoordinatesByZipQuery object" do
+      subject.select_coordinates_by_zip.should be_a(WeatherForecasts::Client::SelectCoordinatesByZipQuery)
+    end
+  end
+
+  describe "#select_gridpoint_coordinates" do
+    it "returns as WeatherForecasts::Client::SelectGridpointCoordinatesQuery object" do
+      subject.select_gridpoint_coordinates.should be_a(WeatherForecasts::Client::SelectGridpointCoordinatesQuery)
+    end
+  end
+
+  describe "#select_linepoint_coordinates" do
+    it "returns as WeatherForecasts::Client::SelectLinepointCoordinatesQuery object" do
+      subject.select_linepoint_coordinates.should be_a(WeatherForecasts::Client::SelectLinepointCoordinatesQuery)
+    end
+  end
+
+  describe "#select_cities_coordinates" do
+    it "returns as WeatherForecasts::Client::SelectCitiesCoordinatesQuery object" do
+      subject.select_coordinates_by_cities.should be_a(WeatherForecasts::Client::SelectCoordinatesByCitiesQuery)
+    end
+  end
+
+  describe "#select_corner_coordinates" do
+    it "returns as WeatherForecasts::Client::SelectCornerCoordinatesQuery object" do
+      subject.select_corner_coordinates.should be_a(WeatherForecasts::Client::SelectCornerCoordinatesQuery)
+    end
+  end
+
+  describe "#select_square_coordinates" do
+    it "returns as WeatherForecasts::Client::SelectSquareCoordinatesQuery object" do
+      subject.select_square_coordinates.should be_a(WeatherForecasts::Client::SelectSquareCoordinatesQuery)
+    end
+  end
+end