weak_parameters 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4f727084d2f5b6f19f5e23073a6bdb53da5612e8
-  data.tar.gz: 5d41ed3547ea2ee49ab1b3651feecf7b93ecd590
+  metadata.gz: 50b0c13f9e3c5697ffe2103ce08be27f4f647d04
+  data.tar.gz: 2d29e0b13db351bfb7149b8a503995ec76ff1ec0
 SHA512:
-  metadata.gz: 13b1e3c781bb9ce765edd8c7236ce116f31eaf3044644ab991b4d253a3d4068ad8b89c29d4620db1d55245f94b57edf89e901878b5c54f839b016b1457a77f8b
-  data.tar.gz: 6d86b954fb1053e3e467892bb1daae3b0774de30c5608f13b1893033b66dde035beea8d021afd0fee7385ce207ec14a4acf5b404bccb854c5414baa75f2b1f9e
+  metadata.gz: 5b2cb7add33324eb6368ed684116d7b9e08d045e59efcd1e70ad9fe9bed2856f06c84401902ff81ba254b4d3d15478cd77ad1b1ed63b1c02ab1a78df731e5225
+  data.tar.gz: 5456a73dbb05f9a45d676d251ce1082034946e0a3c56ed3394b6c59597ee64687f032fd743673ebaa09b7e25840bd43a412d1abdf66a7de6387e09ec678cef49

data/.travis.yml

@@ -0,0 +1,5 @@
+before_install:
+  - gem update bundler
+language: ruby
+rvm:
+- 2.2.0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.2.3
+- Change execution context of validator block
+- Fix a development dependencies problem
+
 ## 0.2.2
 - Fix nil validation bug on nested parameters (Thx @mzp)
 

data/Gemfile

@@ -3,9 +3,3 @@ source "https://rubygems.org"
 gemspec
 
 gem "rails", "4.0.0"
-
-group :test do
-  gem "autodoc"
-  gem "pry-rails"
-  gem "rspec-rails"
-end

data/README.md

@@ -1,4 +1,4 @@
-# WeakParameters
+# WeakParameters [![Build Status](https://travis-ci.org/r7kamura/weak_parameters.svg?branch=master)](https://travis-ci.org/r7kamura/weak_parameters)
 Validates `params` in your controller.
 
 ## Installation
@@ -59,7 +59,7 @@ irb(main):005:0> app.post "/recipes", name: "alice", type: "bob"
 * object
 * list
 
-### Avilable options
+### Available options
 * required
 * only
 * except

data/Rakefile

@@ -1 +1,5 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new(:spec)
+task default: :spec

data/lib/weak_parameters/base_validator.rb

@@ -46,7 +46,7 @@ module WeakParameters
         false
       when exist? && exceptional?
         false
-      when exist? && block && !block.call(value)
+      when exist? && block && !controller.instance_exec(value, &block)
         false
       else
         true

data/lib/weak_parameters/version.rb

@@ -1,3 +1,3 @@
 module WeakParameters
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/dummy/app/controllers/recipes_controller.rb

@@ -11,7 +11,7 @@ class RecipesController < ApplicationController
     file :attachment
     integer :custom, only: 0..1, handler: :render_error
     string :zip_code do |value|
-      value =~ /\A\d{3}-\d{4}\z/
+      zip_pattern(value)
     end
     object :nested, required: true do
       integer :number, only: [0, 1]
@@ -36,4 +36,8 @@ class RecipesController < ApplicationController
   def render_error
     head 403
   end
+
+  def zip_pattern(value)
+    value =~ /\A\d{3}-\d{4}\z/
+  end
 end

data/spec/requests/recipes_spec.rb

@@ -29,14 +29,14 @@ describe "Recipes", type: :request do
   shared_examples_for "400" do
     it "returns 400" do
       post "/recipes", params
-      response.status.should == 400
+      expect(response.status).to eq(400)
     end
   end
 
   shared_examples_for "201" do
     it "creates a new recipe" do
       post "/recipes", params
-      response.status.should == 201
+      expect(response.status).to eq(201)
     end
   end
 
@@ -142,7 +142,7 @@ describe "Recipes", type: :request do
       end
       it "delegates to specified method" do
         post "/recipes", params
-        response.status.should == 403
+        expect(response.status).to eq(403)
       end
     end
 

data/spec/requests/strong_spec.rb

@@ -49,52 +49,52 @@ describe "Strong", type: :request do
   describe "#permitted_params" do
     it "returns permitted_params" do
       post "/strongs", params
-      controller.permitted_params.should have_key "strong_object"
-      controller.permitted_params.should_not have_key "object"
+      expect(controller.permitted_params).to have_key "strong_object"
+      expect(controller.permitted_params).not_to have_key "object"
 
-      controller.permitted_params.should have_key "strong_name"
-      controller.permitted_params.should_not have_key "name"
+      expect(controller.permitted_params).to have_key "strong_name"
+      expect(controller.permitted_params).not_to have_key "name"
 
-      controller.permitted_params.should have_key "strong_number"
-      controller.permitted_params.should_not have_key "number"
+      expect(controller.permitted_params).to have_key "strong_number"
+      expect(controller.permitted_params).not_to have_key "number"
 
-      controller.permitted_params.should have_key "strong_type"
-      controller.permitted_params.should_not have_key "type"
+      expect(controller.permitted_params).to have_key "strong_type"
+      expect(controller.permitted_params).not_to have_key "type"
 
-      controller.permitted_params.should have_key "strong_flag"
-      controller.permitted_params.should_not have_key "flag"
+      expect(controller.permitted_params).to have_key "strong_flag"
+      expect(controller.permitted_params).not_to have_key "flag"
 
-      controller.permitted_params.should have_key "strong_config"
-      controller.permitted_params.should_not have_key "config"
+      expect(controller.permitted_params).to have_key "strong_config"
+      expect(controller.permitted_params).not_to have_key "config"
 
-      controller.permitted_params.should have_key "strong_tags"
-      controller.permitted_params.should_not have_key "tags"
+      expect(controller.permitted_params).to have_key "strong_tags"
+      expect(controller.permitted_params).not_to have_key "tags"
 
-      controller.permitted_params.should_not have_key "strong_rate"
-      controller.permitted_params.should_not have_key "rate"
+      expect(controller.permitted_params).not_to have_key "strong_rate"
+      expect(controller.permitted_params).not_to have_key "rate"
 
-      controller.permitted_params.should have_key "strong_attachment"
-      controller.permitted_params.should_not have_key "attachment"
+      expect(controller.permitted_params).to have_key "strong_attachment"
+      expect(controller.permitted_params).not_to have_key "attachment"
 
-      controller.permitted_params.should have_key "strong_zip_code"
-      controller.permitted_params.should_not have_key "zip_code"
+      expect(controller.permitted_params).to have_key "strong_zip_code"
+      expect(controller.permitted_params).not_to have_key "zip_code"
 
-      controller.permitted_params.should have_key "strong_custom"
-      controller.permitted_params.should_not have_key "custom"
+      expect(controller.permitted_params).to have_key "strong_custom"
+      expect(controller.permitted_params).not_to have_key "custom"
 
-      controller.permitted_params.should have_key "strong_nested"
-      controller.permitted_params.should_not have_key "nested"
+      expect(controller.permitted_params).to have_key "strong_nested"
+      expect(controller.permitted_params).not_to have_key "nested"
 
-      controller.permitted_params.should have_key "strong_numbers"
-      controller.permitted_params.should_not have_key "numbers"
+      expect(controller.permitted_params).to have_key "strong_numbers"
+      expect(controller.permitted_params).not_to have_key "numbers"
 
-      controller.permitted_params.should have_key "strong_body"
-      controller.permitted_params.should_not have_key "body"
+      expect(controller.permitted_params).to have_key "strong_body"
+      expect(controller.permitted_params).not_to have_key "body"
 
-      controller.permitted_params[:strong_body].should have_key "items"
+      expect(controller.permitted_params[:strong_body]).to have_key "items"
 
-      controller.permitted_params[:strong_body][:items].first.should have_key "strong_price"
-      controller.permitted_params[:strong_body][:items].first.should_not have_key "name"
+      expect(controller.permitted_params[:strong_body][:items].first).to have_key "strong_price"
+      expect(controller.permitted_params[:strong_body][:items].first).not_to have_key "name"
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,7 +1,6 @@
 ENV["RAILS_ENV"] ||= "test"
 require File.expand_path("../../spec/dummy/config/environment", __FILE__)
 require "rspec/rails"
-require "rspec/autorun"
 
 RSpec.configure do |config|
   # If you"re not using ActiveRecord, or you"d prefer not to run each of your
@@ -14,5 +13,14 @@ RSpec.configure do |config|
   # rspec-rails.
   config.infer_base_class_for_anonymous_controllers = false
 
-  config.treat_symbols_as_metadata_keys_with_true_values = true
+  # rspec-rails 3 will no longer automatically infer an example group's spec type
+  # from the file location. You can explicitly opt-in to the feature using this
+  # config option.
+  # To explicitly tag specs without using automatic inference, set the `:type`
+  # metadata manually:
+  #
+  #     describe ThingsController, :type => :controller do
+  #       # Equivalent to being in spec/controllers
+  #     end
+  config.infer_spec_type_from_file_location!
 end

data/weak_parameters.gemspec

@@ -18,7 +18,11 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "rails", ">= 3.2.11"
+  spec.add_development_dependency "autodoc"
   spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_development_dependency "pry-rails"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec-rails"
   spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "test-unit"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: weak_parameters
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-26 00:00:00.000000000 Z
+date: 2016-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.11
+- !ruby/object:Gem::Dependency
+  name: autodoc
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: pry-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: test-unit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - r7kamura@gmail.com
@@ -74,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt