weak_parameters 0.0.9 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80441093aeafd1c3ab763657a7abaf130aa040a9
-  data.tar.gz: 4218d72117b187a0b8bb5c4604f3f3d5977d23ce
+  metadata.gz: 85725f4ac0c2a36ca6158bb56342ef10c559381e
+  data.tar.gz: 22952cd5107d5446762e90d58c9470491278270d
 SHA512:
-  metadata.gz: 2868dfff63a99b7c01b041a56589dd4b234276d879e625d8399697ac095183ff1ecde34b54dafb17821858cc8d4673aec8f4137c0badcb2f32027ef86011706c
-  data.tar.gz: b51907dbbd0c0e5e0d25b46cf3c77b5c5bd4cc7da0323bf8fe98b5a1ff86bdf55df472560f63e9c540302d6fb9c353eacf22489bdea4fed8957e9525dbe5be57
+  metadata.gz: 1e63d3e62024bed8f9a47a7a9e1aff8cef35b8bdd6e4d7934864256f325bc2bc766747ef373f3aab47356d015d6fec8497a45b16f8cdfe20dedcfc780c6b2f56
+  data.tar.gz: 7aa8fa5a0340426603b0e9e61e676bfd401309aa0b73d2840d56bcdc403d53eb00cbf67f6f4b8bd4e2cc4ff86a836b1e788512eac0728336039d9686c0e733ce

data/lib/weak_parameters/string_validator.rb

@@ -1,4 +1,7 @@
 module WeakParameters
   class StringValidator < WeakParameters::BaseValidator
+    def valid_type?
+      value.is_a?(String)
+    end
   end
 end

data/lib/weak_parameters/version.rb

@@ -1,3 +1,3 @@
 module WeakParameters
-  VERSION = "0.0.9"
+  VERSION = "0.1.0"
 end

data/spec/requests/recipes_spec.rb

@@ -13,133 +13,107 @@ describe "Recipes" do
     }
   end
 
+  shared_examples_for "400" do
+    it "returns 400" do
+      post "/recipes", params
+      response.status.should == 400
+    end
+  end
+
+  shared_examples_for "201" do
+    it "creates a new recipe" do
+      post "/recipes", params
+      response.status.should == 201
+    end
+  end
+
   describe "POST /recipes" do
     context "without required param" do
       before do
         params.delete(:name)
       end
+      include_examples "400"
+    end
 
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
+    context "with wrong string param" do
+      before do
+        params[:name] = ["x"]
       end
+      include_examples "400"
     end
 
     context "with wrong integer param" do
       before do
         params[:type] = "x"
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
+      include_examples "400"
     end
 
     context "with exceptional interger param" do
       before do
         params[:number] = true
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
+      include_examples "400"
     end
 
     context "with wrong boolean param" do
       before do
         params[:flag] = "x"
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
+      include_examples "400"
     end
 
     context "with wrong array param" do
       before do
         params[:tags] = "x"
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
+      include_examples "400"
     end
 
     context "with wrong hash param" do
       before do
         params[:config] = "x"
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
+      include_examples "400"
     end
 
     context "with wrong float param" do
       before do
         params[:rate] = "-x"
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
+      include_examples "400"
     end
 
     context "with block failure" do
       before do
         params[:zip_code] = "123-456"
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
-    end
-
-    context "without non-required param" do
-      before do
-        params.delete(:type)
-      end
-
-      it "creates a new recipe" do
-        post "/recipes", params
-        response.status.should == 201
-      end
+      include_examples "400"
     end
 
     context "with invalid param to :only condition" do
       before do
         params[:type] = 4
       end
-
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
-      end
+      include_examples "400"
     end
 
     context "with invalid param to :except condition" do
       before do
         params[:name] = "invalid"
       end
+      include_examples "400"
+    end
 
-      it "returns 400" do
-        post "/recipes", params
-        response.status.should == 400
+    context "without non-required param" do
+      before do
+        params.delete(:type)
       end
+      include_examples "201"
     end
 
     context "with valid condition", :autodoc do
-      it "creates a new recipe" do
-        post "/recipes", params
-        response.status.should == 201
-      end
+      include_examples "201"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: weak_parameters
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.0
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-04 00:00:00.000000000 Z
+date: 2013-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails