wavefront-sdk 3.7.1 → 5.2.0

data/spec/wavefront-sdk/cloudintegration_spec.rb

@@ -37,6 +37,36 @@ class WavefrontCloudIntegrationTest < WavefrontTestBase
     assert_raises(ArgumentError) { wf.disable }
   end
 
+  def test_create_aws_external_id
+    assert_posts('/api/v2/cloudintegration/awsExternalId', nil, :json) do
+      wf.create_aws_external_id
+    end
+  end
+
+  def test_delete_aws_external_id
+    assert_deletes("/api/v2/cloudintegration/awsExternalId/#{external_id}") do
+      wf.delete_aws_external_id(external_id)
+    end
+
+    assert_raises(Wavefront::Exception::InvalidAwsExternalId) do
+      wf.delete_aws_external_id(invalid_external_id)
+    end
+
+    assert_raises(ArgumentError) { wf.delete_aws_external_id }
+  end
+
+  def test_confirm_aws_external_id
+    assert_gets("/api/v2/cloudintegration/awsExternalId/#{external_id}") do
+      wf.confirm_aws_external_id(external_id)
+    end
+
+    assert_raises(Wavefront::Exception::InvalidAwsExternalId) do
+      wf.confirm_aws_external_id(invalid_external_id)
+    end
+
+    assert_raises(ArgumentError) { wf.confirm_aws_external_id }
+  end
+
   private
 
   def id
@@ -62,4 +92,12 @@ class WavefrontCloudIntegrationTest < WavefrontTestBase
   def api_class
     'cloudintegration'
   end
+
+  def external_id
+    'HqOM4mru5svd3uFp'
+  end
+
+  def invalid_external_id
+    '__nonsense__'
+  end
 end

data/spec/wavefront-sdk/core/api_caller_spec.rb

@@ -37,6 +37,49 @@ class WavefrontApiCallerTest < MiniTest::Test
     assert_requested(:get, uri, headers: headers)
   end
 
+  def test_get_flat_params
+    query = { rkey: %w[val1 val2 val3], ukey: 36 }
+    uri = "#{uri_base}/path?rkey=val1&rkey=val2&rkey=val3&ukey=36"
+    stub_request(:get, uri).to_return(body: DUMMY_RESPONSE, status: 200)
+    wf.get_flat_params('/path', query)
+    assert_requested(:get, uri, headers: headers)
+  end
+
+  def test_get_stream
+    uri = "#{uri_base}/path?key1=val1"
+    stub_request(:get, uri).to_return(body: DUMMY_RESPONSE, status: 200)
+    out, err = capture_io { wf.get_stream('/path', key1: 'val1') }
+    assert_requested(:get, uri, headers: headers)
+    assert_equal(out.strip, DUMMY_RESPONSE)
+    assert_empty(err)
+  end
+
+  def test_get_stream_array_params
+    uri = "#{uri_base}/path?key=val1&key=val2"
+    stub_request(:get, uri).to_return(body: DUMMY_RESPONSE, status: 200)
+    out, err = capture_io { wf.get_stream('/path', key: %w[val1 val2]) }
+    assert_requested(:get, uri, headers: headers)
+    assert_equal(out.strip, DUMMY_RESPONSE)
+    assert_empty(err)
+  end
+
+  def test_get_stream_timestamp
+    uri = "#{uri_base}/path?key1=val1"
+    stub_request(:get, uri).to_return(body: DUMMY_RESPONSE, status: 200)
+
+    out, err = capture_io do
+      wf.get_stream('/path',
+                    { key1: 'val1' },
+                    timestamp_chunks: true)
+    end
+
+    assert_requested(:get, uri, headers: headers)
+    out_lines = out.split("\n")
+    assert_match(/^\d{4}-\d\d-\d\d \d\d:\d\d:\d\d \+\d{4}$/, out_lines[0])
+    assert_equal(out_lines[1], DUMMY_RESPONSE)
+    assert_empty(err)
+  end
+
   def test_post
     uri = "#{uri_base}/path"
     obj = { key: 'value' }

data/spec/wavefront-sdk/credentials_spec.rb

@@ -153,10 +153,9 @@ class GibletsTest < MiniTest::Test
   end
 
   def test_load_from_file
-    assert_equal({},
-                 wf.load_from_file(
-                   [Pathname.new('/no/file/1'), Pathname.new('/no/file/2')]
-                 ))
+    assert_raises(Wavefront::Exception::InvalidConfigFile) do
+      wf.load_from_file([Pathname.new('/nofile/1'), Pathname.new('/nofile/2')])
+    end
 
     assert_equal({ file: CONF1 }, wf.load_from_file([CONF1], 'noprofile'))
 

data/spec/wavefront-sdk/metric_helper_spec.rb

@@ -118,7 +118,7 @@ class WavefrontMetricHelperTest < MiniTest::Test
     assert_equal(1, out.select do |o|
                       o[:value] == [[2, 10.0], [1, 11.0],
                                     [1, 12.0]]
-                    end .size)
+                    end.size)
     assert_equal(1, out.select { |o| o[:tags] == WH_TAGS }.size)
     assert_equal(3, out.select { |o| o[:path] == 'test.dist1' }.size)
   end

data/spec/wavefront-sdk/role_spec.rb

@@ -0,0 +1,96 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require_relative '../spec_helper'
+require_relative '../test_mixins/general'
+
+# Unit tests for Wavefront::Role
+#
+class WavefrontRoleTest < WavefrontTestBase
+  include WavefrontTest::Create
+  include WavefrontTest::Delete
+  include WavefrontTest::Describe
+  include WavefrontTest::List
+  include WavefrontTest::Update
+
+  def test_add_assignees
+    assert_posts("/api/v2/role/#{id}/addAssignees", assignees.to_json) do
+      wf.add_assignees(id, assignees)
+    end
+
+    assert_raises(Wavefront::Exception::InvalidRoleId) do
+      wf.add_assignees(invalid_id, assignees)
+    end
+  end
+
+  def test_remove_assignees
+    assert_posts("/api/v2/role/#{id}/removeAssignees", assignees.to_json) do
+      wf.remove_assignees(id, assignees)
+    end
+
+    assert_raises(Wavefront::Exception::InvalidRoleId) do
+      wf.remove_assignees(invalid_id, assignees)
+    end
+  end
+
+  def test_grant
+    assert_posts("/api/v2/role/grant/#{permission}", roles.to_json) do
+      wf.grant(permission, roles)
+    end
+
+    assert_raises(Wavefront::Exception::InvalidRoleId) do
+      wf.grant(permission, [invalid_id])
+    end
+
+    assert_raises(Wavefront::Exception::InvalidPermission) do
+      wf.grant('made_up_permission', roles)
+    end
+  end
+
+  def test_revoke
+    assert_posts("/api/v2/role/revoke/#{permission}", roles.to_json) do
+      wf.revoke(permission, roles)
+    end
+
+    assert_raises(Wavefront::Exception::InvalidRoleId) do
+      wf.revoke(permission, [invalid_id])
+    end
+
+    assert_raises(Wavefront::Exception::InvalidPermission) do
+      wf.revoke('made_up_permission', roles)
+    end
+  end
+
+  private
+
+  def api_class
+    :role
+  end
+
+  def id
+    'f8dc0c14-91a0-4ca9-8a2a-7d47f4db4672'
+  end
+
+  def roles
+    %w[f8dc0c14-91a0-4ca9-8a2a-7d47f4db4672
+       2659191e-aad4-4302-a94e-9667e1517127]
+  end
+
+  def assignees
+    roles.push('sa::test')
+  end
+
+  def invalid_id
+    '__BAD_ID__'
+  end
+
+  def payload
+    { name: 'test role',
+      permissions: %w[alerts_management events_management],
+      description: 'dummy role for unit tests' }
+  end
+
+  def permission
+    'alerts_management'
+  end
+end

data/spec/wavefront-sdk/spy_spec.rb

@@ -0,0 +1,113 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require_relative '../spec_helper'
+require_relative '../../lib/wavefront-sdk/spy'
+
+# Unit tests for Spy class
+#
+class WavefrontSpyTest < MiniTest::Test
+  attr_reader :wf
+
+  def setup
+    @wf = Wavefront::Spy.new(CREDS)
+  end
+
+  def test_points
+    capture_io do
+      assert_gets('/api/spy/points?sampling=0.01') { wf.points }
+      assert_gets('/api/spy/points?sampling=0.05') { wf.points(0.05) }
+
+      assert_gets('/api/spy/points?sampling=0.05&metric=my_prefix') do
+        wf.points(0.05, prefix: 'my_prefix')
+      end
+
+      assert_gets('/api/spy/points?sampling=0.05&metric=my_prefix&host=h1') do
+        wf.points(0.05, prefix: 'my_prefix', host: 'h1')
+      end
+
+      assert_gets('/api/spy/points?sampling=0.02&metric=my_prefix&' \
+                  'pointTagKey=mytag') do
+        wf.points(0.02, prefix: 'my_prefix', tag_key: 'mytag')
+      end
+
+      assert_gets('/api/spy/points?sampling=0.02&metric=my_prefix&' \
+                  'pointTagKey=tag1&pointTagKey=tag2') do
+        wf.points(0.02, prefix: 'my_prefix', tag_key: %w[tag1 tag2])
+      end
+    end
+  end
+
+  def test_histograms
+    capture_io do
+      assert_gets('/api/spy/histograms?sampling=0.01') { wf.histograms }
+      assert_gets('/api/spy/histograms?sampling=0.05') { wf.histograms(0.05) }
+
+      assert_gets('/api/spy/histograms?sampling=0.05&histogram=my_prefix') do
+        wf.histograms(0.05, prefix: 'my_prefix')
+      end
+
+      assert_gets(
+        '/api/spy/histograms?sampling=0.05&histogram=my_prefix&host=h1'
+      ) do
+        wf.histograms(0.05, prefix: 'my_prefix', host: 'h1')
+      end
+
+      assert_gets('/api/spy/histograms?sampling=0.02&histogram=my_prefix&' \
+                  'histogramTagKey=the_tag') do
+        wf.histograms(0.02, prefix: 'my_prefix', tag_key: 'the_tag')
+      end
+
+      assert_gets('/api/spy/histograms?sampling=0.02&histogram=my_prefix&' \
+                  'histogramTagKey=tag1&histogramTagKey=tag2') do
+        wf.histograms(0.02, prefix: 'my_prefix', tag_key: %w[tag1 tag2])
+      end
+    end
+  end
+
+  def test_spans
+    capture_io do
+      assert_gets('/api/spy/spans?sampling=0.01') { wf.spans }
+      assert_gets('/api/spy/spans?sampling=0.05') { wf.spans(0.05) }
+
+      assert_gets('/api/spy/spans?sampling=0.05&name=my_prefix') do
+        wf.spans(0.05, prefix: 'my_prefix')
+      end
+
+      assert_gets(
+        '/api/spy/spans?sampling=0.05&name=my_prefix&host=h1'
+      ) do
+        wf.spans(0.05, prefix: 'my_prefix', host: 'h1')
+      end
+
+      assert_gets('/api/spy/spans?sampling=0.02&name=my_prefix&' \
+                  'spanTagKey=the_tag') do
+        wf.spans(0.02, prefix: 'my_prefix', tag_key: 'the_tag')
+      end
+
+      assert_gets('/api/spy/spans?sampling=0.02&name=my_prefix&' \
+                  'spanTagKey=tag1&spanTagKey=tag2') do
+        wf.spans(0.02, prefix: 'my_prefix', tag_key: %w[tag1 tag2])
+      end
+    end
+  end
+
+  def test_ids
+    capture_io do
+      assert_gets('/api/spy/ids?sampling=0.01') { wf.ids }
+      assert_gets('/api/spy/ids?sampling=0.05') { wf.ids(0.05) }
+
+      assert_gets('/api/spy/ids?sampling=0.05&type=METRIC') do
+        wf.ids(0.05, type: 'METRIC')
+      end
+
+      assert_gets('/api/spy/ids?sampling=0.05&type=SPAN&name=my_prefix') do
+        wf.ids(0.05, type: 'SPAN', prefix: 'my_prefix')
+      end
+    end
+  end
+
+  def dummy_response
+    DUMMY_RESPONSE
+  end
+end

data/spec/wavefront-sdk/unstable/chart_spec.rb

@@ -0,0 +1,39 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require_relative '../../spec_helper'
+require_relative '../../../lib/wavefront-sdk/unstable/chart'
+
+# Unit tests for Chart class
+#
+class WavefrontChartTest < MiniTest::Test
+  attr_reader :wf
+
+  def setup
+    @wf = Wavefront::Unstable::Chart.new(CREDS)
+  end
+
+  def test_all_metrics
+    assert_gets('/chart/metrics/all?l=100&q=&trie=true') do
+      wf.metrics_under('')
+    end
+  end
+
+  def test_metrics_under
+    assert_gets('/chart/metrics/all?l=100&q=test.path&trie=true') do
+      wf.metrics_under('test.path')
+    end
+
+    assert_gets('/chart/metrics/all?l=10&q=test.path&trie=true') do
+      wf.metrics_under('test.path', nil, 10)
+    end
+
+    assert_gets('/chart/metrics/all?l=100&p=last.one&q=test.path&trie=true') do
+      wf.metrics_under('test.path', 'last.one')
+    end
+  end
+
+  def dummy_response
+    { metrics: ['test data'] }.to_json
+  end
+end

data/spec/wavefront-sdk/user_spec.rb

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
+require 'logger'
 require_relative '../spec_helper'
 require_relative '../test_mixins/general'
 
@@ -13,6 +14,13 @@ class WavefrontUserTest < WavefrontTestBase
   include WavefrontTest::Describe
   include WavefrontTest::Update
 
+  # Override the parent constructor so we can suppress all the 'deprecated'
+  # log messages
+  #
+  def setup
+    @wf = Wavefront::User.new(CREDS, logger: Logger.new('/dev/null'))
+  end
+
   def test_list
     assert_gets('/api/v2/user') { wf.list }
   end

data/spec/wavefront-sdk/usergroup_spec.rb

@@ -7,7 +7,8 @@ require_relative '../test_mixins/general'
 # Unit tests for WavefrontUserGroup
 #
 class WavefrontUserGroupTest < WavefrontTestBase
-  attr_reader :users, :groups, :permission, :invalid_groups, :invalid_users
+  attr_reader :users, :groups, :permission, :invalid_groups, :invalid_users,
+              :roles, :invalid_roles
 
   include WavefrontTest::Create
   include WavefrontTest::Delete
@@ -39,22 +40,28 @@ class WavefrontUserGroupTest < WavefrontTestBase
     assert_invalid_id { wf.remove_users_from_group(invalid_id, users) }
   end
 
-  def test_grant
-    assert_posts("/api/v2/usergroup/grant/#{permission}",
-                 groups.to_json) do
-      wf.grant(permission, groups)
+  def test_add_roles_to_group
+    assert_posts("/api/v2/usergroup/#{id}/addRoles", roles.to_json) do
+      wf.add_roles_to_group(id, roles)
     end
 
-    assert_invalid_id { wf.grant(permission, invalid_groups) }
+    assert_raises(Wavefront::Exception::InvalidRoleId) do
+      wf.add_roles_to_group(id, invalid_roles)
+    end
+
+    assert_invalid_id { wf.add_roles_to_group(invalid_id, roles) }
   end
 
-  def test_revoke
-    assert_posts("/api/v2/usergroup/revoke/#{permission}",
-                 groups.to_json) do
-      wf.revoke(permission, groups)
+  def test_remove_roles_from_group
+    assert_posts("/api/v2/usergroup/#{id}/removeRoles", roles.to_json) do
+      wf.remove_roles_from_group(id, roles)
+    end
+
+    assert_raises(Wavefront::Exception::InvalidRoleId) do
+      wf.remove_roles_from_group(id, invalid_roles)
     end
 
-    assert_invalid_id { wf.revoke(permission, invalid_groups) }
+    assert_invalid_id { wf.remove_roles_from_group(invalid_id, roles) }
   end
 
   def setup_fixtures
@@ -63,7 +70,10 @@ class WavefrontUserGroupTest < WavefrontTestBase
     @groups = %w[f8dc0c14-91a0-4ca9-8a2a-7d47f4db4672
                  2659191e-aad4-4302-a94e-9667e1517127]
     @users = %w[someone@somewhere.com other@elsewhere.net]
+    @roles = %w[abcdef14-91a0-4ca9-8a2a-7d47f4db4672
+                fedcba1e-aad4-4302-a94e-9667e1517127]
     @invalid_users = ['bad' * 500, '']
+    @invalid_roles = ['some nonsense']
   end
 
   private