wavefront-client 3.5.4 → 3.6.0

data/spec/cli_spec.rb

@@ -23,11 +23,6 @@ require 'uri'
 require_relative './spec_helper'
 require 'wavefront/client/version'
 
-ROOT = Pathname.new(__FILE__).dirname.parent
-WF = ROOT + 'bin' + 'wavefront'
-LIB = ROOT + 'lib'
-CF = ROOT + 'spec' + 'wavefront' + 'resources' + 'conf.yaml'
-
 # Things from the sample config file, for shorthand
 #
 DEF_TOKEN = '12345678-abcd-1234-abcd-123456789012'
@@ -48,6 +43,263 @@ TIME = {
   }
 }
 
+describe 'dashboard mode' do
+  cmds = %W(list import export create clone delete undelete
+            history).each do |cmd|
+    it "#{cmd} fails with no token if there is no token" do
+      args = 'arg1'
+      args = '' if cmd == 'list'
+      args = 'arg1 arg2 arg3' if cmd == 'clone'
+      args = 'arg1 arg2' if cmd == 'create'
+      o = wf("dashboard #{cmd} -c/nf #{args}")
+      expect(o.status).to eq(1)
+      expect(o.stderr).to eq(
+        'dashboard query failed. Please supply an API token.')
+      expect(o.stdout).to eq(
+        "config file '/nf' not found. Taking options from command-line.")
+    end
+  end
+
+  describe 'list subcommand' do
+    it 'performs a verbose noop with default options' do
+      o = wf('dashboard -c /nf -n -t token list')
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+      expect(o.stdout_a[-2]).to match(
+        'GET https://metrics.wavefront.com/api/dashboard')
+      expect(o.stdout).to match(/Taking options from command-line/)
+    end
+
+    it 'performs a verbose noop with default config file options' do
+      o = wf("dashboard -c #{CF} -n -T tag1 list")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-1]).to eq(
+        "HEADERS {:\"X-AUTH-TOKEN\"=>\"#{DEF_TOKEN}\"}")
+      expect(o.stdout_a[-2]).to start_with(
+        'GET https://default.wavefront.com/api/dashboard/')
+      expect(o.stdout_a[-2]).to have_element([:customerTag, 'tag1'])
+      expect(o.stdout).to_not match(/Taking options from command-line/)
+    end
+
+    it 'performs a verbose noop with config file and CLI options' do
+      o = wf("dashboard -c #{CF} -P other -n list -a")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"abcdefab-0123-abcd-0123-abcdefabcdef"}')
+      expect(o.stdout_a[-2]).to start_with(
+        'GET https://other.wavefront.com/api/dashboard/')
+      expect(o.stdout).to_not match(/Taking options from command-line/)
+    end
+  end
+
+  describe 'import subcommand' do
+    it 'errors safely on a non-existent file' do
+      o = wf("dashboard -c #{CF} -t token import /no/such/file")
+      expect(o.stdout).to be_empty
+      expect(o.status).to eq(1)
+      expect(o.stderr).to eq(
+        'dashboard query failed. Import file does not exist.')
+    end
+
+    it 'errors safely on an unsupported file type' do
+      o = wf("dashboard -c #{CF} -t token import #{RES_DIR +
+             'sample_dash.txt'}")
+      expect(o.stdout).to be_empty
+      expect(o.status).to eq(1)
+      expect(o.stderr).to eq(
+        'dashboard query failed. Unsupported file format.')
+    end
+
+    it 'performs a verbose no-op with a JSON import file' do
+      o = wf("dashboard -c #{CF} -n -t token import #{RES_DIR +
+             'sample_dash.json'}")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://default.wavefront.com/api/dashboard/?rejectIfExists=true')
+      expect(o.stdout_a[-2]).to start_with(
+        'QUERY {"customer":"sysdef","url":"internal_metrics"')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose no-op with a YAML import file' do
+      o = wf("dashboard -c #{CF} -P other -n -F import #{RES_DIR +
+             'sample_dash.yaml'}")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://other.wavefront.com/api/dashboard/')
+      expect(o.stdout_a[-2]).to start_with(
+        'QUERY {"customer":"sysdef","url":"internal_metrics"')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"abcdefab-0123-abcd-0123-abcdefabcdef"}')
+    end
+  end
+
+  describe 'export subcommand' do
+    it 'performs a verbose no-op with options' do
+      o = wf("dashboard -E endpoint.wavefront.com -n -t token export mydash")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('GET ' \
+        'https://endpoint.wavefront.com/api/dashboard/mydash')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose no-op with a config file' do
+      o = wf("dashboard -c #{CF} -n export mydash")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('GET ' \
+        'https://default.wavefront.com/api/dashboard/mydash')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"12345678-abcd-1234-abcd-123456789012"}')
+    end
+  end
+
+  describe 'create subcommand' do
+    it 'performs a verbose no-op with defaults' do
+      o = wf("dashboard -t token -n create test_id \"test name\"")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://metrics.wavefront.com/api/dashboard/test_id/create')
+      expect(o.stdout_a[-2]).to eq('QUERY name=test%20name')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose no-op with a config file' do
+      o = wf("dashboard -c #{CF} -P other -n create test_id \"test name\"")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://other.wavefront.com/api/dashboard/test_id/create')
+      expect(o.stdout_a[-2]).to eq('QUERY name=test%20name')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"abcdefab-0123-abcd-0123-abcdefabcdef"}')
+    end
+  end
+
+  describe 'clone subcommand' do
+    it 'performs a verbose no-op with defaults' do
+      o = wf('dashboard clone -t token -n src_id new_id "new name"')
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://metrics.wavefront.com/api/dashboard/src_id/clone')
+      expect(o.stdout_a[-2]).to eq('QUERY name=new%20name&url=new_id')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose no-op with config file' do
+      o = wf("dashboard clone -c #{CF} -n src_id new_id 'new name'")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://default.wavefront.com/api/dashboard/src_id/clone')
+      expect(o.stdout_a[-2]).to eq('QUERY name=new%20name&url=new_id')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"12345678-abcd-1234-abcd-123456789012"}')
+    end
+
+    it 'performs a verbose no-op with options and config file' do
+      o = wf("dashboard clone -E endpoint.wavefront.com -c #{CF} " \
+             '-v 14 -P other -n src_id new_id "new name"')
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://endpoint.wavefront.com/api/dashboard/src_id/clone')
+      expect(o.stdout_a[-2]).to eq('QUERY name=new%20name&url=new_id&v=14')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"abcdefab-0123-abcd-0123-abcdefabcdef"}')
+    end
+  end
+
+  describe 'delete subcommand' do
+    it 'performs a verbose no-op with options ' do
+      o = wf(
+        'dashboard -E endpoint.wavefront.com -t token -n delete mydash')
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('POST ' \
+        'https://endpoint.wavefront.com/api/dashboard/mydash/delete')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose no-op with a config file' do
+      o = wf("dashboard -c #{CF} -n delete mydash")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('POST ' \
+        'https://default.wavefront.com/api/dashboard/mydash/delete')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"12345678-abcd-1234-abcd-123456789012"}')
+    end
+  end
+
+  describe 'undelete subcommand' do
+    it 'performs a verbose no-op with options ' do
+      o = wf(
+        'dashboard -E endpoint.wavefront.com -t token -n undelete mydash')
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('POST ' \
+        'https://endpoint.wavefront.com/api/dashboard/mydash/undelete')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose no-op with a config file' do
+      o = wf("dashboard -c #{CF} -n undelete mydash")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('POST ' \
+        'https://default.wavefront.com/api/dashboard/mydash/undelete')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"12345678-abcd-1234-abcd-123456789012"}')
+    end
+  end
+
+
+  describe 'history subcommand' do
+    it 'performs a verbose no-op with no options' do
+      o = wf('dashboard -t token -n history mydash')
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('GET https://metrics.wavefront.com/' \
+        'api/dashboard/mydash/history?start=100')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+  end
+
+  describe 'history subcommand' do
+    it 'performs a verbose no-op with config file' do
+      o = wf("dashboard -c #{CF} -S 10 -n history mydash")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('GET https://default.wavefront.com/' \
+        'api/dashboard/mydash/history?start=10')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"12345678-abcd-1234-abcd-123456789012"}')
+    end
+  end
+
+  describe 'history subcommand' do
+    it 'performs a verbose no-op with config file and options' do
+      o = wf("dashboard -c #{CF} -P other -S 10 -L 5 -n history mydash")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to eq('GET https://other.wavefront.com/' \
+        'api/dashboard/mydash/history?start=10&limit=5')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"abcdefab-0123-abcd-0123-abcdefabcdef"}')
+    end
+
+  end
+end
+
 describe 'usage' do
   commands = %w(alerts event source ts write)
 
@@ -85,6 +337,75 @@ describe 'usage' do
   end
 end
 
+describe 'alerts mode' do
+
+  describe 'export subcommand' do
+    it 'performs a verbose noop with a CLI token' do
+      o = wf('alerts -n -t token export 1489152324000')
+      expect(o.status).to eq(0)
+      expect(o.stderr).to be_empty
+      expect(o.stdout_a[-2]).to eq(
+        'GET https://metrics.wavefront.com/api/alert/1489152324000')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose noop with a config file and CLI token' do
+      o = wf("alerts -c #{CF} -n -t token -f yaml export 1489152324000")
+      expect(o.status).to eq(0)
+      expect(o.stderr).to be_empty
+      expect(o.stdout_a[-2]).to eq(
+        'GET https://default.wavefront.com/api/alert/1489152324000')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+  end
+
+  describe 'import subcommand' do
+    it 'errors safely on a non-existent file' do
+      o = wf("alerts -c #{CF} -t token import /no/such/file")
+      expect(o.stdout).to be_empty
+      expect(o.status).to eq(1)
+      expect(o.stderr).to eq(
+        'alerts query failed. Import file does not exist.')
+    end
+
+    it 'errors safely on an unsupported file type' do
+      o = wf("alerts -c #{CF} -t token import #{RES_DIR +
+             'sample_alert.txt'}")
+      expect(o.stdout).to be_empty
+      expect(o.status).to eq(1)
+      expect(o.stderr).to eq(
+        'alerts query failed. Unsupported file format.')
+    end
+
+    it 'performs a verbose no-op with a JSON import file' do
+      o = wf("alerts -c #{CF} -n -t token import #{RES_DIR +
+             'sample_alert.json'}")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to have_element([:severity, 'WARN'])
+      expect(o.stdout_a[-2]).to have_element([:resolveMinutes, 5])
+      expect(o.stdout_a[-2]).to_not have_element([:resolveAfterMinutes, 5])
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://default.wavefront.com/api/alert/create')
+      expect(o.stdout_a[-1]).to eq('HEADERS {:"X-AUTH-TOKEN"=>"token"}')
+    end
+
+    it 'performs a verbose no-op with a YAML import file' do
+      o = wf("alerts -c #{CF} -n -E test.wavefront.com import #{RES_DIR +
+             'sample_alert.yaml'}")
+      expect(o.stderr).to be_empty
+      expect(o.status).to eq(0)
+      expect(o.stdout_a[-2]).to have_element([:severity, 'WARN'])
+      expect(o.stdout_a[-2]).to have_element([:resolveMinutes, 5])
+      expect(o.stdout_a[-2]).to_not have_element([:resolveAfterMinutes, 5])
+      expect(o.stdout_a[-3]).to eq('POST ' \
+        'https://test.wavefront.com/api/alert/create')
+      expect(o.stdout_a[-1]).to eq(
+        'HEADERS {:"X-AUTH-TOKEN"=>"12345678-abcd-1234-abcd-123456789012"}')
+    end
+  end
+end
+
 describe 'alerts mode' do
   it 'fails with no token if there is no token' do
     o = wf('alerts -c/nf -E metrics.wavefront.com active')
@@ -107,24 +428,29 @@ describe 'alerts mode' do
     o = wf('alerts -n -c/nf -t token -E test.wavefront.com active')
     expect(o.status).to eq(0)
     expect(o.stderr).to be_empty
-    expect(o.stdout_a[-1]).to eq(
-      'GET https://test.wavefront.com/api/alert/active?t=token')
+    expect(o.stdout_a[-2]).to eq(
+      'GET https://test.wavefront.com/api/alert/active')
   end
 
   it 'performs a verbose noop with default config file options' do
     o = wf("alerts -n -c #{CF} active")
     expect(o.status).to eq(0)
     expect(o.stderr).to be_empty
+    expect(o.stdout_a[-2]).to eq(
+      'GET https://default.wavefront.com/api/alert/active')
     expect(o.stdout_a.last).to eq(
-      "GET https://default.wavefront.com/api/alert/active?t=#{DEF_TOKEN}")
+      "HEADERS {:\"X-AUTH-TOKEN\"=>\"#{DEF_TOKEN}\"}")
+
   end
 
   it 'performs a verbose noop with config file and CLI options' do
     o = wf("alerts -n -c #{CF} -E cli.wavefront.com active")
     expect(o.status).to eq(0)
     expect(o.stderr).to be_empty
+    expect(o.stdout_a[-2]).to eq(
+      'GET https://cli.wavefront.com/api/alert/active')
     expect(o.stdout_a.last).to eq(
-      "GET https://cli.wavefront.com/api/alert/active?t=#{DEF_TOKEN}")
+      "HEADERS {:\"X-AUTH-TOKEN\"=>\"#{DEF_TOKEN}\"}")
   end
 end
 

data/spec/spec_helper.rb

@@ -23,15 +23,22 @@ require 'wavefront/events'
 require 'wavefront/batch_writer'
 require 'wavefront/validators'
 require 'wavefront/opt_handler'
+require 'wavefront/dashboards'
 require 'wavefront/cli'
 require 'wavefront/cli/alerts'
 require 'wavefront/cli/events'
 require 'wavefront/cli/batch_write'
 require 'wavefront/cli/write'
 require 'wavefront/cli/sources'
+require 'wavefront/cli/dashboards'
 
 TEST_TOKEN = "test"
 TEST_HOST = "metrics.wavefront.com"
+ROOT = Pathname.new(__FILE__).dirname.parent
+RES_DIR = ROOT + 'spec' + 'wavefront' + 'cli' + 'resources'
+CF = RES_DIR + 'conf.yaml'
+WF = ROOT + 'bin' + 'wavefront'
+LIB = ROOT + 'lib'
 
 # The following RSpec matcher is used to test things which `puts`
 # (or related), which RSpec can't do by default. It works with RSpec

data/spec/wavefront/alerting_spec.rb

@@ -44,67 +44,114 @@ describe Wavefront::Alerting do
 
   describe '#get_alerts' do
     it 'makes API request with default options' do
-      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, "all?t=#{TEST_TOKEN}")}")
+      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, 'all')}", {:"X-AUTH-TOKEN"=>"test"})
       @wave.all
     end
 
     it 'makes API request with specified host' do
       host = 'madeup.wavefront.com'
-      expect(RestClient).to receive(:get).with("https://#{File.join(host, Wavefront::Alerting::DEFAULT_PATH, "all?t=#{TEST_TOKEN}")}")
+      expect(RestClient).to receive(:get).with("https://#{File.join(host, Wavefront::Alerting::DEFAULT_PATH, 'all')}", {:"X-AUTH-TOKEN"=>"test"})
       @wave.all({ :host => host })
     end
 
-    it 'makes API request with specified path' do
-      path = '/api/new_alerts'
-      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, path, "all?t=#{TEST_TOKEN}")}")
-      @wave.all({ :path => path })
-    end
-
     it 'makes API request with appended shared tags' do
       tags = [ 'first', 'second' ]
-      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, "all?t=#{TEST_TOKEN}&customerTag=first&customerTag=second")}")
+      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, "all?customerTag=first&customerTag=second")}", {:"X-AUTH-TOKEN"=>"test"})
       @wave.all({ :shared_tags => tags })
     end
 
     it 'makes API request with appended private tags' do
       tags = [ 'first', 'second' ]
-      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, "all?t=#{TEST_TOKEN}&userTag=first&userTag=second")}")
+      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, "all?userTag=first&userTag=second")}", {:"X-AUTH-TOKEN"=>"test"})
       @wave.all({ :private_tags => tags })
     end
 
     it 'makes API request with both appended private tags and shared tags' do
       private_tag = 'first'
       shared_tag = 'second'
-      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, "all?t=#{TEST_TOKEN}&customerTag=second&userTag=first")}")
+      expect(RestClient).to receive(:get).with("https://#{File.join(Wavefront::Alerting::DEFAULT_HOST, Wavefront::Alerting::DEFAULT_PATH, "all?customerTag=second&userTag=first")}", {:"X-AUTH-TOKEN"=>"test"})
       @wave.all({ :private_tags => private_tag, :shared_tags => shared_tag })
     end
   end
 
   describe '#active' do
     it 'requests all active alerts' do
-      expect(@wave).to receive(:get_alerts).with("active", {})
+      expect(@wave).to receive(:create_uri).with(path: "active", qs: "")
+      expect(@wave).to receive(:call_get)
       @wave.active
     end
   end
 
   describe '#snoozed' do
     it 'requests all snoozed alerts' do
-      expect(@wave).to receive(:get_alerts).with("snoozed", {})
+      expect(@wave).to receive(:create_uri).with(path: "snoozed", qs: "")
+      expect(@wave).to receive(:call_get)
       @wave.snoozed
     end
   end
 
   describe '#invalid' do
     it 'requests all invalid alerts' do
-      expect(@wave).to receive(:get_alerts).with("invalid", {})
+      expect(@wave).to receive(:create_uri).with(path: "invalid", qs: "")
+      expect(@wave).to receive(:call_get)
       @wave.invalid
     end
   end
 
   describe '#affected_by_maintenance' do
     it 'requests all affected_by_maintenance alerts' do
-      expect(@wave).to receive(:get_alerts).with("affected_by_maintenance", {})
+      expect(@wave).to receive(:create_uri).with(path: "affected_by_maintenance", qs: "")
+      expect(@wave).to receive(:call_get)
       @wave.affected_by_maintenance
     end
   end
+
+  describe '#import_to_create' do
+    it 'produces expected output from known input' do
+      raw = JSON.load(IO.read(RES_DIR + 'input_alert.json'))
+      out = @wave.import_to_create(raw)
+      p out
+      expect(out).to be_instance_of(Hash)
+      expect(out.keys).to match_array(
+        [:name, :condition, :minutes, :resolveMinutes, :notifications,
+         :severity, :sharedTags, :additionalInformation])
+      expect(out[:sharedTags]).to be_instance_of(Array)
+      expect(out[:minutes]).to be_instance_of(Fixnum)
+    end
+
+    it 'ignores extraneous fields' do
+      raw = JSON.load(IO.read(RES_DIR + 'input_alert.json'))
+      raw[:junk] = 'nonsense'
+      raw.delete('name')
+      out = @wave.import_to_create(raw)
+      expect(out).to be_instance_of(Hash)
+      expect(out.keys).not_to include(:junk)
+    end
+  end
+
+  describe '#create_alert' do
+    input = {:name=>"test1", :condition=>"ts(\"cpu\") > 0",
+             :minutes=>3, :notifications=>["slackboy@gmail.com",
+             "rob@sysdef.xyz"], :severity=>"INFO",
+             :resolveMinutes=>2, :sharedTags=>[],
+             :additionalInformation=>"some information"}
+
+    it 'makes a correct API call on good data' do
+      expect(@wave).to receive(:create_uri).with(path: 'create')
+      expect(@wave).to receive(:call_post)
+      out = @wave.create_alert(input)
+    end
+
+    it 'throws an error on bad severity data' do
+      input[:severity] = 'NOT_THAT_SERIOUS'
+       expect{@wave.create_alert(input)}.to raise_exception(
+         'invalid severity')
+    end
+
+    it 'throws an error on missing severity data' do
+      input.delete(:severity)
+       expect{@wave.create_alert(input)}.to raise_exception(
+         'missing field: severity')
+    end
+  end
 end