waveform 0.1.0 → 0.1.1

data/README.md

@@ -87,6 +87,10 @@ Sample sound file used in tests is in the Public Domain from soundbible.com: <ht
 Changes
 =======
 
+0.1.1
+-----
+  * Fixed RMS calculation (was calculating RMSD instead of RMS before) -- thanks, cviedmai
+
 0.1.0
 -----
   * No more wrapping ffmpeg to automatically convert mp3 to wav

data/lib/waveform.rb

@@ -214,12 +214,8 @@ class Waveform
 
     # Returns the rms value across the given collection of frames for the given
     # channel.
-    # 
-    # FIXME: this RMS calculation might be wrong...
-    # refactored this from: http://pscode.org/javadoc/src-html/org/pscode/ui/audiotrace/AudioPlotPanel.html#line.996
     def channel_rms(frames, channel=0)
-      avg = frames.inject(0.0){ |sum, frame| sum += frame ? Array(frame)[channel] : 0 }/frames.size.to_f
-      Math.sqrt(frames.inject(0.0){ |sum, frame| sum += frame ? (Array(frame)[channel]-avg)**2 : 0 }/frames.size.to_f)
+      Math.sqrt(frames.inject(0.0){ |sum, frame| sum += (frame ? Array(frame)[channel] ** 2 : 0) } / frames.size)
     end
   end
 end

data/lib/waveform/version.rb

@@ -1,3 +1,3 @@
 class Waveform
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: waveform
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: 
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Ben Alavi
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-09-27 00:00:00 Z
+date: 2012-09-28 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: ruby-audio
@@ -91,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.5
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Generate waveform images from audio files