wavefile 1.0.1 → 1.1.0

data/test/smpte_timecode_test.rb

@@ -0,0 +1,103 @@
+require 'minitest/autorun'
+require 'wavefile.rb'
+
+include WaveFile
+
+class SMPTETimecodeTest < Minitest::Test
+  VALID_8_BIT_SIGNED_INTEGER_TEST_VALUES = [0, 1, -1, -128, 127]
+  INVALID_8_BIT_SIGNED_INTEGER_TEST_VALUES = ["dsfsfsdf", :foo, -129, 128, 2.5, 2.0, -2.0, [10], nil]
+  VALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES = [0, 1, 128, 255]
+  INVALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES = ["dsfsfsdf", :foo, -1, 256, 2.5, 2.0, [10], nil]
+
+  def test_missing_keywords
+    assert_raises(ArgumentError) { SMPTETimecode.new }
+  end
+
+  def test_valid_hours
+    VALID_8_BIT_SIGNED_INTEGER_TEST_VALUES.each do |valid_value|
+      smpte_timecode = SMPTETimecode.new(hours: valid_value,
+                                         minutes: 0,
+                                         seconds: 0,
+                                         frames: 0)
+
+      assert_equal(valid_value, smpte_timecode.hours)
+    end
+  end
+
+  def test_invalid_hours
+    INVALID_8_BIT_SIGNED_INTEGER_TEST_VALUES.each do |invalid_value|
+      assert_raises(InvalidSMPTETimecodeError) do
+        SMPTETimecode.new(hours: invalid_value,
+                          minutes: 0,
+                          seconds: 0,
+                          frames: 0)
+      end
+    end
+  end
+
+  def test_valid_minutes
+    VALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES.each do |valid_value|
+      smpte_timecode = SMPTETimecode.new(hours: 0,
+                                         minutes: valid_value,
+                                         seconds: 0,
+                                         frames: 0)
+
+      assert_equal(valid_value, smpte_timecode.minutes)
+    end
+  end
+
+  def test_invalid_minutes
+    INVALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES.each do |invalid_value|
+      assert_raises(InvalidSMPTETimecodeError) do
+        SMPTETimecode.new(hours: 0,
+                          minutes: invalid_value,
+                          seconds: 0,
+                          frames: 0)
+      end
+    end
+  end
+
+  def test_valid_seconds
+    VALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES.each do |valid_value|
+      smpte_timecode = SMPTETimecode.new(hours: 0,
+                                         minutes: 0,
+                                         seconds: valid_value,
+                                         frames: 0)
+
+      assert_equal(valid_value, smpte_timecode.seconds)
+    end
+  end
+
+  def test_invalid_seconds
+    INVALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES.each do |invalid_value|
+      assert_raises(InvalidSMPTETimecodeError) do
+        SMPTETimecode.new(hours: 0,
+                          minutes: 0,
+                          seconds: invalid_value,
+                          frames: 0)
+      end
+    end
+  end
+
+  def test_valid_frames
+    VALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES.each do |valid_value|
+      smpte_timecode = SMPTETimecode.new(hours: 0,
+                                         minutes: 0,
+                                         seconds: 0,
+                                         frames: valid_value)
+
+      assert_equal(valid_value, smpte_timecode.frames)
+    end
+  end
+
+  def test_invalid_frames
+    INVALID_8_BIT_UNSIGNED_INTEGER_TEST_VALUES.each do |invalid_value|
+      assert_raises(InvalidSMPTETimecodeError) do
+        SMPTETimecode.new(hours: 0,
+                          minutes: 0,
+                          seconds: 0,
+                          frames: invalid_value)
+      end
+    end
+  end
+end

data/test/writer_test.rb

@@ -164,7 +164,7 @@ class WriterTest < Minitest::Test
       writer = Writer.new(io_or_file_name, format)
       writer.write(Buffer.new(SQUARE_WAVE_CYCLE[:mono][:pcm_8] * 128, format))
       writer.write(Buffer.new(SQUARE_WAVE_CYCLE[:mono][:pcm_8] * 128, format))
-      writer.write(Buffer.new(SQUARE_WAVE_CYCLE[:mono][:pcm_8] * 23 + [88, 88, 88, 88, 167, 167, 167], format))
+      writer.write(Buffer.new(SQUARE_WAVE_CYCLE[:mono][:pcm_8] * 24 + [88], format))
       writer.close
 
       assert_equal(read_file(:expected, file_name), read_file(:actual, file_name))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: wavefile
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Joel Strait
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-02 00:00:00.000000000 Z
+date: 2019-01-20 00:00:00.000000000 Z
 dependencies: []
 description: You can use this gem to create Ruby programs that work with audio, by
   reading and writing Wave sound files (*.wav). Since it is written in pure Ruby (as
@@ -28,12 +28,14 @@ files:
 - lib/wavefile/chunk_readers/base_chunk_reader.rb
 - lib/wavefile/chunk_readers/data_chunk_reader.rb
 - lib/wavefile/chunk_readers/format_chunk_reader.rb
-- lib/wavefile/chunk_readers/generic_chunk_reader.rb
-- lib/wavefile/chunk_readers/riff_chunk_reader.rb
 - lib/wavefile/chunk_readers/riff_reader.rb
+- lib/wavefile/chunk_readers/sample_chunk_reader.rb
 - lib/wavefile/duration.rb
 - lib/wavefile/format.rb
 - lib/wavefile/reader.rb
+- lib/wavefile/sampler_info.rb
+- lib/wavefile/sampler_loop.rb
+- lib/wavefile/smpte_timecode.rb
 - lib/wavefile/unvalidated_format.rb
 - lib/wavefile/writer.rb
 - test/buffer_test.rb
@@ -41,12 +43,25 @@ files:
 - test/duration_test.rb
 - test/fixtures/wave/invalid/bad_riff_header.wav
 - test/fixtures/wave/invalid/bad_wavefile_format.wav
+- test/fixtures/wave/invalid/data_chunk_ends_after_chunk_id.wav
+- test/fixtures/wave/invalid/data_chunk_has_incomplete_chunk_size.wav
+- test/fixtures/wave/invalid/data_chunk_truncated.wav
 - test/fixtures/wave/invalid/empty.wav
 - test/fixtures/wave/invalid/empty_format_chunk.wav
+- test/fixtures/wave/invalid/format_chunk_after_data_chunk.wav
+- test/fixtures/wave/invalid/incomplete_riff_format.wav
 - test/fixtures/wave/invalid/incomplete_riff_header.wav
 - test/fixtures/wave/invalid/insufficient_format_chunk.wav
 - test/fixtures/wave/invalid/no_data_chunk.wav
 - test/fixtures/wave/invalid/no_format_chunk.wav
+- test/fixtures/wave/invalid/no_format_chunk_size.wav
+- test/fixtures/wave/invalid/no_riff_format.wav
+- test/fixtures/wave/invalid/riff_chunk_has_incomplete_chunk_size.wav
+- test/fixtures/wave/invalid/smpl_chunk_empty.wav
+- test/fixtures/wave/invalid/smpl_chunk_fields_out_of_range.wav
+- test/fixtures/wave/invalid/smpl_chunk_loop_count_too_high.wav
+- test/fixtures/wave/invalid/smpl_chunk_truncated_sampler_specific_data.wav
+- test/fixtures/wave/invalid/truncated_smpl_chunk.wav
 - test/fixtures/wave/unsupported/bad_audio_format.wav
 - test/fixtures/wave/unsupported/bad_channel_count.wav
 - test/fixtures/wave/unsupported/bad_sample_rate.wav
@@ -85,6 +100,7 @@ files:
 - test/fixtures/wave/valid/valid_mono_float_32_44100.wav
 - test/fixtures/wave/valid/valid_mono_float_64_44100.wav
 - test/fixtures/wave/valid/valid_mono_pcm_16_44100.wav
+- test/fixtures/wave/valid/valid_mono_pcm_16_44100_junk_chunk_final_chunk_missing_padding_byte.wav
 - test/fixtures/wave/valid/valid_mono_pcm_16_44100_junk_chunk_with_padding_byte.wav
 - test/fixtures/wave/valid/valid_mono_pcm_16_44100_with_extension.wav
 - test/fixtures/wave/valid/valid_mono_pcm_24_44100.wav
@@ -103,8 +119,17 @@ files:
 - test/fixtures/wave/valid/valid_tri_pcm_24_44100.wav
 - test/fixtures/wave/valid/valid_tri_pcm_32_44100.wav
 - test/fixtures/wave/valid/valid_tri_pcm_8_44100.wav
+- test/fixtures/wave/valid/valid_with_sample_chunk_after_data_chunk.wav
+- test/fixtures/wave/valid/valid_with_sample_chunk_after_data_chunk_and_data_chunk_has_padding_byte.wav
+- test/fixtures/wave/valid/valid_with_sample_chunk_before_data_chunk.wav
+- test/fixtures/wave/valid/valid_with_sample_chunk_no_loops.wav
+- test/fixtures/wave/valid/valid_with_sample_chunk_with_extra_unused_bytes.wav
+- test/fixtures/wave/valid/valid_with_sample_chunk_with_sampler_specific_data.wav
 - test/format_test.rb
 - test/reader_test.rb
+- test/sampler_info_test.rb
+- test/sampler_loop_test.rb
+- test/smpte_timecode_test.rb
 - test/unvalidated_format_test.rb
 - test/wavefile_io_test_helper.rb
 - test/writer_test.rb
@@ -128,8 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: A pure Ruby library for reading and writing Wave sound files (*.wav)

data/lib/wavefile/chunk_readers/generic_chunk_reader.rb

@@ -1,15 +0,0 @@
-module WaveFile
-  module ChunkReaders
-    # Internal
-    class GenericChunkReader < BaseChunkReader    # :nodoc:
-      def initialize(io, chunk_size)
-        @io = io
-        @chunk_size = chunk_size
-      end
-
-      def read
-        @io.sysread(@chunk_size)
-      end
-    end
-  end
-end

data/lib/wavefile/chunk_readers/riff_chunk_reader.rb

@@ -1,19 +0,0 @@
-module WaveFile
-  module ChunkReaders
-    # Internal
-    class RiffChunkReader < BaseChunkReader    # :nodoc:
-      def initialize(io, chunk_size)
-        @io = io
-        @chunk_size = chunk_size
-      end
-
-      def read
-        riff_format = @io.sysread(4)
-
-        unless riff_format == WAVEFILE_FORMAT_CODE
-          raise_error InvalidFormatError, "Expected RIFF format of '#{WAVEFILE_FORMAT_CODE}', but was '#{riff_format}'"
-        end
-      end
-    end
-  end
-end