watir 7.2.0 → 7.3.0

data/spec/watirspec/capabilities_spec.rb

@@ -21,7 +21,7 @@ module Watir
     let(:browser_symbol) { WatirSpec.implementation.browser_args.first }
     let(:actual_capabilities) { @browser.wd.capabilities }
     let(:actual_http) { @browser.wd.instance_variable_get(:@bridge).instance_variable_get(:@http) }
-    let(:actual_service) { @browser.wd.instance_variable_get(:@service) }
+    let(:actual_service) { @browser.wd.instance_variable_get(:@service_manager) }
     let(:actual_listener) { @browser.wd.instance_variable_get(:@bridge).instance_variable_get(:@listener) }
 
     before(:all) do
@@ -30,7 +30,7 @@ module Watir
       Watir.logger.ignore(:watir_client)
     end
 
-    after(:each) { @browser&.close }
+    after { @browser&.close }
 
     after(:all) { $browser = nil }
 
@@ -55,10 +55,10 @@ module Watir
     # :capabilities (default Generated; Selenium object, or built from Hash; incompatible with options)
 
     context 'when local', exclusive: {driver: :local_driver} do
-      context 'all browsers' do
+      context 'when any browser' do
         it 'accepts driver instance' do
           driver = Selenium::WebDriver.for browser_symbol
-          @browser = Watir::Browser.new(driver)
+          @browser = described_class.new(driver)
 
           expect(actual_http).not_to be_a(Watir::HttpClient)
         end
@@ -68,14 +68,14 @@ module Watir
           client = Remote::Http::Default.new
           capabilities = Watir::Capabilities.new(browser_symbol, service: service, http_client: client)
 
-          @browser = Browser.new(capabilities)
+          @browser = described_class.new(capabilities)
 
           expect(actual_service.instance_variable_get(:@port)).to eq 1234
           expect(actual_http).to eq client
         end
 
         it 'browser symbol uses designated options and watir client without service' do
-          @browser = Browser.new(browser_symbol)
+          @browser = described_class.new(browser_symbol)
 
           expect(generated_options).to be_a Options.send(browser_symbol).class
           expect(selenium_args).not_to include(:service)
@@ -83,8 +83,16 @@ module Watir
         end
 
         describe 'capabilities' do
+          it 'accepts namespaced value', except: {browser: :ie,
+                                                  reason: 'IE is more strict'} do
+            options = {'key:value' => 'something'}
+            @browser = described_class.new(browser_symbol, options: options)
+
+            expect(generated_options.instance_variable_get(:@options)['key:value']).to eq 'something'
+          end
+
           it 'just options object has options and watir client without capabilities or service' do
-            @browser = Browser.new(options: Options.send(browser_symbol))
+            @browser = described_class.new(options: Options.send(browser_symbol))
 
             expect(generated_options).to be_a Options.send(browser_symbol).class
             expect(selenium_args).not_to include(:service)
@@ -95,7 +103,7 @@ module Watir
             service = Service.send(browser_symbol, port: 1234)
             client = Remote::Http::Default.new
             options = {browser_name: browser_name, unhandled_prompt_behavior: :accept_and_notify}
-            @browser = Browser.new(options: options, service: service, http_client: client)
+            @browser = described_class.new(options: options, service: service, http_client: client)
 
             expect(generated_options).to be_a Options.send(browser_symbol).class
             expect(selenium_args[:service]).to eq service
@@ -103,35 +111,23 @@ module Watir
             expect(actual_http).to eq client
           end
 
-          it 'just capabilities has capabilities and watir client without service' do
-            caps = Remote::Capabilities.new(browser_name: browser_name)
-
-            expect {
-              @browser = Browser.new(capabilities: caps)
-            }.to have_deprecated(:capabilities)
-
-            expect(selenium_args[:capabilities]).to eq(caps)
-            expect(selenium_args).not_to include(:service)
-            expect(actual_http).to be_a HttpClient
-          end
-
           it 'accepts page load and script timeouts in seconds' do
             options = {page_load_timeout: 11,
                        script_timeout: 12}
-            @browser = Browser.new(browser_symbol, options: options)
+            @browser = described_class.new(browser_symbol, options: options)
 
             expect(actual_capabilities.timeouts[:page_load]).to eq 11_000
             expect(actual_capabilities.timeouts[:script]).to eq 12_000
           end
 
           it 'unhandled prompt behavior defaults to ignore' do
-            @browser = Browser.new(browser_symbol)
+            @browser = described_class.new(browser_symbol)
 
             expect(actual_capabilities.unhandled_prompt_behavior).to eq 'ignore'
           end
 
           it 'unhandled prompt behavior can be overridden' do
-            @browser = Browser.new(browser_symbol, options: {unhandled_prompt_behavior: :accept_and_notify})
+            @browser = described_class.new(browser_symbol, options: {unhandled_prompt_behavior: :accept_and_notify})
 
             expect(actual_capabilities.unhandled_prompt_behavior).to eq 'accept and notify'
           end
@@ -139,7 +135,7 @@ module Watir
           it 'generates options from Hash', except: {browser: :safari,
                                                      reason: 'Does not accept unrecognized args'} do
             options = {page_load_strategy: 'eager', args: %w[--foo --bar]}
-            @browser = Browser.new(browser_symbol, options: options)
+            @browser = described_class.new(browser_symbol, options: options)
 
             expect(generated_options).to be_a Options.send(browser_symbol).class
             expect(generated_options.page_load_strategy).to eq 'eager'
@@ -150,7 +146,7 @@ module Watir
         describe 'service' do
           it 'uses provided service' do
             service = Service.send(browser_symbol, port: 1234)
-            @browser = Browser.new(browser_symbol, service: service)
+            @browser = described_class.new(browser_symbol, service: service)
 
             expect(selenium_browser).to eq browser_symbol
             expect(selenium_args[:service]).to eq service
@@ -159,7 +155,7 @@ module Watir
 
           it 'builds service from a Hash' do
             @service = {port: 1234}
-            @browser = Browser.new(browser_symbol, service: @service)
+            @browser = described_class.new(browser_symbol, service: @service)
 
             expect(selenium_browser).to eq browser_symbol
             expect(selenium_args[:service]).to be_a Service
@@ -169,21 +165,21 @@ module Watir
 
         describe 'http_client' do
           it 'uses default HTTP Client' do
-            @browser = Browser.new(browser_symbol)
+            @browser = described_class.new(browser_symbol)
 
             expect(actual_http).to be_a HttpClient
           end
 
           it 'accepts an HTTP Client object' do
             client = Remote::Http::Default.new
-            @browser = Browser.new(browser_symbol, http_client: client)
+            @browser = described_class.new(browser_symbol, http_client: client)
 
             expect(actual_http).to eq client
           end
 
           it 'builds an HTTP Client from Hash' do
             client_opts = {open_timeout: 9, read_timeout: 11}
-            @browser = Browser.new(browser_symbol, http_client: client_opts)
+            @browser = described_class.new(browser_symbol, http_client: client_opts)
 
             expect(actual_http).to be_a HttpClient
             expect(actual_http.instance_variable_get(:@open_timeout)).to eq 9
@@ -193,16 +189,17 @@ module Watir
 
         it 'uses a listener' do
           listener = Selenium::WebDriver::Support::AbstractEventListener.new
-          @browser = Browser.new(browser_symbol, listener: listener)
+          @browser = described_class.new(browser_symbol, listener: listener)
 
           expect(actual_listener).to eq listener
         end
 
-        describe 'proxy' do
+        describe 'proxy', except: {browser: :ie,
+                                   reason: 'Bug in Selenium 4.11 Selenium Manager'} do
           it 'adds Selenium Proxy to empty Options', except: {browser: :safari,
                                                               reason: 'Safari does not like proxies'} do
             proxy = Selenium::WebDriver::Proxy.new(http: '127.0.0.1:8080', ssl: '127.0.0.1:443')
-            @browser = Browser.new(browser_symbol, proxy: proxy)
+            @browser = described_class.new(browser_symbol, proxy: proxy)
 
             expect(actual_capabilities.proxy).to eq proxy
           end
@@ -210,7 +207,7 @@ module Watir
           it 'builds a Proxy from Hash for Options', except: {browser: :safari,
                                                               reason: 'Safari does not like proxies'} do
             proxy = {http: '127.0.0.1:8080', ssl: '127.0.0.1:443'}
-            @browser = Browser.new(browser_symbol, proxy: proxy)
+            @browser = described_class.new(browser_symbol, proxy: proxy)
 
             expect(actual_capabilities.proxy).to be_a Selenium::WebDriver::Proxy
             expect(actual_capabilities.proxy.type).to eq(:manual)
@@ -224,7 +221,7 @@ module Watir
             options = {unhandled_prompt_behavior: :accept,
                        page_load_strategy: :eager}
 
-            @browser = Browser.new(browser_symbol, options: options, proxy: proxy)
+            @browser = described_class.new(browser_symbol, options: options, proxy: proxy)
 
             expect(actual_capabilities.proxy).to be_a Selenium::WebDriver::Proxy
             expect(actual_capabilities.proxy.type).to eq(:manual)
@@ -239,7 +236,7 @@ module Watir
             proxy = {http: '127.0.0.1:8080', ssl: '127.0.0.1:443'}
             options = Options.send(browser_symbol, unhandled_prompt_behavior: :accept, page_load_strategy: :eager)
 
-            @browser = Browser.new(browser_symbol, options: options, proxy: proxy)
+            @browser = described_class.new(browser_symbol, options: options, proxy: proxy)
 
             expect(actual_capabilities.proxy).to be_a Selenium::WebDriver::Proxy
             expect(actual_capabilities.proxy.type).to eq(:manual)
@@ -251,9 +248,9 @@ module Watir
         end
       end
 
-      context 'chrome', exclusive: {browser: :chrome} do
+      context 'when chrome', exclusive: {browser: :chrome} do
         it 'by default uses chrome, has client, options, but not capabilities' do
-          @browser = Browser.new
+          @browser = described_class.new
 
           expect(generated_options).to be_a Selenium::WebDriver::Chrome::Options
           expect(actual_http).to be_a HttpClient
@@ -261,116 +258,106 @@ module Watir
         end
 
         it 'sets headless by creating options' do
-          @browser = Browser.new(:chrome, headless: true)
+          @browser = described_class.new(:chrome, headless: true)
 
           expect(generated_options.args).to include '--headless'
         end
 
         it 'sets headless in existing options class' do
-          @browser = Browser.new(:chrome,
-                                 options: Options.chrome,
-                                 headless: true)
+          @browser = described_class.new(:chrome,
+                                         options: Options.chrome,
+                                         headless: true)
 
           expect(generated_options.args).to include '--headless'
         end
 
         it 'sets headless when existing options is a Hash' do
           options = {args: ['--foo']}
-          @browser = Browser.new(:chrome,
-                                 options: options,
-                                 headless: true)
+          @browser = described_class.new(:chrome,
+                                         options: options,
+                                         headless: true)
 
           expect(generated_options.args).to include '--headless'
         end
       end
 
-      context 'edge', exclusive: {browser: :edge} do
+      context 'when edge', exclusive: {browser: :edge} do
         it 'sets headless by creating options' do
-          @browser = Browser.new(:edge, headless: true)
+          @browser = described_class.new(:edge, headless: true)
 
           expect(generated_options.args).to include '--headless'
         end
 
         it 'sets headless in existing options class' do
-          @browser = Browser.new(:edge,
-                                 options: Options.edge,
-                                 headless: true)
+          @browser = described_class.new(:edge,
+                                         options: Options.edge,
+                                         headless: true)
 
           expect(generated_options.args).to include '--headless'
         end
 
         it 'sets headless when existing options is a Hash' do
           options = {args: ['--foo']}
-          @browser = Browser.new(:edge,
-                                 options: options,
-                                 headless: true)
+          @browser = described_class.new(:edge,
+                                         options: options,
+                                         headless: true)
 
           expect(generated_options.args).to include '--headless'
         end
       end
 
-      context 'firefox', exclusive: {browser: :firefox} do
+      context 'when firefox', exclusive: {browser: :firefox} do
         it 'puts Profile inside Options as Hash' do
           profile = Selenium::WebDriver::Firefox::Profile.new
           options = {args: ['--foo'], profile: profile}
 
-          @browser = Browser.new(:firefox, options: options)
-
-          expect(generated_options.args).to include '--foo'
-          expect(generated_options.profile).to eq profile
-        end
-
-        it 'puts Profile inside Hash options' do
-          profile = Selenium::WebDriver::Firefox::Profile.new
-          options = {args: ['--foo'], profile: profile}
-
-          @browser = Browser.new(:firefox, options: options)
+          @browser = described_class.new(:firefox, options: options)
 
           expect(generated_options.args).to include '--foo'
           expect(generated_options.profile).to eq profile
         end
 
         it 'sets headless by creating options' do
-          @browser = Browser.new(:firefox, headless: true)
+          @browser = described_class.new(:firefox, headless: true)
 
           expect(generated_options.args).to include '-headless'
         end
 
         it 'sets headless in existing options class' do
-          @browser = Browser.new(:firefox,
-                                 options: Options.firefox,
-                                 headless: true)
+          @browser = described_class.new(:firefox,
+                                         options: Options.firefox,
+                                         headless: true)
 
           expect(generated_options.args).to include '-headless'
         end
 
         it 'sets headless when existing options is a Hash' do
           options = {args: ['-foo']}
-          @browser = Browser.new(:firefox,
-                                 options: options,
-                                 headless: true)
+          @browser = described_class.new(:firefox,
+                                         options: options,
+                                         headless: true)
 
           expect(generated_options.args).to include '-headless', '-foo'
         end
       end
 
-      context 'safari', exclusive: {browser: :safari} do
-        after(:each) { Selenium::WebDriver::Safari.use_technology_preview = false }
+      context 'when safari', exclusive: {browser: :safari} do
+        after { Selenium::WebDriver::Safari.use_technology_preview = false }
 
         it 'sets Technology Preview', exclude: {browser: :safari,
                                                 reason: 'Broken in Selenium'} do
-          @browser = Browser.new(:safari, technology_preview: true)
+          @browser = described_class.new(:safari, technology_preview: true)
 
-          expect(Selenium::WebDriver::Safari.technology_preview?).to eq true
+          expect(Selenium::WebDriver::Safari.technology_preview?).to be true
         end
 
         it 'generates options from Hash with custom option' do
           options = {page_load_strategy: 'eager', automatic_inspection: true}
-          @browser = Browser.new(browser_symbol, options: options)
+          @browser = described_class.new(browser_symbol, options: options)
 
           expect(generated_options).to be_a Options.send(browser_symbol).class
           expect(actual_capabilities.page_load_strategy).to eq 'eager'
-          expect(actual_capabilities['safari:automaticInspection']).to eq true
+          expect(actual_capabilities['safari:automaticInspection']).to be true
         end
       end
     end
@@ -388,7 +375,7 @@ module Watir
       let(:url) { "#{WatirSpec.implementation.browser_args.last[:url]}/" }
 
       it 'with just url' do
-        @browser = Browser.new(url: url)
+        @browser = described_class.new(url: url)
 
         expect(selenium_browser).to eq :remote
         expect(selenium_args).not_to include(:service)
@@ -399,7 +386,7 @@ module Watir
       end
 
       it 'just url & browser name has options and client but not service' do
-        @browser = Browser.new(browser_symbol, url: url)
+        @browser = described_class.new(browser_symbol, url: url)
 
         expect(selenium_browser).to eq :remote
         expect(selenium_args).not_to include(:service)
@@ -411,9 +398,9 @@ module Watir
 
       it 'accepts a listener' do
         listener = Selenium::WebDriver::Support::AbstractEventListener.new
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               listener: listener)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       listener: listener)
 
         expect(actual_listener).to eq listener
 
@@ -425,9 +412,9 @@ module Watir
 
       it 'accepts http client object' do
         client = HttpClient.new
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               http_client: client)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       http_client: client)
 
         expect(actual_http).to eq client
 
@@ -439,9 +426,9 @@ module Watir
       end
 
       it 'accepts http client Hash' do
-        @browser = Watir::Browser.new(browser_symbol,
-                                      url: url,
-                                      http_client: {read_timeout: 30})
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       http_client: {read_timeout: 30})
 
         expect(actual_http.instance_variable_get(:@read_timeout)).to eq 30
 
@@ -454,9 +441,9 @@ module Watir
 
       it 'accepts proxy object' do
         proxy = Selenium::WebDriver::Proxy.new(http: '127.0.0.1:8080', ssl: '127.0.0.1:443')
-        @browser = Watir::Browser.new(browser_symbol,
-                                      url: url,
-                                      proxy: proxy)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       proxy: proxy)
 
         expect(actual_capabilities.proxy).to eq proxy
 
@@ -470,9 +457,9 @@ module Watir
 
       it 'accepts proxy Hash' do
         proxy = {http: '127.0.0.1:8080', ssl: '127.0.0.1:443'}
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               proxy: proxy)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       proxy: proxy)
 
         expect(actual_capabilities.proxy).to be_a Selenium::WebDriver::Proxy
         expect(actual_capabilities.proxy.type).to eq(:manual)
@@ -488,9 +475,9 @@ module Watir
       end
 
       it 'accepts options object' do
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               options: Options.send(browser_symbol, args: ['--foo']))
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       options: Options.send(browser_symbol, args: ['--foo']))
 
         expect(generated_options.args).to include('--foo')
 
@@ -504,9 +491,9 @@ module Watir
 
       it 'accepts options hash' do
         options = {prefs: {foo: 'bar'}}
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               options: options)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       options: options)
 
         expect(selenium_browser).to eq :remote
         expect(selenium_args).not_to include(:service)
@@ -519,9 +506,9 @@ module Watir
 
       it 'accepts capabilities object' do
         capabilities = Remote::Capabilities.send(browser_symbol)
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               capabilities: capabilities)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       capabilities: capabilities)
 
         expect(selenium_browser).to eq :remote
         expect(selenium_args).not_to include(:service)
@@ -534,10 +521,10 @@ module Watir
       it 'accepts http client & capabilities objects' do
         client = HttpClient.new
         capabilities = Remote::Capabilities.send(browser_symbol)
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               capabilities: capabilities,
-                               http_client: client)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       capabilities: capabilities,
+                                       http_client: client)
 
         expect(selenium_browser).to eq :remote
         expect(selenium_args).not_to include(:service)
@@ -551,11 +538,11 @@ module Watir
         client = HttpClient.new
         proxy = Selenium::WebDriver::Proxy.new(http: '127.0.0.1:8080', ssl: '127.0.0.1:443')
         options = Options.send(browser_symbol, prefs: {foo: 'bar'})
-        @browser = Browser.new(browser_symbol,
-                               url: url,
-                               proxy: proxy,
-                               options: options,
-                               http_client: client)
+        @browser = described_class.new(browser_symbol,
+                                       url: url,
+                                       proxy: proxy,
+                                       options: options,
+                                       http_client: client)
 
         expect(selenium_browser).to eq :remote
         expect(selenium_args).not_to include :service