watir 7.2.0 → 7.2.1

data/spec/watirspec/elements/checkbox_spec.rb

@@ -3,7 +3,7 @@
 require 'watirspec_helper'
 
 describe 'CheckBox' do
-  before :each do
+  before do
     browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
   end
 
@@ -28,16 +28,17 @@ describe 'CheckBox' do
       expect(browser.checkbox(xpath: "//input[@id='new_user_interests_books']")).to exist
     end
 
-    # TODO: More of this for text & labels somewhere central
-    it 'handles text_regexp deprecations for label locators' do
-      expect(browser.checkbox(label: /some visible/)).to exist
-      expect(browser.checkbox(label: /some (visible|Jeff)/)).to exist
-      expect(browser.checkbox(label: /none visible/)).to exist
-      expect(browser.checkbox(label: /this will not match/)).to_not exist
-    end
+    context 'when some text hidden' do
+      it 'locates matching hidden text' do
+        expect(browser.checkbox(label: /some visible/)).to exist
+        expect(browser.checkbox(label: /some (visible|Jeff)/)).to exist
+        expect(browser.checkbox(label: /none visible/)).to exist
+        expect(browser.checkbox(label: /some visible some hidden/)).to exist
+      end
 
-    it 'handles text_regexp deprecation in spite of hidden text' do
-      expect(browser.checkbox(label: /some visible some hidden/)).to exist
+      it 'does not locate when matches without hidden text' do
+        expect(browser.checkbox(label: /some visible$/)).not_to exist
+      end
     end
 
     it 'returns true if the checkbox button exists (search by name and value)' do
@@ -50,25 +51,25 @@ describe 'CheckBox' do
     end
 
     it 'returns false if the checkbox button does not exist' do
-      expect(browser.checkbox(id: 'no_such_id')).to_not exist
-      expect(browser.checkbox(id: /no_such_id/)).to_not exist
-      expect(browser.checkbox(name: 'no_such_name')).to_not exist
-      expect(browser.checkbox(name: /no_such_name/)).to_not exist
-      expect(browser.checkbox(value: 'no_such_value')).to_not exist
-      expect(browser.checkbox(value: /no_such_value/)).to_not exist
-      expect(browser.checkbox(text: 'no_such_text')).to_not exist
-      expect(browser.checkbox(text: /no_such_text/)).to_not exist
-      expect(browser.checkbox(class: 'no_such_class')).to_not exist
-      expect(browser.checkbox(class: /no_such_class/)).to_not exist
-      expect(browser.checkbox(index: 1337)).to_not exist
-      expect(browser.checkbox(xpath: "//input[@id='no_such_id']")).to_not exist
+      expect(browser.checkbox(id: 'no_such_id')).not_to exist
+      expect(browser.checkbox(id: /no_such_id/)).not_to exist
+      expect(browser.checkbox(name: 'no_such_name')).not_to exist
+      expect(browser.checkbox(name: /no_such_name/)).not_to exist
+      expect(browser.checkbox(value: 'no_such_value')).not_to exist
+      expect(browser.checkbox(value: /no_such_value/)).not_to exist
+      expect(browser.checkbox(text: 'no_such_text')).not_to exist
+      expect(browser.checkbox(text: /no_such_text/)).not_to exist
+      expect(browser.checkbox(class: 'no_such_class')).not_to exist
+      expect(browser.checkbox(class: /no_such_class/)).not_to exist
+      expect(browser.checkbox(index: 1337)).not_to exist
+      expect(browser.checkbox(xpath: "//input[@id='no_such_id']")).not_to exist
     end
 
     it 'returns false if the checkbox button does not exist (search by name and value)' do
-      expect(browser.checkbox(name: 'new_user_interests', value: 'no_such_value')).to_not exist
-      expect(browser.checkbox(xpath: "//input[@name='new_user_interests' and @value='no_such_value']")).to_not exist
-      expect(browser.checkbox(name: 'no_such_name', value: 'cars')).to_not exist
-      expect(browser.checkbox(xpath: "//input[@name='no_such_name' and @value='cars']")).to_not exist
+      expect(browser.checkbox(name: 'new_user_interests', value: 'no_such_value')).not_to exist
+      expect(browser.checkbox(xpath: "//input[@name='new_user_interests' and @value='no_such_value']")).not_to exist
+      expect(browser.checkbox(name: 'no_such_name', value: 'cars')).not_to exist
+      expect(browser.checkbox(xpath: "//input[@name='no_such_name' and @value='cars']")).not_to exist
     end
 
     it 'returns true for checkboxes with a string value' do
@@ -159,6 +160,17 @@ describe 'CheckBox' do
     end
   end
 
+  describe '#tabindex' do
+    it 'finds tab index' do
+      expect(browser.checkbox(tabindex: '4').tabindex).to eq 4
+    end
+
+    it 'finds element with boolean' do
+      expect(browser.checkbox(tabindex: false).id).to eq 'toggle_button_checkbox'
+      expect(browser.checkbox(tabindex: true).id).to eq 'new_user_interests_books'
+    end
+  end
+
   # Access methods
 
   describe '#enabled?' do
@@ -168,8 +180,8 @@ describe 'CheckBox' do
     end
 
     it 'returns false if the checkbox button is disabled' do
-      expect(browser.checkbox(id: 'new_user_interests_dentistry')).to_not be_enabled
-      expect(browser.checkbox(xpath: "//input[@id='new_user_interests_dentistry']")).to_not be_enabled
+      expect(browser.checkbox(id: 'new_user_interests_dentistry')).not_to be_enabled
+      expect(browser.checkbox(xpath: "//input[@id='new_user_interests_dentistry']")).not_to be_enabled
     end
 
     it "raises UnknownObjectException if the checkbox button doesn't exist" do
@@ -184,7 +196,7 @@ describe 'CheckBox' do
     end
 
     it 'returns false if the checkbox is enabled' do
-      expect(browser.checkbox(id: 'new_user_interests_books')).to_not be_disabled
+      expect(browser.checkbox(id: 'new_user_interests_books')).not_to be_disabled
     end
 
     it "raises UnknownObjectException if the checkbox doesn't exist" do
@@ -196,7 +208,7 @@ describe 'CheckBox' do
 
   describe '#clear' do
     it 'raises ObjectDisabledException if the checkbox is disabled' do
-      expect(browser.checkbox(id: 'new_user_interests_dentistry')).to_not be_set
+      expect(browser.checkbox(id: 'new_user_interests_dentistry')).not_to be_set
       expect { browser.checkbox(id: 'new_user_interests_dentistry').clear }
         .to raise_object_disabled_exception
       expect { browser.checkbox(xpath: "//input[@id='new_user_interests_dentistry']").clear }
@@ -205,12 +217,12 @@ describe 'CheckBox' do
 
     it 'clears the checkbox button if it is set' do
       browser.checkbox(id: 'new_user_interests_books').clear
-      expect(browser.checkbox(id: 'new_user_interests_books')).to_not be_set
+      expect(browser.checkbox(id: 'new_user_interests_books')).not_to be_set
     end
 
     it 'clears the checkbox button when found by :xpath' do
       browser.checkbox(xpath: "//input[@id='new_user_interests_books']").clear
-      expect(browser.checkbox(xpath: "//input[@id='new_user_interests_books']")).to_not be_set
+      expect(browser.checkbox(xpath: "//input[@id='new_user_interests_books']")).not_to be_set
     end
 
     it "raises UnknownObjectException if the checkbox button doesn't exist" do
@@ -233,7 +245,7 @@ describe 'CheckBox' do
     it 'fires the onclick event' do
       expect(browser.button(id: 'disabled_button')).to be_disabled
       browser.checkbox(id: 'toggle_button_checkbox').set
-      expect(browser.button(id: 'disabled_button')).to_not be_disabled
+      expect(browser.button(id: 'disabled_button')).not_to be_disabled
       browser.checkbox(id: 'toggle_button_checkbox').clear
       expect(browser.button(id: 'disabled_button')).to be_disabled
     end
@@ -259,15 +271,15 @@ describe 'CheckBox' do
     end
 
     it 'returns false if the checkbox button unset' do
-      expect(browser.checkbox(id: 'new_user_interests_cars')).to_not be_set
+      expect(browser.checkbox(id: 'new_user_interests_cars')).not_to be_set
     end
 
     it 'returns the state for checkboxes with string values' do
-      expect(browser.checkbox(name: 'new_user_interests', value: 'cars')).to_not be_set
+      expect(browser.checkbox(name: 'new_user_interests', value: 'cars')).not_to be_set
       browser.checkbox(name: 'new_user_interests', value: 'cars').set
       expect(browser.checkbox(name: 'new_user_interests', value: 'cars')).to be_set
       browser.checkbox(name: 'new_user_interests', value: 'cars').clear
-      expect(browser.checkbox(name: 'new_user_interests', value: 'cars')).to_not be_set
+      expect(browser.checkbox(name: 'new_user_interests', value: 'cars')).not_to be_set
     end
 
     it "raises UnknownObjectException if the checkbox button doesn't exist" do

data/spec/watirspec/elements/checkboxes_spec.rb

@@ -2,43 +2,45 @@
 
 require 'watirspec_helper'
 
-describe 'CheckBoxes' do
-  before :each do
-    browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
-  end
+module Watir
+  describe CheckBoxCollection do
+    before do
+      browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+    end
 
-  describe 'with selectors' do
-    it 'returns the matching elements' do
-      expect(browser.checkboxes(value: 'books').to_a).to eq [browser.checkbox(value: 'books')]
+    describe 'with selectors' do
+      it 'returns the matching elements' do
+        expect(browser.checkboxes(value: 'books').to_a).to eq [browser.checkbox(value: 'books')]
+      end
     end
-  end
 
-  describe '#length' do
-    it 'returns the number of checkboxes' do
-      expect(browser.checkboxes.length).to eq 11
+    describe '#length' do
+      it 'returns the number of checkboxes' do
+        expect(browser.checkboxes.length).to eq 11
+      end
     end
-  end
 
-  describe '#[]' do
-    it 'returns the checkbox at the given index' do
-      expect(browser.checkboxes[0].id).to eq 'new_user_interests_books'
+    describe '#[]' do
+      it 'returns the checkbox at the given index' do
+        expect(browser.checkboxes[0].id).to eq 'new_user_interests_books'
+      end
     end
-  end
 
-  describe '#each' do
-    it 'iterates through checkboxes correctly' do
-      count = 0
+    describe '#each' do
+      it 'iterates through checkboxes correctly' do
+        count = 0
 
-      browser.checkboxes.each_with_index do |c, index|
-        expect(c).to be_instance_of(Watir::CheckBox)
-        expect(c.name).to eq browser.checkbox(index: index).name
-        expect(c.id).to eq browser.checkbox(index: index).id
-        expect(c.value).to eq browser.checkbox(index: index).value
+        browser.checkboxes.each_with_index do |c, index|
+          expect(c).to be_instance_of(CheckBox)
+          expect(c.name).to eq browser.checkbox(index: index).name
+          expect(c.id).to eq browser.checkbox(index: index).id
+          expect(c.value).to eq browser.checkbox(index: index).value
 
-        count += 1
-      end
+          count += 1
+        end
 
-      expect(count).to be > 0
+        expect(count).to be > 0
+      end
     end
   end
 end

data/spec/watirspec/elements/collections_spec.rb

@@ -2,124 +2,131 @@
 
 require 'watirspec_helper'
 
-describe 'Collections' do
-  it 'returns inner elements of parent element having different html tag' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    expect(browser.span(id: 'a_span').divs.size).to eq 2
-  end
-
-  it 'returns inner elements of parent element having same html tag' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    expect(browser.span(id: 'a_span').spans.size).to eq 2
-  end
-
-  it 'returns correct subtype of elements' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    collection = browser.span(id: 'a_span').spans
-    expect(collection.all?(Watir::Span)).to eq true
-  end
-
-  it 'returns correct subtype of elements without tag_name' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    collection = browser.span(id: 'a_span').elements
-    collection.locate
-    expect(collection.first).to be_a Watir::Div
-    expect(collection.last).to be_a Watir::Span
-  end
-
-  it 'can contain more than one type of element' do
-    browser.goto(WatirSpec.url_for('nested_elements.html'))
-    collection = browser.div(id: 'parent').children
-    expect(collection.any?(Watir::Span)).to eq true
-    expect(collection.any?(Watir::Div)).to eq true
-  end
-
-  it 'relocates the same element' do
-    browser.goto(WatirSpec.url_for('nested_elements.html'))
-    collection = browser.div(id: 'parent').children
-    tag = collection[3].tag_name
-    browser.refresh
-    expect(collection[3].tag_name).to eq tag
-  end
-
-  it 'returns value for #empty?' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    expect(browser.span(id: 'a_span').options.empty?).to eq true
-  end
-
-  it 'returns value for #any?' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    expect(browser.span(id: 'a_span').spans.any?).to eq true
-  end
-
-  it 'locates elements' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    spans = browser.span(id: 'a_span').spans
-    expect(spans).to receive(:elements).and_return([])
-    expect(spans.locate).to be_a Watir::SpanCollection
-  end
-
-  it 'lazy loads collections referenced with #[]' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    expect(browser.wd).to_not receive(:find_elements)
-    browser.spans[3]
-  end
-
-  it 'does not relocate collections when previously evaluated' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    elements = browser.spans.tap(&:to_a)
-
-    expect(browser.wd).to_not receive(:find_elements)
-    elements[1].id
-  end
-
-  it 'relocates cached elements that go stale' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    elements = browser.spans.tap(&:to_a)
-
-    browser.refresh
-    expect(elements[1]).to be_stale
-    expect { elements[1] }.to_not raise_unknown_object_exception
-  end
-
-  it 'does not retrieve tag_name on elements when specifying tag_name' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    collection = browser.span(id: 'a_span').spans
-
-    expect_any_instance_of(Selenium::WebDriver::Element).to_not receive(:tag_name)
-    collection.locate
-  end
-
-  it 'does not retrieve tag_name on elements without specifying tag_name' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    collection = browser.span(id: 'a_span').elements
-
-    expect_any_instance_of(Selenium::WebDriver::Element).to_not receive(:tag_name)
-    collection.locate
-  end
-
-  it 'does not execute_script to retrieve tag_names when specifying tag_name' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    collection = browser.span(id: 'a_span').spans
-
-    expect(browser.wd).to_not receive(:execute_script)
-    collection.locate
-  end
-
-  it 'returns correct containers without specifying tag_name' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-    elements = browser.span(id: 'a_span').elements.to_a
-    expect(elements[0]).to be_a(Watir::Div)
-    expect(elements[-1]).to be_a(Watir::Span)
-  end
-
-  it 'Raises Exception if any element in collection continues to go stale' do
-    browser.goto(WatirSpec.url_for('collections.html'))
-
-    stale_exception = Selenium::WebDriver::Error::StaleElementReferenceError
-    expect(browser.wd).to receive(:execute_script).and_raise(stale_exception).exactly(3).times
-
-    msg = 'Unable to locate element collection from {:xpath=>".//span"} due to changing page'
-    expect { browser.span.elements(xpath: './/span').to_a }.to raise_exception Watir::Exception::LocatorException, msg
+module Watir
+  describe ElementCollection do
+    it 'returns inner elements of parent element having different html tag' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      expect(browser.span(id: 'a_span').divs.size).to eq 2
+    end
+
+    it 'returns inner elements of parent element having same html tag' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      expect(browser.span(id: 'a_span').spans.size).to eq 2
+    end
+
+    it 'returns correct subtype of elements' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      collection = browser.span(id: 'a_span').spans
+      expect(collection.all?(Span)).to be true
+    end
+
+    it 'returns correct subtype of elements without tag_name' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      collection = browser.span(id: 'a_span').elements
+      collection.locate
+      expect(collection.first).to be_a Div
+      expect(collection.last).to be_a Span
+    end
+
+    it 'can contain more than one type of element' do
+      browser.goto(WatirSpec.url_for('nested_elements.html'))
+      collection = browser.div(id: 'parent').children
+      expect(collection.any?(Span)).to be true
+      expect(collection.any?(Div)).to be true
+    end
+
+    it 'relocates the same element' do
+      browser.goto(WatirSpec.url_for('nested_elements.html'))
+      collection = browser.div(id: 'parent').children
+      tag = collection[3].tag_name
+      browser.refresh
+      expect(collection[3].tag_name).to eq tag
+    end
+
+    it 'returns value for #empty?' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      expect(browser.span(id: 'a_span').options.empty?).to be true
+    end
+
+    it 'returns value for #any?' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      expect(browser.span(id: 'a_span').spans.any?).to be true
+    end
+
+    it 'locates elements' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      spans = browser.span(id: 'a_span').spans
+      allow(spans).to receive(:elements).and_return([])
+      expect(spans.locate).to be_a SpanCollection
+      expect(spans).to have_received(:elements).once
+    end
+
+    it 'lazy loads collections referenced with #[]' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      allow(browser.wd).to receive(:find_elements)
+      browser.spans[3]
+      expect(browser.wd).not_to have_received(:find_elements)
+    end
+
+    it 'does not relocate collections when previously evaluated' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      elements = browser.spans.tap(&:to_a)
+
+      allow(browser.wd).to receive(:find_elements)
+      elements[1].id
+      expect(browser.wd).not_to have_received(:find_elements)
+    end
+
+    it 'relocates cached elements that go stale' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      elements = browser.spans.tap(&:to_a)
+
+      browser.refresh
+      expect(elements[1]).to be_stale
+      expect { elements[1] }.not_to raise_unknown_object_exception
+    end
+
+    it 'does not retrieve tag_name on elements when specifying tag_name' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      collection = browser.span(id: 'a_span').spans
+
+      expect_any_instance_of(Selenium::WebDriver::Element).not_to receive(:tag_name)
+      collection.locate
+    end
+
+    it 'does not retrieve tag_name on elements without specifying tag_name' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      collection = browser.span(id: 'a_span').elements
+
+      expect_any_instance_of(Selenium::WebDriver::Element).not_to receive(:tag_name)
+      collection.locate
+    end
+
+    it 'does not execute_script to retrieve tag_names when specifying tag_name' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      collection = browser.span(id: 'a_span').spans
+
+      allow(browser.wd).to receive(:execute_script)
+      collection.locate
+      expect(browser.wd).not_to have_received(:execute_script)
+    end
+
+    it 'returns correct containers without specifying tag_name' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+      elements = browser.span(id: 'a_span').elements.to_a
+      expect(elements[0]).to be_a(Div)
+      expect(elements[-1]).to be_a(Span)
+    end
+
+    it 'Raises Exception if any element in collection continues to go stale' do
+      browser.goto(WatirSpec.url_for('collections.html'))
+
+      stale_exception = Selenium::WebDriver::Error::StaleElementReferenceError
+      allow(browser.wd).to receive(:execute_script).and_raise(stale_exception)
+
+      msg = 'Unable to locate element collection from {:xpath=>".//span"} due to changing page'
+      expect { browser.span.elements(xpath: './/span').to_a }.to raise_exception Exception::LocatorException, msg
+      expect(browser.wd).to have_received(:execute_script).exactly(3).times
+    end
   end
 end