watir 6.15.1 → 6.16.0

data/spec/unit/selector_builder/row_spec.rb

@@ -0,0 +1,111 @@
+require_relative '../unit_helper'
+
+describe Watir::Locators::Row::SelectorBuilder do
+  include LocatorSpecHelper
+
+  let(:row_selector_builder) { described_class.new(attributes, query_scope) }
+  let(:selector_built) { row_selector_builder.build(selector).reject { |key| key == :scope } }
+  let(:selector) { @selector || {} }
+
+  describe '#build' do
+    context 'with query scopes' do
+      it 'with only table query scope' do
+        @query_scope = element(tag_name: 'table')
+
+        built = {xpath: "./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr']"}
+
+        expect(selector_built).to eq built
+      end
+
+      it 'with tbody query scope' do
+        @query_scope = element(tag_name: 'tbody')
+        built = {xpath: "./*[local-name()='tr']"}
+
+        expect(selector_built).to eq built
+      end
+
+      it 'with thead query scope' do
+        @query_scope = element(tag_name: 'thead')
+        built = {xpath: "./*[local-name()='tr']"}
+
+        expect(selector_built).to eq built
+      end
+
+      it 'with tfoot query scope' do
+        @query_scope = element(tag_name: 'tfoot')
+        built = {xpath: "./*[local-name()='tr']"}
+
+        expect(selector_built).to eq built
+      end
+    end
+
+    context 'when tag name is specified' do
+      before do
+        @query_scope = element(tag_name: 'table')
+      end
+
+      context 'with index' do
+        it 'positive' do
+          @selector = {index: 1}
+          built = {xpath: "(./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr'])[2]"}
+
+          expect(selector_built).to eq built
+        end
+
+        it 'negative' do
+          @selector = {index: -3}
+          built = {xpath: "(./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr'])[last()-2]"}
+
+          expect(selector_built).to eq built
+        end
+
+        it 'last' do
+          @selector = {index: -1}
+          built = {xpath: "(./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr'])[last()]"}
+
+          expect(selector_built).to eq built
+        end
+
+        it 'does not return index if it is zero' do
+          @selector = {index: 0}
+          built = {xpath: "./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr']"}
+
+          expect(selector_built).to eq built
+        end
+
+        it 'raises exception when index is not an Integer', skip_after: true do
+          @selector = {index: 'foo'}
+          msg = /expected one of \[(Integer|Fixnum)\], got "foo":String/
+          expect { selector_built }.to raise_exception TypeError, msg
+        end
+      end
+
+      context 'with multiple locators' do
+        it 'attribute and class' do
+          @selector = {id: 'gregory', class: /brick/}
+          built = {xpath: "./*[local-name()='tr'][contains(@class, 'brick')][@id='gregory'] | " \
+"./*[local-name()='tbody']/*[local-name()='tr'][contains(@class, 'brick')][@id='gregory'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'][contains(@class, 'brick')][@id='gregory'] | " \
+"./*[local-name()='tfoot']/*[local-name()='tr'][contains(@class, 'brick')][@id='gregory']"}
+
+          expect(selector_built).to eq built
+        end
+      end
+
+      context 'returns locators that can not be directly translated' do
+        it 'any text value' do
+          @selector = {text: 'Gregory'}
+          built = {xpath: "./*[local-name()='tr'] | ./*[local-name()='tbody']/*[local-name()='tr'] | " \
+"./*[local-name()='thead']/*[local-name()='tr'] | ./*[local-name()='tfoot']/*[local-name()='tr']", text: 'Gregory'}
+
+          expect(selector_built).to eq built
+        end
+      end
+    end
+  end
+end

data/spec/unit/selector_builder/text_field_spec.rb

@@ -0,0 +1,189 @@
+require_relative '../unit_helper'
+
+describe Watir::Locators::TextField::SelectorBuilder do
+  include LocatorSpecHelper
+
+  let(:selector_builder) { described_class.new(attributes, query_scope) }
+  let(:uppercase) { 'ABCDEFGHIJKLMNOPQRSTUVWXYZÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝÞŸŽŠŒ' }
+  let(:lowercase) { 'abcdefghijklmnopqrstuvwxyzàáâãäåæçèéêëìíîïðñòóôõöøùúûüýþÿžšœ' }
+  let(:negative_types) do
+    "translate(@type,'#{uppercase}','#{lowercase}')!='file' and "\
+"translate(@type,'#{uppercase}','#{lowercase}')!='radio' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='checkbox' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='submit' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='reset' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='image' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='button' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='hidden' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='range' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='color' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='date' and " \
+"translate(@type,'#{uppercase}','#{lowercase}')!='datetime-local'"
+  end
+
+  describe '#build' do
+    it 'without any arguments' do
+      selector = {}
+      built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+
+      expect(selector_builder.build(selector)).to eq built
+    end
+
+    context 'with type' do
+      it 'specified text field type that is text' do
+        selector = {type: 'text'}
+        built = {xpath: ".//*[local-name()='input']" \
+"[translate(@type,'#{uppercase}','#{lowercase}')='text']"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'specified text field type that is not text' do
+        selector = {type: 'number'}
+        built = {xpath: ".//*[local-name()='input']" \
+"[translate(@type,'#{uppercase}','#{lowercase}')='number']"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'true locates text field with a type specified' do
+        selector = {type: true}
+        built = {xpath: ".//*[local-name()='input'][#{negative_types}]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'false locates text field without type specified' do
+        selector = {type: false}
+        built = {xpath: ".//*[local-name()='input'][not(@type)]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'raises exception when a non-text field type input is specified' do
+        selector = {type: 'checkbox'}
+        msg = 'TextField Elements can not be located by type: checkbox'
+
+        expect { selector_builder.build(selector) }
+          .to raise_exception Watir::Exception::LocatorException, msg
+      end
+    end
+
+    context 'with index' do
+      it 'positive' do
+        selector = {index: 4}
+        built = {xpath: "(.//*[local-name()='input'][not(@type) or (#{negative_types})])[5]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'negative' do
+        selector = {index: -3}
+        built = {xpath: "(.//*[local-name()='input'][not(@type) or (#{negative_types})])[last()-2]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'last' do
+        selector = {index: -1}
+        built = {xpath: "(.//*[local-name()='input'][not(@type) or (#{negative_types})])[last()]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'does not return index if it is zero' do
+        selector = {index: 0}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'raises exception when index is not an Integer' do
+        selector = {index: 'foo'}
+        msg = /expected one of \[(Integer|Fixnum)\], got "foo":String/
+
+        expect { selector_builder.build(selector) }.to raise_exception TypeError, msg
+      end
+    end
+
+    context 'with wrong tag name' do
+      # TODO: Should this throw exception?
+      it 'ignores tag name' do
+        selector = {tag_name: 'div'}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+    end
+
+    context 'with text' do
+      it 'String for value' do
+        selector = {text: 'Developer'}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]", text: 'Developer'}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'Simple Regexp for value' do
+        selector = {text: /Dev/}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]", text: /Dev/}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'returns complicated Regexp to the locator as a value' do
+        selector = {text: /^foo$/}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]", text: /^foo$/}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+    end
+
+    context 'with label' do
+      it 'using String' do
+        selector = {label: 'First name'}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]" \
+"[@id=//label[normalize-space()='First name']/@for or parent::label[normalize-space()='First name']]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'uses String with hidden text' do
+        selector = {label: 'With hidden text'}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]" \
+"[@id=//label[normalize-space()='With hidden text']/@for or parent::label[normalize-space()='With hidden text']]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      # TODO: Can use contains once remove :text_regexp deprecation
+      xit 'using simple Regexp' do
+        selector = {label: /First/}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]" \
+"[@id=//label[contains(text(), 'First')]/@for or parent::label[contains(text(), 'First')]]"}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      # TODO: Can use contains once remove :text_regexp deprecation
+      xit 'using complex Regexp' do
+        selector = {label: /([qa])st? name/}
+        built = {xpath: ".//*[local-name()='input'][not(@type) or (#{negative_types})]" \
+"[@id=//label[contains(text(), 's') and contains(text(), ' name')]/@for or " \
+"parent::label[contains(text(), 's') and contains(text(), ' name')]]", label_element: /([qa])st? name/}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+    end
+
+    context 'with multiple locators' do
+      it 'locates using tag name, class, attributes and text' do
+        selector = {text: 'Developer', class: /c/, id: true}
+        built = {xpath: ".//*[local-name()='input'][contains(@class, 'c')]" \
+"[not(@type) or (#{negative_types})][@id]", text: 'Developer'}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+    end
+  end
+end

data/spec/unit/selector_builder/textarea_spec.rb

@@ -0,0 +1,25 @@
+require_relative '../unit_helper'
+
+describe Watir::Locators::TextArea::SelectorBuilder do
+  include LocatorSpecHelper
+
+  let(:selector_builder) { described_class.new(attributes, query_scope) }
+
+  describe '#build' do
+    context 'Always returns value argument' do
+      it 'String' do
+        selector = {tag_name: 'textarea', value: 'Foo'}
+        built = {xpath: ".//*[local-name()='textarea']", value: 'Foo'}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+
+      it 'Regexp' do
+        selector = {tag_name: 'textarea', value: /Foo/}
+        built = {xpath: ".//*[local-name()='textarea']", value: /Foo/}
+
+        expect(selector_builder.build(selector)).to eq built
+      end
+    end
+  end
+end

data/spec/watirspec/browser_spec.rb

@@ -90,16 +90,15 @@ describe 'Browser' do
       expect(browser.text_field(id: 'new_user_first_name').value).to eq 'hello'
     end
 
-    not_compliant_on(:firefox) do
-      it 'sends keys to a frame' do
-        browser.goto WatirSpec.url_for 'frames.html'
-        tf = browser.frame.text_field(id: 'senderElement')
-        tf.clear
+    it 'sends keys to a frame' do
+      browser.goto WatirSpec.url_for 'frames.html'
+      tf = browser.frame.text_field(id: 'senderElement')
+      tf.clear
+      tf.click
 
-        browser.frame.send_keys 'hello'
+      browser.frame.send_keys 'hello'
 
-        expect(tf.value).to eq 'hello'
-      end
+      expect(tf.value).to eq 'hello'
     end
   end
 

data/spec/watirspec/element_hidden_spec.rb

@@ -71,9 +71,8 @@ describe Watir::Locators::Element::Locator do
     end
 
     it 'raises exception when value is not Boolean' do
-      element = browser.body.element(visible: 'true')
       msg = 'expected one of [TrueClass, FalseClass], got "true":String'
-      expect { element.exists? }.to raise_exception(TypeError, msg)
+      expect { browser.body.element(visible: 'true') }.to raise_exception(TypeError, msg)
     end
   end
 end

data/spec/watirspec/elements/element_spec.rb

@@ -20,19 +20,32 @@ describe 'Element' do
       expect { Watir::Element.new(container, 1, 2, 3, 4) }.to raise_error(ArgumentError)
       expect { Watir::Element.new(container, 'foo') }.to raise_error(ArgumentError)
     end
+
+    it 'throws deprecation warning when combining element locator with other locators' do
+      element = double Selenium::WebDriver::Element
+      allow(element).to receive(:enabled?).and_return(true)
+      expect { browser.text_field(class_name: 'name', index: 1, element: element) }.to have_deprecated_element_cache
+    end
   end
 
   describe '#element_call' do
     it 'handles exceptions when taking an action on a stale element' do
       browser.goto WatirSpec.url_for('removed_element.html')
 
-      element = browser.div(id: 'text').tap(&:exists?)
+      element = browser.div(id: 'text').locate
 
       browser.refresh
 
       expect(element).to be_stale
       expect { element.text }.to_not raise_error
     end
+
+    it 'relocates stale element when taking an action on it' do
+      browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+      element = browser.text_field(id: 'new_user_first_name').locate
+      browser.refresh
+      expect { element.click }.not_to raise_exception
+    end
   end
 
   describe '#eq and #eql?' do
@@ -224,7 +237,7 @@ describe 'Element' do
     end
 
     it 'raises UnknownObjectException exception if the element is stale' do
-      element = browser.text_field(id: 'new_user_email').tap(&:exists?)
+      element = browser.text_field(id: 'new_user_email').locate
 
       browser.refresh
 
@@ -261,13 +274,36 @@ describe 'Element' do
     end
   end
 
+  describe '#cache=' do
+    it 'bypasses selector location' do
+      browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+
+      wd = browser.div.wd
+      element = Watir::Element.new(browser, id: 'not_valid')
+      element.cache = wd
+
+      expect(element).to exist
+    end
+
+    it 'can be cleared' do
+      browser.goto(WatirSpec.url_for('forms_with_input_elements.html'))
+
+      wd = browser.div.wd
+      element = Watir::Element.new(browser, id: 'not_valid')
+      element.cache = wd
+
+      browser.refresh
+      expect(element).to_not exist
+    end
+  end
+
   describe '#exists?' do
     before do
       browser.goto WatirSpec.url_for('removed_element.html')
     end
 
     it 'element from a collection returns false when it becomes stale' do
-      element = browser.divs(id: 'text').first.tap(&:exists?)
+      element = browser.divs(id: 'text').first.locate
 
       browser.refresh
 
@@ -301,7 +337,7 @@ describe 'Element' do
     end
 
     it 'returns false if the element is stale' do
-      element = browser.div(id: 'foo').tap(&:exists?)
+      element = browser.div(id: 'foo').locate
 
       browser.refresh
 
@@ -313,7 +349,7 @@ describe 'Element' do
     end
 
     it 'does not raise staleness deprecation if element no longer exists in DOM' do
-      element = browser.div(id: 'foo').tap(&:exists?)
+      element = browser.div(id: 'foo').locate
       browser.goto(WatirSpec.url_for('iframes.html'))
 
       expect { element.present? }.to_not have_deprecated_stale_present
@@ -321,7 +357,7 @@ describe 'Element' do
 
     # TODO: Documents Current Behavior, but needs to be refactored/removed
     it 'returns true the second time if the element is stale' do
-      element = browser.div(id: 'foo').tap(&:exists?)
+      element = browser.div(id: 'foo').locate
 
       browser.refresh
 
@@ -354,7 +390,7 @@ describe 'Element' do
 
   describe '#stale?' do
     it 'returns true if the element is stale' do
-      element = browser.button(name: 'new_user_submit_disabled').tap(&:exists?)
+      element = browser.button(name: 'new_user_submit_disabled').locate
 
       browser.refresh
 
@@ -362,7 +398,7 @@ describe 'Element' do
     end
 
     it 'returns false if the element is not stale' do
-      element = browser.button(name: 'new_user_submit_disabled').tap(&:exists?)
+      element = browser.button(name: 'new_user_submit_disabled').locate
 
       expect(element).to_not be_stale
     end
@@ -455,12 +491,6 @@ describe 'Element' do
       expect(browser.div(id: 'no_such_div').link(id: 'no_such_id')).to_not exist
     end
 
-    it 'raises if both :xpath and :css are given' do
-      msg = ':xpath and :css cannot be combined ({:xpath=>"//div", :css=>"div"})'
-      expect { browser.div(xpath: '//div', css: 'div').exists? }
-        .to raise_exception Watir::Exception::LocatorException, msg
-    end
-
     it "doesn't raise when selector has with :xpath has :index" do
       expect(browser.div(xpath: '//div', index: 1)).to exist
     end
@@ -787,7 +817,7 @@ describe 'Element' do
     end
 
     it 'returns false if element has not been located' do
-      expect(browser.form(id: 'new_user').tap(&:exists?)).to be_located
+      expect(browser.form(id: 'new_user').locate).to be_located
     end
   end
 
@@ -897,12 +927,18 @@ describe 'Element' do
       expect { btn.click }.not_to raise_exception
     end
 
-    it 'scrolls element into view before checking if obscured' do
+    it 'scrolls interactive element into view before checking if obscured' do
       btn = browser.button(id: 'requires_scrolling')
       expect(btn).not_to be_obscured
       expect { btn.click }.not_to raise_exception
     end
 
+    it 'scrolls non-interactive element into view before checking if obscured' do
+      div = browser.div(id: 'requires_scrolling_container')
+      expect(div).not_to be_obscured
+      expect { div.click }.not_to raise_exception
+    end
+
     it 'returns true if element cannot be scrolled into view' do
       btn = browser.button(id: 'off_screen')
       expect(btn).to be_obscured