watir 6.11.0 → 6.12.0

data/spec/watirspec/elements/checkbox_spec.rb

@@ -169,7 +169,7 @@ describe "CheckBox" do
 
     it "returns false if the checkbox button is disabled" do
       expect(browser.checkbox(id: "new_user_interests_dentistry")).to_not be_enabled
-      expect(browser.checkbox(:xpath,"//input[@id='new_user_interests_dentistry']")).to_not be_enabled
+      expect(browser.checkbox(xpath: "//input[@id='new_user_interests_dentistry']")).to_not be_enabled
     end
 
     it "raises UnknownObjectException if the checkbox button doesn't exist" do

data/spec/watirspec/elements/del_spec.rb

@@ -95,7 +95,7 @@ describe "Del" do
 
     it "raises UnknownObjectException if the del doesn't exist" do
       expect { browser.del(id: 'no_such_id').text }.to raise_unknown_object_exception
-      expect { browser.del(:xpath , "//del[@id='no_such_id']").text }.to raise_unknown_object_exception
+      expect { browser.del(xpath: "//del[@id='no_such_id']").text }.to raise_unknown_object_exception
     end
   end
 

data/spec/watirspec/elements/div_spec.rb

@@ -14,8 +14,7 @@ describe "Div" do
       expect(browser.div(title: "Header and primary navigation")).to exist
       expect(browser.div(title: /Header and primary navigation/)).to exist
       expect(browser.div(text: "Not shownNot hidden")).to exist
-      msg =  /text locator with RegExp values to find elements based on only visible text is deprecated\. Use :visible_text instead/
-      expect { expect(browser.div(text: /Not hidden/)).to exist }.to output(msg).to_stdout_from_any_process
+      expect(browser.div(text: /Not hidden/)).to exist
       expect(browser.div(class: "profile")).to exist
       expect(browser.div(class: /profile/)).to exist
       expect(browser.div(index: 0)).to exist
@@ -34,8 +33,7 @@ describe "Div" do
       expect(browser.div(title: "no_such_title")).to_not exist
       expect(browser.div(title: /no_such_title/)).to_not exist
       expect(browser.div(text: "no_such_text")).to_not exist
-      msg = /:text locator with RegExp values to find elements based on only visible text is deprecated\. Use :visible_text instead/
-      expect { expect(browser.div(text: /no_such_text/)).to_not exist }.to output(msg).to_stdout_from_any_process
+      expect(browser.div(text: /no_such_text/)).to_not exist
       expect(browser.div(class: "no_such_class")).to_not exist
       expect(browser.div(class: /no_such_class/)).to_not exist
       expect(browser.div(index: 1337)).to_not exist
@@ -148,9 +146,22 @@ describe "Div" do
   end
 
   describe "Deprecation Warnings" do
-    it "throws deprecation when for text and RegExp" do
-      msg =  /text locator with RegExp values to find elements based on only visible text is deprecated\. Use :visible_text instead/
-      expect { browser.div(text: /Not hidden/).exists? }.to output(msg).to_stdout_from_any_process
+    describe "text locator with RegExp values" do
+      it "does not throw deprecation when still matched by text content" do
+        expect { browser.div(text: /some visible/).exists? }.not_to have_deprecated_text_regexp
+      end
+
+      it "throws deprecation when no longer matched by text content" do
+        expect { browser.div(text: /some visible$/).exists? }.to have_deprecated_text_regexp
+      end
+
+      it "throws deprecation when begins to be matched by text content" do
+        expect { browser.div(text: /some hidden/).exists? }.to have_deprecated_text_regexp
+      end
+
+      it "does not throw deprecation when still not matched by text content" do
+        expect { browser.div(text: /does not exist/).exists? }.not_to have_deprecated_text_regexp
+      end
     end
   end
 
@@ -171,7 +182,7 @@ describe "Div" do
       end
 
       it "includes custom message if element with a custom attribute does not exist" do
-        message = "Watir treated [\"custom_attribute\"] as a non-HTML compliant attribute, ensure that was intended"
+        message = /Watir treated \[\"custom_attribute\"\] as a non-HTML compliant attribute, ensure that was intended/
         expect { browser.div(custom_attribute: "not_there").click }.to raise_unknown_object_exception(message)
       end
     end

data/spec/watirspec/elements/divs_spec.rb

@@ -22,6 +22,18 @@ describe "Divs" do
     it "returns the div at the given index" do
       expect(browser.divs[1].id).to eq "outer_container"
     end
+
+    it "returns an array of divs with a given range of positive values" do
+      divs = browser.divs[2..4]
+      ids = divs.map(&:id)
+      expect(ids).to eq %w(header promo content)
+    end
+
+    it "returns an array of divs with a given range including negative values" do
+      divs = browser.divs[11..-3]
+      ids = divs.map(&:id)
+      expect(ids).to eq %w(messages ins_tag_test del_tag_test)
+    end
   end
 
   describe "#each" do

data/spec/watirspec/elements/dt_spec.rb

@@ -31,11 +31,11 @@ describe "Dt" do
   # Attribute methods
   describe "#class_name" do
     it "returns the class attribute if the element exists" do
-      expect(browser.dt(:id , "experience").class_name).to eq "industry"
+      expect(browser.dt(id: "experience").class_name).to eq "industry"
     end
 
     it "returns an empty string if the element exists but the attribute doesn't" do
-      expect(browser.dt(:id , "education").class_name).to eq ""
+      expect(browser.dt(id: "education").class_name).to eq ""
     end
 
     it "raises UnknownObjectException if the element does not exist" do

data/spec/watirspec/elements/element_spec.rb

@@ -23,6 +23,19 @@ describe "Element" do
     end
   end
 
+  describe "#element_call" do
+    it 'handles exceptions when taking an action on a stale element' do
+      browser.goto WatirSpec.url_for('removed_element.html')
+
+      element = browser.div(id: "text").tap(&:exists?)
+
+      browser.refresh
+
+      expect(element).to be_stale
+      expect { element.text }.to_not raise_error
+    end
+  end
+
   describe "#eq and #eql?" do
     before { browser.goto WatirSpec.url_for("definition_lists.html") }
 
@@ -119,7 +132,7 @@ describe "Element" do
     end
 
     it "finds several elements from an element's subtree" do
-      expect(browser.fieldset.elements(xpath: ".//label").length).to eq 21
+      expect(browser.fieldset.elements(xpath: ".//label").length).to eq 22
     end
   end
 
@@ -191,11 +204,17 @@ describe "Element" do
 
   describe "#visible?" do
     it "returns true if the element is visible" do
-      expect(browser.text_field(id: "new_user_email")).to be_visible
+      msg = /WARN Watir \[\"visible_element\"\]/
+      expect {
+        expect(browser.text_field(id: "new_user_email")).to be_visible
+      }.to output(msg).to_stdout_from_any_process
     end
 
     it "raises UnknownObjectException exception if the element does not exist" do
-      expect { browser.text_field(id: "no_such_id").visible? }.to raise_unknown_object_exception
+      msg = /WARN Watir \[\"visible_element\"\]/
+      expect {
+        expect { browser.text_field(id: "no_such_id").visible? }.to raise_unknown_object_exception
+      }.to output(msg).to_stdout_from_any_process
     end
 
     it "raises UnknownObjectException exception if the element is stale" do
@@ -204,11 +223,16 @@ describe "Element" do
       browser.refresh
 
       expect(element).to be_stale
-      expect { element.visible? }.to raise_unknown_object_exception
+      expect {
+        expect { element.visible? }.to raise_unknown_object_exception
+      }.to have_deprecated_stale_visible
     end
 
     it "returns true if the element has style='visibility: visible' even if parent has style='visibility: hidden'" do
-      expect(browser.div(id: "visible_child")).to be_visible
+      msg = /WARN Watir \[\"visible_element\"\]/
+      expect {
+        expect(browser.div(id: "visible_child")).to be_visible
+      }.to output(msg).to_stdout_from_any_process
     end
 
     it "returns false if the element is input element where type eq 'hidden'" do
@@ -216,15 +240,108 @@ describe "Element" do
     end
 
     it "returns false if the element has style='display: none;'" do
-      expect(browser.div(id: 'changed_language')).to_not be_visible
+      msg = /WARN Watir \[\"visible_element\"\]/
+      expect {
+        expect(browser.div(id: 'changed_language')).to_not be_visible
+      }.to output(msg).to_stdout_from_any_process
     end
 
     it "returns false if the element has style='visibility: hidden;" do
-      expect(browser.div(id: 'wants_newsletter')).to_not be_visible
+      msg = /WARN Watir \[\"visible_element\"\]/
+      expect {
+        expect(browser.div(id: 'wants_newsletter')).to_not be_visible
+      }
     end
 
     it "returns false if one of the parent elements is hidden" do
-      expect(browser.div(id: 'hidden_parent')).to_not be_visible
+      msg = /WARN Watir \[\"visible_element\"\]/
+      expect {
+        expect(browser.div(id: 'hidden_parent')).to_not be_visible
+      }
+    end
+  end
+
+  describe "#exists?" do
+    before do
+      browser.goto WatirSpec.url_for('removed_element.html')
+    end
+
+    it "element from a collection returns false when it becomes stale" do
+      element = browser.divs(id: "text").first.tap(&:exists?)
+
+      browser.refresh
+
+      expect(element).to be_stale
+      expect(element).to_not exist
+    end
+
+    it "returns false when tag name does not match id" do
+      watir_element = browser.span(id: "text")
+      expect(watir_element).to_not exist
+    end
+  end
+
+  describe '#present?' do
+    before do
+      browser.goto(WatirSpec.url_for("wait.html"))
+    end
+
+    it 'returns true if the element exists and is visible' do
+      expect(browser.div(id: 'foo')).to be_present
+    end
+
+    it 'returns false if the element exists but is not visible' do
+      expect(browser.div(id: 'bar')).to_not be_present
+    end
+
+    it 'returns false if the element does not exist' do
+      expect(browser.div(id: 'should-not-exist')).to_not be_present
+    end
+
+    # TODO Refactor so that this returns true
+    it "returns false if the element is stale" do
+      element = browser.div(id: "foo").tap(&:exists?)
+
+      browser.refresh
+
+      expect(element).to be_stale
+
+      expect {
+        expect(element).to_not be_present
+      }.to have_deprecated_stale_present
+    end
+
+    # TODO Documents Current Behavior, but needs to be refactored/removed
+    it "returns true the second time if the element is stale" do
+      element = browser.div(id: "foo").tap(&:exists?)
+
+      browser.refresh
+
+      expect(element).to be_stale
+
+      expect {
+        expect(element).to_not be_present
+      }.to have_deprecated_stale_present
+      expect(element).to be_present
+    end
+
+  end
+
+  describe "#enabled?" do
+    before do
+      browser.goto(WatirSpec.url_for("forms_with_input_elements.html"))
+    end
+
+    it "returns true if the element is enabled" do
+      expect(browser.element(name: 'new_user_submit')).to be_enabled
+    end
+
+    it "returns false if the element is disabled" do
+      expect(browser.element(name: 'new_user_submit_disabled')).to_not be_enabled
+    end
+
+    it "raises UnknownObjectException if the element doesn't exist" do
+      expect { browser.element(name: "no_such_name").enabled? }.to raise_unknown_object_exception
     end
   end
 
@@ -339,6 +456,11 @@ describe "Element" do
       expect(browser.element(name: "new_user_first_name")).to exist
       expect(browser.element(name: /new_user_first_name/)).to exist
     end
+
+    it "returns false when tag name does not match id" do
+      watir_element = browser.span(id: "text")
+      expect(watir_element).to_not exist
+    end
   end
 
   describe '#send_keys' do
@@ -389,12 +511,90 @@ describe "Element" do
   end
 
   describe "#flash" do
-
     let(:h2) { browser.h2(text: 'Add user') }
+    let(:h1) { browser.h1(text: 'User administration') }
 
     it 'returns the element on which it was called' do
       expect(h2.flash).to eq h2
     end
+
+    it 'should keep the element background color after flashing' do
+      expect(h2.style('background-color')).to eq h2.flash(:rainbow).style('background-color')
+      expect(h1.style('background-color')).to eq h1.flash.style('background-color')
+    end
+
+    it 'should respond to preset symbols like :fast and :slow' do
+      expect(h1.flash(:rainbow)).to eq h1
+      expect(h2.flash(:slow)).to eq h2
+      expect(h1.flash(:fast)).to eq h1
+      expect(h2.flash(:long)).to eq h2
+    end
+
+  end
+
+  describe "#hover" do
+    not_compliant_on :internet_explorer, :safari do
+      it "should hover over the element" do
+        browser.goto WatirSpec.url_for('hover.html')
+        link = browser.a
+
+        expect(link.style("font-size")).to eq "10px"
+        link.hover
+        link.wait_until { |l| l.style("font-size") == "20px" }
+        expect(link.style("font-size")).to eq "20px"
+      end
+    end
+  end
+
+  describe "#inspect" do
+    before(:each) { browser.goto(WatirSpec.url_for("nested_iframes.html")) }
+
+    it "does displays specified element type" do
+      expect(browser.div.inspect).to include('Watir::Div')
+    end
+
+    it "does not display element type if not specified" do
+      element = browser.element(index: 4)
+      expect(element.inspect).to include('Watir::HTMLElement')
+    end
+
+    it "displays keyword if specified" do
+      element = browser.h3
+      element.keyword = 'foo'
+      expect(element.inspect).to include('keyword: foo')
+    end
+
+    it "does not display keyword if not specified" do
+      element = browser.h3
+      expect(element.inspect).to_not include('keyword')
+    end
+
+    it "locate is false when not located" do
+      element = browser.div(id: 'not_present')
+      expect(element.inspect).to include('located: false')
+    end
+
+    it "locate is true when located" do
+      element = browser.h3
+      element.exists?
+      expect(element.inspect).to include('located: true')
+    end
+
+    it "displays selector string for element from colection" do
+      elements = browser.frames
+      expect(elements.last.inspect).to include '{:tag_name=>"frame", :index=>-1}'
+    end
+
+    it "displays selector string for nested element" do
+      browser.goto(WatirSpec.url_for("wait.html"))
+      element = browser.div(index: 1).div(id: 'div2')
+      expect(element.inspect).to include '{:index=>1, :tag_name=>"div"} --> {:id=>"div2", :tag_name=>"div"}'
+    end
+
+    it "displays selector string for nested element under frame" do
+      element = browser.iframe(id: 'one').iframe(id: 'three')
+      expect(element.inspect).to include '{:id=>"one", :tag_name=>"iframe"} --> {:id=>"three", :tag_name=>"iframe"}'
+    end
   end
 
   describe '#text_content' do
@@ -493,4 +693,15 @@ describe "Element" do
     end
   end
 
+  describe '#attribute_value' do
+    before { browser.goto WatirSpec.url_for("data_attributes.html") }
+
+    it 'returns attribute value by string attribute name' do
+      expect(browser.p.attribute_value('data-type')).to eq "ruby-library"
+    end
+
+    it 'returns attribute value by symbol attribute name' do
+      expect(browser.p.attribute_value(:data_type)).to eq "ruby-library"
+    end
+  end
 end

data/spec/watirspec/elements/hn_spec.rb

@@ -77,7 +77,7 @@ describe ["H1", "H2", "H3", "H4", "H5", "H6"] do
 
     it "raises UnknownObjectException if the p doesn't exist" do
       expect { browser.h1(id: 'no_such_id').text }.to raise_unknown_object_exception
-      expect { browser.h1(:xpath , "//h1[@id='no_such_id']").text }.to raise_unknown_object_exception
+      expect { browser.h1(xpath: "//h1[@id='no_such_id']").text }.to raise_unknown_object_exception
     end
   end
 

data/spec/watirspec/elements/hns_spec.rb

@@ -28,7 +28,7 @@ describe ["H1s", "H2s", "H3s", "H4s", "H5s", "H6s"] do
       lengths = (1..6).collect do |i|
         collection = browser.send(:"h#{i}s")
         collection.each_with_index do |h, index|
-          expect(h.id).to eq browser.send(:"h#{i}", :index, index).id
+          expect(h.id).to eq browser.send(:"h#{i}", index: index).id
         end
         collection.length
       end

data/spec/watirspec/elements/ins_spec.rb

@@ -95,7 +95,7 @@ describe "Ins" do
 
     it "raises UnknownObjectException if the ins doesn't exist" do
       expect { browser.ins(id: 'no_such_id').text }.to raise_unknown_object_exception
-      expect { browser.ins(:xpath , "//ins[@id='no_such_id']").text }.to raise_unknown_object_exception
+      expect { browser.ins(xpath: "//ins[@id='no_such_id']").text }.to raise_unknown_object_exception
     end
   end
 

data/spec/watirspec/elements/labels_spec.rb

@@ -14,7 +14,7 @@ describe "Labels" do
 
   describe "#length" do
     it "returns the number of labels" do
-      expect(browser.labels.length).to eq 40
+      expect(browser.labels.length).to eq 41
     end
   end
 

data/spec/watirspec/elements/li_spec.rb

@@ -95,7 +95,7 @@ describe "Li" do
 
     it "raises UnknownObjectException if the li doesn't exist" do
       expect { browser.li(id: 'no_such_id').text }.to raise_unknown_object_exception
-      expect { browser.li(:xpath , "//li[@id='no_such_id']").text }.to raise_unknown_object_exception
+      expect { browser.li(xpath: "//li[@id='no_such_id']").text }.to raise_unknown_object_exception
     end
   end