watir-webdriver 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1f54118bae04cf0d3fa63789d3e497c44598568
-  data.tar.gz: 577b5480be284ed6fb2872faf741e5dc657fe81f
+  metadata.gz: a322877b0c96368348e29e32226bac91b8b36b75
+  data.tar.gz: 775b4abdc05e2c96ce2097dab57fcd4304b5b5b6
 SHA512:
-  metadata.gz: 720bbaa5c0629b2dbd845b336b9870d1cf48bc659ee3c5bd2ed7e83104d65141c80da02f327f6d0cb68a515ce534629a3c772a7454dc9a4faff201a10ece6866
-  data.tar.gz: d3d4c44c25c95ba661ed233c9c11f2b032019a45b89c7aa61352ea56d9da2c06b7e45a6636f39b813ef7058e20c1d55c1b5114cb0920b46c392dc97327763b45
+  metadata.gz: 0b32874e38997f2162fae6c1bca220a4c7c39d926574f45c10773a3dba5fac00d9a7904dace123af818f61a611ce2dccb2f387f0ac12dd27f37b9add27743217
+  data.tar.gz: 0bf9c9e31e1c14f0b7c749154b269666619d242c47c211349941c8af523ffdf049210c665cac1867527c4862eae542f60751e6868c00044244ee01c44893534f

data/CHANGES.md

@@ -1,3 +1,7 @@
+### 0.9.3 (2016-07-31)
+
+* Fix warning message for untyped text field (#434)
+
 ### 0.9.2 (2016-07-29)
 
 * Massive reorganization and refactoring of element locators (#392)

data/Rakefile

@@ -126,31 +126,36 @@ namespace :spec do
   require 'selenium-webdriver'
 
   desc 'Run specs in all browsers'
-  task all_browsers: [:chrome,
-                      :firefox,
-                      :phantomjs,
-                      :remote_chrome,
-                      :remote_firefox,
-                      :remote_phantomjs,
-                      (:safari if Selenium::WebDriver::Platform.os == :macosx),
-                      (:remote_safari if Selenium::WebDriver::Platform.os == :macosx),
-                      (:ie if Selenium::WebDriver::Platform.os == :windows),
-                      (:remote_ie if Selenium::WebDriver::Platform.os == :windows),
-                      (:edge if Selenium::WebDriver::Platform.os == :windows),
-                      (:remote_edge if Selenium::WebDriver::Platform.os == :windows)].compact
+  task all_browsers: [:browsers, :remote_browsers]
+
+  desc 'Run specs locally for all browsers'
+  task browsers: [:chrome,
+                  :firefox,
+                  :phantomjs,
+                  (:safari if Selenium::WebDriver::Platform.os == :macosx),
+                  (:ie if Selenium::WebDriver::Platform.os == :windows),
+                  (:edge if Selenium::WebDriver::Platform.os == :windows)].compact
+
+  desc 'Run specs remotely for all browsers'
+  task remote_browsers: [:remote_chrome,
+             :remote_firefox,
+             :remote_phantomjs,
+             (:remote_safari if Selenium::WebDriver::Platform.os == :macosx),
+             (:remote_ie if Selenium::WebDriver::Platform.os == :windows),
+             (:remote_edge if Selenium::WebDriver::Platform.os == :windows)].compact
 
   %w(firefox marionette chrome safari phantomjs ie edge).each do |browser|
     desc "Run specs in #{browser}"
     task browser do
       ENV['WATIR_WEBDRIVER_BROWSER'] = browser
-      Rake::Task['spec'].execute
+      Rake::Task[:spec].execute
     end
 
     desc "Run specs in Remote #{browser}"
     task "remote_#{browser}" do
       ENV['WATIR_WEBDRIVER_BROWSER'] = 'remote'
       ENV['REMOTE_BROWSER'] =  browser
-      Rake::Task['spec'].execute
+      Rake::Task[:spec].execute
     end
   end
 end

data/lib/watir-webdriver/locators/text_field/locator.rb

@@ -32,7 +32,9 @@ module Watir
           element = super
 
           if element && !Watir::TextField::NON_TEXT_TYPES.include?(element.attribute(:type))
-            warn "Locating textareas with '#text_field' is deprecated. Please, use '#textarea' method instead."
+            if element.tag_name.downcase == 'textarea'
+              warn "Locating textareas with '#text_field' is deprecated. Please, use '#textarea' method instead."
+            end
             element
           end
         end

data/lib/watir-webdriver/version.rb

@@ -1,3 +1,3 @@
 module Watir
-  VERSION = '0.9.2'
+  VERSION = '0.9.3'
 end

data/spec/element_locator_spec.rb

@@ -69,7 +69,6 @@ describe Watir::Locators::Element::Locator do
       end
     end
 
-
     describe "with special cased selectors" do
       it "normalizes space for :text" do
         expect_one :xpath, ".//div[normalize-space()='foo']"

data/spec/element_spec.rb

@@ -114,4 +114,21 @@ describe Watir::Element do
       end
     end
   end
+
+  # TODO - Can remove when decide issue #295
+  describe "warnings" do
+    it "does not return a warning if using text_field for an unspecified text input" do
+       browser.goto(WatirSpec.url_for("forms_with_input_elements.html"))
+      expect do
+       browser.text_field(id: "new_user_first_name").exists?
+      end.to_not output.to_stderr
+    end
+
+    it "returns a warning if using text_field for textarea" do
+      browser.goto(WatirSpec.url_for("forms_with_input_elements.html"))
+      expect do
+        browser.text_field(id: "create_user_comment").exists?
+      end.to output.to_stderr
+    end
+  end
 end

data/spec/implementation.rb

@@ -21,10 +21,10 @@ class ImplementationConfig
     require 'selenium/server'
 
     @server ||= Selenium::Server.new(remote_server_jar,
-                                     :port       => Selenium::WebDriver::PortProber.above(4444),
-                                     :log        => !!$DEBUG,
-                                     :background => true,
-                                     :timeout    => 60)
+                                     port: Selenium::WebDriver::PortProber.above(4444),
+                                     log: !!$DEBUG,
+                                     background: true,
+                                     timeout: 60)
 
     @server.start
     at_exit { @server.stop }
@@ -50,23 +50,21 @@ class ImplementationConfig
 
   def set_browser_args
     args = case browser
-           when :firefox
-             firefox_args
            when :chrome
              chrome_args
            when :remote
              remote_args
            else
-             [browser, {}]
+             {}
            end
 
     if ENV['SELECTOR_STATS']
       listener = SelectorListener.new
-      args.last.merge!(listener: listener)
+      args.merge!(listener: listener)
       at_exit { listener.report }
     end
 
-    @imp.browser_args = args
+    @imp.browser_args = [browser, args]
   end
 
   def mobile?
@@ -124,14 +122,8 @@ class ImplementationConfig
     browser_instance.close if browser_instance
   end
 
-  def firefox_args
-    [:firefox, {}]
-  end
-
   def chrome_args
-    opts = {
-      args: ["--disable-translate"]
-    }
+    opts = {args: ["--disable-translate"]}
 
     if url = ENV['WATIR_WEBDRIVER_CHROME_SERVER']
       opts[:url] = url
@@ -149,14 +141,13 @@ class ImplementationConfig
       opts[:args] << "--no-sandbox" # https://github.com/travis-ci/travis-ci/issues/938
     end
 
-    [:chrome, opts]
+    opts
   end
 
   def remote_args
     url = ENV["REMOTE_SERVER_URL"] || "http://127.0.0.1:#{@server.port}/wd/hub"
-    remote_browser_name = ENV['REMOTE_BROWSER'].to_sym
-    caps =  Selenium::WebDriver::Remote::Capabilities.send(remote_browser_name)
-    [:remote, {url: url, desired_capabilities: caps}]
+    caps = Selenium::WebDriver::Remote::Capabilities.send(remote_browser)
+    {url: url, desired_capabilities: caps}
   end
 
   def add_html_routes

data/watir-webdriver.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency "selenium-webdriver", ">= 2.46.2"
 
-  s.add_development_dependency "rspec", "~> 2.6"
+  s.add_development_dependency "rspec", "~> 3.0"
   s.add_development_dependency "yard", "> 0.8.2.1"
   s.add_development_dependency "webidl", ">= 0.1.5"
   s.add_development_dependency "sinatra", "~> 1.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: watir-webdriver
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Jari Bakken
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-29 00:00:00.000000000 Z
+date: 2016-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement