watir-dom-wait 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8da70c7e860203cf57a19b7fdf423af4e5ce90ab
-  data.tar.gz: b2e1ecf9fc2834274b2a2f8cb6f82a9affe7f9ec
+  metadata.gz: 7f58c8ee42532287c905e965095b1b51b10d8a5a
+  data.tar.gz: 68916d0b9e8a00999a460428727297b91378697a
 SHA512:
-  metadata.gz: 8c52446146fd41d3b0d3f45048bc8d0f500b46e7cb0aa6a84189e81df8030ff28c8cfc32941e83460a3e80f1386dc423998c6da10f3d6aa14f5f63b5a0ad0a50
-  data.tar.gz: fa4c3b011bfc92646d022ea75e65ece0f1d439bc9baa271880772a668c597a4f98c2234dbc2a769d0306d71be308a1a4e5210ea272528a8f51ba6ed04178bab7
+  metadata.gz: cdebe4f8e76f264593f2ed3ce7af40153a9b4e20778936586bd54a62b2403d6709a77a4494420a7b825cd807352149b8eca4a41ed43bacd3b50d80d1ad206ab4
+  data.tar.gz: 794bba96d303eb4aae5380bf25dcaf1e561a5330209455ef1518a2e0eb8671792fced2034929fa95c6a472dc54c659cb1cd83240e9bf8c0d7a08864d3524f6b0

data/lib/watir/dom/elements/element.rb

@@ -17,19 +17,21 @@ module Watir
     #
 
     def dom_changed?(delay: 1.1)
-      driver.manage.timeouts.script_timeout = delay + 1
-      driver.execute_async_script(DOM_WAIT_JS, wd, delay)
-    rescue Selenium::WebDriver::Error::StaleElementReferenceError
-      retry
-    rescue Selenium::WebDriver::Error::JavascriptError => error
-      # sometimes we start script execution before new page is loaded and
-      # in rare cases ChromeDriver throws this error, we just swallow it and retry
-      retry if error.message.include?('document unloaded while waiting for result')
-      raise
-    ensure
-      # TODO: make sure we rollback to user-defined timeout
-      # blocked by https://github.com/seleniumhq/selenium-google-code-issue-archive/issues/6608
-      driver.manage.timeouts.script_timeout = 1
+      element_call do
+        begin
+          driver.manage.timeouts.script_timeout = delay + 1
+          driver.execute_async_script(DOM_WAIT_JS, wd, delay)
+        rescue Selenium::WebDriver::Error::JavascriptError => error
+          # sometimes we start script execution before new page is loaded and
+          # in rare cases ChromeDriver throws this error, we just swallow it and retry
+          retry if error.message.include?('document unloaded while waiting for result')
+          raise
+        ensure
+          # TODO: make sure we rollback to user-defined timeout
+          # blocked by https://github.com/seleniumhq/selenium-google-code-issue-archive/issues/6608
+          driver.manage.timeouts.script_timeout = 1
+        end
+      end
     end
   end # Element
 end # Watir

data/spec/spec_helper.rb

@@ -1,15 +1,10 @@
-require "pry"
 require "watir-dom-wait"
 
 RSpec.configure do |spec|
   spec.filter_run_excluding bug: /\d+/
 
   spec.before(:all) do
-    opts = {}
-    if ENV['TRAVIS']
-      Selenium::WebDriver::Chrome.path = "#{File.dirname(__FILE__)}/../bin/google-chrome"
-      opts[:args] = ['no-sandbox']
-    end
+    Selenium::WebDriver::Chrome.path = "#{File.dirname(__FILE__)}/../bin/google-chrome" if ENV['TRAVIS']
     @browser = Watir::Browser.new(:chrome, opts)
     @browser.goto "data:text/html,#{File.read('spec/support/html/wait_for_dom.html')}"
   end
@@ -19,7 +14,6 @@ RSpec.configure do |spec|
   end
 
   spec.after(:each) do |example|
-    binding.pry if example.exception && ENV['DEBUG']
     @browser.refresh
   end
 end

data/watir-dom-wait.gemspec

@@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "watir-dom-wait"
-  spec.version       = "0.3.2"
+  spec.version       = "0.3.3"
   spec.authors       = ["Alex Rodionov"]
   spec.email         = %w(p0deje@gmail.com)
   spec.description   = "Watir extension which provides with method to check for DOM changes."
@@ -16,10 +16,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "watir", ">= 6.0"
+  spec.add_dependency "watir", ">= 6.4"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "pry"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: watir-dom-wait
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Alex Rodionov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-27 00:00:00.000000000 Z
+date: 2017-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: watir
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.4'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -66,20 +66,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Watir extension which provides with method to check for DOM changes.
 email:
 - p0deje@gmail.com
@@ -121,7 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Watir extension which provides with method to check for DOM changes.