waterfurnace_aurora 0.7.7 → 1.1.0

data/lib/aurora/abc_client.rb

@@ -3,6 +3,7 @@
 require "yaml"
 require "uri"
 
+require "aurora/aux_heat"
 require "aurora/blower"
 require "aurora/compressor"
 require "aurora/dhw"
@@ -14,7 +15,7 @@ require "aurora/thermostat"
 module Aurora
   class ABCClient
     class << self
-      def open_modbus_slave(uri)
+      def open_modbus_slave(uri, ignore_missing_registers: false)
         uri = URI.parse(uri)
 
         io = case uri.scheme
@@ -31,7 +32,10 @@ module Aurora
                require "aurora/mqtt_modbus"
                return Aurora::MQTTModBus.new(uri)
              else
-               return Aurora::MockABC.new(YAML.load_file(uri.path)) if File.file?(uri.path)
+               if File.file?(uri.path)
+                 return Aurora::MockABC.new(YAML.load_file(uri.path),
+                                            ignore_missing_registers: ignore_missing_registers)
+               end
 
                require "ccutrer-serialport"
                CCutrer::SerialPort.new(uri.path, baud: 19_200, parity: :even)
@@ -53,6 +57,10 @@ module Aurora
             implicit = true
             try_individual = true if try_individual.nil?
             break Aurora::REGISTER_RANGES
+          when "all"
+            implicit = true
+            try_individual = true if try_individual.nil?
+            break 0..65_535
           when /^(\d+)(?:\.\.|-)(\d+)$/
             $1.to_i..$2.to_i
           else
@@ -61,41 +69,71 @@ module Aurora
         end
         queries = Aurora.normalize_ranges(ranges)
         registers = {}
+        last_log_time = nil
         queries.each do |subquery|
+          last_log_time = log_query(last_log_time, subquery.inspect)
           registers.merge!(modbus_slave.read_multiple_holding_registers(*subquery))
-        rescue ::ModBus::Errors::IllegalDataAddress, ::ModBus::Errors::IllegalFunction
+        rescue ::ModBus::Errors::IllegalDataAddress, ::ModBus::Errors::IllegalFunction, ::ModBus::Errors::ModBusTimeout
           # maybe this unit doesn't respond to all the addresses we want?
           raise unless implicit
 
           # try each query individually
           subquery.each do |subsubquery|
+            last_log_time = log_query(last_log_time, subsubquery.inspect)
             registers.merge!(modbus_slave.read_multiple_holding_registers(subsubquery))
-          rescue ::ModBus::Errors::IllegalDataAddress, ::ModBus::Errors::IllegalFunction
+          rescue ::ModBus::Errors::IllegalDataAddress,
+                 ::ModBus::Errors::IllegalFunction,
+                 ::ModBus::Errors::ModBusTimeout => e
+            raise if e.is_a?(::ModBus::Errors::ModBusTimeout) && !try_individual
             next unless try_individual
 
             # seriously?? try each register individually
-            subsubquery.each do |i|
+            Array(subsubquery).each do |i|
+              last_log_time = log_query(last_log_time, i.to_s)
               registers[i] = modbus_slave.holding_registers[i]
             rescue ::ModBus::Errors::IllegalDataAddress, ::ModBus::Errors::IllegalFunction
+              # don't catch ModBusTimeout here... it should have no problem responding to a single register request
               next
             end
           end
         end
         registers
       end
+
+      private
+
+      def log_query(last_log_time, query)
+        last_log_time ||= Process.clock_gettime(Process::CLOCK_MONOTONIC)
+        now = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+        if now - last_log_time > 5
+          Aurora&.logger&.info("Fetching register(s) #{query}...")
+          last_log_time = now
+        end
+        last_log_time
+      end
     end
 
     attr_reader :modbus_slave,
+                :abc_version,
                 :model,
                 :serial_number,
                 :zones,
+                :aux_heat,
                 :compressor,
                 :blower,
                 :pump,
                 :dhw,
                 :humidistat,
+                :current_fault,
                 :faults,
+                :locked_out,
+                :derated,
+                :safe_mode,
                 :current_mode,
+                :low_pressure_switch,
+                :high_pressure_switch,
+                :emergency_shutdown,
+                :load_shed,
                 :entering_air_temperature,
                 :leaving_air_temperature,
                 :leaving_water_temperature,
@@ -104,21 +142,27 @@ module Aurora
                 :fp1,
                 :fp2,
                 :line_voltage,
-                :aux_heat_watts,
-                :total_watts
+                :watts
+
+    alias_method :emergency_shutdown?, :emergency_shutdown
+    alias_method :load_shed?, :load_shed
+    alias_method :locked_out?, :locked_out
+    alias_method :derated?, :derated
+    alias_method :safe_mode?, :safe_mode
 
     def initialize(uri)
       @modbus_slave = self.class.open_modbus_slave(uri)
       @modbus_slave.read_retry_timeout = 15
       @modbus_slave.read_retries = 2
-      raw_registers = @modbus_slave.holding_registers[33, 88...110, 404, 412..413, 1103, 1114]
+      raw_registers = @modbus_slave.holding_registers[2, 33, 88...110, 404, 412..413, 813, 1103, 1114]
       registers = Aurora.transform_registers(raw_registers.dup)
+      @abc_version = registers[2]
       @program = registers[88]
       @model = registers[92]
       @serial_number = registers[105]
       @energy_monitor = raw_registers[412]
 
-      @zones = if iz2?
+      @zones = if iz2? && iz2_version >= 2.0
                  iz2_zone_count = @modbus_slave.holding_registers[483]
                  (0...iz2_zone_count).map { |i| IZ2Zone.new(self, i + 1) }
                else
@@ -127,6 +171,7 @@ module Aurora
 
       @abc_dipswitches = registers[33]
       @axb_dipswitches = registers[1103]
+      @aux_heat = AuxHeat.new(self)
       @compressor = if @program == "ABCVSP"
                       Compressor::VSDrive.new(self)
                     else
@@ -152,12 +197,15 @@ module Aurora
 
       @faults = []
 
-      @registers_to_read = [6, 19..20, 25, 30, 112, 344, 740..741, 900, 1104, 1110..1111, 1114, 1150..1153, 1165,
-                            31_003]
+      @entering_air_register = awl_axb? ? 740 : 567
+      @registers_to_read = [6, 19..20, 25, 30..31, 112, 344, @entering_air_register, 1104, 1110..1111, 1114, 1150..1153,
+                            1165]
+      @registers_to_read.concat([741, 31_003]) if awl_communicating?
+      @registers_to_read << 900 if awl_axb?
       zones.each do |z|
         @registers_to_read.concat(z.registers_to_read)
       end
-      @components = [compressor, blower, pump, dhw, humidistat].compact
+      @components = [aux_heat, compressor, blower, pump, dhw, humidistat].compact
       @components.each do |component|
         @registers_to_read.concat(component.registers_to_read)
       end
@@ -178,34 +226,41 @@ module Aurora
 
       outputs = registers[30]
 
-      @entering_air_temperature   = registers[740]
-      @leaving_air_temperature    = registers[900]
+      @entering_air_temperature   = registers[@entering_air_register]
+      @leaving_air_temperature    = registers[900] if awl_axb?
       @leaving_water_temperature  = registers[1110]
       @entering_water_temperature = registers[1111]
       @outdoor_temperature        = registers[31_003]
       @fp1                        = registers[19]
       @fp2                        = registers[20]
-      @locked_out                 = registers[25] & 0x8000
-      @error                      = registers[25] & 0x7fff
-      @derated                    = (41..46).cover?(@error)
-      @safe_mode                  = [47, 48, 49, 72, 74].include?(@error)
+      @locked_out                 = !(registers[25] & 0x8000).zero?
+      @current_fault              = registers[25] & 0x7fff
+      @derated                    = (41..46).cover?(@current_fault)
+      @safe_mode                  = [47, 48, 49, 72, 74].include?(@current_fault)
+      @low_pressure_switch        = registers[31][:lps]
+      @high_pressure_switch       = registers[31][:hps]
+      @emergency_shutdown         = !!registers[31][:emergency_shutdown]
+      @load_shed                  = !!registers[31][:load_shed]
       @line_voltage               = registers[112]
-      @aux_heat_watts             = registers[1151]
-      @total_watts                = registers[1153]
+      @watts                      = registers[1153]
 
       @current_mode = if outputs.include?(:lockout)
                         :lockout
                       elsif registers[362]
                         :dehumidify
                       elsif outputs.include?(:cc2) || outputs.include?(:cc)
-                        outputs.include?(:rv) ? :cooling : :heating
-                      elsif outputs.include?(:eh2)
-                        outputs.include?(:rv) ? :eh2 : :emergency
-                      elsif outputs.include?(:eh1)
-                        outputs.include?(:rv) ? :eh1 : :emergency
+                        if outputs.include?(:rv)
+                          :cooling
+                        elsif outputs.include?(:eh2) || outputs.include?(:eh1)
+                          :heating_with_aux
+                        else
+                          :heating
+                        end
+                      elsif outputs.include?(:eh2) || outputs.include?(:eh1)
+                        :emergency_heat
                       elsif outputs.include?(:blower)
                         :blower
-                      elsif registers[6]
+                      elsif !registers[6].zero?
                         :waiting
                       else
                         :standby
@@ -270,13 +325,18 @@ module Aurora
     end
 
     # config aurora system
-    { thermostat: 800, axb: 806, iz2: 812, aoc: 815, moc: 818, eev2: 824 }.each do |(component, register)|
+    { thermostat: 800, axb: 806, iz2: 812, aoc: 815, moc: 818, eev2: 824, awl: 827 }.each do |(component, register)|
       class_eval <<-RUBY, __FILE__, __LINE__ + 1
         def #{component}?
           return @#{component} if instance_variable_defined?(:@#{component})
           @#{component} = @modbus_slave.holding_registers[#{register}] != 3
         end
 
+        def #{component}_version
+          return @#{component}_version if instance_variable_defined?(:@#{component}_version)
+          @#{component}_version = @modbus_slave.holding_registers[#{register + 1}].to_f / 100
+        end
+
         def add_#{component}
           @modbus_slave.holding_registers[#{register}] = 2
         end
@@ -287,6 +347,27 @@ module Aurora
       RUBY
     end
 
+    # see https://www.waterfurnace.com/literature/symphony/ig2001ew.pdf
+    # is there a communicating system compliant with AWL?
+    def awl_communicating?
+      awl_thermostat? || awl_iz2?
+    end
+
+    # is the thermostat AWL compliant?
+    def awl_thermostat?
+      thermostat? && thermostat_version >= 3.0
+    end
+
+    # is the IZ2 AWL compliant?
+    def awl_iz2?
+      iz2? && iz2_version >= 2.0
+    end
+
+    # is the AXB AWL compliant?
+    def awl_axb?
+      axb? && axb_version >= 2.0
+    end
+
     def inspect
       "#<Aurora::ABCClient #{(instance_variables - [:@modbus_slave]).map do |iv|
                                "#{iv}=#{instance_variable_get(iv).inspect}"

data/lib/aurora/aux_heat.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+require "aurora/component"
+
+module Aurora
+  class AuxHeat < Component
+    attr_reader :stage, :watts
+
+    def refresh(registers)
+      outputs = registers[30]
+      @stage = if outputs.include?(:eh2)
+                 2
+               elsif outputs.include?(:eh1)
+                 1
+               else
+                 0
+               end
+      @watts = registers[1151] if abc.energy_monitoring?
+    end
+  end
+end

data/lib/aurora/blower.rb

@@ -36,7 +36,7 @@ module Aurora
 
       def refresh(registers)
         outputs = registers[30]
-        @speed = if outputs.include?(:eh1)
+        @speed = if outputs.include?(:eh1) || outputs.include?(:eh2)
                    4
                  elsif outputs.include?(:cc2)
                    3

data/lib/aurora/component.rb

@@ -6,6 +6,10 @@ module Aurora
       @abc = abc
     end
 
+    def registers_to_read
+      []
+    end
+
     def inspect
       "#<Aurora::#{self.class.name} #{(instance_variables - [:@abc]).map do |iv|
                                         "#{iv}=#{instance_variable_get(iv).inspect}"

data/lib/aurora/compressor.rb

@@ -5,7 +5,7 @@ require "aurora/component"
 module Aurora
   module Compressor
     class GenericCompressor < Component
-      attr_reader :speed, :watts
+      attr_reader :speed, :watts, :saturated_condensor_discharge_temperature
 
       def initialize(abc, stages)
         super(abc)
@@ -21,11 +21,9 @@ module Aurora
       end
 
       def registers_to_read
-        if abc.energy_monitoring?
-          [1146..1147]
-        else
-          []
-        end
+        result = [1134]
+        result << (1146..1147) if abc.energy_monitoring?
+        result
       end
 
       def refresh(registers)
@@ -37,12 +35,24 @@ module Aurora
                  else
                    0
                  end
+        @saturated_condensor_discharge_temperature = registers[1134]
         @watts = registers[1146] if abc.energy_monitoring?
       end
     end
 
     class VSDrive < GenericCompressor
-      attr_reader :ambient_temperature, :iz2_desired_speed
+      attr_reader :drive_temperature,
+                  :inverter_temperature,
+                  :ambient_temperature,
+                  :iz2_desired_speed,
+                  :fan_speed,
+                  :discharge_pressure,
+                  :discharge_temperature,
+                  :suction_pressure,
+                  :suction_temperature,
+                  :saturated_evaporator_discharge_temperature,
+                  :superheat_temperature,
+                  :superheat_percentage
 
       def initialize(abc)
         super(abc, 12)
@@ -53,7 +63,7 @@ module Aurora
       end
 
       def registers_to_read
-        result = super + [209, 3001, 3326]
+        result = super + [209, 3001, 3322..3327, 3522, 3524, 3808, 3903..3906]
         result << 564 if abc.iz2?
         result
       end
@@ -62,7 +72,18 @@ module Aurora
         super
 
         @speed = registers[3001]
+        @discharge_pressure = registers[3322]
+        @suction_pressure = registers[3323]
+        @discharge_temperature = registers[3325]
         @ambient_temperature = registers[3326]
+        @drive_temperature = registers[3327]
+        @inverter_temperature = registers[3522]
+        @fan_speed = registers[3524]
+        @superheat_percentage = registers[3808]
+        @suction_temperature = registers[3903]
+        @saturated_evaporator_discharge_temperature = registers[3905]
+        @superheat_temperature = registers[3906]
+
         @iz2_desired_speed = registers[564] if abc.iz2?
       end
     end

data/lib/aurora/dhw.rb

@@ -27,7 +27,6 @@ module Aurora
 
       raw_value = (value * 10).to_i
       holding_registers[401] = raw_value
-      @set_point = value
     end
   end
 end

data/lib/aurora/humidistat.rb

@@ -29,6 +29,8 @@ module Aurora
     alias_method :dehumidifier_running?, :dehumidifier_running
 
     def registers_to_read
+      return [] unless @abc.awl_communicating?
+
       result = [741]
       if humidifier? || dehumidifier? || abc.compressor.is_a?(Compressor::VSDrive)
         result.concat(abc.iz2? ? [21_114, 31_109..31_110] : [12_309..12_310])
@@ -73,8 +75,6 @@ module Aurora
       raw_value |= 0x4000 if humidifier_mode == :auto
       raw_value |= 0x8000 if dehumidifier_mode == :auto
       holding_registers[abc.iz2? ? 21_114 : 12_309] = raw_value
-      @humidifier_mode = humidifier_mode
-      @dehumidifier_mode = dehumidifier_mode
     end
 
     def humidification_target=(value)
@@ -90,8 +90,6 @@ module Aurora
       raise ArgumentError unless (35..65).cover?(dehumidification_target)
 
       holding_registers[abc.iz2? ? 21_115 : 12_310] = (humidification_target << 8) + dehumidification_target
-      @humidification_target = humidification_target
-      @dehumidification_target = dehumidification_target
     end
   end
 end

data/lib/aurora/iz2_zone.rb

@@ -46,28 +46,24 @@ module Aurora
       return unless (raw_value = Aurora::HEATING_MODE.invert[value])
 
       holding_registers[21_202 + ((zone_number - 1) * 9)] = raw_value
-      @target_mode = value
     end
 
     def target_fan_mode=(value)
       return unless (raw_value = Aurora::FAN_MODE.invert[value])
 
       holding_registers[21_205 + ((zone_number - 1) * 9)] = raw_value
-      @target_fan_mode = value
     end
 
     def fan_intermittent_on=(value)
       return unless value >= 0 && value <= 25 && (value % 5).zero?
 
       holding_registers[21_206 + ((zone_number - 1) * 9)] = value
-      @fan_intermittent_on = value
     end
 
     def fan_intermittent_off=(value)
       return unless value >= 0 && value <= 40 && (value % 5).zero?
 
       holding_registers[21_207 + ((zone_number - 1) * 9)] = value
-      @fan_intermittent_off = value
     end
 
     def heating_target_temperature=(value)
@@ -75,7 +71,6 @@ module Aurora
 
       raw_value = (value * 10).to_i
       holding_registers[21_203 + ((zone_number - 1) * 9)] = raw_value
-      @heating_target_temperature = value
     end
 
     def cooling_target_temperature=(value)
@@ -83,7 +78,6 @@ module Aurora
 
       raw_value = (value * 10).to_i
       holding_registers[21_204 + ((zone_number - 1) * 9)] = raw_value
-      @cooling_target_temperature = value
     end
   end
 end

data/lib/aurora/mock_abc.rb

@@ -4,7 +4,8 @@ module Aurora
   class MockABC
     attr_accessor :logger
 
-    def initialize(registers)
+    def initialize(registers, ignore_missing_registers: false)
+      @ignore_missing_registers = ignore_missing_registers
       @registers = registers
     end
 
@@ -20,9 +21,14 @@ module Aurora
       if register.length == 1
         case register.first
         when Integer
+          missing_register(register.first) unless @registers.key?(register.first)
           @registers[register.first]
         when Range
-          @registers.values_at(*register.first.to_a)
+          registers = register.first.to_a
+          registers.each do |i|
+            missing_register(i) unless @registers.key?(i)
+          end
+          @registers.values_at(*registers)
         else
           raise ArgumentError, "Not implemented yet #{register.inspect}"
         end
@@ -35,6 +41,11 @@ module Aurora
       result = {}
       queries.each do |query|
         Array(query).each do |i|
+          unless @registers.key?(i)
+            missing_register(i)
+            next
+          end
+
           result[i] = @registers[i]
         end
       end
@@ -45,5 +56,13 @@ module Aurora
       @registers[addr] = value
     end
     alias_method :[]=, :write_holding_register
+
+    private
+
+    def missing_register(idx)
+      raise ::ModBus::Errors::IllegalDataAddress unless @ignore_missing_registers
+
+      logger.warn("missing register #{idx}")
+    end
   end
 end

data/lib/aurora/pump.rb

@@ -31,7 +31,7 @@ module Aurora
       alias_method :manual_control?, :manual_control
 
       def registers_to_read
-        super + [321..325]
+        super + (@abc.awl_axb? ? [321..325] : [321..324])
       end
 
       def refresh(registers)
@@ -39,7 +39,7 @@ module Aurora
         @minimum_speed = registers[321]
         @maximum_speed = registers[322]
         @manual_control = registers[323] != :off
-        @speed = registers[325]
+        @speed = registers[325] if @abc.awl_axb?
       end
 
       def manual_control=(value)

data/lib/aurora/registers.rb

@@ -60,12 +60,13 @@ module Aurora
   end
 
   def to_int32(registers, idx)
+    Aurora&.logger&.warn("Missing register #{idx + 1}") unless registers[idx + 1]
     (registers[idx] << 16) + registers[idx + 1]
   end
 
   def to_string(registers, idx, length)
     (idx...(idx + length)).map do |i|
-      raise ArgumentError, "Missing register #{i} for string starting at #{idx}" unless registers[i]
+      next "\ufffd" unless registers[i] # missing data? add unicode invalid character
 
       (registers[i] >> 8).chr + (registers[i] & 0xff).chr
     end.join.sub(/[ \0]+$/, "")
@@ -112,7 +113,7 @@ module Aurora
     53 => "Condensing Pressure Sensor", # Low condensing pressure (PD) or invalid (0 to 870 psi) Retry 10x.
     54 => "Low Supply Voltage", # Supply Voltage is <180 V (190V to reset) or powered off/on too quickly (<30 sec.).
     55 => "Out of Envelope", # Comp Operating out of envelope (P0) more than 90 sec. Retry 10x.
-    56 => "Drive Over Currnet", # Over current tripped by phase loss, earth fault, short circuit, low water flow, low air flow, or major drive fault. # rubocop:disable Layout/LineLength
+    56 => "Drive Over Current", # Over current tripped by phase loss, earth fault, short circuit, low water flow, low air flow, or major drive fault. # rubocop:disable Layout/LineLength
     57 => "Drive Over/Under Voltage", # DC Link Voltage to compressor is >450vdc or at minimum voltage (<185vdc).
     58 => "High Drive Temp", # Drive Temp has reached critical High Temp >239 F
     59 => "Internal Drive Error", # The MOC has encountered an internal fault or an internal error. Probably fatal.
@@ -229,6 +230,8 @@ module Aurora
     0x08 => :blower,
     0x10 => :eh1,
     0x20 => :eh2,
+    # 0x40 => ??, # this turns on and off quite a bit during normal operation
+    # 0x80 => ??, # this turns on occasionally during normal operation; I've only seen it when aux heat is on
     0x200 => :accessory,
     0x400 => :lockout,
     0x800 => :alarm
@@ -703,8 +706,9 @@ module Aurora
     9 => "Compressor Minimum Run Time",
     15 => "Blower Off Delay",
     16 => "Line Voltage",
-    17 => "Aux/E Heat Stage", # this has some complicated condition based on
-    # current inputs and outputs on if it should have a value (310 - v) or (130 - v), or be 0
+    17 => "Aux/E Heat Stage", # this is how long aux/eheat have been requested in seconds
+    # when in eheat mode (explicit on the thermostat), it will stage up to eh2 after 130s
+    # when in aux mode (thermostat set to heat; compressor at full capacity), it will stage up to eh2 after 310s
     19 => "FP1 (Cooling Liquid Line) Temperature",
     20 => "FP2",
     21 => "Condensate", # >= 270 normal, otherwise fault
@@ -867,11 +871,11 @@ module Aurora
     3225 => "VS Drive Details (Safemode 2)",
     3226 => "VS Drive Details (Alarm 1)",
     3227 => "VS Drive Details (Alarm 2)",
-    3327 => "VS Drive Temperature",
     3322 => "VS Drive Discharge Pressure",
     3323 => "VS Drive Suction Pressure",
     3325 => "VS Drive Discharge Temperature",
     3326 => "VS Drive Compressor Ambient Temperature",
+    3327 => "VS Drive Temperature",
     3330 => "VS Drive Entering Water Temperature",
     3331 => "VS Drive Line Voltage",
     3332 => "VS Drive Thermo Power",

data/lib/aurora/thermostat.rb

@@ -15,19 +15,23 @@ module Aurora
                 :fan_intermittent_off
 
     def registers_to_read
-      [31, 502, 745..746, 12_005..12_006]
+      return [] unless @abc.awl_thermostat?
+
+      [502, 745..746, 12_005..12_006]
     end
 
     def refresh(registers)
-      @ambient_temperature = registers[502]
-      @heating_target_temperature = registers[745]
-      @cooling_target_temperature = registers[746]
-      config1 = registers[12_005]
-      config2 = registers[12_006]
-      @target_fan_mode = config1[:fan]
-      @fan_intermittent_on = config1[:on_time]
-      @fan_intermittent_off = config1[:off_time]
-      @target_mode = config2[:mode]
+      if @abc.awl_thermostat?
+        @ambient_temperature = registers[502]
+        @heating_target_temperature = registers[745]
+        @cooling_target_temperature = registers[746]
+        config1 = registers[12_005]
+        config2 = registers[12_006]
+        @target_fan_mode = config1[:fan]
+        @fan_intermittent_on = config1[:on_time]
+        @fan_intermittent_off = config1[:off_time]
+        @target_mode = config2[:mode]
+      end
 
       inputs = registers[31]
       @current_fan_mode = inputs.include?(:g)
@@ -44,14 +48,12 @@ module Aurora
       return unless (raw_value = HEATING_MODE.invert[value])
 
       @abc.modbus_slave.holding_registers[12_606] = raw_value
-      @target_mode = value
     end
 
     def target_fan_mode=(value)
       return unless (raw_value = FAN_MODE.invert[value])
 
       @abc.modbus_slave.holding_registers[12_621] = raw_value
-      @target_fan_mode = value
     end
 
     def heating_target_temperature=(value)
@@ -59,7 +61,6 @@ module Aurora
 
       raw_value = (value * 10).to_i
       @abc.modbus_slave.holding_registers[12_619] = raw_value
-      @heating_target_temperature = value
     end
 
     def cooling_target_temperature=(value)
@@ -67,21 +68,18 @@ module Aurora
 
       raw_value = (value * 10).to_i
       @abc.modbus_slave.holding_registers[12_620] = raw_value
-      @cooling_target_temperature = value
     end
 
     def fan_intermittent_on=(value)
       return unless value >= 0 && value <= 25 && (value % 5).zero?
 
       holding_registers[12_622] = value
-      @fan_intermittent_on = value
     end
 
     def fan_intermittent_off=(value)
       return unless value >= 0 && value <= 40 && (value % 5).zero?
 
       holding_registers[12_623] = value
-      @fan_intermittent_off = value
     end
   end
 end