waterdrop 2.8.6 → 2.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96b89ee79adb2be90c97e5e87f79d79ad86ceb7d3652c0220d32030e605afadf
-  data.tar.gz: fbdc38cc1c913e3dd433fa4448848f9f3f3799552d2c18741dd207849f59750d
+  metadata.gz: c6fd5bbc4f935b3d55794ad4f62970ab9feab3d4ebd100f9394c1bb456b8a9b5
+  data.tar.gz: 00ab23a92637285766a29741324b65422b77aba3522aa812b0f72350e3061585
 SHA512:
-  metadata.gz: 253cdaf4f5ba5e0f92e723d0a8214dd36b05a9b11986c005a63399bce38f193a90922281cf150f434ea4f0aaa6e6950dbb02a7df2e4134e0508ed474b0a68c04
-  data.tar.gz: 07043a71104f7a818dcb0a4261ee559b62aadb37ad28696ae5ca6d8c0c66c20de5f7d7ad3ab7bfd68ef0b9f91b1f55d67cc1319e37c009a0023beea6fa49905d
+  metadata.gz: 0a41a342c8b16e167f1292ea6068647ac100f21f7f632342280a0bf69debcee3e6929f070e63b0fde2c28b85454edc6845d66895376a953c3ccaad48873646df
+  data.tar.gz: 89956ae428a553f91d91a8064954dea2095cb81457fd78f1565e31ec47e31799b823942931a08f1e6f2d0a7f04b7f730d5d1856fe01fd4de9a57055b5e301360

data/.github/workflows/ci.yml

@@ -6,9 +6,7 @@ concurrency:
 
 on:
   pull_request:
-    branches: [ main, master ]
-  push:
-    branches: [ main, master ]
+    branches: [ master ]
   schedule:
     - cron:  '0 1 * * *'
 
@@ -48,7 +46,7 @@ jobs:
       - name: Remove platform-specific ffi entries for Ruby previews
         if: contains(matrix.ruby, '3.5')
         run: |
-          ruby -i -ne 'puts $_ unless /^\s*ffi \(.*-.*\)$/' Gemfile.lock
+          sed -i '/^\s*ffi (.*-.*)$/d' Gemfile.lock
 
       - name: Set up Ruby
         uses: ruby/setup-ruby@2a7b30092b0caf9c046252510f9273b4875f3db9 # v1.254.0
@@ -56,6 +54,7 @@ jobs:
           ruby-version: ${{matrix.ruby}}
           bundler-cache: true
           bundler: 'latest'
+          self-hosted: false
 
       - name: Run Kafka with Docker Compose
         run: |
@@ -91,6 +90,7 @@ jobs:
 
   diffend:
     timeout-minutes: 5
+
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -102,6 +102,8 @@ jobs:
         uses: ruby/setup-ruby@2a7b30092b0caf9c046252510f9273b4875f3db9 # v1.254.0
         with:
           ruby-version: 3.4
+          self-hosted: false
+
       - name: Install latest bundler
         run: gem install bundler --no-document
       - name: Install Diffend plugin
@@ -132,3 +134,20 @@ jobs:
           fi
       - name: Run Coditsu
         run: ./coditsu_script.sh
+
+  ci-success:
+    name: CI Success
+    runs-on: ubuntu-latest
+    if: always()
+    needs:
+      - diffend
+      - coditsu
+      - specs
+    steps:
+      - name: Check all jobs passed
+        if: |
+          contains(needs.*.result, 'failure') ||
+          contains(needs.*.result, 'cancelled') ||
+          contains(needs.*.result, 'skipped')
+        run: exit 1
+      - run: echo "All CI checks passed!"

data/.github/workflows/trigger-wiki-refresh.yml

@@ -8,7 +8,14 @@ on:
 
 jobs:
   trigger-wiki-refresh:
-    runs-on: ubuntu-latest
+    runs-on: >-
+      ${{
+        (github.event_name != 'pull_request' ||
+         github.event.pull_request.head.repo.full_name == github.repository)
+        && fromJSON('["self-hosted", "linux", "x64", "qemu"]')
+        || 'ubuntu-latest'
+      }}
+
     environment: wiki-trigger
     if: github.repository_owner == 'karafka'
     steps:

data/.github/workflows/verify-action-pins.yml

@@ -5,7 +5,14 @@ on:
       - '.github/workflows/**'
 jobs:
   verify_action_pins:
-    runs-on: ubuntu-latest
+    runs-on: >-
+      ${{
+        (github.event_name != 'pull_request' ||
+         github.event.pull_request.head.repo.full_name == github.repository)
+        && fromJSON('["self-hosted", "linux", "x64", "qemu"]')
+        || 'ubuntu-latest'
+      }}
+
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - name: Check SHA pins

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # WaterDrop changelog
 
+## 2.8.7 (2025-09-02)
+- [Enhancement] Disable Nagle algorithm by default (improves latency / aligned with librdkafka)
+- [Change] Normalize how libs and dependencies are required (no functional change for the end user)
+
 ## 2.8.6 (2025-08-18)
 - [Feature] Add `idle_disconnect_timeout` config option to automatically disconnect idle producers after a configurable timeout period.
 - [Feature] Add support for [async](https://github.com/socketry/async) gems ecosystem with proper fiber yielding during blocking operations.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    waterdrop (2.8.6)
+    waterdrop (2.8.7)
       karafka-core (>= 2.4.9, < 3.0.0)
       karafka-rdkafka (>= 0.20.0)
       zeitwerk (~> 2.3)
@@ -23,26 +23,37 @@ GEM
     ffi (1.17.2-x86_64-darwin)
     ffi (1.17.2-x86_64-linux-gnu)
     ffi (1.17.2-x86_64-linux-musl)
-    karafka-core (2.5.2)
-      karafka-rdkafka (>= 0.19.2, < 0.21.0)
+    json (2.13.2)
+    karafka-core (2.5.6)
+      karafka-rdkafka (>= 0.20.0)
       logger (>= 1.6.0)
-    karafka-rdkafka (0.21.0.rc1)
+    karafka-rdkafka (0.21.0)
+      ffi (~> 1.15)
+      json (> 2.0)
+      logger
+      mini_portile2 (~> 2.6)
+      rake (> 12)
+    karafka-rdkafka (0.21.0-aarch64-linux-gnu)
       ffi (~> 1.15)
+      json (> 2.0)
       logger
       mini_portile2 (~> 2.6)
       rake (> 12)
-    karafka-rdkafka (0.21.0.rc1-arm64-darwin)
+    karafka-rdkafka (0.21.0-arm64-darwin)
       ffi (~> 1.15)
+      json (> 2.0)
       logger
       mini_portile2 (~> 2.6)
       rake (> 12)
-    karafka-rdkafka (0.21.0.rc1-x86_64-linux-gnu)
+    karafka-rdkafka (0.21.0-x86_64-linux-gnu)
       ffi (~> 1.15)
+      json (> 2.0)
       logger
       mini_portile2 (~> 2.6)
       rake (> 12)
-    karafka-rdkafka (0.21.0.rc1-x86_64-linux-musl)
+    karafka-rdkafka (0.21.0-x86_64-linux-musl)
       ffi (~> 1.15)
+      json (> 2.0)
       logger
       mini_portile2 (~> 2.6)
       rake (> 12)

data/bin/verify_kafka_warnings

@@ -9,7 +9,7 @@ allowed_patterns=(
 )
 
 # Get all warnings
-warnings=$(docker logs --since=0 kafka | grep WARN)
+warnings=$(docker logs --since=0 kafka | grep "] WARN ")
 exit_code=0
 
 while IFS= read -r line; do

data/lib/waterdrop/config.rb

@@ -17,7 +17,10 @@ module WaterDrop
       # sync delivery
       'message.timeout.ms': 50_000,
       # Must be more or equal to `message.timeout.ms` defaults
-      'transaction.timeout.ms': 55_000
+      'transaction.timeout.ms': 55_000,
+      # Lowers latency. Default in newer librdkafka but we want to make sure it is shipped to
+      # users despite what librdkafka they run on
+      'socket.nagle.disable': true
     }.freeze
 
     private_constant :KAFKA_DEFAULTS

data/lib/waterdrop/version.rb

@@ -3,5 +3,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '2.8.6'
+  VERSION = '2.8.7'
 end

data/lib/waterdrop.rb

@@ -1,16 +1,13 @@
 # frozen_string_literal: true
 
 # External components
-# delegate should be removed because we don't need it, we just add it because of ruby-kafka
-%w[
-  delegate
-  forwardable
-  json
-  zeitwerk
-  securerandom
-  karafka-core
-  pathname
-].each { |lib| require lib }
+require 'delegate'
+require 'forwardable'
+require 'json'
+require 'zeitwerk'
+require 'securerandom'
+require 'karafka-core'
+require 'pathname'
 
 # WaterDrop library
 module WaterDrop

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 2.8.6
+  version: 2.8.7
 platform: ruby
 authors:
 - Maciej Mensfeld