waterdrop 2.8.2 → 2.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1dd1ecba0be29bdf637575f0fe8eaea654900f7466d5840c62fbcdeb5000492
-  data.tar.gz: 663b683a670ec1df3700dd3440c80435b376c493bcdb7d024eedcc9a9c7b0de9
+  metadata.gz: 35cafc9c123ce50a97b59e067381fb2f3ca09909e44a6571565c605dc921aac5
+  data.tar.gz: 6402fc7e0460c58b7fb65706d1c57e239fde3ba262812663cd72c1906590a730
 SHA512:
-  metadata.gz: 8ff3c1d142dd9d855c7a26223ceefa973764dfde23b0ec8530999e87d52b7827b7180b30dd1f9f545a65eb7e1b00a8ddf753baa4fa365b93ec997450491ddc9b
-  data.tar.gz: 0fee34d4935ee757fef55ae9205570894b20894b839a1e6abd80fa918eb7d733603a0c791b3d81c73fd913699f07a1ddf1d3af9921722713accdb8bc90a17255
+  metadata.gz: aab2db95b7b60dda60d21175c7690bf8dfca3b48cc9b8df5616d4bbbda71317e1bc7a2b63f8d24d136b5e69f3bdf9962faee931a19b9f3caccce02d854be9260
+  data.tar.gz: 49a9d9c4069618a21c4bf141bd8075aa47ecb6b01d8bc9fa2af14d86fb5a54b8946ec96ee1ec3bdd3d5e414f3880b34db3fafc7676cdcd01c523dc38296f18ee

data/.github/CODEOWNERS

@@ -0,0 +1,3 @@
+/.github @mensfeld
+/.github/workflows/ @mensfeld
+/.github/actions/ @mensfeld

data/.github/workflows/ci.yml

@@ -6,12 +6,18 @@ concurrency:
 
 on:
   pull_request:
+    branches: [ main, master ]
   push:
+    branches: [ main, master ]
   schedule:
     - cron:  '0 1 * * *'
 
+permissions:
+  contents: read
+
 jobs:
   specs:
+    timeout-minutes: 15
     runs-on: ubuntu-latest
     needs: diffend
     strategy:
@@ -26,31 +32,31 @@ jobs:
           - ruby: '3.4'
             coverage: 'true'
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          fetch-depth: 0
 
       - name: Install package dependencies
         run: "[ -e $APT_DEPS ] || sudo apt-get install -y --no-install-recommends $APT_DEPS"
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
+        uses: ruby/setup-ruby@1a0ff446f5856bdfec298b61a09727c860d9d480 # v1.240.0
         with:
           ruby-version: ${{matrix.ruby}}
           bundler-cache: true
           bundler: 'latest'
 
-      - name: Run Kafka with docker compose
+      - name: Run Kafka with Docker Compose
         run: |
           docker compose up -d || (sleep 5 && docker compose up -d)
 
       - name: Wait for Kafka
-        run: |
-          sleep 15
+        run: sleep 15
 
       - name: Install latest bundler
         run: |
           gem install bundler --no-document
           gem update --system --no-document
-
           bundle config set without 'tools benchmarks docs'
 
       - name: Bundle install
@@ -66,16 +72,20 @@ jobs:
       - name: Check Kafka logs for unexpected warnings
         run: bin/verify_kafka_warnings
 
+      - name: Check test topics naming convention
+        run: bin/verify_topics_naming
+
   diffend:
+    timeout-minutes: 5
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           fetch-depth: 0
       - name: Set up Ruby
-        uses: ruby/setup-ruby@v1
+        uses: ruby/setup-ruby@1a0ff446f5856bdfec298b61a09727c860d9d480 # v1.240.0
         with:
           ruby-version: 3.4
       - name: Install latest bundler
@@ -86,12 +96,25 @@ jobs:
         run: bundle secure
 
   coditsu:
+    timeout-minutes: 5
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           fetch-depth: 0
+      - name: Download Coditsu script
+        run: |
+          curl -sSL https://api.coditsu.io/run/ci -o coditsu_script.sh
+          chmod +x coditsu_script.sh
+      - name: Verify Coditsu script checksum
+        run: |
+          EXPECTED_SHA256="0aecc5aa010f53fca264548a41467a2b0a1208d750ce1da3e98a217304cacbbc"
+          ACTUAL_SHA256=$(sha256sum coditsu_script.sh | awk '{ print $1 }')
+          if [ "$ACTUAL_SHA256" != "$EXPECTED_SHA256" ]; then
+            echo "::error::Checksum verification failed. Expected $EXPECTED_SHA256 but got $ACTUAL_SHA256."
+            exit 1
+          fi
       - name: Run Coditsu
-        run: \curl -sSL https://api.coditsu.io/run/ci | bash
+        run: ./coditsu_script.sh

data/.github/workflows/push.yml

@@ -0,0 +1,36 @@
+name: Push Gem
+
+on:
+  push:
+    tags:
+      - v*
+
+permissions:
+  contents: read
+
+jobs:
+  push:
+    if: github.repository_owner == 'karafka'
+    runs-on: ubuntu-latest
+    environment: deployment
+
+    permissions:
+      contents: write
+      id-token: write
+
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          fetch-depth: 0
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@84684c07c1965536eb4802c8daf1a77968df0cb1 # v1.239.0
+        with:
+          bundler-cache: false
+
+      - name: Bundle install
+        run: |
+          bundle install --jobs 4 --retry 3
+
+      # Release
+      - uses: rubygems/release-gem@9e85cb11501bebc2ae661c1500176316d3987059 # v1

data/.github/workflows/verify-action-pins.yml

@@ -0,0 +1,16 @@
+name: Verify Action Pins
+on:
+  pull_request:
+    paths:
+      - '.github/workflows/**'
+jobs:
+  verify:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - name: Check SHA pins
+        run: |
+          if grep -E -r "uses: .*/.*@(v[0-9]+|main|master)($|[[:space:]]|$)" --include="*.yml" --include="*.yaml" .github/workflows/ | grep -v "#"; then
+            echo "::error::Actions should use SHA pins, not tags or branch names"
+            exit 1
+          fi

data/.ruby-version

@@ -1 +1 @@
-3.4.1
+3.4.4

data/CHANGELOG.md

@@ -1,8 +1,19 @@
 # WaterDrop changelog
 
+## 2.8.4 (2025-05-23)
+- [Change] Require `karafka-rdkafka` `>= 0.19.2` due to new partition count caching usage.
+- [Change] Move to trusted-publishers and remove signing since no longer needed.
+
+## 2.8.3 (2025-04-08)
+- [Enhancement] Support producing messages with arrays of strings in headers (KIP-82).
+- [Refactor] Introduce a `bin/verify_topics_naming` script to ensure proper test topics naming convention.
+- [Refactor] Remove factory bot and active support requirement in tests/dev.
+- [Change] Require `karafka-rdkafka` `>= 0.19.1` due to KIP-82.
+
 ## 2.8.2 (2025-02-13)
 - [Feature] Allow for tagging of producer instances similar to how consumers can be tagged.
 - [Refactor] Ensure all test topics in the test suite start with "it-" prefix. 
+- [Refactor] Introduce a `bin/verify_kafka_warnings` script to clean Kafka from temporary test-suite topics.
 
 ## 2.8.1 (2024-12-26)
 - [Enhancement] Raise `WaterDrop::ProducerNotTransactionalError` when attempting to use transactions on a non-transactional producer.
@@ -22,90 +33,6 @@ This release contains **BREAKING** changes. Make sure to read and apply upgrade
 - [Enhancement] Align the `LoggerListener` async messages to reflect, that messages are delegated to the internal queue and not dispatched.
 - [Fix] Ensure, that `:dispatched` key for `#produce_many_sync` always contains delivery handles (final) and not delivery reports.
 
-### Upgrade Notes
-
-**PLEASE MAKE SURE TO READ AND APPLY THEM!**
-
-#### `throw(:abort)` No Longer Allowed To Abort Transactions
-
-Replace:
-
-```ruby
-producer.transaction do
-  messages.each do |message|
-    # Pipe all events
-    producer.produce_async(topic: 'events', payload: message.raw_payload)
-  end
-
-  # And abort if more events are no longer needed
-  throw(:abort) if KnowledgeBase.more_events_needed?
-end
-```
-
-With:
-
-```ruby
-producer.transaction do
-  messages.each do |message|
-    # Pipe all events
-    producer.produce_async(topic: 'events', payload: message.raw_payload)
-  end
-
-  # And abort if more events are no longer needed
-  raise(WaterDrop::AbortTransaction) if KnowledgeBase.more_events_needed?
-end
-```
-
-#### `return`, `break` and `throw` No Longer Allowed Inside Transaction Block
-
-Previously, transactions would abort if you exited early using `return`, `break`, or `throw`. This could create unexpected behavior, where users might not notice the rollback or have different intentions. For example, the following would trigger a rollback:
-
-```ruby
-MAX = 10
-
-def process(messages)
-  count = 0
-
-  producer.transaction do
-    messages.each do |message|
-      count += 1
-
-      producer.produce_async(topic: 'events', payload: message.raw_payload)
-
-      # This would trigger a rollback.
-      return if count >= MAX
-    end
-  end
-end
-```
-
-This is a source of errors, hence such exits are no longer allowed. You can implement similar flow control inside of your methods that are wrapped in a WaterDrop transaction:
-
-```ruby
-MAX = 10
-
-def process(messages)
-  producer.transaction do
-    # Early return from this method will not affect the transaction.
-    # It will be committed
-    insert_with_limit(messages)
-  end
-end
-
-def insert_with_limit(messages)
-  count = 0
-
-  messages.each do |message|
-    count += 1
-
-    producer.produce_async(topic: 'events', payload: message.raw_payload)
-
-    # This would trigger a rollback.
-    return if count >= MAX
-  end
-end
-```
-
 ## 2.7.4 (2024-07-04)
 - [Maintenance] Alias `WaterDrop::Errors::AbortTransaction` with `WaterDrop::AbortTransaction`.
 - [Maintenance] Lower the precision reporting to 100 microseconds in the logger listener.
@@ -146,116 +73,6 @@ This release contains **BREAKING** changes. Make sure to read and apply upgrade
 - [Fix] Middlewares run twice when using buffered produce.
 - [Fix] Validations run twice when using buffered produce.
 
-### Upgrade Notes
-
-**PLEASE MAKE SURE TO READ AND APPLY THEM!**
-
-#### `wait_timeout` Configuration No Longer Needed
-
-The `wait_timeout` WaterDrop configuration option is no longer needed. You can safely remove it.
-
-```ruby
-producer = WaterDrop::Producer.new
-
-producer.setup do |config|
-  # Other config...
-
-  # Remove this, no longer needed
-  config.wait_timeout = 30
-end
-```
-
-#### Time Settings Format Alignment
-
-**All** time-related values are now configured in milliseconds instead of some being in seconds and some in milliseconds.
-
-The values that were changed from seconds to milliseconds are:
-
-- `max_wait_timeout`
-- `wait_backoff_on_queue_full`
-- `wait_timeout_on_queue_full`
-- `wait_backoff_on_transaction_command, default`
-
-If you have configured any of those yourself, please replace the seconds representation with milliseconds:
-
-```ruby
-producer = WaterDrop::Producer.new
-
-producer.setup do |config|
-  config.deliver = true
-
-  # Replace this:
-  config.max_wait_timeout = 30
-
-  # With
-  config.max_wait_timeout = 30_000
-  # ...
-end
-```
-
-#### Defaults Alignment
-
-In this release, we've updated our default settings to address a crucial issue: previous defaults could lead to inconclusive outcomes in synchronous operations due to wait timeout errors. Users often mistakenly believed that a message dispatch was halted because of these errors when, in fact, the timeout was related to awaiting the final dispatch verdict, not the dispatch action itself.
-
-The new defaults in WaterDrop 2.7.0 eliminate this confusion by ensuring synchronous operation results are always transparent and conclusive. This change aims to provide a straightforward understanding of wait timeout errors, reinforcing that they reflect the wait state, not the dispatch success.
-
-Below, you can find a table with what has changed, the new defaults, and the current ones in case you want to retain the previous behavior:
-
-<table>
-  <thead>
-    <tr>
-      <th>Config</th>
-      <th>Previous Default</th>
-      <th>New Default</th>
-    </tr>
-  </thead>
-  <tbody>
-    <tr>
-      <td>root <code>max_wait_timeout</code></td>
-      <td>5000 ms (5 seconds)</td>
-      <td>60000 ms (60 seconds)</td>
-    </tr>
-    <tr>
-      <td>kafka <code>message.timeout.ms</code></td>
-      <td>300000 ms (5 minutes)</td>
-      <td>50000 ms (50 seconds)</td>
-    </tr>
-    <tr>
-      <td>kafka <code>transaction.timeout.ms</code></td>
-      <td>60000 ms (1 minute)</td>
-      <td>55000 ms (55 seconds)</td>
-    </tr>
-  </tbody>
-</table>
-
-This alignment ensures that when using sync operations or invoking `#wait`, any exception you get should give you a conclusive and final delivery verdict.
-
-#### Buffering No Longer Early Validates Messages
-
-As of version `2.7.0`, WaterDrop has changed how message buffering works. Previously, messages underwent validation and middleware processing when they were buffered. Now, these steps are deferred until just before dispatching the messages. The buffer functions strictly as a thread-safe storage area without performing any validations or middleware operations until the messages are ready to be sent.
-
-This adjustment was made primarily to ensure that middleware runs and validations are applied when most relevant—shortly before message dispatch. This approach addresses potential issues with buffers that might hold messages for extended periods:
-
-- **Temporal Relevance**: Validating and processing messages near their dispatch time helps ensure that actions such as partition assignments reflect the current system state. This is crucial in dynamic environments where system states are subject to rapid changes.
-
-- **Stale State Management**: By delaying validations and middleware to the dispatch phase, the system minimizes the risk of acting on outdated information, which could lead to incorrect processing or partitioning decisions.
-
-```ruby
-# Prior to 2.7.0 this would raise an error
-producer.buffer(topic: nil, payload: '')
-# => WaterDrop::Errors::MessageInvalidError
-
-# After 2.7.0 buffer will not, but flush_async will
-producer.buffer(topic: nil, payload: '')
-# => all good here
-producer.flush_async(topic: nil, payload: '')
-# => WaterDrop::Errors::MessageInvalidError
-```
-
-#### Middleware Execution Prior to Flush When Buffering
-
-The timing of middleware execution has been adjusted. Middleware, which was previously run when messages were added to the buffer, will now only execute immediately before the messages are flushed from the buffer and dispatched. This change is similar to the validation-related changes.
-
 ## 2.6.14 (2024-02-06)
 - [Enhancement] Instrument `producer.connected` and `producer.closing` lifecycle events.
 
@@ -330,11 +147,6 @@ The timing of middleware execution has been adjusted. Middleware, which was prev
 - [Enhancement] Introduce `wait_timeout_on_queue_full` with proper meaning. That is, this represents time after which despite backoff the error will be raised. This should allow to raise an error in case the backoff attempts were insufficient. This prevents from a case, where upon never deliverable messages we would end up with an infinite loop.
 - [Fix] Provide `type` for queue full errors that references the appropriate public API method correctly.
 
-### Upgrade notes
-
-1. Rename `wait_on_queue_full_timeout` to `wait_backoff_on_queue_full`.
-2. Set `wait_on_queue_full` to `false` if you did not use it and do not want.
-
 ## 2.5.3 (2023-05-26)
 - [Enhancement] Include topic name in the `error.occurred` notification payload.
 - [Enhancement] Include topic name in the `message.acknowledged` notification payload.
@@ -356,27 +168,6 @@ The timing of middleware execution has been adjusted. Middleware, which was prev
 - [Fix] Do **not** flush when there is no data to flush in the internal buffer.
 - [Fix] Wait on the final data flush for short-lived producers to make sure, that the message is actually dispatched by `librdkafka` or timeout.
 
-### Upgrade notes
-
-Please note, this **is** a **breaking** release, hence `2.5.0`.
-
-1. If you used to catch `WaterDrop::Errors::FlushFailureError` now you need to catch `WaterDrop::Errors::ProduceError`. `WaterDrop::Errors::ProduceManyError` is based on the `ProduceError`, hence it should be enough.
-2. Prior to `2.5.0` there was always a chance of partial dispatches via `produce_many_` methods. Now you can get the info on all the errors via `error.occurred`.
-3. Inline `Rdkafka::RdkafkaError` are now re-raised via `WaterDrop::Errors::ProduceError` and available under `#cause`. Async `Rdkafka::RdkafkaError` errors are still directly available and you can differentiate between errors using the event `type`.
-4. If you are using the Datadog listener, you need to:
-
-```ruby
-# Replace require:
-require 'waterdrop/instrumentation/vendors/datadog/listener'
-# With
-require 'waterdrop/instrumentation/vendors/datadog/metrics_listener'
-
-# Replace references of
-::WaterDrop::Instrumentation::Vendors::Datadog::Listener.new
-# With
-::WaterDrop::Instrumentation::Vendors::Datadog::MetricsListener.new
-```
-
 ## 2.4.11 (2023-02-24)
 - Replace the local rspec locator with generalized core one.
 - Make `::WaterDrop::Instrumentation::Notifications::EVENTS` list public for anyone wanting to re-bind those into a different notification bus.
@@ -400,22 +191,6 @@ require 'waterdrop/instrumentation/vendors/datadog/metrics_listener'
 ## 2.4.6 (2022-12-10)
 - Set `statistics.interval.ms` to 5 seconds by default, so the defaults cover all the instrumentation out of the box.
 
-### Upgrade notes
-
-If you want to disable `librdkafka` statistics because you do not use them at all, update the `kafka` `statistics.interval.ms` setting and set it to `0`:
-
-```ruby
-producer = WaterDrop::Producer.new
-
-producer.setup do |config|
-  config.deliver = true
-  config.kafka = {
-    'bootstrap.servers': 'localhost:9092',
-    'statistics.interval.ms': 0
-  }
-end
-```
-
 ## 2.4.5 (2022-12-10)
 - Fix invalid error scope visibility.
 - Cache partition count to improve messages production and lower stress on Kafka when `partition_key` is on.

data/Gemfile

@@ -6,12 +6,14 @@ plugin 'diffend'
 
 gemspec
 
+# Relaxed from 2.7 because we support Ruby 3.1
+gem 'zeitwerk', '~> 2.6.18'
+
 group :development do
   gem 'byebug'
 end
 
 group :test do
-  gem 'factory_bot'
   gem 'ostruct'
   gem 'rspec'
   gem 'simplecov'

data/Gemfile.lock

@@ -1,86 +1,81 @@
 PATH
   remote: .
   specs:
-    waterdrop (2.8.2)
-      karafka-core (>= 2.4.3, < 3.0.0)
-      karafka-rdkafka (>= 0.17.5)
+    waterdrop (2.8.4)
+      karafka-core (>= 2.4.9, < 3.0.0)
+      karafka-rdkafka (>= 0.19.2)
       zeitwerk (~> 2.3)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.2.2.1)
-      base64
-      benchmark (>= 0.3)
-      bigdecimal
-      concurrent-ruby (~> 1.0, >= 1.3.1)
-      connection_pool (>= 2.2.5)
-      drb
-      i18n (>= 1.6, < 2)
-      logger (>= 1.4.2)
-      minitest (>= 5.1)
-      securerandom (>= 0.3)
-      tzinfo (~> 2.0, >= 2.0.5)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
-    byebug (11.1.3)
-    concurrent-ruby (1.3.5)
-    connection_pool (2.4.1)
-    diff-lcs (1.5.1)
+    byebug (12.0.0)
+    diff-lcs (1.6.1)
     docile (1.4.1)
-    drb (2.2.1)
-    factory_bot (6.5.1)
-      activesupport (>= 6.1.0)
-    ffi (1.17.0)
-    i18n (1.14.7)
-      concurrent-ruby (~> 1.0)
-    karafka-core (2.4.4)
-      karafka-rdkafka (>= 0.15.0, < 0.18.0)
-    karafka-rdkafka (0.17.6)
+    ffi (1.17.2)
+    ffi (1.17.2-aarch64-linux-gnu)
+    ffi (1.17.2-aarch64-linux-musl)
+    ffi (1.17.2-arm-linux-gnu)
+    ffi (1.17.2-arm-linux-musl)
+    ffi (1.17.2-arm64-darwin)
+    ffi (1.17.2-x86-linux-gnu)
+    ffi (1.17.2-x86-linux-musl)
+    ffi (1.17.2-x86_64-darwin)
+    ffi (1.17.2-x86_64-linux-gnu)
+    ffi (1.17.2-x86_64-linux-musl)
+    karafka-core (2.4.11)
+      karafka-rdkafka (>= 0.17.6, < 0.20.0)
+      logger (>= 1.6.0)
+    karafka-rdkafka (0.20.0.rc2)
       ffi (~> 1.15)
+      logger (>= 1.5)
       mini_portile2 (~> 2.6)
       rake (> 12)
-    logger (1.6.5)
-    mini_portile2 (2.8.7)
-    minitest (5.25.4)
+    logger (1.7.0)
+    mini_portile2 (2.8.8)
     ostruct (0.6.1)
     rake (13.2.1)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.1)
+    rspec-core (3.13.3)
       rspec-support (~> 3.13.0)
     rspec-expectations (3.13.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.1)
+    rspec-mocks (3.13.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.1)
-    securerandom (0.3.2)
+    rspec-support (3.13.2)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    tzinfo (2.0.6)
-      concurrent-ruby (~> 1.0)
     zeitwerk (2.6.18)
 
 PLATFORMS
+  aarch64-linux-gnu
+  aarch64-linux-musl
+  arm-linux-gnu
+  arm-linux-musl
+  arm64-darwin
   ruby
-  x86_64-linux
+  x86-linux-gnu
+  x86-linux-musl
+  x86_64-darwin
+  x86_64-linux-gnu
+  x86_64-linux-musl
 
 DEPENDENCIES
   byebug
-  factory_bot
   ostruct
   rspec
   simplecov
   waterdrop!
+  zeitwerk (~> 2.6.18)
 
 BUNDLED WITH
-   2.5.16
+   2.6.7

data/Rakefile

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'bundler/gem_tasks'

data/bin/verify_topics_naming

@@ -0,0 +1,30 @@
+#!/usr/bin/env ruby
+
+# This script verifies that we do not create (except few needed exceptions) test topics that do
+# not start with the "it-" prefix which is our standard.
+#
+# This ensures that we can clearly identify all test topics for removal in case of doing dev work
+# on a long-lived Kafka cluster without option to fully reset it.
+#
+# It also ensures we have one convention that we can follow.
+
+require 'bundler'
+Bundler.setup(:default, :test, :integrations)
+require 'rdkafka'
+
+admin = Rdkafka::Config.new('bootstrap.servers': 'localhost:9092').admin
+
+invalid = admin
+          .metadata
+          .topics
+          .map { |topic| topic[:topic_name] }
+          .select { |topic| !topic.start_with?('it-') }
+          .select { |topic| topic.length <= 6 }
+
+admin.close
+
+invalid.each do |invalid_name|
+  puts "#{invalid_name} does not start with the \"it-\" prefix"
+end
+
+exit invalid.empty? ? 0 : 1

data/config/locales/errors.yml

@@ -39,7 +39,7 @@ en:
       key_format: must be a non-empty string
       payload_max_size: is more than `max_payload_size` config value
       headers_invalid_key_type: all headers keys need to be of type String
-      headers_invalid_value_type: all headers values need to be of type String
+      headers_invalid_value_type: all headers values need to be strings or arrays of strings
 
     transactional_offset:
       consumer_format: 'must respond to #consumer_group_metadata_pointer method'

data/docker-compose.yml

@@ -1,7 +1,7 @@
 services:
   kafka:
     container_name: kafka
-    image: confluentinc/cp-kafka:7.8.1
+    image: confluentinc/cp-kafka:7.9.1
 
     ports:
       - 9092:9092

data/lib/waterdrop/contracts/message.rb

@@ -46,7 +46,12 @@ module WaterDrop
 
         message.fetch(:headers).each do |key, value|
           errors << [%i[headers], :invalid_key_type] unless key.is_a?(String)
-          errors << [%i[headers], :invalid_value_type] unless value.is_a?(String)
+
+          # Headers can be either strings or arrays of strings
+          next if value.is_a?(String)
+          next if value.is_a?(Array) && value.all? { |value| value.is_a?(String) }
+
+          errors << [%i[headers], :invalid_value_type]
         end
 
         errors

data/lib/waterdrop/version.rb

@@ -3,5 +3,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '2.8.2'
+  VERSION = '2.8.4'
 end

data/renovate.json

@@ -1,6 +1,18 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
   "extends": [
-    "config:base"
+    "config:recommended"
+  ],
+  "github-actions": {
+    "enabled": true,
+    "pinDigests": true
+  },
+  "packageRules": [
+    {
+      "matchManagers": [
+        "github-actions"
+      ],
+      "minimumReleaseAge": "7 days"
+    }
   ]
 }

data/waterdrop.gemspec

@@ -16,17 +16,12 @@ Gem::Specification.new do |spec|
   spec.description   = spec.summary
   spec.licenses      = %w[LGPL-3.0-only Commercial]
 
-  spec.add_dependency 'karafka-core', '>= 2.4.3', '< 3.0.0'
-  spec.add_dependency 'karafka-rdkafka', '>= 0.17.5'
+  spec.add_dependency 'karafka-core', '>= 2.4.9', '< 3.0.0'
+  spec.add_dependency 'karafka-rdkafka', '>= 0.19.2'
   spec.add_dependency 'zeitwerk', '~> 2.3'
 
   spec.required_ruby_version = '>= 3.1.0'
 
-  if $PROGRAM_NAME.end_with?('gem')
-    spec.signing_key = File.expand_path('~/.ssh/gem-private_key.pem')
-  end
-
-  spec.cert_chain    = %w[certs/cert.pem]
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec)/}) }
   spec.executables   = []
   spec.require_paths = %w[lib]

metadata

@@ -1,40 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 2.8.2
+  version: 2.8.4
 platform: ruby
 authors:
 - Maciej Mensfeld
 bindir: bin
-cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIEcDCCAtigAwIBAgIBATANBgkqhkiG9w0BAQsFADA/MRAwDgYDVQQDDAdjb250
-  YWN0MRcwFQYKCZImiZPyLGQBGRYHa2FyYWZrYTESMBAGCgmSJomT8ixkARkWAmlv
-  MB4XDTI0MDgyMzEwMTkyMFoXDTQ5MDgxNzEwMTkyMFowPzEQMA4GA1UEAwwHY29u
-  dGFjdDEXMBUGCgmSJomT8ixkARkWB2thcmFma2ExEjAQBgoJkiaJk/IsZAEZFgJp
-  bzCCAaIwDQYJKoZIhvcNAQEBBQADggGPADCCAYoCggGBAKjLhLjQqUlNayxkXnO+
-  PsmCDs/KFIzhrsYMfLZRZNaWmzV3ujljMOdDjd4snM2X06C41iVdQPWjpe3j8vVe
-  ZXEWR/twSbOP6Eeg8WVH2wCOo0x5i7yhVn4UBLH4JpfEMCbemVcWQ9ry9OMg4WpH
-  Uu4dRwxFV7hzCz3p0QfNLRI4miAxnGWcnlD98IJRjBAksTuR1Llj0vbOrDGsL9ZT
-  JeXP2gdRLd8SqzAFJEWrbeTBCBU7gfSh3oMg5SVDLjaqf7Kz5wC/8bDZydzanOxB
-  T6CDXPsCnllmvTNx2ei2T5rGYJOzJeNTmJLLK6hJWUlAvaQSvCwZRvFJ0tVGLEoS
-  flqSr6uGyyl1eMUsNmsH4BqPEYcAV6P2PKTv2vUR8AP0raDvZ3xL1TKvfRb8xRpo
-  vPopCGlY5XBWEc6QERHfVLTIVsjnls2/Ujj4h8/TSfqqYnaHKefIMLbuD/tquMjD
-  iWQsW2qStBV0T+U7FijKxVfrfqZP7GxQmDAc9o1iiyAa3QIDAQABo3cwdTAJBgNV
-  HRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHQ4EFgQU3O4dTXmvE7YpAkszGzR9DdL9
-  sbEwHQYDVR0RBBYwFIESY29udGFjdEBrYXJhZmthLmlvMB0GA1UdEgQWMBSBEmNv
-  bnRhY3RAa2FyYWZrYS5pbzANBgkqhkiG9w0BAQsFAAOCAYEAVKTfoLXn7mqdSxIR
-  eqxcR6Huudg1jes81s1+X0uiRTR3hxxKZ3Y82cPsee9zYWyBrN8TA4KA0WILTru7
-  Ygxvzha0SRPsSiaKLmgOJ+61ebI4+bOORzIJLpD6GxCxu1r7MI4+0r1u1xe0EWi8
-  agkVo1k4Vi8cKMLm6Gl9b3wG9zQBw6fcgKwmpjKiNnOLP+OytzUANrIUJjoq6oal
-  TC+f/Uc0TLaRqUaW/bejxzDWWHoM3SU6aoLPuerglzp9zZVzihXwx3jPLUVKDFpF
-  Rl2lcBDxlpYGueGo0/oNzGJAAy6js8jhtHC9+19PD53vk7wHtFTZ/0ugDQYnwQ+x
-  oml2fAAuVWpTBCgOVFe6XCQpMKopzoxQ1PjKztW2KYxgJdIBX87SnL3aWuBQmhRd
-  i9zWxov0mr44TWegTVeypcWGd/0nxu1+QHVNHJrpqlPBRvwQsUm7fwmRInGpcaB8
-  ap8wNYvryYzrzvzUxIVFBVM5PacgkFqRmolCa8I7tdKQN+R1
-  -----END CERTIFICATE-----
-date: 2025-02-13 00:00:00.000000000 Z
+cert_chain: []
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: karafka-core
@@ -42,7 +15,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.3
+        version: 2.4.9
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -52,7 +25,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.3
+        version: 2.4.9
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -62,14 +35,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.5
+        version: 0.19.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.17.5
+        version: 0.19.2
 - !ruby/object:Gem::Dependency
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
@@ -93,10 +66,13 @@ extra_rdoc_files: []
 files:
 - ".coditsu/ci.yml"
 - ".diffend.yml"
+- ".github/CODEOWNERS"
 - ".github/FUNDING.yml"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/workflows/ci.yml"
+- ".github/workflows/push.yml"
+- ".github/workflows/verify-action-pins.yml"
 - ".gitignore"
 - ".rspec"
 - ".ruby-gemset"
@@ -106,8 +82,9 @@ files:
 - Gemfile.lock
 - LICENSE
 - README.md
+- Rakefile
 - bin/verify_kafka_warnings
-- certs/cert.pem
+- bin/verify_topics_naming
 - config/locales/errors.yml
 - docker-compose.yml
 - lib/waterdrop.rb
@@ -170,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Kafka messaging made easy!
 test_files: []

data/certs/cert.pem

@@ -1,26 +0,0 @@
------BEGIN CERTIFICATE-----
-MIIEcDCCAtigAwIBAgIBATANBgkqhkiG9w0BAQsFADA/MRAwDgYDVQQDDAdjb250
-YWN0MRcwFQYKCZImiZPyLGQBGRYHa2FyYWZrYTESMBAGCgmSJomT8ixkARkWAmlv
-MB4XDTI0MDgyMzEwMTkyMFoXDTQ5MDgxNzEwMTkyMFowPzEQMA4GA1UEAwwHY29u
-dGFjdDEXMBUGCgmSJomT8ixkARkWB2thcmFma2ExEjAQBgoJkiaJk/IsZAEZFgJp
-bzCCAaIwDQYJKoZIhvcNAQEBBQADggGPADCCAYoCggGBAKjLhLjQqUlNayxkXnO+
-PsmCDs/KFIzhrsYMfLZRZNaWmzV3ujljMOdDjd4snM2X06C41iVdQPWjpe3j8vVe
-ZXEWR/twSbOP6Eeg8WVH2wCOo0x5i7yhVn4UBLH4JpfEMCbemVcWQ9ry9OMg4WpH
-Uu4dRwxFV7hzCz3p0QfNLRI4miAxnGWcnlD98IJRjBAksTuR1Llj0vbOrDGsL9ZT
-JeXP2gdRLd8SqzAFJEWrbeTBCBU7gfSh3oMg5SVDLjaqf7Kz5wC/8bDZydzanOxB
-T6CDXPsCnllmvTNx2ei2T5rGYJOzJeNTmJLLK6hJWUlAvaQSvCwZRvFJ0tVGLEoS
-flqSr6uGyyl1eMUsNmsH4BqPEYcAV6P2PKTv2vUR8AP0raDvZ3xL1TKvfRb8xRpo
-vPopCGlY5XBWEc6QERHfVLTIVsjnls2/Ujj4h8/TSfqqYnaHKefIMLbuD/tquMjD
-iWQsW2qStBV0T+U7FijKxVfrfqZP7GxQmDAc9o1iiyAa3QIDAQABo3cwdTAJBgNV
-HRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHQ4EFgQU3O4dTXmvE7YpAkszGzR9DdL9
-sbEwHQYDVR0RBBYwFIESY29udGFjdEBrYXJhZmthLmlvMB0GA1UdEgQWMBSBEmNv
-bnRhY3RAa2FyYWZrYS5pbzANBgkqhkiG9w0BAQsFAAOCAYEAVKTfoLXn7mqdSxIR
-eqxcR6Huudg1jes81s1+X0uiRTR3hxxKZ3Y82cPsee9zYWyBrN8TA4KA0WILTru7
-Ygxvzha0SRPsSiaKLmgOJ+61ebI4+bOORzIJLpD6GxCxu1r7MI4+0r1u1xe0EWi8
-agkVo1k4Vi8cKMLm6Gl9b3wG9zQBw6fcgKwmpjKiNnOLP+OytzUANrIUJjoq6oal
-TC+f/Uc0TLaRqUaW/bejxzDWWHoM3SU6aoLPuerglzp9zZVzihXwx3jPLUVKDFpF
-Rl2lcBDxlpYGueGo0/oNzGJAAy6js8jhtHC9+19PD53vk7wHtFTZ/0ugDQYnwQ+x
-oml2fAAuVWpTBCgOVFe6XCQpMKopzoxQ1PjKztW2KYxgJdIBX87SnL3aWuBQmhRd
-i9zWxov0mr44TWegTVeypcWGd/0nxu1+QHVNHJrpqlPBRvwQsUm7fwmRInGpcaB8
-ap8wNYvryYzrzvzUxIVFBVM5PacgkFqRmolCa8I7tdKQN+R1
------END CERTIFICATE-----