waterdrop 2.7.0.rc1 → 2.7.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e715326d8ff0715491d71ec9f42c60eb049258a9b5eaf739a0b088cf515427dd
-  data.tar.gz: ed94552c972a77b5509907f59910d9ad37f033b718666d5520335bbb7f5d545f
+  metadata.gz: 1b34784c24ea856bc39203d722b386282960a3387b34171a6911d030a70b308f
+  data.tar.gz: fc095eae32f55193b98b3d1d9f13b96cdc74eaa9d2e25d50e773046e4749843a
 SHA512:
-  metadata.gz: 460c2e3f8989059293835af6f5a96c5c3af68a4f47608d98d22a217cfd15179edd8a834e8c621ff10ae894c5713878c833f23a6af47d83cfc215454326aabc37
-  data.tar.gz: 67d497d37e6be9593dbe14bfb0d4df7d8c80c18f176dda66987a372acaffa68f172ae415d9797b713af0c67f6127113bd49a6ebb7a778eec4f8b69b864bceea7
+  metadata.gz: aaec4c4216c2c8360c5a6b17e5a33fc726ee5fa6220d496216d1181c535b5755c4b6a51a28c9ff72757768c3c513cc3e81a3d3cad24a532d6cebe1a7bf2e8e1c
+  data.tar.gz: 8589024b7bcbd01f4c0f41c85224ace586dbe5e0a4679fe68abbdf66b9d49ff279ee44f15887cc864e50f0bc28302095c87e6d0863561db258db3e95e7507ad5

data/CHANGELOG.md

@@ -9,13 +9,33 @@ This release contains **BREAKING** changes. Make sure to read and apply upgrade
 - **[Breaking]** Change default timeouts so final delivery `message.timeout.ms` is less that `max_wait_time` so we do not end up with not final verdict.
 - **[Breaking]** Update all the time related configuration settings to be in `ms` and not mixed.
 - **[Breaking]** Remove no longer needed `wait_timeout` configuration option.
+- **[Breaking]** Do **not** validate or morph (via middleware) messages added to the buffer prior to `flush_sync` or `flush_async`.
 - [Enhancement] Provide `WaterDrop::Producer#transaction?` that returns only when producer has an active transaction running.
 - [Enhancement] Introduce `instrument_on_wait_queue_full` flag (defaults to `true`) to be able to configure whether non critical (retryable) queue full errors should be instrumented in the error pipeline. Useful when building high-performance pipes with WaterDrop queue retry backoff as a throttler.
+- [Enhancement] Treat the queue size as a gauge rather than a cumulative stat (isturdy).
+- [Fix] Fix a case where purge on non-initialized client would crash.
+- [Fix] Middlewares run twice when using buffered produce.
+- [Fix] Validations run twice when using buffered produce.
 
 ### Upgrade Notes
 
 **PLEASE MAKE SURE TO READ AND APPLY THEM!**
 
+#### `wait_timeout` Configuration No Longer Needed
+
+The `wait_timeout` WaterDrop configuration option is no longer needed. You can safely remove it.
+
+```ruby
+producer = WaterDrop::Producer.new
+
+producer.setup do |config|
+  # Other config...
+
+  # Remove this, no longer needed
+  config.wait_timeout = 30
+end
+```
+
 #### Time Settings Format Alignment
 
 **All** time-related values are now configured in milliseconds instead of some being in seconds and some in milliseconds.
@@ -23,7 +43,6 @@ This release contains **BREAKING** changes. Make sure to read and apply upgrade
 The values that were changed from seconds to milliseconds are:
 
 - `max_wait_timeout`
-- `wait_timeout`
 - `wait_backoff_on_queue_full`
 - `wait_timeout_on_queue_full`
 - `wait_backoff_on_transaction_command, default`
@@ -37,10 +56,10 @@ producer.setup do |config|
   config.deliver = true
 
   # Replace this:
-  config.wait_timeout = 30
+  config.max_wait_timeout = 30
 
   # With
-  config.wait_timeout = 30_000
+  config.max_wait_timeout = 30_000
   # ...
 end
 ```
@@ -82,6 +101,32 @@ Below, you can find a table with what has changed, the new defaults, and the cur
 
 This alignment ensures that when using sync operations or invoking `#wait`, any exception you get should give you a conclusive and final delivery verdict.
 
+#### Buffering No Longer Early Validates Messages
+
+As of version `2.7.0`, WaterDrop has changed how message buffering works. Previously, messages underwent validation and middleware processing when they were buffered. Now, these steps are deferred until just before dispatching the messages. The buffer functions strictly as a thread-safe storage area without performing any validations or middleware operations until the messages are ready to be sent.
+
+This adjustment was made primarily to ensure that middleware runs and validations are applied when most relevant—shortly before message dispatch. This approach addresses potential issues with buffers that might hold messages for extended periods:
+
+- **Temporal Relevance**: Validating and processing messages near their dispatch time helps ensure that actions such as partition assignments reflect the current system state. This is crucial in dynamic environments where system states are subject to rapid changes.
+
+- **Stale State Management**: By delaying validations and middleware to the dispatch phase, the system minimizes the risk of acting on outdated information, which could lead to incorrect processing or partitioning decisions.
+
+```ruby
+# Prior to 2.7.0 this would raise an error
+producer.buffer(topic: nil, payload: '')
+# => WaterDrop::Errors::MessageInvalidError
+
+# After 2.7.0 buffer will not, but flush_async will
+producer.buffer(topic: nil, payload: '')
+# => all good here
+producer.flush_async(topic: nil, payload: '')
+# => WaterDrop::Errors::MessageInvalidError
+```
+
+#### Middleware Execution Prior to Flush When Buffering
+
+The timing of middleware execution has been adjusted. Middleware, which was previously run when messages were added to the buffer, will now only execute immediately before the messages are flushed from the buffer and dispatched. This change is similar to the validation-related changes.
+
 ## 2.6.14 (2024-02-06)
 - [Enhancement] Instrument `producer.connected` and `producer.closing` lifecycle events.
 

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    waterdrop (2.7.0.rc1)
-      karafka-core (>= 2.4.0.rc1, < 3.0.0)
+    waterdrop (2.7.0.rc2)
+      karafka-core (>= 2.4.0.rc2, < 3.0.0)
       zeitwerk (~> 2.3)
 
 GEM
@@ -31,9 +31,9 @@ GEM
     ffi (1.16.3)
     i18n (1.14.4)
       concurrent-ruby (~> 1.0)
-    karafka-core (2.4.0.rc1)
-      karafka-rdkafka (>= 0.15.0.rc1, < 0.16.0)
-    karafka-rdkafka (0.15.0.rc1)
+    karafka-core (2.4.0.rc2)
+      karafka-rdkafka (>= 0.15.0.rc2, < 0.16.0)
+    karafka-rdkafka (0.15.0.rc2)
       ffi (~> 1.15)
       mini_portile2 (~> 2.6)
       rake (> 12)

data/docker-compose.yml

@@ -3,7 +3,7 @@ version: '2'
 services:
   kafka:
     container_name: kafka
-    image: confluentinc/cp-kafka:7.6.0
+    image: confluentinc/cp-kafka:7.6.1
 
     ports:
       - 9092:9092

data/lib/waterdrop/instrumentation/vendors/datadog/metrics_listener.rb

@@ -36,7 +36,7 @@ module WaterDrop
           setting :rd_kafka_metrics, default: [
             # Client metrics
             RdKafkaMetric.new(:count, :root, 'calls', 'tx_d'),
-            RdKafkaMetric.new(:histogram, :root, 'queue.size', 'msg_cnt_d'),
+            RdKafkaMetric.new(:histogram, :root, 'queue.size', 'msg_cnt'),
 
             # Broker metrics
             RdKafkaMetric.new(:count, :brokers, 'deliver.attempts', 'txretries_d'),

data/lib/waterdrop/producer/buffer.rb

@@ -12,9 +12,6 @@ module WaterDrop
       def buffer(message)
         ensure_active!
 
-        message = middleware.run(message)
-        validate_message!(message)
-
         @monitor.instrument(
           'message.buffered',
           producer_id: id,
@@ -32,9 +29,6 @@ module WaterDrop
       def buffer_many(messages)
         ensure_active!
 
-        messages = middleware.run_many(messages)
-        messages.each { |message| validate_message!(message) }
-
         @monitor.instrument(
           'messages.buffered',
           producer_id: id,

data/lib/waterdrop/producer.rb

@@ -133,7 +133,12 @@ module WaterDrop
           @messages = []
         end
 
-        @client.purge
+        # We should not purge if there is no client initialized
+        # It may not be initialized if we created a new producer that never connected to kafka,
+        # we used buffer and purged. In cases like this client won't exist
+        @connecting_mutex.synchronize do
+          @client&.purge
+        end
       end
     end
 

data/lib/waterdrop/version.rb

@@ -3,5 +3,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '2.7.0.rc1'
+  VERSION = '2.7.0.rc2'
 end

data/waterdrop.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
   spec.description   = spec.summary
   spec.license       = 'MIT'
 
-  spec.add_dependency 'karafka-core', '>= 2.4.0.rc1', '< 3.0.0'
+  spec.add_dependency 'karafka-core', '>= 2.4.0.rc2', '< 3.0.0'
   spec.add_dependency 'zeitwerk', '~> 2.3'
 
   spec.required_ruby_version = '>= 3.0.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 2.7.0.rc1
+  version: 2.7.0.rc2
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -35,7 +35,7 @@ cert_chain:
   AnG1dJU+yL2BK7vaVytLTstJME5mepSZ46qqIJXMuWob/YPDmVaBF39TDSG9e34s
   msG3BiCqgOgHAnL23+CN3Rt8MsuRfEtoTKpJVcCfoEoNHOkc
   -----END CERTIFICATE-----
-date: 2024-04-10 00:00:00.000000000 Z
+date: 2024-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: karafka-core
@@ -43,7 +43,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.0.rc1
+        version: 2.4.0.rc2
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -53,7 +53,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.0.rc1
+        version: 2.4.0.rc2
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0