waterdrop 2.7.0.alpha1 → 2.7.0.alpha3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 938018b39bca57a68925d61e00a1347c34d3ad536fb73c910589065fc8e6cbca
-  data.tar.gz: cdad580ebf6e91d51464fb2336f9c78896f3d1b03e96919463c99f141b5dc5ff
+  metadata.gz: 3a30c157d6e57db9b04d59f4478cff152bc07ea4ed6462c7b9654ffd695b3655
+  data.tar.gz: 96b6c4d6d9b00c24a1e4aef685335d46daf9bd536ad11ef5ddd983ad1eaa97bc
 SHA512:
-  metadata.gz: 15e328bfe3135a14b3f61019185bcbb88c56ed2ed01e2a6523439229ee709940c0f38e4d2259e208c785fb06c2326fb290423c88d5213f730120b0a11ea8a152
-  data.tar.gz: f6642bb5dbc1cb84e923bc5bdc43417bf3f88215eab4a537e3fa14290726e935a45aec0cf640962f3e48615310d639ed1f592cf324b9963e1ff1dc0dabb8cbe2
+  metadata.gz: d154491762173b4632d5294186dc97c835d90c6ed8bc3a229500ef698833f1b8304bd3c554c592af138d9fe56694dced89adb78bb4c64ea9ef00679209b9ac24
+  data.tar.gz: 721ab6abdfcdbc028200c6c1b8032f5036c661b1e02b1685f4733f9f060ee8465a53ea0e8e0e6c67c01ef59ce12d01aa499ba9406173aea4e20179f74ec5ec81

data/CHANGELOG.md

@@ -7,6 +7,7 @@ This release contains **BREAKING** changes. Make sure to read and apply upgrade
 - **[Breaking]** Drop Ruby `2.7` support.
 - **[Breaking]** Change default timeouts so final delivery `message.timeout.ms` is less that `max_wait_time` so we do not end up with not final verdict.
 - **[Breaking]** Update all the time related configuration settings to be in `ms` and not mixed.
+- **[Breaking]** Remove no longer needed `wait_timeout` configuration option.
 - [Enhancement] Introduce `instrument_on_wait_queue_full` flag (defaults to `true`) to be able to configure whether non critical (retryable) queue full errors should be instrumented in the error pipeline. Useful when building high-performance pipes with WaterDrop queue retry backoff as a throttler.
 
 ### Upgrade Notes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    waterdrop (2.7.0.alpha1)
+    waterdrop (2.7.0.alpha3)
       karafka-core (>= 2.4.0.alpha1, < 3.0.0)
       zeitwerk (~> 2.3)
 

data/config/locales/errors.yml

@@ -6,7 +6,6 @@ en:
       deliver_format: must be boolean
       id_format: must be a non-empty string
       max_payload_size_format: must be an integer that is equal or bigger than 1
-      wait_timeout_format: must be a numeric that is bigger than 0
       max_wait_timeout_format: must be an integer that is equal or bigger than 0
       kafka_format: must be a hash with symbol based keys
       kafka_key_must_be_a_symbol: All keys under the kafka settings scope need to be symbols

data/lib/waterdrop/config.rb

@@ -13,11 +13,11 @@ module WaterDrop
       # emit librdkafka statistics every five seconds. This is used in instrumentation.
       # When disabled, part of metrics will not be published and available.
       'statistics.interval.ms': 5_000,
-      # We set it to a value that is lower than `max_wait_time` to have a final verdict upon sync
-      # delivery
-      'message.timeout.ms': 55_000,
-      # Must be less or equal to `message.timeout.ms` defaults
-      'transaction.timeout.ms': 45_000
+      # We set it to a value that is lower than `max_wait_timeout` to have a final verdict upon
+      # sync delivery
+      'message.timeout.ms': 50_000,
+      # Must be more or equal to `message.timeout.ms` defaults
+      'transaction.timeout.ms': 55_000
     }.freeze
 
     private_constant :KAFKA_DEFAULTS
@@ -51,10 +51,6 @@ module WaterDrop
     # option [Integer] Wait that long for the delivery report or raise an error if this takes
     #   longer than the timeout ms.
     setting :max_wait_timeout, default: 60_000
-    # option [Numeric] how long should we wait between re-checks on the availability of the
-    #   delivery report. In a really robust systems, this describes the min-delivery time
-    #   for a single sync message when produced in isolation
-    setting :wait_timeout, default: 5 # 5 milliseconds
     # option [Boolean] should we upon detecting full librdkafka queue backoff and retry or should
     #   we raise an exception.
     #   When this is set to `true`, upon full queue, we won't raise an error. There will be error

data/lib/waterdrop/contracts/config.rb

@@ -17,7 +17,6 @@ module WaterDrop
       required(:deliver) { |val| [true, false].include?(val) }
       required(:max_payload_size) { |val| val.is_a?(Integer) && val >= 1 }
       required(:max_wait_timeout) { |val| val.is_a?(Numeric) && val >= 0 }
-      required(:wait_timeout) { |val| val.is_a?(Numeric) && val.positive? }
       required(:kafka) { |val| val.is_a?(Hash) && !val.empty? }
       required(:wait_on_queue_full) { |val| [true, false].include?(val) }
       required(:wait_backoff_on_queue_full) { |val| val.is_a?(Numeric) && val >= 0 }

data/lib/waterdrop/producer.rb

@@ -250,8 +250,7 @@ module WaterDrop
     def wait(handler)
       handler.wait(
         # rdkafka max_wait_timeout is in seconds and we use ms
-        max_wait_timeout: @config.max_wait_timeout / 1_000.0,
-        wait_timeout: @config.wait_timeout / 1_000.0
+        max_wait_timeout: @config.max_wait_timeout / 1_000.0
       )
     end
 

data/lib/waterdrop/version.rb

@@ -3,5 +3,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '2.7.0.alpha1'
+  VERSION = '2.7.0.alpha3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: waterdrop
 version: !ruby/object:Gem::Version
-  version: 2.7.0.alpha1
+  version: 2.7.0.alpha3
 platform: ruby
 authors:
 - Maciej Mensfeld