watchdog 0.2.0 → 0.3.0

data/CHANGELOG.txt

@@ -1,3 +1,6 @@
+== 0.3.0
+* Add Watchdog.sleep
+
 == 0.2.0
 * Fix multiple guards per extended class
 * Fix guarding for subclasses of extended classes

data/README.md

@@ -59,6 +59,15 @@ Watchdog also guards over extension modules that define class methods:
     Date.extend DaysTillXmas
     # Date.days_till_xmas ->  253  NOOOO...
 
+Caveats
+=======
+
+Watchdog's protectiveness can be problematic with mocks in a test suite as they love to redefine
+methods. Watchdog provides Watchdog.sleep, a Proc to conditionally turn off guarding extension
+methods. By default, Watchdog sets this so that Rspec mocks are allowed to slip by:
+
+    Watchdog.sleep = lambda { defined? RSpec && !caller.grep(/rspec-mocks/).empty? }
+
 Credits
 =======
 

data/lib/watchdog.rb

@@ -3,12 +3,14 @@ require 'watchdog/german_shepard'
 require 'watchdog/version'
 
 module Watchdog
-  class <<self; attr_accessor :extensions, :subclasses; end
+  class <<self; attr_accessor :extensions, :subclasses, :sleep; end
   self.extensions, self.subclasses = {}, []
+  # sleep when rspec mocks redefine guarded methods
+  self.sleep = lambda { defined? RSpec && !caller.grep(/rspec-mocks/).empty? }
 
   # Guards extension methods from being overwritten
   def self.guard(obj, meth)
-    return if subclasses.include?(obj)
+    return if subclasses.include?(obj) || (sleep && sleep.call)
     return subclasses << obj if !extensions.key?(obj) && extensions.keys.
       any? {|e| e.is_a?(Module) && e > obj }
     if extensions[obj].instance_methods.map(&:to_sym).include?(meth)

data/lib/watchdog/version.rb

@@ -1,3 +1,3 @@
 module Watchdog
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/spec/watchdog_spec.rb

@@ -1,4 +1,5 @@
 require 'watchdog'
+Watchdog.sleep = nil
 
 describe Watchdog do
   def create_methods(obj, *meths)
@@ -103,5 +104,23 @@ describe Watchdog do
       existing.send :include, another_extensions
       Watchdog::GermanShepard.created.size.should == 1
     end
+
+    context ".sleep" do
+      def redefined_method
+        existing = Class.new.send :include, extensions
+        lambda { existing.send(:define_method, :blah) { } }
+      end
+      after { Watchdog.sleep = nil }
+
+      it "ignores error if it evaluates to true" do
+        Watchdog.sleep = lambda { true }
+        redefined_method.should_not raise_error
+      end
+
+      it "ignores error if set to false" do
+        Watchdog.sleep = false
+        redefined_method.should raise_error Watchdog::ExtensionMethodExistsError
+      end
+    end
   end
 end

metadata

@@ -2,7 +2,7 @@
 name: watchdog
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Gabriel Horner
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-17 00:00:00 -04:00
+date: 2011-04-20 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency