warp 1.3.3 → 1.4.0

data/spec/warp/controller_matchers/assign_matcher_spec.rb

@@ -4,12 +4,12 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
   with_contexts do
     context "with implicit controller" do
       build_controller(:controller)
-      
+
       let(:_controller) { controller }
 
       subject { matcher.tap {|m| m.matches?(Object.new) } }
     end
-    
+
     context "with explicit controller" do
       build_controller(:other_controller)
       let(:controller) { double("fake controller") }
@@ -18,7 +18,7 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
 
       subject { matcher.tap {|m| m.matches?(other_controller) } }
     end
-    
+
     behaviour do
       let(:matcher) { assign(:assign) }
 
@@ -34,7 +34,7 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
         end
 
         specify { expect(subject).to match(_controller) }
-      
+
         describe_failure_message_when_negated do
           specify { expect(subject).to eq "expected @assign to not be assigned" }
         end
@@ -46,18 +46,13 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
         end
 
         specify { expect(subject).to_not match(_controller) }
-        
+
         describe_failure_message do
           specify { expect(subject).to eq "expected @assign to be assigned" }
         end
       end
 
       describe "#with" do
-        controller_action do
-          @assign = spec.actual_assign_value
-        end
-
-        let(:actual_assign_value) { "foobar" }
         let(:expected_assign_value) { "foobar" }
 
         let(:matcher) { super().with(expected_assign_value) }
@@ -68,32 +63,47 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
           specify { expect(subject).to eq "assign @assign with #{expected_assign_value.inspect}" }
         end
 
-        context "with the right value" do
-          specify { expect(subject).to match(_controller) }
-        
-          describe_failure_message_when_negated do
-            specify { expect(subject).to eq "expected @assign to not be assigned with #{expected_assign_value.inspect}" }
+        context "when assigned" do
+          controller_action do
+            @assign = spec.actual_assign_value
+          end
+
+          context "with the right value" do
+            let(:actual_assign_value) { expected_assign_value }
+
+            specify { expect(subject).to match(_controller) }
+
+            describe_failure_message_when_negated do
+              specify { expect(subject).to eq "expected @assign to not be assigned with #{expected_assign_value.inspect}" }
+            end
+          end
+
+          context "with the wrong value" do
+            let(:actual_assign_value) { "foobaz" }
+
+            specify { expect(subject).to_not match(_controller) }
+
+            describe_failure_message do
+              specify { expect(subject).to eq "expected @assign to be assigned with #{expected_assign_value.inspect} but was assigned with #{actual_assign_value.inspect}" }
+            end
           end
         end
 
-        context "with the wrong value" do
-          let(:expected_assign_value) { "foobaz" }
+        context "when not assigned" do
+          controller_action do
+            # no assign
+          end
 
           specify { expect(subject).to_not match(_controller) }
-          
+
           describe_failure_message do
-            specify { expect(subject).to eq "expected @assign to be assigned with #{expected_assign_value.inspect} but was assigned with #{actual_assign_value.inspect}" }
+            specify { expect(subject).to eq "expected @assign to be assigned with #{expected_assign_value.inspect} but was not assigned" }
           end
         end
       end
 
       describe "#with_a" do
-        controller_action do
-          @assign = spec.actual_assign_class.new
-        end
-
-        let(:actual_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "FooClass" } } }
-        let(:expected_assign_class) { actual_assign_class }
+        let(:expected_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "FooClass" } } }
 
         let(:matcher) { super().with_a(expected_assign_class) }
 
@@ -103,40 +113,48 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
           specify { expect(subject).to eq "assign @assign with an instance of #{expected_assign_class.name}" }
         end
 
-        context "with the right class" do
-          specify { expect(subject).to match(_controller) }
-            
-          describe_failure_message_when_negated do
-            specify { expect(subject).to eq "expected @assign to not be assigned with an instance of #{expected_assign_class.name}" }
+        context "when assigned" do
+          controller_action do
+            @assign = spec.actual_assign_class.new
+          end
+
+          context "with the right class" do
+            let(:actual_assign_class) { expected_assign_class }
+
+            specify { expect(subject).to match(_controller) }
+
+            describe_failure_message_when_negated do
+              specify { expect(subject).to eq "expected @assign to not be assigned with an instance of #{expected_assign_class.name}" }
+            end
+          end
+
+          context "with the wrong class" do
+            let(:actual_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "BarClass" } } }
+
+            specify { expect(subject).to_not match(_controller) }
+
+            describe_failure_message do
+              specify { expect(subject).to eq "expected @assign to be assigned with an instance of #{expected_assign_class.name} but was assigned with an instance of #{actual_assign_class.name}"
+       }
+            end
           end
         end
 
-        context "with the wrong class" do
-          let(:expected_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "BarClass" } } }
+        context "when not assigned" do
+          controller_action do
+            # no assign
+          end
 
           specify { expect(subject).to_not match(_controller) }
-          
+
           describe_failure_message do
-            specify { expect(subject).to eq "expected @assign to be assigned with an instance of #{expected_assign_class.name} but was assigned with an instance of #{actual_assign_class.name}"
-     }
+            specify { expect(subject).to eq "expected @assign to be assigned with an instance of #{expected_assign_class.name} but was not assigned" }
           end
         end
       end
 
       describe "#with_a_new" do
-        controller_action do
-          @assign = spec.actual_assign_class.new
-        end
-
-        let(:actual_persisted?) { false }
-        let(:actual_assign_class) do
-          Class.new.tap do |klass| 
-            allow(klass).to receive(:name) { "FooClass" }
-            allow_any_instance_of(klass).to receive(:persisted?) { actual_persisted? }
-          end
-        end
-
-        let(:expected_assign_class) { actual_assign_class }
+        let(:expected_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "FooClass" } } }
 
         let(:matcher) { super().with_a_new(expected_assign_class) }
 
@@ -146,64 +164,90 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
           specify { expect(subject).to eq "assign @assign with a new instance of #{expected_assign_class.name}" }
         end
 
-        context "with a new object" do
-          let(:actual_persisted?) { false }
+        context "when assigned" do
+          controller_action do
+            @assign = spec.actual_assign_class.new
+          end
 
-          context "with the right class" do
-            specify { expect(subject).to match(_controller) }
+          let(:actual_assign_class) { expected_assign_class }
 
-            describe_failure_message_when_negated do
-              specify { expect(subject).to eq "expected @assign to not be assigned with a new instance of #{expected_assign_class.name}" }
+          before do
+            actual_assign_class.tap do |klass|
+              allow_any_instance_of(klass).to receive(:persisted?) { actual_persisted? }
             end
           end
 
-          context "with a descendant class" do
-            let(:actual_assign_class) do
-              Class.new(super())
+          context "with a new object" do
+            let(:actual_persisted?) { false }
+
+            context "with the right class" do
+              specify { expect(subject).to match(_controller) }
+
+              describe_failure_message_when_negated do
+                specify { expect(subject).to eq "expected @assign to not be assigned with a new instance of #{expected_assign_class.name}" }
+              end
             end
 
-            specify { expect(subject).to match(_controller) }
+            context "with a descendant class" do
+              let(:actual_assign_class) do
+                Class.new(super())
+              end
 
-            describe_failure_message_when_negated do
-              specify { expect(subject).to eq "expected @assign to not be assigned with a new instance of #{expected_assign_class.name}" }
-            end 
-          end
+              specify { expect(subject).to match(_controller) }
 
-          context "with the wrong class" do
-            let(:expected_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "BarClass" } } }
+              describe_failure_message_when_negated do
+                specify { expect(subject).to eq "expected @assign to not be assigned with a new instance of #{expected_assign_class.name}" }
+              end
+            end
 
-            specify { expect(subject).to_not match(_controller) }
-            
-            describe_failure_message do
-              specify { expect(subject).to eq "expected @assign to be assigned with a new instance of #{expected_assign_class.name} but was assigned with a new instance of #{actual_assign_class.name}"
-       }
+            context "with the wrong class" do
+              let(:actual_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "BarClass" } } }
+
+              specify { expect(subject).to_not match(_controller) }
+
+              describe_failure_message do
+                specify { expect(subject).to eq "expected @assign to be assigned with a new instance of #{expected_assign_class.name} but was assigned with a new instance of #{actual_assign_class.name}"
+         }
+              end
             end
           end
-        end
 
-        context "with a persisted object" do
-          let(:actual_persisted?) { true }
+          context "with a persisted object" do
+            let(:actual_persisted?) { true }
 
-          context "with the right class" do
-            specify { expect(subject).to_not match(_controller) }
-            
-            describe_failure_message do
-              specify { expect(subject).to eq "expected @assign to be assigned with a new instance of #{expected_assign_class.name} but was assigned with a persisted instance of #{actual_assign_class.name}"
-       }
+            context "with the right class" do
+              specify { expect(subject).to_not match(_controller) }
+
+              describe_failure_message do
+                specify { expect(subject).to eq "expected @assign to be assigned with a new instance of #{expected_assign_class.name} but was assigned with a persisted instance of #{actual_assign_class.name}"
+         }
+              end
             end
-          end
 
-          context "with the wrong class" do
-            let(:expected_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "BarClass" } } }
+            context "with the wrong class" do
+              let(:actual_assign_class) { Class.new.tap {|klass| allow(klass).to receive(:name) { "BarClass" } } }
 
-            specify { expect(subject).to_not match(_controller) }
-            
-            describe_failure_message do
-              specify { expect(subject).to eq "expected @assign to be assigned with a new instance of #{expected_assign_class.name} but was assigned with a persisted instance of #{actual_assign_class.name}"
-       }
+              specify { expect(subject).to_not match(_controller) }
+
+              describe_failure_message do
+                specify { expect(subject).to eq "expected @assign to be assigned with a new instance of #{expected_assign_class.name} but was assigned with a persisted instance of #{actual_assign_class.name}"
+         }
+              end
             end
           end
         end
+
+        context "when not assigned" do
+          controller_action do
+            # no assign
+          end
+
+          specify { expect(subject).to_not match(_controller) }
+
+          describe_failure_message do
+            specify { expect(subject).to eq "expected @assign to be assigned with a new instance of #{expected_assign_class.name} but was not assigned" }
+          end
+        end
       end
 
       context "multiple assertions" do
@@ -225,10 +269,10 @@ describe Warp::ControllerMatchers::AssignMatcher, type: :controller do
           end
 
           behaviour do
-            specify { expect{ subject }.to raise_error("Only one of .with, .with_a, and .with_a_new can be used with the assigns matcher.") }
+            specify { expect{ subject }.to raise_error(NoMethodError) }
           end
         end
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: warp
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.4.0
 platform: ruby
 authors:
 - Thomas Drake-Brockman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-21 00:00:00.000000000 Z
+date: 2015-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -43,22 +43,22 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- gemfiles/rails_3.2_rspec_2.99.gemfile
 - gemfiles/rails_3.2_rspec_3.0.gemfile
 - gemfiles/rails_3.2_rspec_3.1.gemfile
 - gemfiles/rails_3.2_rspec_3.2.gemfile
-- gemfiles/rails_4.0_rspec_2.99.gemfile
+- gemfiles/rails_3.2_rspec_3.3.gemfile
 - gemfiles/rails_4.0_rspec_3.0.gemfile
 - gemfiles/rails_4.0_rspec_3.1.gemfile
 - gemfiles/rails_4.0_rspec_3.2.gemfile
-- gemfiles/rails_4.1_rspec_2.99.gemfile
+- gemfiles/rails_4.0_rspec_3.3.gemfile
 - gemfiles/rails_4.1_rspec_3.0.gemfile
 - gemfiles/rails_4.1_rspec_3.1.gemfile
 - gemfiles/rails_4.1_rspec_3.2.gemfile
-- gemfiles/rails_4.2_rspec_2.99.gemfile
+- gemfiles/rails_4.1_rspec_3.3.gemfile
 - gemfiles/rails_4.2_rspec_3.0.gemfile
 - gemfiles/rails_4.2_rspec_3.1.gemfile
 - gemfiles/rails_4.2_rspec_3.2.gemfile
+- gemfiles/rails_4.2_rspec_3.3.gemfile
 - lib/warp.rb
 - lib/warp/action_matchers.rb
 - lib/warp/action_matchers/create_matcher.rb
@@ -112,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Awesome RSpec matchers for testing your Rails applications.