warder 0.2.4 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 497806d6de8caaabfeeef4bb2a0f282516fc99b4
-  data.tar.gz: 3fee0b32c6c3e56f3b76b8e8e6f5ba372c707295
+  metadata.gz: 875ec7cea81b3bf1256ce70e4223d3689c39f49d
+  data.tar.gz: 77867c0e07c745362775ef46d7a52cc54e00a5c7
 SHA512:
-  metadata.gz: 1e23cb77a50c305686c4036adc49b26f82d09fc6ece6a947b51d04e65d637a9e8d2f035c578751854041de73b3c00537c91708fc02ecebc501c6a9c061aa7dae
-  data.tar.gz: 868c4abad60f965ae17bfc46b960c1cf1373cf2c877ee708148b4120a3d8f3429b680e6d050808348aeb20f0e46d2817afd834c6d9acef5fc6995b45ea603e94
+  metadata.gz: 277b38d6bfc29fdb36d90e06acbea2427ef87c783ea92f67b523123bfdbf822e452e3e0da5fa8e44c7a8ba15d781fbfe6d009badb99d9b15d07428019ce3ca05
+  data.tar.gz: 38628e344b7a6b323207a9fcab6f8cde5593aecfd30241080d635ed4e1dbec83297a7c5644d2eb0afcdd899ee57d8dade4918c00cbe35cf5a4167cf601eba687

data/.travis.yml

@@ -10,6 +10,6 @@ script:
   - bundle exec warder --style-guide Gemfile Rakefile warder.gemspec bin/ lib/ features/
   - bundle exec warder --magick-numbers Gemfile Rakefile warder.gemspec bin/ lib/ features/
   - bundle exec warder --code-complexity Gemfile Rakefile warder.gemspec bin/ lib/ features/
-  - bundle exec warder --code-smells Gemfile Rakefile warder.gemspec bin/ lib/ features/
+  - bundle exec warder --code-smell Gemfile Rakefile warder.gemspec bin/ lib/ features/
   - bundle exec warder --code-duplication Gemfile Rakefile bin/ lib/ features/
   - bundle exec warder --bundle-audit

data/README.md

@@ -22,12 +22,12 @@ code, according to style guides, you may want to use
 
 But if you want to see you code OOP-friendly, then you need different approach
 
-    $ warder --code-smells
+    $ warder --code-smell
 
 Next steps for stylish code are:
 
-    $ warder --code-duplication
     $ warder --magick-numbers
+    $ warder --code-duplication
 
 And for OOP-style code next steps will be:
 

data/features/checks_for_all_issues.feature

@@ -11,7 +11,7 @@ Feature: checks for all issues
     Then warder detects magick numbers issues
     Then warder detects code complexity issues
     Then warder detects code duplication issues
-    Then warder detects code smells issues
+    Then warder detects code smell issues
     Then warder detects sandi rules violations
     Then warder detects rails best practices issues
     Then warder detects rails security issues
@@ -27,7 +27,7 @@ Feature: checks for all issues
     Then warder detects magick numbers issues
     Then warder detects code complexity issues
     Then warder detects code duplication issues
-    Then warder detects code smells issues
+    Then warder detects code smell issues
     Then warder detects sandi rules violations
     Then warder detects rails best practices issues
     Then warder detects rails security issues

data/features/detects_code_smell.feature

@@ -0,0 +1,29 @@
+Feature: detects code smell
+  In order to find code smell
+  As a ruby developer
+  I want to run warder with --code-smell option
+
+  Scenario: run warder with enabled code smell option
+    Given I have valid file in directory
+    When I run `warder --code-smell`
+    Then warder detects code smell issues
+    Then the exit status should be 0
+
+  Scenario: run warder with enabled code smell option on invalid file
+    Given I have invalid_code_smell file in directory
+    When I run `warder --code-smell`
+    Then warder detects code smell issues
+    Then the exit status should be 1
+
+  Scenario: run warder with enabled code smell option on valid file only
+    Given I have valid file in directory
+    And I have invalid_code_smell file in directory
+    When I run `warder --code-smell valid.rb`
+    Then warder does nothing
+    Then the exit status should be 0
+
+  Scenario: run warder with disabled code smell option on invalid file
+    Given I have invalid_code_smell file in directory
+    When I run `warder --no-code-smell`
+    Then warder does nothing
+    Then the exit status should be 0

data/features/step_definitions/detects_code_duplication_steps.rb

@@ -1,7 +1,7 @@
 def executing_code_duplication
-  "executing 'flay -d -m 15 .'"
+  "executing 'flay -m 15 .'"
 end
 
 def code_duplication_output
-  command_output_for_project_or_file('flay -d')
+  command_output_for_project_or_file('flay')
 end

data/features/step_definitions/{detects_code_smells_steps.rb → detects_code_smell_steps.rb}

@@ -1,7 +1,7 @@
-def executing_code_smells
+def executing_code_smell
   "executing 'reek --no-color .'"
 end
 
-def code_smells_output
+def code_smell_output
   command_output_for_project_or_file('reek')
 end

data/lib/warder.rb

@@ -4,7 +4,7 @@ require 'warder/runner'
 require 'warder/style_guide_runner'
 require 'warder/magick_numbers_runner'
 require 'warder/code_duplication_runner'
-require 'warder/code_smells_runner'
+require 'warder/code_smell_runner'
 require 'warder/code_complexity_runner'
 require 'warder/rails_security_runner'
 require 'warder/rails_advice_runner'

data/lib/warder/code_duplication_runner.rb

@@ -11,7 +11,7 @@ module Warder
     private
 
     def command_with_options
-      "#{COMMAND_NAME} -d -m #{flay_score} #{@options.files}"
+      "#{COMMAND_NAME} -m #{flay_score} #{@options.files}"
     end
 
     def flay_score

data/lib/warder/{code_smells_runner.rb → code_smell_runner.rb}

@@ -1,9 +1,9 @@
 module Warder
-  # responsible for run code smells validation
-  class CodeSmellsRunner < Runner
+  # responsible for run code smell validation
+  class CodeSmellRunner < Runner
     CLI_OPTION = 's'
-    CLI_FULL_OPTION = 'code-smells'
-    DESCRIPTION = 'Run code smells validation'
+    CLI_FULL_OPTION = 'code-smell'
+    DESCRIPTION = 'Run code smell validation'
     COMMAND_NAME = 'reek --no-color'
     FAILURE_REGEXP = /(?<issues>\d+) warnings?/
 

data/lib/warder/version.rb

@@ -1,4 +1,4 @@
 # defines warder version
 module Warder
-  VERSION = '0.2.4'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: warder
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.3.0
 platform: ruby
 authors:
 - Yura Tolstik
@@ -270,7 +270,7 @@ files:
 - features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
-- features/detects_code_smells.feature
+- features/detects_code_smell.feature
 - features/detects_magick_numbers.feature
 - features/quiet.feature
 - features/run.feature
@@ -282,7 +282,7 @@ files:
 - features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb
 - features/step_definitions/detects_code_duplication_steps.rb
-- features/step_definitions/detects_code_smells_steps.rb
+- features/step_definitions/detects_code_smell_steps.rb
 - features/step_definitions/detects_magick_numbers_steps.rb
 - features/step_definitions/run_steps.rb
 - features/step_definitions/show_version_steps.rb
@@ -298,7 +298,7 @@ files:
 - lib/warder/cli/arguments.rb
 - lib/warder/code_complexity_runner.rb
 - lib/warder/code_duplication_runner.rb
-- lib/warder/code_smells_runner.rb
+- lib/warder/code_smell_runner.rb
 - lib/warder/coffee_lint_runner.rb
 - lib/warder/coffee_lint_runner/lint_runner.rb
 - lib/warder/coffee_lint_runner/message_formatter.rb
@@ -312,7 +312,7 @@ files:
 - lib/warder/version.rb
 - spec/fixtures/invalid_code_complexity.rb
 - spec/fixtures/invalid_code_duplication.rb
-- spec/fixtures/invalid_code_smells.rb
+- spec/fixtures/invalid_code_smell.rb
 - spec/fixtures/invalid_coffee_lint.coffee
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_rails_app/Gemfile
@@ -401,7 +401,7 @@ test_files:
 - features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
-- features/detects_code_smells.feature
+- features/detects_code_smell.feature
 - features/detects_magick_numbers.feature
 - features/quiet.feature
 - features/run.feature
@@ -413,7 +413,7 @@ test_files:
 - features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb
 - features/step_definitions/detects_code_duplication_steps.rb
-- features/step_definitions/detects_code_smells_steps.rb
+- features/step_definitions/detects_code_smell_steps.rb
 - features/step_definitions/detects_magick_numbers_steps.rb
 - features/step_definitions/run_steps.rb
 - features/step_definitions/show_version_steps.rb
@@ -425,7 +425,7 @@ test_files:
 - features/validates_ruby_style_guide.feature
 - spec/fixtures/invalid_code_complexity.rb
 - spec/fixtures/invalid_code_duplication.rb
-- spec/fixtures/invalid_code_smells.rb
+- spec/fixtures/invalid_code_smell.rb
 - spec/fixtures/invalid_coffee_lint.coffee
 - spec/fixtures/invalid_magick_numbers.rb
 - spec/fixtures/invalid_rails_app/Gemfile

data/features/detects_code_smells.feature

@@ -1,29 +0,0 @@
-Feature: detects code smells
-  In order to find code smells
-  As a ruby developer
-  I want to run warder with --code-smells option
-
-  Scenario: run warder with enabled code smells option
-    Given I have valid file in directory
-    When I run `warder --code-smells`
-    Then warder detects code smells issues
-    Then the exit status should be 0
-
-  Scenario: run warder with enabled code smells option on invalid file
-    Given I have invalid_code_smells file in directory
-    When I run `warder --code-smells`
-    Then warder detects code smells issues
-    Then the exit status should be 1
-
-  Scenario: run warder with enabled code smells option on valid file only
-    Given I have valid file in directory
-    And I have invalid_code_smells file in directory
-    When I run `warder --code-smells valid.rb`
-    Then warder does nothing
-    Then the exit status should be 0
-
-  Scenario: run warder with disabled code smells option on invalid file
-    Given I have invalid_code_smells file in directory
-    When I run `warder --no-code-smells`
-    Then warder does nothing
-    Then the exit status should be 0