warder 0.2.4 → 0.3.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.travis.yml +1 -1
- data/README.md +2 -2
- data/features/checks_for_all_issues.feature +2 -2
- data/features/detects_code_smell.feature +29 -0
- data/features/step_definitions/detects_code_duplication_steps.rb +2 -2
- data/features/step_definitions/{detects_code_smells_steps.rb → detects_code_smell_steps.rb} +2 -2
- data/lib/warder.rb +1 -1
- data/lib/warder/code_duplication_runner.rb +1 -1
- data/lib/warder/{code_smells_runner.rb → code_smell_runner.rb} +4 -4
- data/lib/warder/version.rb +1 -1
- data/spec/fixtures/{invalid_code_smells.rb → invalid_code_smell.rb} +0 -0
- metadata +8 -8
- data/features/detects_code_smells.feature +0 -29
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA1:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 875ec7cea81b3bf1256ce70e4223d3689c39f49d
|
4
|
+
data.tar.gz: 77867c0e07c745362775ef46d7a52cc54e00a5c7
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 277b38d6bfc29fdb36d90e06acbea2427ef87c783ea92f67b523123bfdbf822e452e3e0da5fa8e44c7a8ba15d781fbfe6d009badb99d9b15d07428019ce3ca05
|
7
|
+
data.tar.gz: 38628e344b7a6b323207a9fcab6f8cde5593aecfd30241080d635ed4e1dbec83297a7c5644d2eb0afcdd899ee57d8dade4918c00cbe35cf5a4167cf601eba687
|
data/.travis.yml
CHANGED
@@ -10,6 +10,6 @@ script:
|
|
10
10
|
- bundle exec warder --style-guide Gemfile Rakefile warder.gemspec bin/ lib/ features/
|
11
11
|
- bundle exec warder --magick-numbers Gemfile Rakefile warder.gemspec bin/ lib/ features/
|
12
12
|
- bundle exec warder --code-complexity Gemfile Rakefile warder.gemspec bin/ lib/ features/
|
13
|
-
- bundle exec warder --code-
|
13
|
+
- bundle exec warder --code-smell Gemfile Rakefile warder.gemspec bin/ lib/ features/
|
14
14
|
- bundle exec warder --code-duplication Gemfile Rakefile bin/ lib/ features/
|
15
15
|
- bundle exec warder --bundle-audit
|
data/README.md
CHANGED
@@ -22,12 +22,12 @@ code, according to style guides, you may want to use
|
|
22
22
|
|
23
23
|
But if you want to see you code OOP-friendly, then you need different approach
|
24
24
|
|
25
|
-
$ warder --code-
|
25
|
+
$ warder --code-smell
|
26
26
|
|
27
27
|
Next steps for stylish code are:
|
28
28
|
|
29
|
-
$ warder --code-duplication
|
30
29
|
$ warder --magick-numbers
|
30
|
+
$ warder --code-duplication
|
31
31
|
|
32
32
|
And for OOP-style code next steps will be:
|
33
33
|
|
@@ -11,7 +11,7 @@ Feature: checks for all issues
|
|
11
11
|
Then warder detects magick numbers issues
|
12
12
|
Then warder detects code complexity issues
|
13
13
|
Then warder detects code duplication issues
|
14
|
-
Then warder detects code
|
14
|
+
Then warder detects code smell issues
|
15
15
|
Then warder detects sandi rules violations
|
16
16
|
Then warder detects rails best practices issues
|
17
17
|
Then warder detects rails security issues
|
@@ -27,7 +27,7 @@ Feature: checks for all issues
|
|
27
27
|
Then warder detects magick numbers issues
|
28
28
|
Then warder detects code complexity issues
|
29
29
|
Then warder detects code duplication issues
|
30
|
-
Then warder detects code
|
30
|
+
Then warder detects code smell issues
|
31
31
|
Then warder detects sandi rules violations
|
32
32
|
Then warder detects rails best practices issues
|
33
33
|
Then warder detects rails security issues
|
@@ -0,0 +1,29 @@
|
|
1
|
+
Feature: detects code smell
|
2
|
+
In order to find code smell
|
3
|
+
As a ruby developer
|
4
|
+
I want to run warder with --code-smell option
|
5
|
+
|
6
|
+
Scenario: run warder with enabled code smell option
|
7
|
+
Given I have valid file in directory
|
8
|
+
When I run `warder --code-smell`
|
9
|
+
Then warder detects code smell issues
|
10
|
+
Then the exit status should be 0
|
11
|
+
|
12
|
+
Scenario: run warder with enabled code smell option on invalid file
|
13
|
+
Given I have invalid_code_smell file in directory
|
14
|
+
When I run `warder --code-smell`
|
15
|
+
Then warder detects code smell issues
|
16
|
+
Then the exit status should be 1
|
17
|
+
|
18
|
+
Scenario: run warder with enabled code smell option on valid file only
|
19
|
+
Given I have valid file in directory
|
20
|
+
And I have invalid_code_smell file in directory
|
21
|
+
When I run `warder --code-smell valid.rb`
|
22
|
+
Then warder does nothing
|
23
|
+
Then the exit status should be 0
|
24
|
+
|
25
|
+
Scenario: run warder with disabled code smell option on invalid file
|
26
|
+
Given I have invalid_code_smell file in directory
|
27
|
+
When I run `warder --no-code-smell`
|
28
|
+
Then warder does nothing
|
29
|
+
Then the exit status should be 0
|
data/lib/warder.rb
CHANGED
@@ -4,7 +4,7 @@ require 'warder/runner'
|
|
4
4
|
require 'warder/style_guide_runner'
|
5
5
|
require 'warder/magick_numbers_runner'
|
6
6
|
require 'warder/code_duplication_runner'
|
7
|
-
require 'warder/
|
7
|
+
require 'warder/code_smell_runner'
|
8
8
|
require 'warder/code_complexity_runner'
|
9
9
|
require 'warder/rails_security_runner'
|
10
10
|
require 'warder/rails_advice_runner'
|
@@ -1,9 +1,9 @@
|
|
1
1
|
module Warder
|
2
|
-
# responsible for run code
|
3
|
-
class
|
2
|
+
# responsible for run code smell validation
|
3
|
+
class CodeSmellRunner < Runner
|
4
4
|
CLI_OPTION = 's'
|
5
|
-
CLI_FULL_OPTION = 'code-
|
6
|
-
DESCRIPTION = 'Run code
|
5
|
+
CLI_FULL_OPTION = 'code-smell'
|
6
|
+
DESCRIPTION = 'Run code smell validation'
|
7
7
|
COMMAND_NAME = 'reek --no-color'
|
8
8
|
FAILURE_REGEXP = /(?<issues>\d+) warnings?/
|
9
9
|
|
data/lib/warder/version.rb
CHANGED
File without changes
|
metadata
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: warder
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 0.
|
4
|
+
version: 0.3.0
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Yura Tolstik
|
@@ -270,7 +270,7 @@ files:
|
|
270
270
|
- features/checks_for_vulnerable_gems.feature
|
271
271
|
- features/detects_code_complexity.feature
|
272
272
|
- features/detects_code_duplication.feature
|
273
|
-
- features/
|
273
|
+
- features/detects_code_smell.feature
|
274
274
|
- features/detects_magick_numbers.feature
|
275
275
|
- features/quiet.feature
|
276
276
|
- features/run.feature
|
@@ -282,7 +282,7 @@ files:
|
|
282
282
|
- features/step_definitions/checks_for_vulnerable_gems_steps.rb
|
283
283
|
- features/step_definitions/detects_code_complexity_steps.rb
|
284
284
|
- features/step_definitions/detects_code_duplication_steps.rb
|
285
|
-
- features/step_definitions/
|
285
|
+
- features/step_definitions/detects_code_smell_steps.rb
|
286
286
|
- features/step_definitions/detects_magick_numbers_steps.rb
|
287
287
|
- features/step_definitions/run_steps.rb
|
288
288
|
- features/step_definitions/show_version_steps.rb
|
@@ -298,7 +298,7 @@ files:
|
|
298
298
|
- lib/warder/cli/arguments.rb
|
299
299
|
- lib/warder/code_complexity_runner.rb
|
300
300
|
- lib/warder/code_duplication_runner.rb
|
301
|
-
- lib/warder/
|
301
|
+
- lib/warder/code_smell_runner.rb
|
302
302
|
- lib/warder/coffee_lint_runner.rb
|
303
303
|
- lib/warder/coffee_lint_runner/lint_runner.rb
|
304
304
|
- lib/warder/coffee_lint_runner/message_formatter.rb
|
@@ -312,7 +312,7 @@ files:
|
|
312
312
|
- lib/warder/version.rb
|
313
313
|
- spec/fixtures/invalid_code_complexity.rb
|
314
314
|
- spec/fixtures/invalid_code_duplication.rb
|
315
|
-
- spec/fixtures/
|
315
|
+
- spec/fixtures/invalid_code_smell.rb
|
316
316
|
- spec/fixtures/invalid_coffee_lint.coffee
|
317
317
|
- spec/fixtures/invalid_magick_numbers.rb
|
318
318
|
- spec/fixtures/invalid_rails_app/Gemfile
|
@@ -401,7 +401,7 @@ test_files:
|
|
401
401
|
- features/checks_for_vulnerable_gems.feature
|
402
402
|
- features/detects_code_complexity.feature
|
403
403
|
- features/detects_code_duplication.feature
|
404
|
-
- features/
|
404
|
+
- features/detects_code_smell.feature
|
405
405
|
- features/detects_magick_numbers.feature
|
406
406
|
- features/quiet.feature
|
407
407
|
- features/run.feature
|
@@ -413,7 +413,7 @@ test_files:
|
|
413
413
|
- features/step_definitions/checks_for_vulnerable_gems_steps.rb
|
414
414
|
- features/step_definitions/detects_code_complexity_steps.rb
|
415
415
|
- features/step_definitions/detects_code_duplication_steps.rb
|
416
|
-
- features/step_definitions/
|
416
|
+
- features/step_definitions/detects_code_smell_steps.rb
|
417
417
|
- features/step_definitions/detects_magick_numbers_steps.rb
|
418
418
|
- features/step_definitions/run_steps.rb
|
419
419
|
- features/step_definitions/show_version_steps.rb
|
@@ -425,7 +425,7 @@ test_files:
|
|
425
425
|
- features/validates_ruby_style_guide.feature
|
426
426
|
- spec/fixtures/invalid_code_complexity.rb
|
427
427
|
- spec/fixtures/invalid_code_duplication.rb
|
428
|
-
- spec/fixtures/
|
428
|
+
- spec/fixtures/invalid_code_smell.rb
|
429
429
|
- spec/fixtures/invalid_coffee_lint.coffee
|
430
430
|
- spec/fixtures/invalid_magick_numbers.rb
|
431
431
|
- spec/fixtures/invalid_rails_app/Gemfile
|
@@ -1,29 +0,0 @@
|
|
1
|
-
Feature: detects code smells
|
2
|
-
In order to find code smells
|
3
|
-
As a ruby developer
|
4
|
-
I want to run warder with --code-smells option
|
5
|
-
|
6
|
-
Scenario: run warder with enabled code smells option
|
7
|
-
Given I have valid file in directory
|
8
|
-
When I run `warder --code-smells`
|
9
|
-
Then warder detects code smells issues
|
10
|
-
Then the exit status should be 0
|
11
|
-
|
12
|
-
Scenario: run warder with enabled code smells option on invalid file
|
13
|
-
Given I have invalid_code_smells file in directory
|
14
|
-
When I run `warder --code-smells`
|
15
|
-
Then warder detects code smells issues
|
16
|
-
Then the exit status should be 1
|
17
|
-
|
18
|
-
Scenario: run warder with enabled code smells option on valid file only
|
19
|
-
Given I have valid file in directory
|
20
|
-
And I have invalid_code_smells file in directory
|
21
|
-
When I run `warder --code-smells valid.rb`
|
22
|
-
Then warder does nothing
|
23
|
-
Then the exit status should be 0
|
24
|
-
|
25
|
-
Scenario: run warder with disabled code smells option on invalid file
|
26
|
-
Given I have invalid_code_smells file in directory
|
27
|
-
When I run `warder --no-code-smells`
|
28
|
-
Then warder does nothing
|
29
|
-
Then the exit status should be 0
|