warder 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 67c7349d6bb5541fa17887d73a3d07697db0f674
-  data.tar.gz: b856e7f29aace7650e04eb46c1976796e33f6c75
+  metadata.gz: 7afe9d3043a0b79203eae14a874da4b7e7476b7f
+  data.tar.gz: 77b48c7afb507db85255b71e0e8630db14e45a4b
 SHA512:
-  metadata.gz: 150bef54f04ba4f3e17ba78ee237fec4aabb2b8f8318ac695c464558a78bbb9248f2bdc2fad9b2582835c03dcbb4d8b1703a98d1d92c3cf8e7773dda0d209d06
-  data.tar.gz: 3e7ba5946db9ce307595b051197348543761169a9824164fa1a751638bf849c8a54761bd746ddf1ef38afa98cbd576c69fd3002a40d4759294e4de5449f0e9f4
+  metadata.gz: b76bcd34640d62415548719b48c4d7ba13608cccf4382ec08992912ae53b904ac308ae9d2d208b9667918e50bd5fed0cd93356d201fdebdc5bd6f8296ec6324e
+  data.tar.gz: c56a8c2cd0659cb171d6372f873ffedf6bac5cc7c68e4212c95ab936f4a6cbad7328cff1b41fc53a9251b810ac0ccecc6b35558c41f28e384dbcbb8cc4ae741d

data/.travis.yml

@@ -6,4 +6,9 @@ gemfile:
   - Gemfile
 script:
   - bundle exec rake
-  - bundle exec warder --style-guide --magick-numbers Gemfile Rakefile warder.gemspec bin/ lib/ features/
+  - bundle exec warder --style-guide Gemfile Rakefile warder.gemspec bin/ lib/ features/
+  - bundle exec warder --magick-numbers Gemfile Rakefile warder.gemspec bin/ lib/ features/
+  - bundle exec warder --code-complexity Gemfile Rakefile warder.gemspec bin/ lib/ features/
+  - bundle exec warder --code-smells Gemfile Rakefile warder.gemspec bin/ lib/ features/
+  - bundle exec warder --code-duplication Gemfile Rakefile bin/ lib/ features/
+  - bundle exec warder --bundle-audit

data/bin/warder

@@ -34,12 +34,17 @@ OptionParser.new do |opts|
     options[:code_complexity] = value
   end
 
+  desc = 'Run bundle freshness validation'
+  opts.on('-b', '--[no-]bundle-audit', desc) do |value|
+    options[:bundle_audit] = value
+  end
+
   opts.on('-v', '--version', 'Show version') do |value|
     puts Warder::VERSION
     exit 0
   end
 end.parse!
 
-options[:files] = ARGV.join(' ')
+options[:files] = ARGV.empty? ? '.' : ARGV.join(' ')
 
 Warder::CLI.new(options).perform

data/features/checks_for_vulnerable_gems.feature

@@ -0,0 +1,22 @@
+Feature: checks for vulnerable gems
+  In order to find vulnerable gems
+  As a ruby developer
+  I want to run warder with --bundle-audit option
+
+  Scenario: run warder with enabled bundle audit option
+    Given I have valid gemfile in directory
+    When I run `warder --bundle-audit`
+    Then warder detects gem freshness issues
+    Then the exit status should be 0
+
+  Scenario: run warder with enabled bundle audit option on invalid file
+    Given I have invalid gemfile in directory
+    When I run `warder --bundle-audit`
+    Then warder detects gem freshness issues
+    Then the exit status should be 1
+
+  Scenario: run warder with disabled bundle audit option on invalid file
+    Given I have invalid gemfile in directory
+    When I run `warder --no-bundle-audit`
+    Then warder does nothing
+    Then the exit status should be 0

data/features/detects_code_complexity.feature

@@ -6,13 +6,13 @@ Feature: detects code complexity
   Scenario: run warder with enabled code complexity option
     Given I have valid file in directory
     When I run `warder --code-complexity`
-    Then warder detects code complexity
+    Then warder detects code complexity issues
     Then the exit status should be 0
 
   Scenario: run warder with enabled code complexity option on invalid file
     Given I have invalid_code_complexity file in directory
     When I run `warder --code-complexity`
-    Then warder detects code complexity
+    Then warder detects code complexity issues
     Then the exit status should be 1
 
   Scenario: run warder with enabled code complexity option on valid file only
@@ -27,4 +27,3 @@ Feature: detects code complexity
     When I run `warder --no-code-complexity`
     Then warder does nothing
     Then the exit status should be 0
-

data/features/detects_code_duplication.feature

@@ -6,13 +6,13 @@ Feature: detects code duplication
   Scenario: run warder with enabled code duplication option
     Given I have valid file in directory
     When I run `warder --code-duplication`
-    Then warder detects code duplication
+    Then warder detects code duplication issues
     Then the exit status should be 0
 
   Scenario: run warder with enabled code duplication option on invalid file
     Given I have invalid_code_duplication file in directory
     When I run `warder --code-duplication`
-    Then warder detects code duplication
+    Then warder detects code duplication issues
     Then the exit status should be 1
 
   Scenario: run warder with enabled code duplication option on valid file only

data/features/detects_code_smells.feature

@@ -6,13 +6,13 @@ Feature: detects code smells
   Scenario: run warder with enabled code smells option
     Given I have valid file in directory
     When I run `warder --code-smells`
-    Then warder detects code smells
+    Then warder detects code smells issues
     Then the exit status should be 0
 
   Scenario: run warder with enabled code smells option on invalid file
     Given I have invalid_code_smells file in directory
     When I run `warder --code-smells`
-    Then warder detects code smells
+    Then warder detects code smells issues
     Then the exit status should be 1
 
   Scenario: run warder with enabled code smells option on valid file only

data/features/detects_magick_numbers.feature

@@ -6,13 +6,13 @@ Feature: detects magick numbers
   Scenario: run warder with enabled magick numbers option
     Given I have valid file in directory
     When I run `warder --magick-numbers`
-    Then warder detects magick numbers
+    Then warder detects magick numbers issues
     Then the exit status should be 0
 
   Scenario: run warder with enabled magick numbers option on invalid file
     Given I have invalid_magick_numbers file in directory
     When I run `warder --magick-numbers`
-    Then warder detects magick numbers
+    Then warder detects magick numbers issues
     Then the exit status should be 1
 
   Scenario: run warder with enabled magick numbers option on valid file only

data/features/step_definitions/checks_for_vulnerable_gems_steps.rb

@@ -0,0 +1,13 @@
+def executing_gem_freshness
+  "executing 'bundle-audit update; (cd . && bundle-audit check)'"
+end
+
+def gem_freshness_output
+  `cd tmp/aruba/ && bundle-audit check`
+end
+
+Given(/^I have ((in)?valid) gemfile in directory$/) do |state, _|
+  @filename = "#{state}_Gemfile.lock"
+  FileUtils.ln_s "../../spec/fixtures/#{@filename}", 'tmp/aruba/Gemfile.lock'
+  expect(`ls tmp/aruba`).to match('Gemfile.lock')
+end

data/features/step_definitions/detects_code_complexity_steps.rb

@@ -1,11 +1,10 @@
-Then(/^warder detects code complexity$/) do
-  executing_flog_output = "executing 'flog -a -c -g -m .'"
-  success_flog_output = `cd spec/fixtures/ && flog  -a -c -g -m ./#{@filename}`
-  step "the output should contain \"#{executing_flog_output}\""
-  success_flog_output
+def executing_code_complexity
+  "executing 'flog -a -c -g -m .'"
+end
+
+def code_complexity_output
+  `cd spec/fixtures/ && flog -a -c -g -m ./#{@filename}`
     .split("\n")
     .reject { |line| line.match(/total|average/) }
-    .each do |string|
-    step "the output should contain \"#{string}\""
-  end
+    .join("\n")
 end

data/features/step_definitions/detects_code_duplication_steps.rb

@@ -1,8 +1,7 @@
-Then(/^warder detects code duplication$/) do
-  executing_flay_output = "executing 'flay -d -m 15 .'"
-  success_flay_output = `cd spec/fixtures/ && flay -d ./#{@filename}`
-  step "the output should contain \"#{executing_flay_output}\""
-  success_flay_output.split("\n").each do |string|
-    step "the output should contain \"#{string}\""
-  end
+def executing_code_duplication
+  "executing 'flay -d -m 15 .'"
+end
+
+def code_duplication_output
+  `cd spec/fixtures/ && flay -d ./#{@filename}`
 end

data/features/step_definitions/detects_code_smells_steps.rb

@@ -1,8 +1,7 @@
-Then(/^warder detects code smells$/) do
-  executing_reek_output = "executing 'reek .'"
-  success_reek_output = `cd spec/fixtures/ && reek #{@filename}`
-  step "the output should contain \"#{executing_reek_output}\""
-  success_reek_output.split("\n").each do |string|
-    step "the output should contain \"#{string}\""
-  end
+def executing_code_smells
+  "executing 'reek .'"
+end
+
+def code_smells_output
+  `cd spec/fixtures/ && reek #{@filename}`
 end

data/features/step_definitions/detects_magick_numbers_steps.rb

@@ -1,8 +1,7 @@
-Then(/^warder detects magick numbers$/) do
-  executing_mago_output = "executing 'mago .'"
-  success_mago_output = `cd spec/fixtures/ && mago #{@filename}`
-  step "the output should contain \"#{executing_mago_output}\""
-  success_mago_output.split("\n").each do |string|
-    step "the output should contain \"#{string}\""
-  end
+def executing_magick_numbers
+  "executing 'mago .'"
+end
+
+def magick_numbers_output
+  `cd spec/fixtures/ && mago #{@filename}`
 end

data/features/step_definitions/run_steps.rb

@@ -15,3 +15,13 @@ end
 Then(/^warder does nothing$/) do
   step 'the output should match /.{0}/'
 end
+
+Then(/^warder detects (.+) issues$/) do |what|
+  executing_output = send(:"executing_#{what.sub(' ', '_')}")
+  step "the output should contain \"#{executing_output}\""
+
+  validation_output = send(:"#{what.sub(' ', '_')}_output")
+  validation_output.split("\n").each do |string|
+    step "the output should contain \"#{string}\""
+  end
+end

data/features/step_definitions/validates_style_guide_steps.rb

@@ -1,8 +1,7 @@
-Then(/^warder validates style guide$/) do
-  executing_rubocop_output = "executing 'rubocop .'"
-  success_rubocop_output = `cd spec/fixtures/ && rubocop #{@filename}`
-  step "the output should contain \"#{executing_rubocop_output}\""
-  success_rubocop_output.split("\n").each do |string|
-    step "the output should contain \"#{string}\""
-  end
+def executing_style_guide
+  "executing 'rubocop .'"
+end
+
+def style_guide_output
+  `cd spec/fixtures/ && rubocop #{@filename}`
 end

data/features/support/env.rb

@@ -1,4 +1,4 @@
 require 'aruba/cucumber'
 
 bin_path = "#{File.expand_path('../../../bin', __FILE__)}"
-ENV['PATH'] = "#{ENV['PATH']}#{File::PATH_SEPARATOR}#{bin_path}"
+ENV['PATH'] = "#{bin_path}#{File::PATH_SEPARATOR}#{ENV['PATH']}"

data/features/validates_style_guide.feature

@@ -6,13 +6,13 @@ Feature: check style guide
   Scenario: run warder with enabled style guide option
     Given I have valid file in directory
     When I run `warder --style-guide`
-    Then warder validates style guide
+    Then warder detects style guide issues
     Then the exit status should be 0
 
   Scenario: run warder with enabled style guide option on invalid file
     Given I have invalid_style_guide file in directory
     When I run `warder --style-guide`
-    Then warder validates style guide
+    Then warder detects style guide issues
     Then the exit status should be 1
 
   Scenario: run warder with enabled style guide option on valid file only

data/lib/warder.rb

@@ -6,4 +6,5 @@ require 'warder/magick_numbers_runner'
 require 'warder/code_duplication_runner'
 require 'warder/code_smells_runner'
 require 'warder/code_complexity_runner'
+require 'warder/bundle_audit_runner'
 require 'warder/cli'

data/lib/warder/bundle_audit_runner.rb

@@ -0,0 +1,18 @@
+module Warder
+  # responsible for run bundle freshness validation
+  class BundleAuditRunner < Runner
+    COMMAND_NAME = 'bundle-audit'
+    FAILURE_REGEXP = /Unpatched versions found!/
+
+    private
+
+    def command_with_options
+      path = @options.files[0]
+      "#{COMMAND_NAME} update; (cd #{path} && #{COMMAND_NAME} check)"
+    end
+
+    def failed?(line)
+      FAILURE_REGEXP.match(line)
+    end
+  end
+end

data/lib/warder/cli.rb

@@ -2,7 +2,6 @@ module Warder
   # responsible for executing warder tools
   class CLI
     def initialize(options)
-      options[:files] = '.' if options[:files].empty?
       @options = OpenStruct.new(options)
     end
 
@@ -11,7 +10,8 @@ module Warder
              perform_magick_numbers_validation +
              perform_code_duplication_validation +
              perform_code_smells_validation +
-             perform_code_complexity_validation
+             perform_code_complexity_validation +
+             perform_bundle_freshness_validation
     end
 
     private
@@ -60,5 +60,14 @@ module Warder
         0
       end
     end
+
+    def perform_bundle_freshness_validation
+      if @options.bundle_audit
+        runner = BundleAuditRunner.new(@options)
+        runner.perform
+      else
+        0
+      end
+    end
   end
 end

data/lib/warder/code_complexity_runner.rb

@@ -2,15 +2,13 @@ module Warder
   # responsible for run code complexity validation
   class CodeComplexityRunner < Runner
     FLOG_SCORE = SCORE
-
-    def initialize(options = {})
-      @options = options
-    end
+    COMMAND_NAME = 'flog'
+    TOTAL_REGEXP = /^\s+\d+.\d+\:.*(total|average)$/
 
     private
 
-    def command
-      "flog -a -c -g -m #{@options.files}"
+    def command_with_options
+      "#{COMMAND_NAME} -a -c -g -m #{@options.files}"
     end
 
     def failed?(line)
@@ -24,7 +22,7 @@ module Warder
     end
 
     def total?(line)
-      line.match(/^\s+\d+.\d+\:.*(total|average)$/)
+      TOTAL_REGEXP.match(line)
     end
   end
 end

data/lib/warder/code_duplication_runner.rb

@@ -2,21 +2,13 @@ module Warder
   # responsible for run code duplication validation
   class CodeDuplicationRunner < Runner
     FLAY_SCORE = SCORE / 2
-
-    def initialize(options = {})
-      @options = options
-    end
+    COMMAND_NAME = 'flay'
+    FAILURE_REGEXP = /Total score \(lower is better\) = (\d+)/
 
     private
 
-    def command
-      "flay -d -m #{FLAY_SCORE} #{@options.files}"
-    end
-
-    def failed?(line)
-      match = line.match(/Total score \(lower is better\) = (\d+)/)
-
-      match && match[1].to_i != 0
+    def command_with_options
+      "#{COMMAND_NAME} -d -m #{FLAY_SCORE} #{@options.files}"
     end
   end
 end

data/lib/warder/code_smells_runner.rb

@@ -1,20 +1,7 @@
 module Warder
   # responsible for run code smells validation
   class CodeSmellsRunner < Runner
-    def initialize(options = {})
-      @options = options
-    end
-
-    private
-
-    def command
-      "reek #{@options.files}"
-    end
-
-    def failed?(line)
-      match = line.match(/ -- (\d+) warnings?:/)
-
-      match && match[1].to_i != 0
-    end
+    COMMAND_NAME = 'reek'
+    FAILURE_REGEXP = / -- (\d+) warnings?:/
   end
 end

data/lib/warder/magick_numbers_runner.rb

@@ -1,17 +1,11 @@
 module Warder
   # responsible for run magick numbers validation
   class MagickNumbersRunner < Runner
-    def initialize(options = {})
-      @options = options
-    end
+    COMMAND_NAME = 'mago'
 
     private
 
-    def command
-      "mago #{@options.files}"
-    end
-
-    def failed?(line)
+    def failed?(*)
       true
     end
   end

data/lib/warder/runner.rb

@@ -3,24 +3,38 @@ module Warder
   class Runner
     SCORE = 30
 
+    def initialize(options = {})
+      @options = options
+      @exit_code = 0
+    end
+
     def perform
-      puts "executing '#{command}'\n"
-      code = 0
-      IO.popen(command).each do |line|
+      run_command do |line|
         print line if printable?(line)
-
-        code = 1 if failed?(line)
+        @exit_code = 1 if failed?(line)
       end
-      code
+      @exit_code
     end
 
     private
 
+    def run_command
+      puts "executing '#{command_with_options}'\n"
+      IO.popen(command_with_options).each do |line|
+        yield(line)
+      end
+    end
+
+    def command_with_options
+      "#{self.class::COMMAND_NAME} #{@options.files}"
+    end
+
     def failed?(line)
-      false
+      match = line.match(self.class::FAILURE_REGEXP)
+      match && match[1].to_i != 0
     end
 
-    def printable?(line)
+    def printable?(*)
       true
     end
   end

data/lib/warder/style_guide_runner.rb

@@ -1,20 +1,7 @@
 module Warder
   # responsible for run style guide validation
   class StyleGuideRunner < Runner
-    def initialize(options = {})
-      @options = options
-    end
-
-    private
-
-    def command
-      "rubocop #{@options.files}"
-    end
-
-    def failed?(line)
-      match = line.match(/(\d+|no) offence/)
-
-      match && match[1].to_i != 0
-    end
+    COMMAND_NAME = 'rubocop'
+    FAILURE_REGEXP = /(\d+|no) offence/
   end
 end

data/lib/warder/version.rb

@@ -1,4 +1,4 @@
 # define warder version
 module Warder
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/spec/fixtures/invalid_Gemfile

@@ -0,0 +1,3 @@
+source 'http://rubygems.org'
+
+gem 'activesupport', '3.2.10'

data/spec/fixtures/invalid_Gemfile.lock

@@ -0,0 +1,14 @@
+GEM
+  remote: http://rubygems.org/
+  specs:
+    activesupport (3.2.10)
+      i18n (~> 0.6)
+      multi_json (~> 1.0)
+    i18n (0.6.9)
+    multi_json (1.8.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activesupport (= 3.2.10)

data/spec/fixtures/valid_Gemfile

@@ -0,0 +1 @@
+source 'https://rubygems.org'

data/spec/fixtures/valid_Gemfile.lock

@@ -0,0 +1,8 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES

data/warder.gemspec

@@ -24,7 +24,10 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'ruby2ruby'
   spec.add_dependency 'flog'
   spec.add_dependency 'mago'
+  spec.add_dependency 'bundler-audit'
   # spec.add_dependency 'sandi_meter'
+  # spec.add_dependency 'brakeman'
+  # spec.add_dependency 'rails_best_practices'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: warder
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Yura Tolstik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-02 00:00:00.000000000 Z
+date: 2014-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler-audit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -180,12 +194,14 @@ files:
 - Rakefile
 - bin/warder
 - cucumber.yml
+- features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
 - features/detects_code_smells.feature
 - features/detects_magick_numbers.feature
 - features/run.feature
 - features/show_version.feature
+- features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb
 - features/step_definitions/detects_code_duplication_steps.rb
 - features/step_definitions/detects_code_smells_steps.rb
@@ -196,6 +212,7 @@ files:
 - features/support/env.rb
 - features/validates_style_guide.feature
 - lib/warder.rb
+- lib/warder/bundle_audit_runner.rb
 - lib/warder/cli.rb
 - lib/warder/code_complexity_runner.rb
 - lib/warder/code_duplication_runner.rb
@@ -204,6 +221,8 @@ files:
 - lib/warder/runner.rb
 - lib/warder/style_guide_runner.rb
 - lib/warder/version.rb
+- spec/fixtures/invalid_Gemfile
+- spec/fixtures/invalid_Gemfile.lock
 - spec/fixtures/invalid_code_complexity.rb
 - spec/fixtures/invalid_code_duplication.rb
 - spec/fixtures/invalid_code_smells.rb
@@ -211,6 +230,8 @@ files:
 - spec/fixtures/invalid_style_guide.rb
 - spec/fixtures/strictly_invalid_style_guide.rb
 - spec/fixtures/valid.rb
+- spec/fixtures/valid_Gemfile
+- spec/fixtures/valid_Gemfile.lock
 - spec/spec_helper.rb
 - warder.gemspec
 homepage: https://github.com/yltsrc/warder
@@ -238,12 +259,14 @@ signing_key:
 specification_version: 4
 summary: Warder of ruby code
 test_files:
+- features/checks_for_vulnerable_gems.feature
 - features/detects_code_complexity.feature
 - features/detects_code_duplication.feature
 - features/detects_code_smells.feature
 - features/detects_magick_numbers.feature
 - features/run.feature
 - features/show_version.feature
+- features/step_definitions/checks_for_vulnerable_gems_steps.rb
 - features/step_definitions/detects_code_complexity_steps.rb
 - features/step_definitions/detects_code_duplication_steps.rb
 - features/step_definitions/detects_code_smells_steps.rb
@@ -253,6 +276,8 @@ test_files:
 - features/step_definitions/validates_style_guide_steps.rb
 - features/support/env.rb
 - features/validates_style_guide.feature
+- spec/fixtures/invalid_Gemfile
+- spec/fixtures/invalid_Gemfile.lock
 - spec/fixtures/invalid_code_complexity.rb
 - spec/fixtures/invalid_code_duplication.rb
 - spec/fixtures/invalid_code_smells.rb
@@ -260,4 +285,6 @@ test_files:
 - spec/fixtures/invalid_style_guide.rb
 - spec/fixtures/strictly_invalid_style_guide.rb
 - spec/fixtures/valid.rb
+- spec/fixtures/valid_Gemfile
+- spec/fixtures/valid_Gemfile.lock
 - spec/spec_helper.rb