warden 1.2.8 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98bbb4bde4e4b1168fd883823a9e63f81cb6be40c117d92fd461299f4de0f86a
-  data.tar.gz: 03ac0df2de9c151a6f5387700141248be127a82177d21da1f1fc2d00db10bc64
+  metadata.gz: b7e6c341f27479e6f36339e5d2c211277b4c0e664c960827c2044dd36b5c1c23
+  data.tar.gz: 62e22ba4d81a887444d60ff033c7a6b0a0a8e723771d15cee045ee83baece801
 SHA512:
-  metadata.gz: 5d8d0d43d9f1a28d12ca7044608e175b08444a46c81c42a6c1ad351d517e45919a653005522c576bd4fe4d8de1d3b2472c52c5b524b32606bb2e69d82a533a33
-  data.tar.gz: 044152b6566f94d9bcdcd4fda5297decb19ed5146adaaee3bdd07b154d9b1e3b9d840c8da21b110add36f8f856f1879cf2547e12298f710b75c734269c86daff
+  metadata.gz: a6b602f560ebc6f04848c0c7e2d9017af8bf55c6cd6e6fec978e28e0463960761eaf488fabdba1b14d78bcf16e352a97d9b95b361142c3a4c14672517ca9e5b5
+  data.tar.gz: 9a6397e9d84063c8f7cf221c878b0657151a0cf01a6f98172b2ca0dfd1d5e7eddf7da9ce616f550928f5f14dcb073553379add7a006acc875fb162a7ce2a8210

data/.github/workflows/ruby.yml

@@ -0,0 +1,27 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Tests
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.6', '2.7' ]
+    name: Ruby ${{ matrix.ruby }}
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.6
+    - name: Install dependencies
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake

data/.gitignore

@@ -3,3 +3,4 @@ pkg
 .*~
 
 *.gem
+Gemfile.lock

data/CHANGELOG.md

@@ -1,86 +1,114 @@
-== Version 1.2.8 / 2018-11-15
+# CHANGELOG
+
+## Version 1.2.9 / 2020-08-31
+* Avoid warning on uninitialized instance variable (#188)
+* Bump rack to 2.2.3 (#190)
+* Remove Gemfile.lock
+* Resolve outstanding TODO entries (#179)
+* A bunch of gem structure cleanup (thanks @olleolleolle)
+* Set winning strategy when :warden is thrown (#174)
+* Bump rack dependency to >= 2.0.9 due to CVEs
+
+## Version 1.2.8 / 2018-11-15
+
 * Bugfix: Flips two lines to allow scopes authenticating from another without stepping on each other's toes. (PR #144)
 * Update `rack` dependency to >= 2.0.6 due to security vulnerability
 * Internal: Add Rubocop Lint checking
 * Internal: Update RSpec to use `.rspec` file
 
-== Version 1.2.7 / 2016-10-12
+## Version 1.2.7 / 2016-10-12
+
 * Added 'frozen_string_literal' comment, bump ruby to 2.3
 
-== Version 1.2.6 / 2016-01-31
+## Version 1.2.6 / 2016-01-31
+
 * Separate test helpers to encapsulate Warden object mocking inside it's own class
 
-== Version 1.2.5 / 2016-01-28
+## Version 1.2.5 / 2016-01-28
+
 * Expands on the test helpers available to make it easier for testing gems
 
-== Version 1.2.3 / 2013-07-14
+## Version 1.2.3 / 2013-07-14
+
 * Fix an issue with lazy loaded sessions
 
-== Version 1.2.2 / 2013-07-12
+## Version 1.2.2 / 2013-07-12
+
 * Support nil session stores on logout
 * Fix strategies blowing up with undefined method base
 
-== Version 1.2.1 / 2012-06-16
+## Version 1.2.1 / 2012-06-16
+
 * Minor caching and speed improvements
 * Add support to #lock in the proxy
 * Add support to after_failed_fetch callback
 
-== Version 1.2.0 / 2012-05-08
+## Version 1.2.0 / 2012-05-08
+
 * Deprecate warden_cookies since it was never functional
 * Add support to serialize_from_session and serialize_into_session per scope
 
-== Version 1.1.1 / 2012-02-16
+## Version 1.1.1 / 2012-02-16
+
 * Allow run_callbacks as an option to set_user and user
 
-== Version 1.1.0 / 2011-11-02
+## Version 1.1.0 / 2011-11-02
+
 * Use the default scopes action when using a bare throw(:warden)
 
-== Version 1.0.6
+## Version 1.0.6
+
 * Remove gem files from the packaged gem
 
-== Version 1.0.3
+## Version 1.0.3
+
 * Do not renew session on user fetch
 
-== Version 1.0.2
+## Version 1.0.2
+
 * Added :intercept_401 to Warden::Config
 
-== Version 1.0.1
+## Version 1.0.1
+
 * Bug fix on strategies errors handler
 
-== Version 1.0.0
+## Version 1.0.0
+
 * Bump!
 * Allow strategies to configure if user should be stored or not
 * Force session id renewal when user is set
 
-== Version 0.10.7
+## Version 0.10.7
+
 * Performance boost. config object to use raw accessors
 * Add per strategy storage option
 
-== Version 0.10.6 / 0.10.7 / 2010-05-22
+## Version 0.10.6 / 0.10.7 / 2010-05-22
+
 * Bugfix set_user was not respecting logouts in hooks
 
-== Version 0.10.4 / 0.10.5 / 2010-05-20
+## Version 0.10.4 / 0.10.5 / 2010-05-20
 * Add action specifying in scope_defaults
 
-== Version 0.10.3 / 2010-03-01
+## Version 0.10.3 / 2010-03-01
 * Bugfix prevent halted winning strategy from being skipped in subsequent runs
 
-== Version 0.10.2 / 2010-03-26
+## Version 0.10.2 / 2010-03-26
 * Halt on fail!.  Add fail to allow cascading
 * cache the winning strategy
 * Make the config object Dupable
 
-== Version 0.10.1 / 2010-03-23
+## Version 0.10.1 / 2010-03-23
 * Merge previous from master
 * tag
 
-== Version 0.10.0 / 2010-03-22
+## Version 0.10.0 / 2010-03-22
 * Allow default strategies to be set on the proxy
 * Provide each scope with it's own default strategies
 * Provide each scope with default set_user opts
 * depricate the Proxy#default_strategies= method
 
-== Version 0.9.5 / 2010-02-28
+## Version 0.9.5 / 2010-02-28
 
 * Add Warden.test_mode!
 * Add Warden.on_next_request
@@ -88,42 +116,42 @@
 ** login_as
 ** logout
 
-== Version 0.9.4 / 2010-02-23
+## Version 0.9.4 / 2010-02-23
 
 * Fix an issue where winning_strategy was not cleaned, allowing multiple scopes to sign in, even when the second one should not
 
-== Version 0.9.3 / 2010-02-17
+## Version 0.9.3 / 2010-02-17
 
 * Add prepend_ to all hooks (josevalim)
 
-== Version 0.9.2 / 2010-02-10
+## Version 0.9.2 / 2010-02-10
 
 * Ruby 1.9 compatibility changes (grimen)
 
-== Version 0.9.1 / 2010-02-09
+## Version 0.9.1 / 2010-02-09
 
 * Support for passing a custom message with Warden::Strategy::Base#success! as second optional (grimen)
 
-== Version 0.9.0 / 2010-01-21
+## Version 0.9.0 / 2010-01-21
 
 * Remove serializers and make strategies more powerful, including cache behavior (josevalim)
 
-== Version 0.8.1 / 2010-01-06
+## Version 0.8.1 / 2010-01-06
 
 * Fix a bug when silence missing serializers is set (josevalim)
 
-== Version 0.8.0 / 2010-01-06
+## Version 0.8.0 / 2010-01-06
 
 * enhancements
   * Add conditionals to callbacks (josevalim)
   * Extract Warden::Config from Warden::Manager (josevalim)
 
-== Version 0.7.0 / 2010-01-04
+## Version 0.7.0 / 2010-01-04
 
 * enhancements
   * Expose config in warden proxy (hassox)
 
-== Version 0.6.0 / 2009-11-16
+## Version 0.6.0 / 2009-11-16
 
 * enhancements
   * added serializers, including session serializer (set by default) and a cookie serializer (josevalim)
@@ -131,24 +159,27 @@
 * deprecation
   * serializer_into_session and serializer_from_session are deprecated, overwrite serialize and deserializer in Warden::Serializers::Session instead (josevalim)
 
-== Version 0.5.3 / 2009-11-10
+## Version 0.5.3 / 2009-11-10
+
 * bug fixes
   * authenticated? and unauthenticated? should return true or false, not the user or false. (hassox)
 
-== Version 0.5.2 / 2009-11-09
+## Version 0.5.2 / 2009-11-09
+
 * enhancements
   * authenticated? always try to serialize the user from session (josevalim)
   * stored_in_session? checks if user information is stored in session, without serializing (josevalim)
   * 401 behaves exactly like throw :warden (staugaard)
 
-=== Version 0.5.1 / 2009-10-25
+## Version 0.5.1 / 2009-10-25
+
 * enhancements
   * Adds yielding to authenticated? and unauthenticated? methods (hassox)
   * Adds an option to silence missing strategies (josevalim)
   * Add an option to authenticate(!) to prevent storage of a user into the session (hassox)
   * allow custom :action to be thrown (josevalim)
 
-=== Version 0.4.0 / 2009-10-12
+## Version 0.4.0 / 2009-10-12
 
 * enhancements
   * add Content-Type header to redirects (staugaard)
@@ -157,7 +188,7 @@
 * bug fixes
   * Do not consume opts twice, otherwise just the first will parse the scope (josevalim)
 
-=== Version 0.3.2 / 2009-09-15
+## Version 0.3.2 / 2009-09-15
 
 * enhancements
   * add a hook for plugins to specify how they can clear the whole section

data/Gemfile

@@ -4,9 +4,9 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'rake'
-gem 'rack', '>= 2.0.6'
+gem 'pry'
 
 group :test do
-  gem 'rspec', '~>3'
+  gem 'rspec', '~> 3'
   gem 'rack-test'
 end

data/LICENSE

@@ -1,4 +1,5 @@
 Copyright (c) 2009-2017 Daniel Neighman
+Copyright (c) 2017-2020 Justin Smestad
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -2,7 +2,7 @@
 
 ## Getting Started
 
-Please see the [Warden Wiki](https://wiki.github.com/hassox/warden) for overview documentation.
+Please see the [Warden Wiki](https://github.com/wardencommunity/warden/wiki) for overview documentation.
 
 ## Maintainers
 

data/lib/warden/proxy.rb

@@ -111,7 +111,7 @@ module Warden
       user
     end
 
-    # Same API as authenticated, but returns a boolean instead of a user.
+    # Same API as authenticate, but returns a boolean instead of a user.
     # The difference between this method (authenticate?) and authenticated?
     # is that the former will run strategies if the user has not yet been
     # authenticated, and the second relies on already performed ones.
@@ -365,9 +365,12 @@ module Warden
       (strategies || args).each do |name|
         strategy = _fetch_strategy(name, scope)
         next unless strategy && !strategy.performed? && strategy.valid?
+        catch(:warden) do
+          _update_winning_strategy(strategy, scope)
+        end
 
         strategy._run!
-        self.winning_strategy = @winning_strategies[scope] = strategy
+        _update_winning_strategy(strategy, scope)
         break if strategy.halted?
       end
     end
@@ -382,6 +385,11 @@ module Warden
         raise "Invalid strategy #{name}"
       end
     end
+
+    # Updates the winning strategy for a given scope
+    def _update_winning_strategy(strategy, scope)
+      self.winning_strategy = @winning_strategies[scope] = strategy
+    end
   end # Proxy
 
 end # Warden

data/lib/warden/strategies/base.rb

@@ -45,6 +45,7 @@ module Warden
         @env, @scope = env, scope
         @status, @headers = nil, {}
         @halted, @performed = false, false
+        @result = nil
       end
 
       # The method that is called from above. This method calls the underlying authenticate! method

data/lib/warden/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 # frozen_string_literal: true
 module Warden
-  VERSION = "1.2.8"
+  VERSION = "1.2.9"
 end

data/warden.gemspec

@@ -7,7 +7,7 @@ require 'warden/version'
 
 Gem::Specification.new do |spec|
   spec.name = "warden"
-  spec.version = Warden::VERSION.dup
+  spec.version = Warden::VERSION
   spec.authors = ["Daniel Neighman", "Justin Smestad", "Whitney Smestad", "José Valim"]
   spec.email = %q{hasox.sox@gmail.com justin.smestad@gmail.com whitcolorado@gmail.com}
   spec.homepage = "https://github.com/hassox/warden"
@@ -20,8 +20,6 @@ Gem::Specification.new do |spec|
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.rdoc_options = ["--charset=UTF-8"]
   spec.require_paths = ["lib"]
-  spec.rubyforge_project = %q{warden}
-  spec.add_dependency "rack", ">= 2.0.6"
+  spec.add_dependency "rack", ">= 2.0.9"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: warden
 version: !ruby/object:Gem::Version
-  version: 1.2.8
+  version: 1.2.9
 platform: ruby
 authors:
 - Daniel Neighman
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-15 00:00:00.000000000 Z
+date: 2020-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -19,14 +19,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.6
+        version: 2.0.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.6
+        version: 2.0.9
 description: 
 email: hasox.sox@gmail.com justin.smestad@gmail.com whitcolorado@gmail.com
 executables: []
@@ -35,12 +35,11 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -64,8 +63,7 @@ licenses:
 - MIT
 metadata: {}
 post_install_message: 
-rdoc_options:
-- "--charset=UTF-8"
+rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -79,8 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: warden
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: An authentication library compatible with all Rack-based frameworks

data/.travis.yml

@@ -1,7 +0,0 @@
-language: ruby
-install:
-  - bundle install
-rvm:
-  - 2.2
-  - 2.3
-  - 2.4.2

data/Gemfile.lock

@@ -1,40 +0,0 @@
-PATH
-  remote: .
-  specs:
-    warden (1.2.8)
-      rack (>= 2.0.6)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    diff-lcs (1.3)
-    rack (2.0.6)
-    rack-test (0.7.0)
-      rack (>= 1.0, < 3)
-    rake (12.1.0)
-    rspec (3.6.0)
-      rspec-core (~> 3.6.0)
-      rspec-expectations (~> 3.6.0)
-      rspec-mocks (~> 3.6.0)
-    rspec-core (3.6.0)
-      rspec-support (~> 3.6.0)
-    rspec-expectations (3.6.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-mocks (3.6.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-support (3.6.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  rack (>= 2.0.6)
-  rack-test
-  rake
-  rspec (~> 3)
-  warden!
-
-BUNDLED WITH
-   1.17.1