waitlist 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 35cfedc9e1889b2aab2989b9341c56397ac720e8
-  data.tar.gz: be60c9da7cf9e5b3100eff50ca07584ccc066172
+  metadata.gz: 6533afd54c85162594112e75d3c9e98753bc88a7
+  data.tar.gz: 33320c6c3bcb723646e3c71e17e75498d5bf2dfe
 SHA512:
-  metadata.gz: 98ee639f050ac83071d0b322bc837c59fb7255611ee26b6659eaea29de8c9bfbe9d56f24ea8778155011ba206917b1820bf895dd388eb74bdf623067609d9f63
-  data.tar.gz: 762ead494757ab9276188df6e7c214c18d387af89050708d72fbb29b68e883c2384aaca07564b2b7b145fd79e578455f211519f939bd685cc1507342a32155cc
+  metadata.gz: 5e93b766869d15614ce15e8fe94ec4b8036d6e2327f01481d8cec81e8b6c75c0b5f6813f2bebbccd6ed9e07cc9da211a8081be371126a89ec72e24a933ba2d28
+  data.tar.gz: 0a0a45b476d1074e28c6f4d174a7b2c9a7f39e8d503a63a5c60204d96aaca091d96dc881ea74a2e9e93bf029df5f337d242988cb02ebc97ad157679135cc04e7

data/app/controllers/waitlist/subscribers_controller.rb

@@ -9,7 +9,7 @@ module Waitlist
 
     def create
       @subscriber = Subscriber.new(subscriber_params)
-      flash[:notice] = 'Thanks for signing up!' if @subscriber.save
+      flash[:notice] = 'Thanks for signing up!' if @subscriber.save && request.format == 'html'
       return_to = params[:return_to] || main_app.root_path
       respond_with @subscriber, location: return_to
     end

data/lib/waitlist/version.rb

@@ -1,3 +1,3 @@
 module Waitlist
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/controllers/waitlist_subscribers_spec.rb

@@ -13,36 +13,46 @@ RSpec.describe Waitlist::SubscribersController do
   end
 
   describe '#create' do
-    context 'with valid address' do
-      before do
-        post :create, subscriber: { email: 'valid.address@thegarage.us' }
+    context 'in response to an html request' do
+      context 'with valid address' do
+        before do
+          post :create, subscriber: { email: 'valid.address@thegarage.us' }
+        end
+        it { should redirect_to '/' }
+        specify { expect(subject.request.flash[:notice]).to eq "Thanks for signing up!" }
       end
 
-      it { should redirect_to '/' }
-    end
-    context 'with valid request and params[:return_to]' do
-      let(:redirect_url) { 'http://google.com' }
-      before do
-        post :create, subscriber: { email: 'valid.address@thegarage.us' }, return_to: redirect_url
+      context 'with valid address and params[:return_to]' do
+        let(:redirect_url) { 'http://google.com' }
+        before do
+          post :create, subscriber: { email: 'valid.address@thegarage.us' }, return_to: redirect_url
+        end
+        it { should redirect_to redirect_url }
       end
-      it { should redirect_to redirect_url }
-    end
+      context 'with an invalid address' do
+        before do
+          post :create, subscriber: { email: "this isn't an email address" }
+        end
 
-    context 'as a json ajax request with invalid paramaters' do
-      before do
-        post :create, format: :json, subscriber: { email: "this isn't an email address" }
+        it { should render_template :new }
       end
-
-      it { should respond_with 422 }
-
     end
 
-    context 'with invalid address' do
-      before do
-        post :create, subscriber: { email: "this isn't an email address" }
+    context 'in reponse to an ajax (json) request' do
+      context 'with valid address' do
+        before do
+          post :create, format: :json, subscriber: { email: "valid.address@thegarage.us" }
+        end
+        specify { expect(subject.request.flash).to be_empty }
       end
 
-      it { should render_template :new }
+      context 'with invalid address' do
+        before do
+          post :create, format: :json, subscriber: { email: "this isn't an email address" }
+        end
+
+        it { should respond_with 422 }
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: waitlist
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - The Garage
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-07 00:00:00.000000000 Z
+date: 2014-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails