waitfor 0.1.0 → 0.1.7

data/spec/waitfor_spec.rb

@@ -1,74 +1,60 @@
 require File.dirname( __FILE__ ) + '/spec_helper.rb'
 
-describe WaitFor, "when event is true" do
-  it "should halt execution for under 1 second" do
-    elapsed_time = timer {
-      WaitFor.upto 1.second do
-        true
-      end
-    }
-
-    elapsed_time.should be < 1.second
+describe WaitFor do
+  context "when event is true" do
+    it "should continue code execution without delay" do
+      Time.should_receive( :now ).once.and_return( NOW )
+      Kernel.should_not_receive( :sleep )
+
+      WaitFor.upto( :seconds => 1 ) { true }
+    end
   end
-end
 
-describe WaitFor, "when event is false" do
-  it "should halt execution for at least 2 seconds, but less than 4 seconds before raising an error" do
-    elapsed_time = timer {
+  context "when event is false" do
+    it "should halt code execution until timer expires then raise an error" do
+      Time.should_receive( :now ).exactly( 3 ).times.and_return( NOW, NOW + 1, NOW + 2 )
+      Kernel.should_receive( :sleep ).once
+
       lambda {
-        WaitFor.upto 2.seconds do
-          false
-        end
+        WaitFor.upto( :seconds => 2 ) { false }
       }.should raise_error
-    }
-    
-    elapsed_time.should be > 2
-    elapsed_time.should be < 4
+    end
   end
-end
 
-describe WaitFor, "when event is false and has custom exception" do
-  it "should raise a CustomTestError error" do
-    lambda {
-      WaitFor.upto( :seconds => 0, :exception => CustomTestError ) do
-        false
-      end
-    }.should raise_error( CustomTestError )
-  end
-end
+  context "when event is initially false but becomes true" do
+    before do
+      ToggleBetweenFalseAndTrue.reset_status
+    end
 
-describe WaitFor, "when event is false and has custom message" do
-  it "should raise an error with a custom message" do
-    lambda {
-      WaitFor.upto( :seconds => 0, :message => "Custom Error Message" ) do
-        false
-      end
-    }.should raise_error( "Custom Error Message" )
-  end
-end
+    it "should halt code execution until event becomes true then continue" do
+      Time.should_receive( :now ).exactly( 2 ).times.and_return( NOW, NOW + 1 )
+      Kernel.should_receive( :sleep ).once
 
-describe WaitFor, "when event is false and has custom exception with a custom message" do
-  it "should raise a CustomTestError error with a custom message" do
-    lambda {
-      WaitFor.upto( :seconds => 0, :exception => CustomTestError, :message => "Custom Error Message" ) do
-        false
-      end
-    }.should raise_error( CustomTestError, "Custom Error Message" )
+      WaitFor.upto( :seconds => 2 ) { ToggleBetweenFalseAndTrue.status? }
+    end
   end
-end
 
-describe WaitFor, "when event is initially false but becomes true " do
-  it "should halt execution for at least 1 second but no more than 3 seconds before continuing on" do
-    event = ToggleBetweenFalseAndTrue.new
+  context "when event is false and has custom exception" do
+    it "should raise a CustomTestError error" do
+      lambda {
+        WaitFor.upto( :seconds => 0, :exception => CustomTestError ) { false }
+      }.should raise_error( CustomTestError )
+    end
+  end
 
-    elapsed_time = timer {
-      WaitFor.upto 2.seconds do
-        event.status
-      end
-    }
+  context "when event is false and has custom message" do
+    it "should raise an error with a custom message" do
+      lambda {
+        WaitFor.upto( :seconds => 0, :message => "Custom Error Message" ) { false }
+      }.should raise_error( "Custom Error Message" )
+    end
+  end
 
-    elapsed_time.should be > 1
-    elapsed_time.should be < 3
+  context "when event is false and has custom exception with a custom message" do
+    it "should raise a CustomTestError error with a custom message" do
+      lambda {
+        WaitFor.upto( :seconds => 0, :exception => CustomTestError, :message => "Custom Error Message" ) { false }
+      }.should raise_error( CustomTestError, "Custom Error Message" )
+    end
   end
 end
-

metadata

@@ -1,7 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: waitfor
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  hash: 21
+  prerelease: 
+  segments: 
+  - 0
+  - 1
+  - 7
+  version: 0.1.7
 platform: ruby
 authors: 
 - James Bobowski
@@ -9,20 +15,25 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-03 00:00:00 -06:00
-default_executable: 
+date: 2011-04-19 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: hoe
-  type: :development
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 5
+        segments: 
+        - 2
+        - 3
+        - 3
         version: 2.3.3
-    version: 
-description: Blocks execution until a specified statement becomes true, or a specified time interval is reached, at which point an error is raised.
+  type: :development
+  version_requirements: *id001
+description: Simple solution to the sleep( ) test anti-pattern. Blocks execution until a supplied block returns true, or a specified time interval is reached, at which point an error is raised.
 email: 
 - james.bobowski@gmail.com
 executables: []
@@ -39,17 +50,22 @@ files:
 - README.rdoc
 - lib/waitfor.rb
 - lib/waitfor/fixnum.rb
+- lib/waitfor/timeout_error.rb
 - lib/waitfor/timer.rb
 - lib/waitfor/version.rb
-- lib/waitfor/waitfor_timeout_error.rb
+- lib/waitfor/settings/configuration.rb
+- lib/waitfor/settings/legacy_parser.rb
+- lib/waitfor/settings/parser.rb
+- spec/configuration_spec.rb
 - spec/fixnum_spec.rb
+- spec/legacy_parser_spec.rb
+- spec/parser_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
 - spec/spec_helper_spec.rb
+- spec/timeout_error_spec.rb
 - spec/timer_spec.rb
 - spec/waitfor_spec.rb
-- spec/waitfor_timeout_error_spec.rb
-has_rdoc: true
 homepage: http://github.com/jamesbobowski/waitfor
 licenses: []
 
@@ -60,21 +76,27 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: waitfor
-rubygems_version: 1.3.5
+rubygems_version: 1.8.7
 signing_key: 
 specification_version: 3
 summary: Generic 'wait for' method

data/lib/waitfor/waitfor_timeout_error.rb

@@ -1,5 +0,0 @@
-module WaitFor #:nodoc:
-  class TimeoutError < RuntimeError #:nodoc:
-
-  end
-end

data/spec/waitfor_timeout_error_spec.rb

@@ -1,6 +0,0 @@
-describe WaitFor::TimeoutError do
-  it "should be of a kind of RuntimeError" do
-    exception = WaitFor::TimeoutError.new
-    exception.should be_a_kind_of( RuntimeError )
-  end
-end