vx-service_connector 0.2.17 → 0.2.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca471671e75ec4f31500012af36283b453356fb9
-  data.tar.gz: 9da8cbc4717cf7207a59d25623951a4b6c338e62
+  metadata.gz: c4d16845570b8f0a590c3a650df7a166125ceed3
+  data.tar.gz: af38d8c131297173381eaf7665584c43a1cf567f
 SHA512:
-  metadata.gz: 3fa7febab44227d34e6b89d7ddcadaa4973461c43988bc4487d41fab7a559d1d99ab5109e7b2f390f906840e3199b9d6a925f25af3055ad4ebf17705783ba9f5
-  data.tar.gz: a8ffd9fc3ed0457e7f6d8c68d05cf95f5311c2952ee6e0a6f800648f1af9fcab2f118dd20edb2d525d41dd6c48fc6ec42d7712c42e172b0fb3e55d4a4ef07ca2
+  metadata.gz: 048f1d236438443d4b24515e9d3896df1e971ab40b03cead9341b293d56440abbaac66c984f743a2669bceb655d876da318c1ca5cceaec6d240490ef48275821
+  data.tar.gz: a4c4faa4ff87610eca86bb38953aefb28f4d1fd612944339fbf58ae5949da282b3a6ee63250f93b8e5588ba1ee59f7d6ab32910b45130facac9aeae8dff83525

data/lib/vx/service_connector/bitbucket/payload.rb

@@ -76,11 +76,15 @@ module Vx
           end
         end
 
+        def commits?
+          not params["commits"].empty?
+        end
+
         def author_email
           if pull_request?
             commit_for_pull_request["author"]["raw"][/.*<([^>]*)/,1]
           else
-            head_commit['raw_author'][/.*<([^>]*)/,1]
+            commits? && head_commit['raw_author'][/.*<([^>]*)/,1]
           end
         end
 
@@ -104,7 +108,7 @@ module Vx
           if pull_request?
             close_pull_request? || !foreign_pull_request?
           else
-            sha == '0000000000000000000000000000000000000000'
+            sha == '0000000000000000000000000000000000000000' || !commits?
           end
         end
 

data/lib/vx/service_connector/github/notices.rb

@@ -13,8 +13,7 @@ module Vx
                 description: description,
                 target_url:  build_url
               )
-            rescue Octokit::UnprocessableEntity => e
-              STDERR.puts "ERROR: #{e.inspect}"
+            rescue Octokit::UnprocessableEntity, Octokit::Unauthorized
             end
           end
         end

data/lib/vx/service_connector/version.rb

@@ -1,5 +1,5 @@
 module Vx
   module ServiceConnector
-    VERSION = "0.2.17"
+    VERSION = "0.2.18"
   end
 end

data/spec/fixtures/bitbucket/payload/bug_1_empty_commits.json

@@ -0,0 +1,18 @@
+{
+  "repository": {
+    "website": "",
+    "fork": false,
+    "name": "preacc",
+    "scm": "git",
+    "owner": "yeticoders",
+    "absolute_url": "/yeticoders/preacc/",
+    "slug": "preacc",
+    "is_private": true
+  },
+  "truncated": false,
+  "commits": [
+
+  ],
+  "canon_url": "https://bitbucket.org",
+  "user": "eagleas"
+}

data/spec/lib/bitbucket_payload_spec.rb

@@ -79,4 +79,11 @@ describe Vx::ServiceConnector::Bitbucket::Payload do
     its(:ignore?) { should be_true }
   end
 
+  context 'push with empty commits' do
+
+    let(:content) { read_json_fixture 'bitbucket/payload/bug_1_empty_commits' }
+
+    its(:ignore?) { should be_true }
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vx-service_connector
 version: !ruby/object:Gem::Version
-  version: 0.2.17
+  version: 0.2.18
 platform: ruby
 authors:
 - Dmitry Galinsky
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-24 00:00:00.000000000 Z
+date: 2014-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -174,6 +174,7 @@ files:
 - spec/fixtures/bitbucket/create_hook.json
 - spec/fixtures/bitbucket/deploy_keys.json
 - spec/fixtures/bitbucket/hooks.json
+- spec/fixtures/bitbucket/payload/bug_1_empty_commits.json
 - spec/fixtures/bitbucket/payload/created_pull_request.json
 - spec/fixtures/bitbucket/payload/declined_pull_request.json
 - spec/fixtures/bitbucket/payload/foreign_pull_request.json
@@ -262,6 +263,7 @@ test_files:
 - spec/fixtures/bitbucket/create_hook.json
 - spec/fixtures/bitbucket/deploy_keys.json
 - spec/fixtures/bitbucket/hooks.json
+- spec/fixtures/bitbucket/payload/bug_1_empty_commits.json
 - spec/fixtures/bitbucket/payload/created_pull_request.json
 - spec/fixtures/bitbucket/payload/declined_pull_request.json
 - spec/fixtures/bitbucket/payload/foreign_pull_request.json