vwo-sdk 1.24.0 → 1.24.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb7f9b19ca3bcec001ea97863046b3d33f3806e8a3b4b0fb76d3d3be0dbe1e41
-  data.tar.gz: 30357fe06aeb296f73fcc8699baf89e9c291a1dd3d44bb7e57c6be7f4317aa13
+  metadata.gz: 68dad84f9b03958ca980c9f9ef2dc91faabdf57bfc33a55baaf5316123eb010b
+  data.tar.gz: de01033026fe5f493d7a6a1419c65a60f41a43ac85526a4f16f90448ff31a3bb
 SHA512:
-  metadata.gz: 171a4e3783e5efd552f8e327deece79d4152a6221cb64efc35d544ba6a806b6eb498587683386e927bf22a2cd7fd6e69cdeb986a3ceec46520203ce513cba169
-  data.tar.gz: 8bf89ba2183b67b158dc0d97cdcf691abde8ea3d30325ab0677dd8e3f9236b72ec55c734c28464fca08420f00028d7ec2b717c64a233822e65292f46cad25b61
+  metadata.gz: 81bfc307f0aa0482c3426edd657ac960fde1d95843401e1f583dc96b6785ef3c6e59f10b1d577424da40d956cd792618275a4451c1f4dc4dff3458454d15f238
+  data.tar.gz: 1f8dadef134e4064962bf606b43de36f9b4e4d4ed00c932948b56ab45960e430e42b20edb9e2eae65709091067dce162959165028698d0010ff767657887f1fd

data/lib/vwo/constants.rb

@@ -27,7 +27,7 @@ class VWO
     HTTP_PROTOCOL = 'http://'
     HTTPS_PROTOCOL = 'https://'
     URL_NAMESPACE = '6ba7b811-9dad-11d1-80b4-00c04fd430c8'
-    SDK_VERSION = '1.24.0'
+    SDK_VERSION = '1.24.1'
     SDK_NAME = 'ruby'
     VWO_DELIMITER = '_vwo_'
     MAX_EVENTS_PER_REQUEST = 5000

data/lib/vwo/enums.rb

@@ -201,7 +201,6 @@ class VWO
         TAG_KEY_LENGTH_EXCEEDED = '(%<file>s): In API: %<api_name>s, the length of tag_key:%<tag_key>s and userID: %<user_id>s can not be greater than 255'
         TRACK_API_MISSING_PARAMS = '(%<file>s): "track" API got bad parameters. It expects campaignKey(null/String/array) as first, userId(String/Number) as second and goalIdentifier (string) as third argument. options is revenueValue(Float/Number/String) and is required for revenue goal only.'
         NO_CAMPAIGN_FOUND = '(%<file>s): No campaign found for goal_identifier:%<goal_identifier>s. Please verify from VWO app.'
-        INVALID_TRACK_RETURNING_USER_VALUE  = '(%<file>s): should_track_returning_user should be boolean'
         INVALID_GOAL_TYPE = '(%<file>s): goal_type_to_track should be certain strings'
         EVENT_BATCHING_NOT_OBJECT = '(%<file>s): Batch events settings are not of type object.'
         EVENTS_PER_REQUEST_INVALID = '(%<file>s): events_per_request should be an integer'

data/lib/vwo.rb

@@ -89,25 +89,6 @@ class VWO
       return
     end
 
-    if options.key?(:should_track_returning_user)
-      if [true, false].include? options[:should_track_returning_user]
-        @should_track_returning_user = options[:should_track_returning_user]
-        usage_stats[:tr] = 1 if @should_track_returning_user
-      else
-        @logger.log(
-          LogLevelEnum::ERROR,
-          format(
-            LogMessageEnum::ErrorMessages::INVALID_TRACK_RETURNING_USER_VALUE,
-            file: FILE
-          )
-        )
-        @is_instance_valid = false
-        return
-      end
-    else
-      @should_track_returning_user = false
-    end
-
     if options.key?(:goal_type_to_track)
       if GOAL_TYPES.key? options[:goal_type_to_track]
         @goal_type_to_track = options[:goal_type_to_track]
@@ -303,10 +284,9 @@ class VWO
     custom_variables = options[:custom_variables]
     variation_targeting_variables = options[:variation_targeting_variables]
 
-    should_track_returning_user = get_should_track_returning_user(options)
     # Validate input parameters
     unless valid_string?(campaign_key) && valid_string?(user_id) && (custom_variables.nil? || valid_hash?(custom_variables)) &&
-      (variation_targeting_variables.nil? || valid_hash?(variation_targeting_variables)) && [true, false].include?(should_track_returning_user)
+      (variation_targeting_variables.nil? || valid_hash?(variation_targeting_variables))
       @logger.log(
         LogLevelEnum::ERROR,
         format(
@@ -381,7 +361,7 @@ class VWO
       return
     end
 
-    if is_eligible_to_send_impression(should_track_returning_user)
+    if is_eligible_to_send_impression()
       if defined?(@batch_events)
         impression = create_bulk_event_impression(
           @settings_file,
@@ -587,12 +567,11 @@ class VWO
     revenue_value = options[:revenue_value]
     custom_variables = options[:custom_variables]
     variation_targeting_variables = options[:variation_targeting_variables]
-    should_track_returning_user = get_should_track_returning_user(options)
     goal_type_to_track = get_goal_type_to_track(options)
 
     # Check for valid args
     unless (valid_string?(campaign_key) || campaign_key.is_a?(Array) || campaign_key.nil?) && valid_string?(user_id) && valid_string?(goal_identifier) && (custom_variables.nil? || valid_hash?(custom_variables)) &&
-      (variation_targeting_variables.nil? || valid_hash?(variation_targeting_variables)) && [true, false].include?(should_track_returning_user) && (GOAL_TYPES.key? (goal_type_to_track))
+      (variation_targeting_variables.nil? || valid_hash?(variation_targeting_variables)) && (GOAL_TYPES.key? (goal_type_to_track))
       # log invalid params
       @logger.log(
         LogLevelEnum::ERROR,
@@ -682,7 +661,7 @@ class VWO
             updated_goal_identifier += VWO_DELIMITER + goal_identifier
             @variation_decider.save_user_storage(user_id, campaign['key'], campaign['name'], variation['name'], updated_goal_identifier) if variation['name']
             # set variation at user storage
-          elsif !should_track_returning_user
+          else
             @logger.log(
               LogLevelEnum::INFO,
               format(
@@ -806,7 +785,6 @@ class VWO
     # Retrieve custom variables
     custom_variables = options[:custom_variables]
     variation_targeting_variables = options[:variation_targeting_variables]
-    should_track_returning_user = get_should_track_returning_user(options)
     @logger.log(
       LogLevelEnum::INFO,
       format(
@@ -818,7 +796,7 @@ class VWO
     )
     # Validate input parameters
     unless valid_string?(campaign_key) && valid_string?(user_id) && (custom_variables.nil? || valid_hash?(custom_variables)) &&
-      (variation_targeting_variables.nil? || valid_hash?(variation_targeting_variables)) && [true, false].include?(should_track_returning_user)
+      (variation_targeting_variables.nil? || valid_hash?(variation_targeting_variables))
       @logger.log(
         LogLevelEnum::ERROR,
         format(
@@ -874,7 +852,7 @@ class VWO
 
     # if campaign type is feature_test Send track call to server
 
-    if is_eligible_to_send_impression(should_track_returning_user)
+    if is_eligible_to_send_impression()
       if defined?(@batch_events)
         impression = create_bulk_event_impression(
           @settings_file,
@@ -1222,23 +1200,8 @@ class VWO
     false
   end
 
-  def get_should_track_returning_user(options)
-    if !options.key?(:should_track_returning_user)
-      options[:should_track_returning_user] = @should_track_returning_user
-    elsif ![true, false].include?(options[:should_track_returning_user])
-      @logger.log(
-        LogLevelEnum::ERROR,
-        format(
-          LogMessageEnum::ErrorMessages::INVALID_TRACK_RETURNING_USER_VALUE,
-          file: FILE
-        )
-      )
-    end
-    options[:should_track_returning_user]
-  end
-
-  def is_eligible_to_send_impression(should_track_returning_user = false)
-    !@user_storage || !@variation_decider.has_stored_variation || should_track_returning_user
+  def is_eligible_to_send_impression()
+    !@user_storage || !@variation_decider.has_stored_variation
   end
 
   def flush_events

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vwo-sdk
 version: !ruby/object:Gem::Version
-  version: 1.24.0
+  version: 1.24.1
 platform: ruby
 authors:
 - VWO
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-07 00:00:00.000000000 Z
+date: 2021-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codecov