vsafe-ruby 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9554215e285634ed75d2a15ee084aee48fd4dc21
-  data.tar.gz: fc340a8c12c446ec0e6c168b9fcb777e3a7dd819
+  metadata.gz: 42ca5c86cc1aae19ac162345d5c41e9ab5a2ff13
+  data.tar.gz: 35e6a7bd5d93ca41f493ab25c44570c9190e105c
 SHA512:
-  metadata.gz: 15a2f77685b3c972eba40a1c1db35112f0ca56706048c6632889b0be2685bdbf3635307948177c407247b4b95712188cc62b169ae23513d3e78add18c1661c1e
-  data.tar.gz: 6668a08b8e4c50006814118e5ce1f8de165f7fc9eec840e84bbe3cb251255a3f6b0d41c29016564a43a67e0fd43c6bd3e5f26bfc9f6bfc3b29ac0f9bc65e9abf
+  metadata.gz: e7e79ed77717746c8a6a87da802cd4a88926a86da6d093d1b1c59674651e9734a4d3c9f4f8d3c651e453e7188a36cb553c22ec16f14bf6120ee36f825c89f51b
+  data.tar.gz: 2c64494c69dbb7e78c6e2571d5bead80f4dcc2d828d88d55927a92f6c395d6a8257868857c13731c53b80adb4c03bc49ab09ba57d7443dd7d9af8c718f689e69

data/README.md

@@ -1,5 +1,6 @@
 # VSafe
-
+[![Build Status](https://travis-ci.org/listia/vsafe-ruby.svg?branch=master)](https://travis-ci.org/listia/vsafe-ruby)
+[![Gem Version](https://badge.fury.io/rb/vsafe-ruby.svg)](http://badge.fury.io/rb/vsafe-ruby)
 
 ## Installation
 
@@ -46,13 +47,18 @@ client = VSafe::Client.new
 ```
 
 ##### Heartbeat request
+
+Check if VSafe API is up or not.
+
 ```ruby
-# Check if VSafe API is up or not
 client.heartbeat.success?
 
 ```
 
 ##### Get vesta session tags
+
+Get web session id for `WEB` charge source.
+
 ```ruby
 response = client.get_session_tags # => #<VSafe::Responses::GetSessionTags ...>
 
@@ -61,42 +67,6 @@ response.org_id
 response.web_session_id
 ```
 
-##### Authorize charge
-```ruby
-auth_params = {
-  TransactionID: "...",
-  ChargeAccountNumberToken: "...",
-  ChargeAmount: 10,
-  WebSessionID: "100_000000000", # Fingerprint generated by get_session_tags as part of ChargeSource::WEB transaction
-  PaymentDescriptor: "...",
-  ChargeSource: VSafe::ChargeSource::WEB, # Or VSafe::ChargeSource::PPD/VSafe::ChargeSource::TEL
-  RiskInformation: "...", # XML string for the transaction
-  IsTempToken: false,
-  CardHolderFirstName: "Foo",
-  CardHolderLastName: "Bar",
-  CardHolderAddressLine1: "...",
-  CardHolderAddressLine2: "...",
-  CardHolderCity: "...",
-  CardHolderRegion: "...",
-  CardHolderPostalCode: "...",
-  CardHolderCountryCode: "...",
-  ChargeCVN: 123, # Card's CVV
-  ChargeExpirationMMYY: "1221", # Card's expiration date in MMYY format
-  StoreCard: true # Get a permanent token or not
-}
-
-client.charge_authorize(params) # => #<VSafe::Responses::ChargeAuthorize ...>
-
-# Response attributes
-response.avs_result
-response.auth_result
-response.cvn_result
-response.charge_permanent_token
-response.payment_acquirer_name
-response.payment_id
-response.payment_status
-```
-
 ##### Authorize charge
 
 Authorize a credit card charge attempt for later confirm usage.

data/lib/vsafe/client.rb

@@ -15,9 +15,6 @@ module VSafe
   class Client
     SANDBOX_FINGERPRINT_PATH = "ThreatMetrixUIRedirector".freeze
     FINGERPRINT_PATH = "PaySafeUIRedirector".freeze
-    # We should only use JSONP_SERVICE_PATH for charge_acct_to_tempory_token call in web js.
-    JSONP_SERVICE_PATH = "GatewayProxyJSON/Service".freeze
-    SERVICE_PATH = "GatewayProxy/Service".freeze
     REQUEST_CONTENT_TYPE = "application/json; charset=utf-8".freeze
 
     attr_reader :config
@@ -64,7 +61,7 @@ module VSafe
     def service_url(endpoint = nil, jsonp = false)
       parts = [
         config.url,
-        jsonp ? JSONP_SERVICE_PATH : SERVICE_PATH
+        jsonp ? config.jsonp_service_path : config.service_path
       ]
       parts << endpoint if endpoint
 

data/lib/vsafe/config.rb

@@ -3,20 +3,30 @@ module VSafe
     DEFAULT_REQUEST_TIMEOUT = 20 # seconds
     DEFAULT_SANDBOX_URL = "https://paysafesandbox.ecustomersupport.com".freeze
     DEFAULT_PRODUCTION_URL = "https://paysafe.ecustomerpayments.com".freeze
+    DEFAULT_JSONP_SERVICE_PATH = "GatewayProxyJSON/Service".freeze
+    DEFAULT_SERVICE_PATH = "GatewayProxy/Service".freeze
 
-    attr_accessor :sandbox,
+    attr_accessor :sandbox_url,
+                  :production_url,
+                  :sandbox,
                   :account_name,
                   :password,
+                  :service_path,
+                  :jsonp_service_path,
                   :request_timeout
 
     def initialize
       # Set sandbox to true by default
       @sandbox = true
+      @service_path = DEFAULT_SERVICE_PATH
+      @jsonp_service_path = DEFAULT_JSONP_SERVICE_PATH
       @request_timeout = DEFAULT_REQUEST_TIMEOUT
+      @sandbox_url = DEFAULT_SANDBOX_URL
+      @production_url = DEFAULT_PRODUCTION_URL
     end
 
     def url
-      sandbox ? DEFAULT_SANDBOX_URL : DEFAULT_PRODUCTION_URL
+      sandbox ? @sandbox_url : @production_url
     end
   end
 end

data/lib/vsafe/version.rb

@@ -1,3 +1,3 @@
 module VSafe
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/vsafe/client_spec.rb

@@ -150,13 +150,35 @@ RSpec.describe VSafe::Client do
     end
 
     context "when jsonp is false" do
-      let(:service_path) { VSafe::Client::SERVICE_PATH }
+      let(:service_path) { VSafe::Config::DEFAULT_SERVICE_PATH }
 
       it_behaves_like "returns url"
     end
 
     context "when jsonp is true" do
-      let(:service_path) { VSafe::Client::JSONP_SERVICE_PATH }
+      let(:service_path) { VSafe::Config::DEFAULT_JSONP_SERVICE_PATH }
+
+      it_behaves_like "returns url", true
+    end
+
+    context "when custom service_path is set" do
+      let(:service_path) { "__custom_service" }
+      let(:client) {
+        VSafe::Client.new do |config|
+          config.service_path = "__custom_service"
+        end
+      }
+
+      it_behaves_like "returns url"
+    end
+
+    context "when custom jsonp_service_path is set" do
+      let(:service_path) { "__custom_jsonp" }
+      let(:client) {
+        VSafe::Client.new do |config|
+          config.jsonp_service_path = "__custom_jsonp"
+        end
+      }
 
       it_behaves_like "returns url", true
     end

data/spec/vsafe/config_spec.rb

@@ -2,13 +2,41 @@ require "spec_helper"
 require "vsafe/config"
 
 RSpec.describe VSafe::Config do
+  let (:config) { VSafe::Config.new }
+  
   describe ".new" do
     it "sets default configs" do
-      config = VSafe::Config.new
-
       expect(config.sandbox).to eq(true)
       expect(config.request_timeout).to be_a(Fixnum)
       expect(config.url).not_to be_empty
     end
   end
+  
+  describe "#url" do
+    context "sandbox is true" do
+      it "uses default sandbox_url" do
+        expect(config.url).to eq(VSafe::Config::DEFAULT_SANDBOX_URL)
+      end
+      
+      it "uses custom sandbox_url when sandbox" do
+        config.sandbox_url = "https://www.google.com"
+        expect(config.url).to eq("https://www.google.com")
+      end
+    end
+    
+    context "sandbox is not true" do
+      before do
+        config.sandbox = false
+      end
+      
+      it "uses default production_url when not sandbox" do
+        expect(config.url).to eq(VSafe::Config::DEFAULT_PRODUCTION_URL)
+      end
+      
+      it "uses custom production_url when not sandbox" do
+        config.production_url = "https://www.google.com"
+        expect(config.url).to eq("https://www.google.com")
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vsafe-ruby
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Xiaoming Lu
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-06-30 00:00:00.000000000 Z
+date: 2016-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty