vpos 0.1.3 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89cc2923597e888adbd3b0ed950546c4aa62e91912cceff1406de414452f2b1c
-  data.tar.gz: de0949ee1d315d7e8f000320c0b28bfa4dc7b0127fe7fd715a502225e515209d
+  metadata.gz: 10b8e6fb86c8c97d29a81597f7cda1c9752d791ca9550c6b190dd06054ebc34b
+  data.tar.gz: 2c468628a9fcf6bb132ef7f80418a7a882acb0232ccb4c3774c11f23c3fd27e0
 SHA512:
-  metadata.gz: 27485c1d09f1f010d6499e081dd39a86c18241dbc9d2c105795f58c636df36f6e550543397be28f4180dcb52f94883f7fc55bf32e9575989983503d4c30ea121
-  data.tar.gz: 7199d91f1e2e7421770f2f1f07c692761ed090cec9f84e795ea645348e6647e54dce341ca7f3e66dfed703e8f2049725b7cf57189e952610f191b4d9a18f8294
+  metadata.gz: 5469c418cd3b02970808267cb0def075c324c2e17c6982a986c06db04fca2fcd1fa17fccd19b322e1b46d2bc72eec5403542de672a08a64d60225488426da590
+  data.tar.gz: dfb359eb34f3e1b7f829e4abd87d452384285343672eb08a2b01b21d4ee2803ace52d56d76478adadd5d60e12e30310b8c9b19afc77babf885a9f3add2337055

data/.github/workflows/ruby.yml

@@ -30,7 +30,7 @@ jobs:
     - name: Install dependencies
       run: bundle install
     - name: Run tests
-      run: bundle exec rake
+      run: rspec
       env:
         MERCHANT_VPOS_TOKEN: ${{ secrets.MERCHANT_VPOS_TOKEN }}
         GPO_POS_ID: ${{ secrets.GPO_POS_ID }}

data/.gitignore

@@ -23,3 +23,4 @@ test/tmp
 test/version_tmp
 tmp
 example.rb
+.idea

data/.ruby-version

@@ -0,0 +1 @@
+2.5.8

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    vpos (0.1.3)
+    vpos (1.0.1)
       httparty (~> 0.18.1)
-      rspec (~> 3.9.0)
+      rspec (~> 3.9, >= 3.9.0)
 
 GEM
   remote: https://rubygems.org/
@@ -16,7 +16,7 @@ GEM
       mime-types-data (~> 3.2015)
     mime-types-data (3.2020.1104)
     multi_xml (0.6.0)
-    rake (10.5.0)
+    rake (12.3.3)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -35,9 +35,9 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 2.1.4)
-  rake (~> 10.0)
+  bundler (~> 2.2, >= 2.2.3)
+  rake (~> 12.3, >= 12.3.3)
   vpos!
 
 BUNDLED WITH
-   2.1.4
+   2.2.6

data/README.md

@@ -1,15 +1,14 @@
 # vPOS Ruby
-
-![Ruby](https://github.com/nextbss/vpos-ruby/workflows/Ruby/badge.svg)
+[![Ruby](https://github.com/v-pos/vpos-ruby/actions/workflows/ruby.yml/badge.svg?branch=main)](https://github.com/v-pos/vpos-ruby/actions/workflows/ruby.yml)
 [![Gem Version](https://badge.fury.io/rb/vpos.svg)](https://badge.fury.io/rb/vpos)
-[![](https://img.shields.io/badge/nextbss-opensource-blue.svg)](https://www.nextbss.co.ao)
+[![](https://img.shields.io/badge/vPOS-OpenSource-blue.svg)](https://www.nextbss.co.ao)
 
 This ruby library helps you easily interact with the vPOS API,
 Allowing merchants apps/services to request a payment from a client through his/her mobile phone number.
 
 The service currently works for solutions listed below:
 
-EMIS (Multicaixa Express)
+- EMIS GPO (Multicaixa Express)
 
 Want to know more about how we are empowering merchants in Angola? See our [website](https://vpos.ao)
 
@@ -24,7 +23,7 @@ See our documentation on [developer.vpos.ao](https://developer.vpos.ao)
 
 ## Installation
 ```ruby
-gem 'vpos', '~> 0.1.2'
+gem 'vpos', '~> 1.0.0'
 ```
 
 or 
@@ -34,9 +33,32 @@ gem install vpos
 ```
 
 ### Configuration
-This ruby library requires you set up the following environment variables on your machine before
-interacting with the API using this library:
+This ruby library requires you to have:
+- POS_ID provided by EMIS that can be requested through your support bank.
+- Supervisor Card provided by EMIS that can be requested through your support bank.
+- Token provided by vPOS that can be generated through vPOS [merchant](https://merchant.vpos.ao) portal.
+
+Don't have this information? [Talk to us](suporte@vpos.ao)
+
+Given you have all the requirements above, you will now
+be able to authenticate and communicate effectively with our API using this library. 
+
+The next section will show the various actions that can be performed by you, the merchant.
+
+## Use
+### Create Instance
+
+```ruby
+require 'vpos'
+
+# use the default environment variables option
+merchant = Vpos.new
+
+# or use optional arguments option
+merchant = Vpos.new(token: 'your_token_here', environment: 'PRD')
+```
 
+#### Environment variables
 | Variable | Description | Required |
 | --- | --- | --- |
 | `GPO_POS_ID` | The Point of Sale ID provided by EMIS | true |
@@ -44,30 +66,31 @@ interacting with the API using this library:
 | `MERCHANT_VPOS_TOKEN` | The API token provided by vPOS | true |
 | `PAYMENT_CALLBACK_URL` | The URL that will handle payment notifications | false |
 | `REFUND_CALLBACK_URL` | The URL that will handle refund notifications | false |
-| `VPOS_ENVIRONMENT` | The vPOS environment, leave empty for `sandbox` mode and use `"prd"` for `production`.  | false |
 
-Don't have this information? [Talk to us](suporte@vpos.ao)
-
-Given you have set up all the environment variables above with the correct information, you will now
-be able to authenticate and communicate effectively with our API using this library. 
+or using one of the optional arguments
 
-The next section will show the various payment actions that can be performed by you, the merchant.
+#### Optional Arguments
+| Argument | Description | Type |
+| --- | --- | --- |
+| `token` | Token generated at [vPOS](https://merchant.vpos.ao) dashboard | `string`
+| `pos_id` | Merchant POS ID provided by EMIS | `string`
+| `supervisor_card` | Merchant Supervisor Card number provided by EMIS | `string`
+| `payment_callback_url` | Merchant application JSON endpoint to accept the callback payment response | `string`
+| `refund_callback_url` | Merchant application JSON endpoint to accept the callback refund response | `string`
+| `environment` | The vPOS environment, leave empty for `sandbox` mode and use `"PRD"` for `production`.  | `string` |
 
 ### Get all Transactions
 This endpoint retrieves all transactions.
 
 ```ruby
-require 'vpos'
-transactions = Vpos.get_transactions
+transaction = merchant.get_transactions
 ```
 
 ### Get a specific Transaction
 Retrieves a transaction given a valid transaction ID.
 
-
 ```ruby
-require 'vpos'
-transactions = Vpos.get_transaction("1jHbXEbRTIbbwaoJ6w06nLcRG7X")
+transaction = merchant.get_transaction('1jHbXEbRTIbbwaoJ6w06nLcRG7X')
 ```
 
 | Argument | Description | Type |
@@ -79,22 +102,19 @@ Creates a new payment transaction given a valid mobile number associated with a
 and a valid amount.
 
 ```ruby
-require 'vpos'
-payment = Vpos.new_payment("900111222", "123.45")
+payment = merchant.new_payment('900111222', '123.45')
 ```
 
 | Argument | Description | Type |
 | --- | --- | --- |
 | `mobile` | The mobile number of the client who will pay | `string`
-| `amount` | The amount the client should pay, eg. "259.99", "259,000.00" | `string`
+| `amount` | The amount the client should pay, eg. "259.99", "259000.00" | `string`
 
 ### Request Refund
 Given an existing `parent_transaction_id`, request a refund.
 
 ```ruby
-require 'vpos'
-
-refund = Vpos.new_refund("1kTFGhJH8i58uD9MdJpMjWnoE")
+refund = merchant.new_refund('1kTFGhJH8i58uD9MdJpMjWnoE')
 ```
 
 | Argument | Description | Type |
@@ -107,19 +127,17 @@ Poll the status of a transaction given a valid `request_id`.
 Note: The `request_id` in this context is essentially the `transaction_id` of an existing request. 
 
 ```ruby
-require 'vpos'
-transactions = Vpos.get_request("1jHbXEbRTIbbwaoJ6w06nLcRG7X")
+transaction = merchant.get_request('1jHbXEbRTIbbwaoJ6w06nLcRG7X')
 ```
 
 | Argument | Description | Type |
 | --- | --- | --- |
 | `request_id` | The ID of transaction you wish to poll | `string`
 
-
 ### Have any doubts?
 In case of any doubts, bugs, or the like, please leave an issue. We would love to help.
 
 License
 ----------------
 
-The library is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
+The library is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/lib/vpos.rb

@@ -1,5 +1,43 @@
 require_relative "vpos_module"
 
-class Vpos 
+class Vpos
   include VposModule
+
+  def initialize(environment: default_environment, token: set_token, pos_id: default_pos_id, supervisor_card: default_supervisor_card, payment_callback_url: default_payment_callback_url, refund_callback_url: default_refund_callback_url)
+    @environment = environment
+    @token = token
+    @pos_id = pos_id
+    @supervisor_card = supervisor_card
+    @payment_callback_url = payment_callback_url
+    @refund_callback_url = refund_callback_url
+  end
+
+  private
+
+  def default_pos_id
+    pos_id = ENV['GPO_POS_ID']
+    "#{pos_id}".to_i
+  end
+
+  def default_supervisor_card
+    supervisor_card = ENV['GPO_SUPERVISOR_CARD']
+    "#{supervisor_card}"
+  end
+
+  def set_token
+    token = ENV['MERCHANT_VPOS_TOKEN']
+    "Bearer #{token}"
+  end
+
+  def default_payment_callback_url
+    ENV['PAYMENT_CALLBACK_URL']
+  end
+
+  def default_refund_callback_url
+    ENV['REFUND_CALLBACK_URL']
+  end
+
+  def default_environment
+    ENV['VPOS_PROFILE']
+  end
 end

data/lib/vpos/version.rb

@@ -1,3 +1,3 @@
 module VposModule
-  VERSION = "0.1.3"
+  VERSION = "1.0.2"
 end

data/lib/vpos_module.rb

@@ -7,14 +7,14 @@ module VposModule
   include HTTParty
   follow_redirects false
 
-  def new_payment(customer, amount, pos_id: default_pos_id, callback_url: default_payment_callback_url)
+  def new_payment(customer, amount, pos_id: @pos_id, callback_url: @payment_callback_url)
     content = set_headers
     content[:body] = {type:"payment", pos_id: pos_id, mobile: customer, amount: amount, callback_url: callback_url}.to_json
     request = HTTParty.post("#{host}/transactions", content)
     return_vpos_object(request)
   end
 
-  def new_refund(transaction_id, supervisor_card: default_supervisor_card, callback_url: default_refund_callback_url)
+  def new_refund(transaction_id, supervisor_card: @supervisor_card, callback_url: @refund_callback_url)
     content = set_headers
     content[:body] = {type: "refund", parent_transaction_id: transaction_id, supervisor_card: supervisor_card, callback_url: callback_url}.to_json
     request = HTTParty.post("#{host}/transactions", content)
@@ -31,14 +31,14 @@ module VposModule
     return_vpos_object(request)
   end
 
-  def get_request_id(request)
-    if request[:location].nil?
+  def get_request_id(response)
+    if response[:location].nil?
       HTTParty.get("#{host}/references/invalid", set_headers)
     else
-      if request[:status] == 202
-        request[:location].gsub("/api/v1/requests/", "")
+      if response[:status_code] == 202
+        response[:location].gsub("/api/v1/requests/", "")
       else
-        request[:location].gsub("/api/v1/transactions/", "")
+        response[:location].gsub("/api/v1/transactions/", "")
       end
     end
   end
@@ -52,51 +52,26 @@ module VposModule
     def return_vpos_object(request)
       case request.response.code.to_i
       when 200, 201
-        return {status: request.response.code.to_i, message: request.response.message, data: request.parsed_response}
+        return {status_code: request.response.code.to_i, message: request.response.message, data: request.parsed_response}
       when 202, 303
-        return {status: request.response.code.to_i, message: request.response.message, location: request.headers["location"]}
+        return {status_code: request.response.code.to_i, message: request.response.message, location: request.headers["location"]}
       else
-        return {status: request.response.code.to_i, message: request.response.message, details: request.parsed_response["errors"]}
+        return {status_code: request.response.code.to_i, message: request.response.message, details: request.parsed_response["errors"]}
       end
     end
 
     def set_headers
       content = {}
-      headers = {'Content-Type' => "application/json", 'Accept' => "application/json", 'Authorization' => set_token, 'Idempotency-Key' => SecureRandom.uuid}
+      headers = {'Content-Type' => "application/json", 'Accept' => "application/json", 'Authorization' => @token, 'Idempotency-Key' => SecureRandom.uuid}
       content[:headers] = headers
-      return content
-    end
-
-    def default_pos_id
-      pos_id = ENV["GPO_POS_ID"]
-      return "#{pos_id}".to_i
-    end
-
-    def default_supervisor_card
-      supervisor_card = ENV["GPO_SUPERVISOR_CARD"]
-      return "#{supervisor_card}"
-    end
-    
-    def set_token
-      token = ENV["MERCHANT_VPOS_TOKEN"]
-      return "Bearer #{token}"
-    end
-
-    def default_payment_callback_url
-      url = ENV["PAYMENT_CALLBACK_URL"]
-      return url
-    end
-
-    def default_refund_callback_url
-      url = ENV["REFUND_CALLBACK_URL"]
-      return url
+      content
     end
 
     def host
-      if ENV["VPOS_ENVIRONMENT"] == "PRD"
-        return "https://api.vpos.ao/api/v1"
+      if @environment == "PRD"
+        "https://api.vpos.ao/api/v1"
       else
-        return "https://sandbox.vpos.ao/api/v1"
+        "https://sandbox.vpos.ao/api/v1"
       end
     end
 end

data/vpos.gemspec

@@ -6,11 +6,11 @@ Gem::Specification.new do |spec|
   spec.name          = "vpos"
   spec.version       = VposModule::VERSION
   spec.authors       = ["Sergio Maziano"]
-  spec.email         = ["sergio@nextbss.co.ao"]
+  spec.email         = ["sergio.maziano@vpos.ao"]
 
   spec.summary       = %q{The one stop shop for online payments in Angola.}
   spec.description   = %q{The one stop shop for online payments in Angola, allowing you to process payments requests from EMIS GPO through vPOS.}
-  spec.homepage      = "https://github.com/nextbss/vpos-ruby"
+  spec.homepage      = "https://github.com/v-pos/vpos-ruby"
   spec.license       = "MIT"
 
   # Specify which files should be added to the gem when it is released.
@@ -22,8 +22,8 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 2.2.3"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler", '~> 2.2', '>= 2.2.3'
+  spec.add_development_dependency 'rake', '~> 12.3', '>= 12.3.3'
   spec.add_dependency "httparty", "~> 0.18.1"
-  spec.add_dependency "rspec", "~> 3.9.0"
-end
+  spec.add_dependency "rspec", '~> 3.9', ">= 3.9.0"
+end

metadata

@@ -1,20 +1,23 @@
 --- !ruby/object:Gem::Specification
 name: vpos
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 1.0.2
 platform: ruby
 authors:
 - Sergio Maziano
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-12-31 00:00:00.000000000 Z
+date: 2021-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.2.3
   type: :development
@@ -22,6 +25,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.2.3
 - !ruby/object:Gem::Dependency
@@ -30,14 +36,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -57,6 +69,9 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.9'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.9.0
   type: :runtime
@@ -64,18 +79,22 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.9'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.9.0
 description: The one stop shop for online payments in Angola, allowing you to process
   payments requests from EMIS GPO through vPOS.
 email:
-- sergio@nextbss.co.ao
+- sergio.maziano@vpos.ao
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/ruby.yml"
 - ".gitignore"
+- ".ruby-version"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -88,7 +107,7 @@ files:
 - lib/vpos_module.rb
 - tags
 - vpos.gemspec
-homepage: https://github.com/nextbss/vpos-ruby
+homepage: https://github.com/v-pos/vpos-ruby
 licenses:
 - MIT
 metadata: {}
@@ -107,7 +126,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: The one stop shop for online payments in Angola.