voyager_api 0.3.8 → 0.3.9

data/VERSION

@@ -1 +1 @@
-0.3.8
+0.3.9

data/lib/holdings/record.rb

@@ -116,14 +116,14 @@ module Voyager
       #
       def parse_call_number(tag852)
         
-        g = tag852.at_css("slim|subfield[@code='g']")
-        h = tag852.at_css("slim|subfield[@code='h']")
-        i = tag852.at_css("slim|subfield[@code='i']")
-        k = tag852.at_css("slim|subfield[@code='k']")
-        m = tag852.at_css("slim|subfield[@code='m']")
+        g = tag852.css("slim|subfield[@code='g']").collect { |subfield| subfield.content }
+        h = tag852.css("slim|subfield[@code='h']").collect { |subfield| subfield.content }
+        i = tag852.css("slim|subfield[@code='i']").collect { |subfield| subfield.content }
+        k = tag852.css("slim|subfield[@code='k']").collect { |subfield| subfield.content }
+        m = tag852.css("slim|subfield[@code='m']").collect { |subfield| subfield.content }
         
         # subfields need to be output in this order even though they may not appear in this order
-        [k,g,h,i,m].compact.collect { |subfield| subfield.content }.join(" ")
+        [k,g,h,i,m].flatten.join(' ')
 
       end
       
@@ -365,9 +365,9 @@ module Voyager
           'rbx4off','off,dic','off,oral'].any? { |loc_code| location_code == loc_code }
           return ['spec_coll']
         end
-        
+
         services << scan_message(location_name)
-        
+
         status = item_status[:status]
         messages = item_status[:messages]
         
@@ -407,11 +407,11 @@ module Voyager
            services << 'precat'
         # doc delivery
         elsif ['glx','mil','ave','avelc','bar','bus','eal','eax','eng','fax','faxlc','glg','jou','leh','mat',
-          'sci','swx','uts','uts,per','uts,unn','war'].any? { |loc_code| location_code == loc_code } &&
+          'mus','sci','swx','uts','uts,per','uts,unn','war'].any? { |loc_code| location_code == loc_code } &&
           temp_loc_flag == 'N'
           services << 'doc_delivery'
         end
-        
+
         services << scan_messages(messages) unless messages.empty?
 
         services

data/test/fixtures/holdings_7686002.xml

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ser:voyagerServiceData xmlns:ser="http://www.endinfosys.com/Voyager/serviceParameters"><ser:serviceData xsi:type="hol:holdingsCollectionType" xmlns:hol="http://www.endinfosys.com/Voyager/holdings" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"><hol:holdingsRecord><hol:bibRecord bibId="7686002" dpsFlag="N"><hol:marcRecord><slim:leader xmlns:slim="http://www.loc.gov/MARC21/slim">01128ctm a2200337Ia 4500</slim:leader><slim:controlfield tag="001" xmlns:slim="http://www.loc.gov/MARC21/slim">7686002</slim:controlfield><slim:controlfield tag="005" xmlns:slim="http://www.loc.gov/MARC21/slim">20100622162458.0</slim:controlfield><slim:controlfield tag="008" xmlns:slim="http://www.loc.gov/MARC21/slim">100304m18711875ctu           000 0 eng d</slim:controlfield><slim:datafield ind2=" " ind1=" " tag="035" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">(OCoLC)611939163</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="035" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">(OCoLC)ocn611939163</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="035" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">(NNC)7686002</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="040" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">NNC</slim:subfield><slim:subfield code="c">NNC</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="043" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">n-us-ct</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1="2" tag="110" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Allen and Morris (Firm)</slim:subfield></slim:datafield><slim:datafield ind2="0" ind1="1" tag="245" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Account books</slim:subfield><slim:subfield code="h">[manuscript].</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="260" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Waterbury, Connecticut,</slim:subfield><slim:subfield code="c">1871-1875.</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="300" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">2 v. ;</slim:subfield><slim:subfield code="c">40 cm.</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="500" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Manuscript on paper.</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1="0" tag="505" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">v.1. Daybook and journal, March - Oct. 1871, 268 p. --v.2. Daybook, 1874-1875, 499 p.</slim:subfield></slim:datafield><slim:datafield ind2="7" ind1=" " tag="655" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Account books.</slim:subfield><slim:subfield code="2">aat</slim:subfield></slim:datafield><slim:datafield ind2="7" ind1=" " tag="655" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Daybooks.</slim:subfield><slim:subfield code="2">aat</slim:subfield></slim:datafield><slim:datafield ind2="7" ind1=" " tag="655" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Journals (accounts)</slim:subfield><slim:subfield code="2">aat</slim:subfield></slim:datafield><slim:datafield ind2="7" ind1=" " tag="655" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Manuscripts</slim:subfield><slim:subfield code="y">1871.</slim:subfield><slim:subfield code="2">lcsh</slim:subfield></slim:datafield><slim:datafield ind2="7" ind1=" " tag="655" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Manuscripts, American.</slim:subfield><slim:subfield code="2">lcsh</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1="2" tag="710" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Columbia University.</slim:subfield><slim:subfield code="b">Rare Book and Manuscript Library.</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1="2" tag="710" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">Montgomery Manuscripts (Columbia University. Rare Book and Manuscript Library)</slim:subfield><slim:subfield code="5">NNC</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="752" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">United States</slim:subfield><slim:subfield code="b">Connecticut</slim:subfield><slim:subfield code="d">Waterbury.</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="900" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">AUTH</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1="2" tag="948" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">20100304</slim:subfield><slim:subfield code="b">e</slim:subfield><slim:subfield code="c">scmc3</slim:subfield><slim:subfield code="d">SCMC</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1="2" tag="948" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">20100304</slim:subfield><slim:subfield code="b">n</slim:subfield><slim:subfield code="c">rjb57</slim:subfield><slim:subfield code="d">SCMC</slim:subfield></slim:datafield><slim:datafield ind2=" " ind1=" " tag="965" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="a">RECON</slim:subfield></slim:datafield></hol:marcRecord><hol:bibData name="databaseCode">LOCAL</hol:bibData><hol:bibData name="databaseName">Local Database</hol:bibData><hol:bibData name="createDate">2010-03-04 09:03:41</hol:bibData><hol:bibData name="updateDate">2010-06-22 16:24:58</hol:bibData><hol:bibData name="suppressInOpac">N</hol:bibData><hol:bibData name="exportOK">N</hol:bibData><hol:bibData name="exportOKDate" xsi:nil="true"/><hol:bibData name="exportOperatorId" xsi:nil="true"/><hol:bibData name="createLocation">CATCUL</hol:bibData><hol:bibData name="updateLocation" xsi:nil="true"/><hol:bibData name="exportOKLocation" xsi:nil="true"/><hol:bibData name="owningLibrary" id="1">COLUMBIA</hol:bibData></hol:bibRecord><hol:mfhdCollection><mfhd:mfhdRecord bibId="7686002" mfhdId="10794534" xmlns:mfhd="http://www.endinfosys.com/Voyager/mfhd"><mfhd:marcRecord><slim:leader xmlns:slim="http://www.loc.gov/MARC21/slim">00204cv  a22000974  4500</slim:leader><slim:controlfield tag="001" xmlns:slim="http://www.loc.gov/MARC21/slim">10794534</slim:controlfield><slim:controlfield tag="004" xmlns:slim="http://www.loc.gov/MARC21/slim">7686002</slim:controlfield><slim:controlfield tag="005" xmlns:slim="http://www.loc.gov/MARC21/slim">20101008144253.0</slim:controlfield><slim:controlfield tag="008" xmlns:slim="http://www.loc.gov/MARC21/slim">1003045u    8   4001bb   0901128</slim:controlfield><slim:datafield ind2="0" ind1="8" tag="852" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="b">rbx</slim:subfield><slim:subfield code="k">Ms</slim:subfield><slim:subfield code="k">MONTGOM</slim:subfield><slim:subfield code="h">675</slim:subfield></slim:datafield><slim:datafield ind2="1" ind1="4" tag="866" xmlns:slim="http://www.loc.gov/MARC21/slim"><slim:subfield code="8">0</slim:subfield><slim:subfield code="a">v.1-2</slim:subfield></slim:datafield></mfhd:marcRecord><mfhd:mfhdData name="databaseCode">LOCAL</mfhd:mfhdData><mfhd:mfhdData name="databaseName">Local Database</mfhd:mfhdData><mfhd:mfhdData name="mfhdStubFlag">0</mfhd:mfhdData><mfhd:mfhdData name="createOperatorId">scmc3</mfhd:mfhdData><mfhd:mfhdData name="updateOperatorId">scmc3</mfhd:mfhdData><mfhd:mfhdData name="createDate">2010-03-04 09:03:49</mfhd:mfhdData><mfhd:mfhdData name="updateDate">2010-10-08 14:42:53</mfhd:mfhdData><mfhd:mfhdData name="createLocation">CATCUL</mfhd:mfhdData><mfhd:mfhdData name="updateLocation">CATCUL</mfhd:mfhdData><mfhd:mfhdData name="suppressInOpac">N</mfhd:mfhdData><mfhd:mfhdData name="exportOK">N</mfhd:mfhdData><mfhd:mfhdData name="sourceModule">C</mfhd:mfhdData><mfhd:mfhdData name="callNumber">Ms MONTGOM 675</mfhd:mfhdData><mfhd:mfhdData name="locationCode" id="342">rbx</mfhd:mfhdData><mfhd:mfhdData name="locationName" xsi:nil="true"/><mfhd:mfhdData name="locationDisplayName">Rare Book, Butler 6th Fl. East (Non-Circulating)</mfhd:mfhdData><mfhd:mfhdData name="locationSpineLabel">rbx</mfhd:mfhdData><mfhd:mfhdData name="owningLibrary" id="1">COLUMBIA</mfhd:mfhdData><mfhd:itemCollection><item:itemCount xmlns:item="http://www.endinfosys.com/Voyager/item">0</item:itemCount><item:itemLocation xmlns:item="http://www.endinfosys.com/Voyager/item"><item:itemLocationData name="tmpLoc" xsi:nil="true"/><item:itemLocationData name="tempLocation">Rare Book, Butler 6th Fl. East (Non-Circulating)</item:itemLocationData><item:itemLocationData name="itemEnum" xsi:nil="true"/><item:itemLocationData name="itemChron" xsi:nil="true"/><item:itemLocationData name="itemYear" xsi:nil="true"/><item:itemLocationData name="itemCaption" xsi:nil="true"/><item:itemLocationData name="itemFreeText" xsi:nil="true"/><item:itemLocationData name="itemCopyNumber" xsi:nil="true"/></item:itemLocation></mfhd:itemCollection></mfhd:mfhdRecord></hol:mfhdCollection></hol:holdingsRecord></ser:serviceData></ser:voyagerServiceData>

data/test/holdings/test_record.rb

@@ -18,6 +18,10 @@ class TestHoldings < HoldingsTestCase
     
     record2 = load_fixture("holdings_7658454.xml").records.first
     assert_equal 'REF GB450 .G23 FF', record2.call_number
+    
+    record3 = load_fixture("holdings_7686002.xml").records.first
+    assert_equal 'Ms MONTGOM 675', record3.call_number
+    
   end
 
   def test_summary_holdings

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: voyager_api
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-31 00:00:00.000000000Z
+date: 2013-09-19 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2153298640 !ruby/object:Gem::Requirement
+  requirement: &2160851680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153298640
+  version_requirements: *2160851680
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &2153298120 !ruby/object:Gem::Requirement
+  requirement: &2160850880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153298120
+  version_requirements: *2160850880
 - !ruby/object:Gem::Dependency
   name: httpclient
-  requirement: &2153297480 !ruby/object:Gem::Requirement
+  requirement: &2160850060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153297480
+  version_requirements: *2160850060
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2153296640 !ruby/object:Gem::Requirement
+  requirement: &2160849200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153296640
+  version_requirements: *2160849200
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &2153296060 !ruby/object:Gem::Requirement
+  requirement: &2160848340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153296060
+  version_requirements: *2160848340
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2153203400 !ruby/object:Gem::Requirement
+  requirement: &2160847500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -77,10 +77,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *2153203400
+  version_requirements: *2160847500
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &2153202720 !ruby/object:Gem::Requirement
+  requirement: &2160846720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -88,10 +88,10 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *2153202720
+  version_requirements: *2160846720
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &2153201860 !ruby/object:Gem::Requirement
+  requirement: &2160845960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -99,10 +99,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153201860
+  version_requirements: *2160845960
 - !ruby/object:Gem::Dependency
   name: guard-minitest
-  requirement: &2153201120 !ruby/object:Gem::Requirement
+  requirement: &2160844900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -110,10 +110,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153201120
+  version_requirements: *2160844900
 - !ruby/object:Gem::Dependency
   name: rb-fsevent
-  requirement: &2153199980 !ruby/object:Gem::Requirement
+  requirement: &2160844080 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -121,10 +121,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153199980
+  version_requirements: *2160844080
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &2153199120 !ruby/object:Gem::Requirement
+  requirement: &2160843200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -132,10 +132,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153199120
+  version_requirements: *2160843200
 - !ruby/object:Gem::Dependency
   name: growl
-  requirement: &2153198400 !ruby/object:Gem::Requirement
+  requirement: &2160842280 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -143,7 +143,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153198400
+  version_requirements: *2160842280
 description: ! 'Middleware gem for Voyager 7 API calls, specificially holdings information '
 email: github@jamesstuart.org
 executables: []
@@ -198,6 +198,7 @@ files:
 - test/fixtures/holdings_7471326.xml
 - test/fixtures/holdings_7658449.xml
 - test/fixtures/holdings_7658454.xml
+- test/fixtures/holdings_7686002.xml
 - test/fixtures/holdings_7784963.xml
 - test/fixtures/holdings_8189127.xml
 - test/fixtures/holdings_8267323.xml
@@ -240,7 +241,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3233840626635347838
+      hash: -3294320703001238788
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: