voxpupuli-test 2.1.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d745fbc5827db89bff008ceea7f415ee870656b2f3375e2b5d39d6cb8603fe45
-  data.tar.gz: 9f6a7acc3bbcbef5325784bdd49ec228d2f3ce5f5cb4395ace8b448ef03298e6
+  metadata.gz: 0f6d599131b16f42240c3870dc33689158046b44c3754f53f3092c83dab42a4e
+  data.tar.gz: 33ff88f7e97048900ca71a4b7de6a62c84f3bfb21eb3bd0b3349399674d02abc
 SHA512:
-  metadata.gz: '088ca28eb46d3ed311a445416d921ad8963a0011c45592032330ad0111bdd51349cc9e0d64b2b8614fb529b37057e1dea16d8d899cc3a5242ed7290663f08fad'
-  data.tar.gz: c836147f89558f2780ebe754ce64f97db24dbd287ae198161cdac31ffec93ed359d377ee85bb0cbd239d0a849573b5b002959fae11f36bd015e4092cb599d216
+  metadata.gz: a0932b5282740e2c5c4e1a2467cfdcdf54c099e1d25a49db127db44cde7f2109d35aa7f6398833be848bcad28fe3c0c60d86a7ad560acc5a03a1e6aecf3e9d1d
+  data.tar.gz: 94ad5f26334c72f1e681fa08396b133d2172312983e7a696f450f3cf74d4d1113cfc7ab939cff24c0e4ad95dc5bb8f9d630b6f2119d8872178d3f5fe49536e65

data/lib/voxpupuli/test/facts.rb

@@ -1,3 +1,6 @@
+require 'rspec-puppet-facts'
+include RspecPuppetFacts
+
 # Override facts
 #
 # This doesn't use deep_merge because that's highly unpredictable. It can merge
@@ -32,3 +35,63 @@ def apply_overrides!(facts, overrides, enforce_strings)
     end
   end
 end
+
+# Add mocked facts based on the metadata present in the module
+#
+# This means that for some module there are hardcoded mocks, such as stdlib.
+# When stdlib is present in metadata.json, facts like service_provider are
+# mocked and return the correct value according to the OS facts.
+def add_mocked_facts!
+  add_facts_for_metadata(RspecPuppetFacts.metadata)
+end
+
+def add_facts_for_metadata(metadata)
+  return unless metadata && metadata['dependencies']
+
+  metadata['dependencies'].each do |dependency|
+    case normalize_module_name(dependency['name'])
+    when 'camptocamp/systemd'
+      add_custom_fact :systemd, ->(os, facts) { facts[:service_provider] == 'systemd' }
+    when 'puppetlabs/stdlib'
+      add_stdlib_facts
+    end
+  end
+end
+
+def normalize_module_name(name)
+  return unless name
+  name.sub('-', '/')
+end
+
+def add_stdlib_facts
+  add_custom_fact :puppet_environmentpath, '/etc/puppetlabs/code/environments'
+  add_custom_fact :puppet_vardir, '/opt/puppetlabs/puppet/cache'
+  add_custom_fact :root_home, '/root'
+
+  # Rough conversion of grepping in the puppet source:
+  # grep defaultfor lib/puppet/provider/service/*.rb
+  add_custom_fact :service_provider, ->(os, facts) do
+    case facts[:osfamily].downcase
+    when 'archlinux'
+      'systemd'
+    when 'darwin'
+      'launchd'
+    when 'debian'
+      'systemd'
+    when 'freebsd'
+      'freebsd'
+    when 'gentoo'
+      'openrc'
+    when 'openbsd'
+      'openbsd'
+    when 'redhat'
+      facts[:operatingsystemrelease].to_i >= 7 ? 'systemd' : 'redhat'
+    when 'suse'
+      facts[:operatingsystemmajrelease].to_i >= 12 ? 'systemd' : 'redhat'
+    when 'windows'
+      'windows'
+    else
+      'init'
+    end
+  end
+end

data/lib/voxpupuli/test/spec_helper.rb

@@ -26,8 +26,6 @@ end
 
 require 'voxpupuli/test/facts'
 require 'puppetlabs_spec_helper/module_spec_helper'
-require 'rspec-puppet-facts'
-include RspecPuppetFacts
 
 # Generating facts is slow - this memoizes the facts between multiple classes.
 # Marshalling is used to get unique instances which helps when tests overrides

data/rubocop.yml

@@ -161,6 +161,9 @@ Style/BracesAroundHashParameters:
 Style/CaseEquality:
   Enabled: True
 
+Style/TrailingCommaInArguments:
+  Enabled: False
+
 Layout/CaseIndentation:
   Enabled: True
 
@@ -333,7 +336,7 @@ Style/TrailingCommaInArguments:
   Enabled: True
 
 Style/TrailingCommaInLiteral:
-  Enabled: True
+  Enabled: False
 
 Style/GlobalVars:
   Enabled: True

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: voxpupuli-test
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-18 00:00:00.000000000 Z
+date: 2021-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -332,6 +332,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: puppet-lint-optional_default-check
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -378,7 +392,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Helpers for testing Vox Pupuli modules