voting 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a4aa7764b2a518434df6182d2f0a0101b9d3079c
-  data.tar.gz: e6a96257d3a5f67a6b8224f21d538285db21c79c
+  metadata.gz: f0f7788833c3a076eb925aac474527ff11af91bf
+  data.tar.gz: b49e89a0bfae1c14bfbaafc785b49901d3d987ea
 SHA512:
-  metadata.gz: '01686bdfc40e30e8ce89208e3f3b2e21425382abc2fb7f9dee4f9f2205e5b63886e8564703198d2e6cae610866a839aa8bfa0352cb00ac5d46fe80e1104096ae'
-  data.tar.gz: d3aa1a7f97da1fa5b2c145e7887beb74ab8277007e89b71a70d9baee8a4bc94138c1236c2e4c6e4c58f1e17ea6b5d744794ecf51d6bd8e3f40623a6b106f80e1
+  metadata.gz: 285ef836d6e3468fdd140d20342b6a6dd2eb728f323e1265632c0591e49d3e74abed06faac44bb0e0c2f15fa0b570e7ce94ec6dd5503d3cb0ce891fe63de8d3e
+  data.tar.gz: eabf0323ba058330e694692f5fe9611234410f2335b6a0bae6500acc096a3d214f18b24298214cd118ce23cc5701728c2f98492dec90d22f8701b7c7332818b0

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## v0.2.0
+
+### News
+
+- The Rails dependency was reduced to only activerecord;
+- The `voted?` method now support ask if the vote was `positive` or `negative`.
+
 ## v0.1.0
 
 - First release.

data/README.md

@@ -2,7 +2,8 @@
 
 [![Build Status](https://travis-ci.org/wbotelhos/voting.svg)](https://travis-ci.org/wbotelhos/voting)
 [![Gem Version](https://badge.fury.io/rb/voting.svg)](https://badge.fury.io/rb/voting)
-[![LiberPay](https://img.shields.io/badge/donate-%3C3-brightgreen.svg)](https://liberapay.com/wbotelhos)
+[![Maintainability](https://api.codeclimate.com/v1/badges/dcdf51e3093148c5ac6a/maintainability)](https://codeclimate.com/github/wbotelhos/voting/maintainability)
+[![Support](https://img.shields.io/badge/donate-%3C3-brightgreen.svg)](https://liberapay.com/wbotelhos)
 
 A Binomial proportion confidence interval voting system with scope and cache enabled.
 
@@ -115,6 +116,13 @@ resource = Comment.last
 author.voted? resource
 ```
 
+If you want to know if the vote was `positive` or `negative`, just pass a symbol about it:
+
+```ruby
+author.voted? resource, :negative
+author.voted? resource, :positive
+```
+
 ### votes
 
 You can retrieve all votes received by some resource:
@@ -182,40 +190,60 @@ An author model still can be voted, but won't generate a Voting record with all
 voting as: :author
 ```
 
-### Scoping
+### Alias
 
-If you need to warm up a record with scope, you need to setup the `scoping` relation.
+You can to use alias to directly call `vote` with positive or negative data.
 
 ```ruby
-class Resource < ApplicationRecord
-  voting scoping: :categories
-end
+author   = Author.last
+resource = Comment.last
+
+author.up   resource # +1
+author.down resource # -1
 ```
 
-Now, when a resource is created, the cache will be generated for each related `category` as `scopeable`.
+#### Options
+
+`down`: makes a negative vote;
 
-# Toggle
+`up`: makes a positive vote;
+
+### Toggle
 
 The toggle functions works out of box, so if you vote up twice or vote twice down, the vote will be canceled.
 When you do that, the vote record is **not destroyed** instead, it receives zero on `negative` and `positive` column.
 
-# Alias
+### Scope
 
-You can to use alias to directly call `vote` with positive or negative data.
+All methods accepts a `scope` param to be persisted with the vote or to be searched:
 
 ```ruby
-author   = Author.last
-resource = Comment.last
-
-author.up   resource # +1
-author.down resource # -1
+category = Category.last
+
+author.down     resource,            scope: category
+author.up       resource,            scope: category
+author.vote     resource, 1,         scope: category
+author.vote_for resource,            scope: category
+author.voted    resource,            scope: category
+author.voted?   resource, :negative, scope: category
+author.voted?   resource, :positive, scope: category
+
+resource.votes  scope: category
+author  .voted  scope: category
+resource.votign scope: category
 ```
 
-### Options
+### Scoping
 
-`down`: makes a negative vote;
+If you need to warm up a record with scope, you need to setup the `scoping` relation.
 
-`up`: makes a positive vote;
+```ruby
+class Resource < ApplicationRecord
+  voting scoping: :categories
+end
+```
+
+Now, when a resource is created, the cache will be generated for each related `category` as `scopeable`.
 
 ### References
 
@@ -226,4 +254,4 @@ author.down resource # -1
 
 ## Love it!
 
-Via [PayPal](https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=X8HEP2878NDEG&item_name=voting) or [LiberPay](https://liberapay.com/wbotelhos). Thanks! (:
+Via [PayPal](https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=X8HEP2878NDEG&item_name=voting) or [Support](https://liberapay.com/wbotelhos). Thanks! (:

data/lib/voting/models/voting/extension.rb

@@ -21,8 +21,12 @@ module Voting
         Vote.vote_for author: self, resource: resource, scopeable: scope
       end
 
-      def voted?(resource, scope: nil)
-        !vote_for(resource, scope: scope).nil?
+      def voted?(resource, value = nil, scope: nil)
+        query = { author: self, resource: resource, scopeable: scope }
+
+        query[value] = 1 unless value.nil?
+
+        Vote.exists? query
       end
 
       def votes(scope: nil)

data/lib/voting/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Voting
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/spec/models/extension/voted_question_spec.rb

@@ -7,32 +7,108 @@ RSpec.describe Voting::Extension, ':voted?' do
   let!(:comment) { create :comment }
 
   context 'with no scopeable' do
-    context 'when has no vote for the given resource' do
-      before { allow(author).to receive(:vote_for).with(comment, scope: nil) { nil } }
+    context 'with no specific value' do
+      context 'when has no vote for the given resource' do
+        specify { expect(author.voted?(comment)).to eq false }
+      end
 
-      specify { expect(author.voted?(comment)).to eq false }
+      context 'when has vote for the given resource' do
+        before { author.up comment }
+
+        specify { expect(author.voted?(comment)).to eq true }
+      end
     end
 
-    context 'when has vote for the given resource' do
-      before { allow(author).to receive(:vote_for).with(comment, scope: nil) { double } }
+    context 'with specific value' do
+      context 'with negative' do
+        context 'when has no vote for the given resource' do
+          specify { expect(author.voted?(comment, :negative)).to eq false }
+        end
+
+        context 'when has vote for the given resource' do
+          before { author.down comment }
+
+          specify { expect(author.voted?(comment, :negative)).to eq true }
+        end
+
+        context 'when has vote for the given resource but positive' do
+          before { author.up comment }
+
+          specify { expect(author.voted?(comment, :negative)).to eq false }
+        end
+      end
+
+      context 'with positive' do
+        context 'when has no vote for the given resource' do
+          specify { expect(author.voted?(comment, :positive)).to eq false }
+        end
+
+        context 'when has vote for the given resource' do
+          before { author.up comment }
+
+          specify { expect(author.voted?(comment, :positive)).to eq true }
+        end
+
+        context 'when has vote for the given resource but negative' do
+          before { author.down comment }
 
-      specify { expect(author.voted?(comment)).to eq true }
+          specify { expect(author.voted?(comment, :positive)).to eq false }
+        end
+      end
     end
   end
 
   context 'with scopeable' do
     let!(:category) { build :category }
 
-    context 'when has no vote for the given resource' do
-      before { allow(author).to receive(:vote_for).with(comment, scope: category) { nil } }
+    context 'with no specific value' do
+      context 'when has no vote for the given resource' do
+        specify { expect(author.voted?(comment, scope: category)).to eq false }
+      end
 
-      specify { expect(author.voted?(comment, scope: category)).to eq false }
+      context 'when has vote for the given resource' do
+        before { author.up comment, scope: category }
+
+        specify { expect(author.voted?(comment, scope: category)).to eq true }
+      end
     end
 
-    context 'when has vote for the given resource' do
-      before { allow(author).to receive(:vote_for).with(comment, scope: category) { double } }
+    context 'with specific value' do
+      context 'with negative' do
+        context 'when has no vote for the given resource' do
+          specify { expect(author.voted?(comment, :negative, scope: category)).to eq false }
+        end
+
+        context 'when has vote for the given resource' do
+          before { author.down comment, scope: category }
+
+          specify { expect(author.voted?(comment, :negative, scope: category)).to eq true }
+        end
+
+        context 'when has vote for the given resource but positive' do
+          before { author.up comment, scope: category }
+
+          specify { expect(author.voted?(comment, :negative, scope: category)).to eq false }
+        end
+      end
+
+      context 'with positive' do
+        context 'when has no vote for the given resource' do
+          specify { expect(author.voted?(comment, :positive, scope: category)).to eq false }
+        end
+
+        context 'when has vote for the given resource' do
+          before { author.up comment, scope: category }
+
+          specify { expect(author.voted?(comment, :positive, scope: category)).to eq true }
+        end
+
+        context 'when has vote for the given resource negative' do
+          before { author.down comment, scope: category }
 
-      specify { expect(author.voted?(comment, scope: category)).to eq true }
+          specify { expect(author.voted?(comment, :positive, scope: category)).to eq false }
+        end
+      end
     end
   end
 end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: voting
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Washington Botelho
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-22 00:00:00.000000000 Z
+date: 2018-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="