volt 0.9.6.pre1 → 0.9.6.pre2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 29fb4233ac14f8c7e64e2989d8b35afef2ad5c46
-  data.tar.gz: 88a4befaffac7d6f0eeba74dcc8c8ca5d4f792ee
+  metadata.gz: 16b909f645dc9943c62dcd512df36371ac4c1dfc
+  data.tar.gz: 3b1bc0f0bdeef3eef63f9f7fbcbf47042a9f3fbe
 SHA512:
-  metadata.gz: 3bd5f4136741543d23af692202144ae62b6f2b4ca239149da6449901b1ef98d8fe4a9cb5b17f747c09cc9918d29ff73a176b6a72ab7e4e7329ee317273100b75
-  data.tar.gz: 608bfcaa76b62dc7e0a7fa085ade630b7dafb466568d6ac046a4f3a3fe205f04fabec87a33f98b0b987d97357f22ffefdbb468118460e6b609eb44e3afc51943
+  metadata.gz: af36ac78914b63e4c3a1c9161a64ec36e85f317320540461bb5008852261a9c0f66a2016f9130d4578122fd4eab8f1bba62eff2e8c48746d9451d87bab66c09e
+  data.tar.gz: 909e57f674271f32315f0f987cb28035703ed949bd704fe601c7ad547a287b9262a10f45525964796f8c92d557102cb3e232f44a82761f7a6da43acf854b12f6

data/CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Changed
 - Finally tracked down an illusive memory leak.
 - Computations now raise an error on their inital run, then log errors (via Volt.logger.error(..)) when running again (since they update on next tick)
+- fixed template caching issue
 
 ## 0.9.5
 ### Breaking Changes

data/lib/volt/models/helpers/change_helpers.rb

@@ -24,7 +24,10 @@ module Volt
             return validate!.then do
               # Buffers are allowed to be in an invalid state
               unless buffer?
-                # First check that all local validations pass
+                # First check that all local validations pass.  Any time any
+                # validations fail, the model is in an invalid state and won't
+                # persist.  However, we want to be able to move the model
+                # towards a valid state one change at a time.
                 if error_in_changed_attributes?
                   # Some errors are present, revert changes
                   revert_changes!

data/lib/volt/models/persistors/model_store.rb

@@ -114,7 +114,10 @@ module Volt
         end.fail do |errors|
           save_promises = @save_promises
           @save_promises = nil
-          save_promises.each { |promise|  promise.reject(errors) }
+
+          # Rewrap in Volt::Errors
+          errors = Volt::Errors.new(errors)
+          save_promises.each { |promise| promise.reject(errors) }
 
           # Mark that we failed to save
           @model.change_state_to(:saved_state, :save_failed)

data/lib/volt/reactive/computation.rb

@@ -41,9 +41,17 @@ module Volt
             # Re-raise if we are in the initial run
             raise
           else
-            msg = "Exception During Compute: " + e.inspect
-            msg += "\n" + e.backtrace.join("\n") if e.respond_to?(:backtrace)
-            Volt.logger.error(msg)
+            # Sometimes we get nil as the exception, not sure if thats an opal
+            # issue or what.
+            if e
+              msg = "Exception During Compute: " + e.inspect
+              msg += "\n" + e.backtrace.join("\n") if e.respond_to?(:backtrace)
+              Volt.logger.error(msg)
+
+              if RUBY_PLATFORM == 'opal'
+                `console.log(e);`
+              end
+            end
           end
         ensure
           @computing = false

data/lib/volt/server/template_handlers/view_processor.rb

@@ -3,13 +3,13 @@ require 'opal/sprockets/processor'
 require 'sprockets'
 require 'tilt'
 require 'opal/sprockets/processor'
+require 'sprockets/uri_utils'
 
 module Volt
 
 
 
   class ViewProcessor < ::Opal::TiltTemplate
-
     def initialize(client)
       @client = client
     end
@@ -49,6 +49,10 @@ module Volt
         # puts input[:data].inspect
         # Remove all semicolons from source
         # input[:content_type] = 'application/javascript'
+
+        # Track the dependency
+        context.metadata[:dependencies] << Sprockets::URIUtils.build_file_digest_uri(input[:filename])
+
         compile(filename, input[:data], context)
       end
 
@@ -81,10 +85,9 @@ module Volt
 
     def self.setup(sprockets=$volt_app.sprockets)
       exts = ComponentTemplates::Preprocessors.extensions.map{ |ext| ".#{ext}" }
-      
+
       sprockets.register_mime_type 'application/vtemplate', extensions: exts
       sprockets.register_transformer 'application/vtemplate', 'application/javascript', Volt::ViewProcessor.new(true)
     end
   end
 end
-

data/lib/volt/tasks/dispatcher.rb

@@ -151,11 +151,28 @@ module Volt
 
         finish.call
       end.fail do |error|
-        finish.call(error)
-        # Convert the error into a string so it can be serialized.
-        error_str = "#{error.class.to_s}: #{error.to_s}"
+        begin
+          finish.call(error)
+
+          begin
+            # Try to send, handle error if we can't convert the result to EJSON
+            reply = EJSON.stringify(['response', callback_id, nil, error, cookies])
+
+            # use send_string_message, since we stringify here, not on the other
+            # side of Drb.
+            channel.send_string_message(reply)
+          rescue EJSON::NonEjsonType => e
+            # Convert the error into a string so it can be serialized to
+            # something.
+            error = "#{error.class.to_s}: #{error.to_s}"
+            channel.send_message('response', callback_id, nil, error, cookies)
+          end
 
-        channel.send_message('response', callback_id, nil, error_str, cookies)
+        rescue => e
+          Volt.logger.error "Error in fail dispatch: #{e.inspect}"
+          Volt.logger.error(e.backtrace.join("\n")) if e.respond_to?(:backtrace)
+          raise
+        end
       end
 
     end

data/lib/volt/version.rb

@@ -1,5 +1,5 @@
 module Volt
   module Version
-    STRING = '0.9.6.pre1'
+    STRING = '0.9.6.pre2'
   end
 end

data/lib/volt/volt/templates.rb

@@ -36,4 +36,4 @@ module Volt
       @templates
     end
   end
-end
+end

data/spec/apps/kitchen_sink/Gemfile

@@ -16,7 +16,7 @@ gem 'volt-bootstrap_jumbotron_theme', '~> 0.1.0'
 gem 'volt-user_templates', '~> 0.4.0'
 
 # Add ability to send e-mail from apps.
-gem 'volt-mailer', '~> 0.1.0'
+gem 'volt-mailer', '~> 0.1.1'
 
 gem 'volt-fields'
 

data/spec/apps/kitchen_sink/app/main/config/routes.rb

@@ -19,6 +19,8 @@ client '/callbacks', action: 'callbacks'
 # Events
 client '/events', component: 'main', controller: 'events', action: 'index'
 
+client '/save', component: 'main', controller: 'save', action: 'index'
+
 # Signup/login routes
 client '/signup', component: 'user_templates', controller: 'signup'
 client '/login', component: 'user_templates', controller: 'login'

data/spec/apps/kitchen_sink/app/main/controllers/save_controller.rb

@@ -0,0 +1,9 @@
+module Main
+  class SaveController < Volt::ModelController
+    def add_post
+      store.posts.create(page._new_post.to_h).fail do |err|
+        flash._notices << err.inspect
+      end
+    end
+  end
+end

data/spec/apps/kitchen_sink/app/main/models/post.rb

@@ -0,0 +1,5 @@
+class Post < Volt::Model
+  field :title, String
+
+  validate :title, length: 5
+end

data/spec/apps/kitchen_sink/app/main/views/save/index.html

@@ -0,0 +1,10 @@
+<:Title>
+  Save
+
+<:Body>
+  <h1>Save</h1>
+
+  <form e-submit="add_post">
+    <input id="post_title" value="{{ page._new_post!._title }}" />
+    <button>Save</button>
+  </form>

data/spec/integration/save_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe 'saving', type: :feature, sauce: true do
+  it 'should return an error as an instance of Volt::Error' do
+    visit '/save'
+
+    fill_in 'post_title', with: 'ok'
+
+    click_button 'Save'
+
+    expect(page).to have_content('#<Volt::Errors {"title"=>["must be at least 5 characters"]}>')
+  end
+end

data/spec/tasks/dispatcher_spec.rb

@@ -43,7 +43,7 @@ if RUBY_PLATFORM != 'opal'
     it 'should not allow eval' do
       channel = double('channel')
 
-      expect(channel).to receive(:send_message).with('response', 0, nil, "RuntimeError: unsafe method: eval", nil)
+      expect(channel).to receive(:send_message).with('response', 0, nil, 'RuntimeError: unsafe method: eval', nil)
 
       dispatcher.dispatch(channel, [0, 'TestTask', :eval, '5 + 10'])
     end
@@ -51,7 +51,12 @@ if RUBY_PLATFORM != 'opal'
     it 'should not allow instance_eval' do
       channel = double('channel')
 
-      expect(channel).to receive(:send_message).with('response', 0, nil, 'RuntimeError: unsafe method: instance_eval', nil)
+
+      first = true
+      expect(channel).to receive(:send_message).with("response", 0, nil, 'RuntimeError: unsafe method: instance_eval', nil)
+
+
+      # .with('response', 0, nil, /RuntimeError: unsafe method: instance_eval/, nil)
 
       dispatcher.dispatch(channel, [0, 'TestTask', :instance_eval, '5 + 10'])
     end

data/templates/project/Gemfile.tt

@@ -16,7 +16,7 @@ gem 'volt-bootstrap_jumbotron_theme', '~> 0.1.0'
 gem 'volt-user_templates', '~> 0.4.0'
 
 # Add ability to send e-mail from apps.
-gem 'volt-mailer', '~> 0.1.0'
+gem 'volt-mailer', '~> 0.1.1'
 
 # Use rbnacl for message bus encrpytion
 # (optional, if you don't need encryption, disable in app.rb and remove)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: volt
 version: !ruby/object:Gem::Version
-  version: 0.9.6.pre1
+  version: 0.9.6.pre2
 platform: ruby
 authors:
 - Ryan Stout
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-29 00:00:00.000000000 Z
+date: 2015-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -638,10 +638,12 @@ files:
 - spec/apps/kitchen_sink/app/main/config/routes.rb
 - spec/apps/kitchen_sink/app/main/controllers/events_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/main_controller.rb
+- spec/apps/kitchen_sink/app/main/controllers/save_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/server/simple_http_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/todos_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/upload_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/yield_component_controller.rb
+- spec/apps/kitchen_sink/app/main/models/post.rb
 - spec/apps/kitchen_sink/app/main/models/user.rb
 - spec/apps/kitchen_sink/app/main/tasks/login_tasks.rb
 - spec/apps/kitchen_sink/app/main/views/events/index.html
@@ -661,6 +663,7 @@ files:
 - spec/apps/kitchen_sink/app/main/views/main/require_test.html
 - spec/apps/kitchen_sink/app/main/views/main/store_demo.html
 - spec/apps/kitchen_sink/app/main/views/main/yield.html
+- spec/apps/kitchen_sink/app/main/views/save/index.html
 - spec/apps/kitchen_sink/app/main/views/todos/index.html
 - spec/apps/kitchen_sink/app/main/views/upload/index.html
 - spec/apps/kitchen_sink/app/main/views/yield_component/index.html
@@ -692,6 +695,7 @@ files:
 - spec/integration/list_spec.rb
 - spec/integration/missing_spec.rb
 - spec/integration/raw_html_binding.rb
+- spec/integration/save_spec.rb
 - spec/integration/store_spec.rb
 - spec/integration/templates_spec.rb
 - spec/integration/todos_spec.rb
@@ -913,10 +917,12 @@ test_files:
 - spec/apps/kitchen_sink/app/main/config/routes.rb
 - spec/apps/kitchen_sink/app/main/controllers/events_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/main_controller.rb
+- spec/apps/kitchen_sink/app/main/controllers/save_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/server/simple_http_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/todos_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/upload_controller.rb
 - spec/apps/kitchen_sink/app/main/controllers/yield_component_controller.rb
+- spec/apps/kitchen_sink/app/main/models/post.rb
 - spec/apps/kitchen_sink/app/main/models/user.rb
 - spec/apps/kitchen_sink/app/main/tasks/login_tasks.rb
 - spec/apps/kitchen_sink/app/main/views/events/index.html
@@ -936,6 +942,7 @@ test_files:
 - spec/apps/kitchen_sink/app/main/views/main/require_test.html
 - spec/apps/kitchen_sink/app/main/views/main/store_demo.html
 - spec/apps/kitchen_sink/app/main/views/main/yield.html
+- spec/apps/kitchen_sink/app/main/views/save/index.html
 - spec/apps/kitchen_sink/app/main/views/todos/index.html
 - spec/apps/kitchen_sink/app/main/views/upload/index.html
 - spec/apps/kitchen_sink/app/main/views/yield_component/index.html
@@ -967,6 +974,7 @@ test_files:
 - spec/integration/list_spec.rb
 - spec/integration/missing_spec.rb
 - spec/integration/raw_html_binding.rb
+- spec/integration/save_spec.rb
 - spec/integration/store_spec.rb
 - spec/integration/templates_spec.rb
 - spec/integration/todos_spec.rb