volt 0.9.5.pre4 → 0.9.5.pre5

data/spec/apps/kitchen_sink/app/main/config/routes.rb

@@ -13,6 +13,9 @@ client '/html_safe', action: 'html_safe'
 client '/missing', action: 'missing'
 client '/require_test', action: 'require_test'
 
+# Events
+client '/events', component: 'main', controller: 'events', action: 'index'
+
 # Signup/login routes
 client '/signup', component: 'user_templates', controller: 'signup'
 client '/login', component: 'user_templates', controller: 'login'

data/spec/apps/kitchen_sink/app/main/controllers/events_controller.rb

@@ -0,0 +1,26 @@
+module Main
+  class EventsController < Volt::ModelController
+    reactive_accessor :ran_some_event
+    reactive_accessor :ran_other_event
+
+    def trig_some_event
+      trigger('some_event', 'yes')
+    end
+
+    def some_event(passes_args, event)
+      if passes_args == 'yes' && event.is_a?(Volt::JSEvent)
+        self.ran_some_event = true
+      end
+    end
+
+    def trig_other_event
+      trigger('other_event', 'yes')
+    end
+
+    def other_event(passes_args)
+      if passes_args == 'yes'
+        self.ran_other_event = true
+      end
+    end
+  end
+end

data/spec/apps/kitchen_sink/app/main/views/events/index.html

@@ -0,0 +1,30 @@
+<:Title>
+  Events
+
+<:Body>
+  <h1>Events</h1>
+
+  <div e-some_event="some_event">
+    <:some-event-button />
+  </div>
+
+
+  <:other-event-button e-other-event="other_event" />
+
+
+  {{ if ran_some_event }}
+    ran some_event
+  {{ end }}
+
+  {{ if ran_other_event }}
+    ran other_event
+  {{ end }}
+
+
+
+
+<:SomeEventButton>
+  <button e-click="trig_some_event">Run Some Event</button>
+
+<:OtherEventButton>
+  <button e-click="trig_other_event">Run Other Event</button>

data/spec/apps/kitchen_sink/app/main/views/main/bindings.html

@@ -154,4 +154,7 @@
   <div id="blurCount">{{ blur_count || 0 }}</div>
   <div id="focusCount">{{ focus_count || 0 }}</div>
 
+  <h2>Raw</h2>
 
+  <p>{{ raw 'some <br /> code' }}</p>
+  <p>{{ raw Promise.new.resolve('some <br /> other code') }}</p>

data/spec/apps/kitchen_sink/app/main/views/main/yield.html

@@ -6,13 +6,8 @@
 
   <:yield-component>This is my {{ content_string }}</:yield-component>
 
-<:Yield-test>
+<:YieldTest>
   <h1>Yield Section</h1>
 
   <p>{{ yield }}</p>
   <p>{{ yield }}</p>
-
-
-  {{ if Volt.current_user }}
-    Email: {{ Volt.current_user._email }}
-  {{ end }}

data/spec/extra_core/array_spec.rb

@@ -7,4 +7,30 @@ describe Array do
       expect([1, 2, 3].sum).to eq(6)
     end
   end
+
+  describe "#to_sentence" do
+    it 'should return an empty string' do
+      expect([].to_sentence).to eq('')
+    end
+
+    it 'should return a single entry' do
+      expect([1].to_sentence).to eq('1')
+    end
+
+    it 'should combine an array into a string with a conjunection and commas' do
+      expect([1,2,3].to_sentence).to eq('1, 2, and 3')
+    end
+
+    it 'should allow you to build an incorrect sentence' do
+      expect([1,2,3].to_sentence(oxford: false)).to eq('1, 2 and 3')
+    end
+
+    it 'let you change the conjunction' do
+      expect([1,2,3].to_sentence(conjunction: 'or')).to eq('1, 2, or 3')
+    end
+
+    it 'let you change the comma' do
+      expect([1,2,3].to_sentence(comma: '!')).to eq('1! 2! and 3')
+    end
+  end
 end

data/spec/integration/bindings_spec.rb

@@ -243,6 +243,15 @@ describe 'bindings test', type: :feature, sauce: true do
     end
   end
 
+  describe 'raw' do
+    it 'should print the raw version, and work with promises' do
+      visit '/bindings'
+
+      expect(page).to have_content("some \ncode")
+      expect(page).to have_content("some \nother code")
+    end
+  end
+
   # NOTE: For some reason this spec fails randomly (capybara issue I think)
   # describe "events" do
   #   it 'should handle focus and blur' do

data/spec/integration/event_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe 'events and bubbling', type: :feature, sauce: true do
+  it 'should bubble events through the dom' do
+    visit '/events'
+
+    click_button 'Run Some Event'
+
+    expect(page).to have_content('ran some_event')
+  end
+
+  it 'should let you specify an e- handler on components' do
+    visit '/events'
+
+    click_button 'Run Other Event'
+
+    expect(page).to have_content('ran other_event')
+  end
+end

data/spec/models/array_model_spec.rb

@@ -28,6 +28,7 @@ describe Volt::ArrayModel do
     expect(array_model.index(2)).to eq(1)
   end
 
+
   it 'should flatten' do
     array = Volt::ArrayModel.new([])
 
@@ -37,4 +38,16 @@ describe Volt::ArrayModel do
     expect(array.flatten.size).to eq(6)
     expect(array.to_a.flatten.size).to eq(6)
   end
+
+  unless RUBY_PLATFORM == 'opal'
+    it 'should return a promise for store on .length, .size, and .count' do
+      store._items << {name: 'One'}
+
+      [:size, :count, :length].each do |method_name|
+        val = store._items.send(method_name)
+        expect(val.class).to eq(Promise)
+        expect(val.sync).to eq(1)
+      end
+    end
+  end
 end

data/spec/models/field_helpers_spec.rb

@@ -26,7 +26,7 @@ describe 'field helpers' do
 
   it 'should raise an error when an invalid cast type is provided' do
     expect do
-      ExampleModelWithField2.field :awesome, Array
+      ExampleModelWithField2.field :awesome, Range
     end.to raise_error(FieldHelpers::InvalidFieldClass)
   end
 
@@ -47,6 +47,6 @@ describe 'field helpers' do
   end
 
   it 'should track the fields on the model class' do
-    expect(ExampleModelWithField.fields_data).to eq({:name=>[nil, {}], :value=>[Numeric, {}]})
+    expect(ExampleModelWithField.fields_data).to eq({:name=>[nil, {}], :value=>[[Numeric, NilClass], {}]})
   end
 end

data/spec/models/validations_spec.rb

@@ -165,4 +165,35 @@ describe Volt::Model do
     expect(model._name).to eq('Jimmy')
   end
 
+  describe 'custom validations' do
+    let(:model) { test_model_with_custom_validation.new }
+    let(:test_model_with_custom_validation) do
+      Class.new(Volt::Model) do
+        validations do
+          validate :something, presence: true
+          validate do
+            if _name.present?
+              {}
+            else
+              {name: ['must be present']}
+            end
+          end
+        end
+      end
+    end
+
+    it 'should return errors for all failed validations' do
+      model.validate!
+      expect(model.errors).to eq(
+        name: ['must be present'],
+        something: ['must be specified']
+      )
+    end
+
+    it 'should not return errors for all passing custom validations' do
+      model._name = 'something'
+      model.validate!
+      expect(model.errors).to eq({something: ["must be specified"]})
+    end
+  end
 end

data/spec/models/validators/type_validator_spec.rb

@@ -20,7 +20,7 @@ describe Volt::TypeValidator do
       describe 'when count is a string' do
         let(:count) { 'Cats' }
         it do
-          expect(subject).to eq({count: ['must be of type Numeric']})
+          expect(subject).to eq({count: ['must be a number']})
         end
       end
     end
@@ -41,6 +41,52 @@ describe Volt::TypeValidator do
           expect(subject).to eq(count: ['must be a number'])
         end
       end
+
+      # Fails on opal because no True/False class
+      # describe 'when passing in multiple types' do
+      #   let(:options) do
+      #     { types: [TrueClass, FalseClass] }
+      #   end
+      #   let(:count) { 'a string' }
+
+      #   it do
+      #     expect(subject).to eq({count: ['must be true or false']})
+      #   end
+      # end
+
+      describe 'when passing in Volt::Boolean' do
+        let(:options) do
+          { type: Volt::Boolean }
+        end
+        let(:count) { 'a string' }
+
+        it do
+          expect(subject).to eq({count: ['must be true or false']})
+        end
+      end
+
+      describe 'when passing in multiple types' do
+        let(:options) do
+          { types: [String, Float] }
+        end
+        let(:count) { 1..1 }
+
+        it do
+          expect(subject).to eq({count: ['must be a String or a number']})
+        end
+      end
+
+      describe 'when passing in multiple types with nil' do
+        let(:options) do
+          { types: [String, Float, NilClass] }
+        end
+        let(:count) { 1..1 }
+
+        it do
+          expect(subject).to eq({count: ['must be a String or a number']})
+        end
+      end
+
     end
   end
 end

data/spec/reactive/reactive_array_spec.rb

@@ -38,6 +38,52 @@ describe Volt::ReactiveArray do
       expect(values).to eq([nil, 4])
     end
 
+    describe ".last" do
+      let(:array) { Volt::ReactiveArray.new([1,2,3]) }
+
+      it 'should trigger changed on .last when appending or inserting' do
+        values = []
+        -> { values << array.last }.watch!
+
+        expect(values).to eq([3])
+
+        array << 4
+        Volt::Computation.flush!
+        expect(values).to eq([3,4])
+
+        array.insert(1,2)
+        Volt::Computation.flush!
+        expect(values).to eq([3,4,4])
+      end
+
+      it 'should trigger changed on .last when the last value is changed' do
+        values = []
+        -> { values << array.last }.watch!
+        expect(values).to eq([3])
+
+        array[2] = 5
+        Volt::Computation.flush!
+        expect(values).to eq([3,5])
+      end
+
+      it 'should not trigger changed on .last when a value other than last changes' do
+        values = []
+        -> { values << array.last }.watch!
+        expect(values).to eq([3])
+
+        array[1] = 20
+        expect(values).to eq([3])
+      end
+
+      it 'should not raise an error on a negative lookup on an empty array' do
+        array = Volt::ArrayModel.new([])
+
+        expect do
+          array[-1]
+        end.not_to raise_error
+      end
+    end
+
     it 'should trigger changes for each cell after index after insert' do
       a = Volt::ReactiveArray.new([1, 2, 3])
 

data/spec/server/forking_server_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+unless RUBY_PLATFORM == 'opal'
+  require 'volt/server'
+
+  describe Volt::ForkingServer do
+    it 'should set polling an an option when using POLL_FS env' do
+      ENV['POLL_FS'] = 'true'
+      forking_server = Volt::ForkingServer.allocate
+
+      # Lots of stubs, since we're working with the FS
+      listener = double('listener')
+      expect(listener).to receive(:start)
+      expect(listener).to receive(:stop)
+      expect(Listen).to receive(:to).with('/app/', {force_polling: true}).and_return(listener)
+      expect(forking_server).to receive(:sync_mod_time)
+
+      server = double('server')
+      expect(server).to receive(:app_path).and_return('/app')
+      forking_server.instance_variable_set(:@server, server)
+
+      forking_server.start_change_listener
+      ENV.delete('POLL_FS')
+
+      forking_server.stop_change_listener
+    end
+  end
+end

data/spec/server/html_parser/view_scope_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe Volt::ViewScope do
+  describe "methodize strings" do
+    def methodize(str)
+      Volt::ViewScope.methodize_string(str)
+    end
+
+    it 'should methodize a method without args' do
+      code = methodize('something')
+      expect(code).to eq('method(:something)')
+    end
+
+    it 'should methodize a method without args2' do
+      code = methodize('something?')
+      expect(code).to eq('method(:something?)')
+    end
+
+    it 'should methodize a method wit args1' do
+      code = methodize('set_something(true)')
+      expect(code).to eq('set_something(true)')
+    end
+
+    it 'should not methodize a method call with args' do
+      code = methodize('something(item1, item2)')
+      expect(code).to eq('something(item1, item2)')
+    end
+
+    it 'should not methodize on assignment' do
+      code = methodize('params._something = 5')
+      expect(code).to eq('params._something = 5')
+    end
+
+    it 'should not methodize on hash lookup' do
+      code = methodize('hash[:something]')
+      expect(code).to eq('hash[:something]')
+    end
+
+    it 'should not methodize on instance variables' do
+      code = methodize('@something.call')
+      expect(code).to eq('@something.call')
+    end
+  end
+end

data/spec/server/rack/asset_files_spec.rb

@@ -21,7 +21,7 @@ if RUBY_PLATFORM != 'opal'
       context "when the component's dependencies.rb does not contain .disable_auto_import" do
         it 'should list all JS files' do
           main = Volt::AssetFiles.new('main', @component_paths)
-          expect(main.javascript(volt_app)).to eq([
+          expect(main.javascript(volt_app).reject{|v| v[0] != :src }).to eq([
             [:src, '/assets/js/jquery-2.0.3.js'],
             [:src, '/assets/js/volt_js_polyfills.js'],
             [:src, '/assets/js/volt_watch.js'],
@@ -38,7 +38,7 @@ if RUBY_PLATFORM != 'opal'
       context "when the component's dependencies.rb contains .disable_auto_import" do
         it 'should list only the files included via the css_file helpers' do
           disabled_auto = Volt::AssetFiles.new('disable_auto', @component_paths)
-          expect(disabled_auto.javascript(volt_app)).to eq([
+          expect(disabled_auto.javascript(volt_app).reject{|v| v[0] != :src }).to eq([
             [:src, '/assets/js/jquery-2.0.3.js'],
             [:src, '/assets/js/volt_js_polyfills.js'],
             [:src, '/assets/js/volt_watch.js'],